148660 2015-08-31 17:19:06 -0700 [Cocoa] Testing: Allow overriding the system language for language-dependent tests 2015-08-31 23:16:50 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 mmaxfield mmaxfield andersca ap oldest_to_newest 1122379 0 mmaxfield 2015-08-31 17:19:06 -0700 [Cocoa] Testing: Allow overriding the system language for language-dependent tests 1122380 1 260340 mmaxfield 2015-08-31 17:19:27 -0700 Created attachment 260340 Patch 1122390 2 260340 mmaxfield 2015-08-31 17:38:53 -0700 Comment on attachment 260340 Patch This should be done inside WebKitTestRunner 1122474 3 260340 ap 2015-08-31 22:05:10 -0700 Comment on attachment 260340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260340&action=review > Tools/Scripts/webkitpy/port/base.py:532 > + first_line = f.readline() We probably need to allow having the metadata on the second line, because nothing can precede XML declaration. 1122496 4 mmaxfield 2015-08-31 23:16:50 -0700 Superseded by https://bugs.webkit.org/show_bug.cgi?id=148671 260340 2015-08-31 17:19:27 -0700 2015-08-31 17:38:53 -0700 Patch bug-148660-20150831171910.patch text/plain 4517 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmUwM2M3MDk5MmEwMTliMDRkMzhkNDBjYmMyMDg5Zjc5 Mjc1NzQxMS4uMzRjOWEyMGFjYzY1NmQ2YjljNWFkMjE2YzVhODJiNTIzNTE2YTBhOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE1LTA4LTMxICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgW0NvY29hXSBUZXN0aW5nOiBBbGxvdyBvdmVycmlkaW5nIHRoZSBzeXN0ZW0g bGFuZ3VhZ2UgZm9yIGxhbmd1YWdlLWRlcGVuZGVudCB0ZXN0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NjYwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9jb250cm9sbGVycy9sYXlvdXRfdGVzdF9ydW5uZXIucHk6CisgICAgICAgIChXb3JrZXIu X3VwZGF0ZV90ZXN0X2lucHV0KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9tb2RlbHMvdGVzdF9pbnB1dC5weToKKyAgICAgICAgKFRlc3RJbnB1dC5fX2luaXRfXyk6 CisgICAgICAgIChUZXN0SW5wdXQuX19yZXByX18pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvcG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5sYW5ndWFnZV9vdmVycmlkZSk6CisKIDIw MTUtMDgtMzEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lw IHNsb3cgbG9jayB0ZXN0cyBvbiBXaW5kb3dzL2RlYnVnCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9sYXlvdXRfdGVzdF9ydW5uZXIu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9sYXlv dXRfdGVzdF9ydW5uZXIucHkKaW5kZXggZjkwYzI2ZmE0ZmUzNGQ4MDQ2M2M3MDhiZTZmMjQzNGE0 ZjFjM2E2Mi4uNjczNTcxMzBiNzg5OThhYzc5MWRhMDBhNjQxZmE4ODQxYzI1ZjkyNCAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5 b3V0X3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2NvbnRyb2xsZXJzL2xheW91dF90ZXN0X3J1bm5lci5weQpAQCAtMjYzLDYgKzI2Myw4IEBA IGNsYXNzIFdvcmtlcihvYmplY3QpOgogICAgICAgICAgICAgdGVzdF9pbnB1dC5zaG91bGRfcnVu X3BpeGVsX3Rlc3QgPSBUcnVlCiAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICB0ZXN0X2lucHV0 LnNob3VsZF9ydW5fcGl4ZWxfdGVzdCA9IHNlbGYuX3BvcnQuc2hvdWxkX3J1bl9hc19waXhlbF90 ZXN0KHRlc3RfaW5wdXQpCisgICAgICAgIGlmIHRlc3RfaW5wdXQubGFuZ3VhZ2Vfb3ZlcnJpZGUg aXMgTm9uZToKKyAgICAgICAgICAgIHRlc3RfaW5wdXQubGFuZ3VhZ2Vfb3ZlcnJpZGUgPSBzZWxm Ll9wb3J0Lmxhbmd1YWdlX292ZXJyaWRlKHRlc3RfaW5wdXQudGVzdF9uYW1lKQogCiAgICAgZGVm IF9ydW5fdGVzdChzZWxmLCB0ZXN0X2lucHV0LCBzaGFyZF9uYW1lKToKICAgICAgICAgc2VsZi5f YmF0Y2hfY291bnQgKz0gMQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbW9kZWxzL3Rlc3RfaW5wdXQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9tb2RlbHMvdGVzdF9pbnB1dC5weQppbmRleCAzM2U0NDU4Y2ViZWE1YjlhYTVm YmE0ZDQ2Y2U2ZjVmY2M2OWQxNjRhLi42MzRhMzYyMTQ4ZjAzNzNlMzhjZjU1ZmFiY2FkOTMyMzQ2 YzljYWI2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9t b2RlbHMvdGVzdF9pbnB1dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9tb2RlbHMvdGVzdF9pbnB1dC5weQpAQCAtMzEsNyArMzEsNyBAQAogY2xhc3MgVGVzdElu cHV0KG9iamVjdCk6CiAgICAgIiIiR3JvdXBzIGluZm9ybWF0aW9uIGFib3V0IGEgdGVzdCBmb3Ig ZWFzeSBwYXNzaW5nIG9mIGRhdGEuIiIiCiAKLSAgICBkZWYgX19pbml0X18oc2VsZiwgdGVzdF9u YW1lLCB0aW1lb3V0PU5vbmUsIG5lZWRzX3NlcnZlcnM9Tm9uZSwgcmVmZXJlbmNlX2ZpbGVzPU5v bmUsIHNob3VsZF9ydW5fcGl4ZWxfdGVzdHM9Tm9uZSk6CisgICAgZGVmIF9faW5pdF9fKHNlbGYs IHRlc3RfbmFtZSwgdGltZW91dD1Ob25lLCBuZWVkc19zZXJ2ZXJzPU5vbmUsIHJlZmVyZW5jZV9m aWxlcz1Ob25lLCBzaG91bGRfcnVuX3BpeGVsX3Rlc3RzPU5vbmUsIGxhbmd1YWdlX292ZXJyaWRl PU5vbmUpOgogICAgICAgICAjIFRlc3RJbnB1dCBvYmplY3RzIGFyZSBub3JtYWxseSBjb25zdHJ1 Y3RlZCBieSB0aGUgbWFuYWdlciBhbmQgcGFzc2VkCiAgICAgICAgICMgdG8gdGhlIHdvcmtlcnMs IGJ1dCB0aGVzZSBzb21lIGZpZWxkcyBhcmUgc2V0IGxhemlseSBpbiB0aGUgd29ya2VycyB3aGVy ZSBwb3NzaWJsZQogICAgICAgICAjIGJlY2F1c2UgdGhleSByZXF1aXJlIHVzIHRvIGxvb2sgYXQg dGhlIGZpbGVzeXN0ZW0gYW5kIHdlIHdhbnQgdG8gYmUgYWJsZSB0byBkbyB0aGF0IGluIHBhcmFs bGVsLgpAQCAtNDAsNiArNDAsNyBAQCBjbGFzcyBUZXN0SW5wdXQob2JqZWN0KToKICAgICAgICAg c2VsZi5uZWVkc19zZXJ2ZXJzID0gbmVlZHNfc2VydmVycwogICAgICAgICBzZWxmLnJlZmVyZW5j ZV9maWxlcyA9IHJlZmVyZW5jZV9maWxlcwogICAgICAgICBzZWxmLnNob3VsZF9ydW5fcGl4ZWxf dGVzdHMgPSBzaG91bGRfcnVuX3BpeGVsX3Rlc3RzCisgICAgICAgIHNlbGYubGFuZ3VhZ2Vfb3Zl cnJpZGUgPSBsYW5ndWFnZV9vdmVycmlkZQogCiAgICAgZGVmIF9fcmVwcl9fKHNlbGYpOgotICAg ICAgICByZXR1cm4gIlRlc3RJbnB1dCgnJXMnLCB0aW1lb3V0PSVzLCBuZWVkc19zZXJ2ZXJzPSVz LCByZWZlcmVuY2VfZmlsZXM9JXMsIHNob3VsZF9ydW5fcGl4ZWxfdGVzdHM9JXMpIiAlIChzZWxm LnRlc3RfbmFtZSwgc2VsZi50aW1lb3V0LCBzZWxmLm5lZWRzX3NlcnZlcnMsIHNlbGYucmVmZXJl bmNlX2ZpbGVzLCBzZWxmLnNob3VsZF9ydW5fcGl4ZWxfdGVzdHMpCisgICAgICAgIHJldHVybiAi VGVzdElucHV0KCclcycsIHRpbWVvdXQ9JXMsIG5lZWRzX3NlcnZlcnM9JXMsIHJlZmVyZW5jZV9m aWxlcz0lcywgc2hvdWxkX3J1bl9waXhlbF90ZXN0cz0lcywgbGFuZ3VhZ2Vfb3ZlcnJpZGU9JXMp IiAlIChzZWxmLnRlc3RfbmFtZSwgc2VsZi50aW1lb3V0LCBzZWxmLm5lZWRzX3NlcnZlcnMsIHNl bGYucmVmZXJlbmNlX2ZpbGVzLCBzZWxmLnNob3VsZF9ydW5fcGl4ZWxfdGVzdHMsIHNlbGYubGFu Z3VhZ2Vfb3ZlcnJpZGUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv YmFzZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5CmluZGV4IGU4ZTJm NTRlZWE0Y2E3ZDM2MzMzYjk2MGFmMzNlYWY2OTNkMjI0NzYuLmUyZTUyZmNjNzI5MGUzNzllYmVj OGZmZWJkM2FjMGZmMTg0ODZmOWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5CkBA IC01MjcsNiArNTI3LDE0IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKIAogICAgICAgICByZXR1cm4g cmVmdGVzdF9saXN0LmdldChzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5sYXlvdXRfdGVzdHNf ZGlyKCksIHRlc3RfbmFtZSksIFtdKSAgIyBweWxpbnQ6IGRpc2FibGU9RTExMDMKIAorICAgIGRl ZiBsYW5ndWFnZV9vdmVycmlkZShzZWxmLCB0ZXN0X25hbWUpOgorICAgICAgICB3aXRoIG9wZW4o c2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYubGF5b3V0X3Rlc3RzX2RpcigpLCB0ZXN0X25hbWUp LCAncicpIGFzIGY6CisgICAgICAgICAgICBmaXJzdF9saW5lID0gZi5yZWFkbGluZSgpCisgICAg ICAgICAgICBtID0gcmUuY29tcGlsZSgiXjwhLS0gd2Via2l0LXRlc3QtcnVubmVyOiAuKm92ZXJy aWRlLWxhbmc9XCIoLis/KVwiIC4qLS0+JCIpLm1hdGNoKGZpcnN0X2xpbmUpCisgICAgICAgICAg ICBpZiBtIGFuZCBsZW4obS5ncm91cHMoKSkgPiAwOgorICAgICAgICAgICAgICAgIHJldHVybiBt Lmdyb3VwcygpWzBdCisgICAgICAgIHJldHVybiBOb25lCisKICAgICBkZWYgdGVzdHMoc2VsZiwg cGF0aHMpOgogICAgICAgICAiIiJSZXR1cm4gdGhlIGxpc3Qgb2YgdGVzdHMgZm91bmQuIEJvdGgg Z2VuZXJpYyBhbmQgcGxhdGZvcm0tc3BlY2lmaWMgdGVzdHMgbWF0Y2hpbmcgcGF0aHMgc2hvdWxk IGJlIHJldHVybmVkLiIiIgogICAgICAgICBleHBhbmRlZF9wYXRocyA9IHNlbGYuX2V4cGFuZGVk X3BhdGhzKHBhdGhzKQo=