148651 2015-08-31 15:58:56 -0700 Web Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger sidebar tree elements 2015-09-08 15:12:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1122329 0 mattbaker 2015-08-31 15:58:56 -0700 * SUMMARY Missing breakpoint context menu for debugger sidebar tree elements. Debugger sidebar needs a BreakpointPopoverController. * STEPS TO REPRODUCE 1. Create a breakpoint 2. Right click breakpoint tree element in Debugger sidebar. => No context menu Regressed in http://trac.webkit.org/changeset/189189. 1122330 1 webkit-bug-importer 2015-08-31 15:59:17 -0700 <rdar://problem/22508652> 1124388 2 260791 mattbaker 2015-09-08 14:15:28 -0700 Created attachment 260791 [Patch] Proposed Fix 1124415 3 260791 commit-queue 2015-09-08 15:12:20 -0700 Comment on attachment 260791 [Patch] Proposed Fix Clearing flags on attachment: 260791 Committed r189508: <http://trac.webkit.org/changeset/189508> 1124416 4 commit-queue 2015-09-08 15:12:24 -0700 All reviewed patches have been landed. Closing bug. 260791 2015-09-08 14:15:28 -0700 2015-09-08 15:12:20 -0700 [Patch] Proposed Fix bug-148651-20150908141523.patch text/plain 4471 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5NTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 MmQ4MThlYmZiMzcwNTZkZWQ2MTAxNmFkMDgyYmMwZWMxNTMyZGZlLi45NzlkNzgwNzVmNzZmNTU1 NDhlMmQyNzhhM2Q2M2JmZjY2NTAwOTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNS0wOS0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjE4OTE4OSk6IE1pc3Npbmcg YnJlYWtwb2ludCBjb250ZXh0IG1lbnUgZm9yIGRlYnVnZ2VyIHNpZGViYXIgdHJlZSBlbGVtZW50 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NjUx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5jb250ZW50TG9h ZGVkKToKKyAgICAgICAgQ3JlYXRlIEJyZWFrcG9pbnRQb3BvdmVyQ29udHJvbGxlciBzaW5nbGV0 b24sIGV4cG9zZSBhcyBwdWJsaWMgcHJvcGVydHkgb2YgZ2xvYmFsIFdlYkluc3BlY3RvciBvYmpl Y3QuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRUcmVlRWxlbWVu dC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CcmVha3BvaW50VHJlZUVsZW1lbnQucHJvdG90 eXBlLm9uY29udGV4dG1lbnUpOgorICAgICAgICBVc2UgQnJlYWtwb2ludFBvcG92ZXJDb250cm9s bGVyIHNpbmdsZXRvbi4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29k ZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0 b3IpOgorICAgICAgICBEb24ndCBjcmVhdGUgQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyIGlu c3RhbmNlLgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yLnByb3Rv dHlwZS50ZXh0RWRpdG9yR3V0dGVyQ29udGV4dE1lbnUpOgorICAgICAgICBVc2UgQnJlYWtwb2lu dFBvcG92ZXJDb250cm9sbGVyIHNpbmdsZXRvbi4KKwogMjAxNS0wOS0wOCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBpbnNwZWN0b3IvY29kZW1p cnJvciB0ZXN0cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jh c2UvTWFpbi5qcwppbmRleCA1ZDEwYWJiMTM0NTFjMjgyMDA5OWViMWY4NzIyNzMzZjE5NGE0Y2Uz Li4wZjhkNWExY2EyM2RkYmJkOWU1M2MwN2ZiNDU1OTA0OWNlZGViNmYxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0yMjcsNiAr MjI3LDcgQEAgV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgdGhp cy5fY29uc29sZVRyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5Mb2dUcmVlRWxlbWVudCh0 aGlzLl9jb25zb2xlUmVwcmVzZW50ZWRPYmplY3QpOwogICAgIHRoaXMuY29uc29sZUNvbnRlbnRW aWV3ID0gV2ViSW5zcGVjdG9yLnNwbGl0Q29udGVudEJyb3dzZXIuY29udGVudFZpZXdGb3JSZXBy ZXNlbnRlZE9iamVjdCh0aGlzLl9jb25zb2xlUmVwcmVzZW50ZWRPYmplY3QpOwogICAgIHRoaXMu Y29uc29sZUxvZ1ZpZXdDb250cm9sbGVyID0gdGhpcy5jb25zb2xlQ29udGVudFZpZXcubG9nVmll d0NvbnRyb2xsZXI7CisgICAgdGhpcy5icmVha3BvaW50UG9wb3ZlckNvbnRyb2xsZXIgPSBuZXcg V2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRQb3BvdmVyQ29udHJvbGxlcjsKIAogICAgIC8vIEZJWE1F OiBUaGUgc2lkZWJhcnMgc2hvdWxkIGJlIGZsaXBwZWQgaW4gUlRMIGxhbmd1YWdlcy4KICAgICB0 aGlzLm5hdmlnYXRpb25TaWRlYmFyID0gbmV3IFdlYkluc3BlY3Rvci5TaWRlYmFyKGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJuYXZpZ2F0aW9uLXNpZGViYXIiKSwgV2ViSW5zcGVjdG9yLlNpZGVi YXIuU2lkZXMuTGVmdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9CcmVha3BvaW50VHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50VHJlZUVsZW1lbnQuanMKaW5kZXgg NmY5MjBiOTg3MTQ3NmEyZDE2Yjc5ODVhMWVmMjk3YTRjNjdkOTA5NC4uM2QwNTI5YmZjYTE0M2Rl Mjk0ZThhN2Q5ZTE2MzBlMzNkOWI2NWYxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQnJlYWtwb2ludFRyZWVFbGVtZW50LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRUcmVlRWxl bWVudC5qcwpAQCAtOTksNyArOTksNyBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludFRyZWVFbGVt ZW50ID0gY2xhc3MgQnJlYWtwb2ludFRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcAogICAgIG9u Y29udGV4dG1lbnUoZXZlbnQpCiAgICAgewogICAgICAgICB2YXIgY29udGV4dE1lbnUgPSBuZXcg V2ViSW5zcGVjdG9yLkNvbnRleHRNZW51KGV2ZW50KTsKLSAgICAgICAgdGhpcy5fYnJlYWtwb2lu dC5hcHBlbmRDb250ZXh0TWVudUl0ZW1zKGNvbnRleHRNZW51LCB0aGlzLl9zdGF0dXNJbWFnZUVs ZW1lbnQpOworICAgICAgICBXZWJJbnNwZWN0b3IuYnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVy LmFwcGVuZENvbnRleHRNZW51SXRlbXMoY29udGV4dE1lbnUsIHRoaXMuX2JyZWFrcG9pbnQsIHRo aXMuX3N0YXR1c0ltYWdlRWxlbWVudCk7CiAgICAgICAgIGNvbnRleHRNZW51LnNob3coKTsKICAg ICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKaW5kZXggM2NjNzg0YTA5Y2Zj MzI4MzI4YzI1MWJkNWIzNzhkOTg3OWU2NzY2Yy4uY2MxYjllMWNmM2ZkNTM1MzQ2NTViNmUwYTc4 Nzk3Mjc2NDRkMWJjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKQEAgLTQ3 LDggKzQ3LDYgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yID0gY2xhc3MgU291 cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXZWJJbnNwZWMKIAogICAgICAgICB0aGlzLl9pc1By b2JhYmx5TWluaWZpZWQgPSBmYWxzZTsKIAotICAgICAgICB0aGlzLl9icmVha3BvaW50UG9wb3Zl ckNvbnRyb2xsZXIgPSBuZXcgV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRQb3BvdmVyQ29udHJvbGxl cjsKLQogICAgICAgICAvLyBGSVhNRTogQ3VycmVudGx5IHRoaXMganVzdCBqdW1wcyBiZXR3ZWVu IHJlc291cmNlcyBhbmQgcmVsYXRlZCBzb3VyY2UgbWFwIHJlc291cmNlcy4gSXQgZG9lc24ndCAi anVtcCB0byBzeW1ib2wiIHlldC4KICAgICAgICAgdGhpcy5fdXBkYXRlVG9rZW5UcmFja2luZ0Nv bnRyb2xsZXJTdGF0ZSgpOwogCkBAIC0xMDI1LDcgKzEwMjMsNyBAQCBXZWJJbnNwZWN0b3IuU291 cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdl Ykluc3BlYwogCiAgICAgICAgIC8vIFNpbmdsZSBicmVha3BvaW50LgogICAgICAgICBpZiAoYnJl YWtwb2ludHMubGVuZ3RoID09PSAxKSB7Ci0gICAgICAgICAgICB0aGlzLl9icmVha3BvaW50UG9w b3ZlckNvbnRyb2xsZXIuYXBwZW5kQ29udGV4dE1lbnVJdGVtcyhjb250ZXh0TWVudSwgYnJlYWtw b2ludHNbMF0sIGV2ZW50LnRhcmdldCk7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3IuYnJlYWtw b2ludFBvcG92ZXJDb250cm9sbGVyLmFwcGVuZENvbnRleHRNZW51SXRlbXMoY29udGV4dE1lbnUs IGJyZWFrcG9pbnRzWzBdLCBldmVudC50YXJnZXQpOwogCiAgICAgICAgICAgICBpZiAoIVdlYklu c3BlY3Rvci5pc1Nob3dpbmdEZWJ1Z2dlclRhYigpKSB7CiAgICAgICAgICAgICAgICAgY29udGV4 dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7Cg==