148635 2015-08-31 09:49:32 -0700 Watchdog timer callback should release the lock before deref’ing the Watchdog 2015-08-31 10:05:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam apavlov ddkilzer oldest_to_newest 1122190 0 mark.lam 2015-08-31 09:49:32 -0700 The deref’ing of the watchdog may free it. The lock may not be available to be unlocked after the deref. 1122193 1 mark.lam 2015-08-31 09:54:36 -0700 <rdar://problem/22495785> 1122194 2 260290 mark.lam 2015-08-31 09:57:52 -0700 Created attachment 260290 the fix. 1122195 3 260291 mark.lam 2015-08-31 10:00:46 -0700 Created attachment 260291 fix 2: fixed ChangeLog comment 1122198 4 mark.lam 2015-08-31 10:05:14 -0700 Thanks for the review. Landed in r189172: <http://trac.webkit.org/r189172>. 260290 2015-08-31 09:57:52 -0700 2015-08-31 10:00:46 -0700 the fix. bug-148635.patch text/plain 1491 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5MTcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA4LTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBX YXRjaGRvZyB0aW1lciBjYWxsYmFjayBzaG91bGQgcmVsZWFzZSB0aGUgbG9jayBiZWZvcmUgZGVy ZWbigJlpbmcgdGhlIHdhdGNoZG9nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ4NjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIGRlcmVm4oCZaW5nIG9mIHRoZSB3YXRjaGRvZyBtYXkgZnJlZSBp dC4gIFRoZSBsb2NrIG1heSBub3QgYmUgYXZhaWxhYmxlIHRvIGJlIHVubG9ja2VkCisgICAgICAg IGFmdGVyIHRoZSBkZXJlZi4KKworICAgICAgICAqIHJ1bnRpbWUvV2F0Y2hkb2cuY3BwOgorICAg ICAgICAoSlNDOjpXYXRjaGRvZzo6V2F0Y2hkb2cpOgorCiAyMDE1LTA4LTMwICBZdXN1a2UgU3V6 dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtFUzZdIEpTT04uc3RyaW5n aWZ5IHNob3VsZCBpZ25vcmUgb2JqZWN0IHByb3BlcnRpZXMgdGhhdCBoYXZlIHN5bWJvbCB2YWx1 ZXMgYW5kIGNvbnZlcnQgdGhlIHN5bWJvbCB2YWx1ZXMgaW4gYXJyYXkgdG8gbnVsbApJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2F0Y2hkb2cuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dhdGNoZG9nLmNwcAkocmV2aXNpb24gMTg5 MTcwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2F0Y2hkb2cuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01MSw4ICs1MSwxMCBAQCBXYXRjaGRvZzo6V2F0Y2hkb2coKQogICAgICwg bV90aW1lclF1ZXVlKFdvcmtRdWV1ZTo6Y3JlYXRlKCJqc2Mud2F0Y2hkb2cucXVldWUiLCBXb3Jr UXVldWU6OlR5cGU6OlNlcmlhbCwgV29ya1F1ZXVlOjpRT1M6OlV0aWxpdHkpKQogewogICAgIG1f dGltZXJIYW5kbGVyID0gW3RoaXNdIHsKLSAgICAgICAgTG9ja0hvbGRlciBsb2NrZXIobV9sb2Nr KTsKLSAgICAgICAgdGhpcy0+bV90aW1lckRpZEZpcmUgPSB0cnVlOworICAgICAgICB7CisgICAg ICAgICAgICBMb2NrSG9sZGVyIGxvY2tlcihtX2xvY2spOworICAgICAgICAgICAgdGhpcy0+bV90 aW1lckRpZEZpcmUgPSB0cnVlOworICAgICAgICB9CiAgICAgICAgIHRoaXMtPmRlcmVmKCk7CiAg ICAgfTsKIH0K 260291 2015-08-31 10:00:46 -0700 2015-08-31 10:02:22 -0700 fix 2: fixed ChangeLog comment bug-148635.patch text/plain 1487 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5MTcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA4LTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBX YXRjaGRvZyB0aW1lciBjYWxsYmFjayBzaG91bGQgcmVsZWFzZSB0aGUgbG9jayBiZWZvcmUgZGVy ZWYnaW5nIHRoZSB3YXRjaGRvZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0ODYzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBkZXJlZidpbmcgb2YgdGhlIHdhdGNoZG9nIG1heSBmcmVlIGl0LiAg VGhlIGxvY2sgbWF5IG5vdCBiZSBhdmFpbGFibGUgdG8gYmUgdW5sb2NrZWQKKyAgICAgICAgYWZ0 ZXIgdGhlIGRlcmVmLgorCisgICAgICAgICogcnVudGltZS9XYXRjaGRvZy5jcHA6CisgICAgICAg IChKU0M6OldhdGNoZG9nOjpXYXRjaGRvZyk6CisKIDIwMTUtMDgtMzAgIFl1c3VrZSBTdXp1a2kg IDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTNl0gSlNPTi5zdHJpbmdpZnkg c2hvdWxkIGlnbm9yZSBvYmplY3QgcHJvcGVydGllcyB0aGF0IGhhdmUgc3ltYm9sIHZhbHVlcyBh bmQgY29udmVydCB0aGUgc3ltYm9sIHZhbHVlcyBpbiBhcnJheSB0byBudWxsCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XYXRjaGRvZy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2F0Y2hkb2cuY3BwCShyZXZpc2lvbiAxODkxNzAp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XYXRjaGRvZy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTUxLDggKzUxLDEwIEBAIFdhdGNoZG9nOjpXYXRjaGRvZygpCiAgICAgLCBtX3Rp bWVyUXVldWUoV29ya1F1ZXVlOjpjcmVhdGUoImpzYy53YXRjaGRvZy5xdWV1ZSIsIFdvcmtRdWV1 ZTo6VHlwZTo6U2VyaWFsLCBXb3JrUXVldWU6OlFPUzo6VXRpbGl0eSkpCiB7CiAgICAgbV90aW1l ckhhbmRsZXIgPSBbdGhpc10gewotICAgICAgICBMb2NrSG9sZGVyIGxvY2tlcihtX2xvY2spOwot ICAgICAgICB0aGlzLT5tX3RpbWVyRGlkRmlyZSA9IHRydWU7CisgICAgICAgIHsKKyAgICAgICAg ICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fbG9jayk7CisgICAgICAgICAgICB0aGlzLT5tX3RpbWVy RGlkRmlyZSA9IHRydWU7CisgICAgICAgIH0KICAgICAgICAgdGhpcy0+ZGVyZWYoKTsKICAgICB9 OwogfQo=