148628 2015-08-30 22:17:53 -0700 [ES6] JSON.stringify should ignore object properties that have symbol values and convert the symbol values in array to null 2015-08-30 22:54:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki darin fpizlo ggaren sam oldest_to_newest 1122127 0 ysuzuki 2015-08-30 22:17:53 -0700 [ES6] JSON.stringify should ignore object properties that have symbol values and convert the symbol values in array to null 1122128 1 260274 ysuzuki 2015-08-30 22:31:28 -0700 Created attachment 260274 Patch 1122132 2 260274 saam 2015-08-30 22:50:57 -0700 Comment on attachment 260274 Patch r=me 1122133 3 ysuzuki 2015-08-30 22:52:52 -0700 (In reply to comment #2) > Comment on attachment 260274 [details] > Patch > > r=me Wow! Thank you for your review :D 1122134 4 ysuzuki 2015-08-30 22:54:02 -0700 Committed r189162: <http://trac.webkit.org/changeset/189162> 260274 2015-08-30 22:31:28 -0700 2015-08-30 22:50:57 -0700 Patch bug-148628-20150830223111.patch text/plain 6741 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZjQwYmQzYTE3NDY1MmFhNzJjM2Q5MWEyNmQxZjIxMjFkNTk0MjljLi4zNzhmYTRjZWFiMGIyZGE3 N2RmNTc4YWRiMGQ3ZDFlYTFjODQxMzVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzNCBAQAorMjAxNS0wOC0zMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbRVM2XSBKU09OLnN0cmluZ2lmeSBzaG91bGQgaWdub3JlIG9iamVj dCBwcm9wZXJ0aWVzIHRoYXQgaGF2ZSBzeW1ib2wgdmFsdWVzIGFuZCBjb252ZXJ0IHRoZSBzeW1i b2wgdmFsdWVzIGluIGFycmF5IHRvIG51bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0ODYyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFzIHBlciBFQ01BMjYyIDYuMCwKKworICAgICAgICAxLiBKU09O LnN0cmluZ2lmeSBzaG91bGQgaWdub3JlIG9iamVjdCBwcm9wZXJ0aWVzIHRoYXQgaGF2ZSBzeW1i b2wgdmFsdWVzLgorCisgICAgICAgICAgICBTZXJpYWxpemVKU09OUHJvcGVydHlbMV0gd2lsbCBy ZXR1cm4gdW5kZWZpbmVkIGlmIHRoZSB2YWx1ZSBvZiB0aGUgcHJvcGVydHkgaXMgYSBzeW1ib2wu CisgICAgICAgICAgICBJbiB0aGlzIGNhc2UsIFNlcmlhbGl6ZUpTT05PYmplY3RbMl0gZG9lcyBu b3QgYXBwZW5kIGFueSBzdHJpbmcgZm9yIHRoaXMgcHJvcGVydHkuCisKKyAgICAgICAgMi4gSlNP Ti5zdHJpbmdpZnkgc2hvdWxkIGNvbnZlcnQgdGhlIHN5bWJvbCB2YWx1ZXMgaW4gYXJyYXkgdG8g bnVsbAorCisgICAgICAgICAgICBBcyB0aGUgc2FtZSB0byB0aGUgb2JqZWN0IGNhc2UsIFNlcmlh bGl6ZUpTT05Qcm9wZXJ0eSB3aWxsIHJldHVybiB1bmRlZmluZWQgaWYgdGhlIHZhbHVlIG9mIHRo ZSBwcm9wZXJ0eSBpcyBhIHN5bWJvbC4KKyAgICAgICAgICAgIEJ1dCBpbiB0aGUgY2FzZSBvZiBh cnJheXMsIGlmIHRoZSByZXN1bHQgb2YgU2VyaWFsaXplSlNPTlByb3BlcnR5IGlzIHVuZGVmaW5l ZCwgaXQgd2lsbCBlbWl0ICJudWxsIlszXS4KKyAgICAgICAgICAgIFRoaXMgYmVoYXZpb3IgaXMg YWxyZWFkeSBpbXBsZW1lbnRlZCBpbiB0aGUgZXhpc3RpbmcgSlNPTi5zdHJpbmdpZnkuIEFkZGVk IHRlc3RzIHRvIGVuc3VyZSB0aGF0LgorCisgICAgICAgIFsxXTogaHR0cDovL3d3dy5lY21hLWlu dGVybmF0aW9uYWwub3JnL2VjbWEtMjYyLzYuMC8jc2VjLXNlcmlhbGl6ZWpzb25wcm9wZXJ0eQor ICAgICAgICBbMl06IGh0dHA6Ly93d3cuZWNtYS1pbnRlcm5hdGlvbmFsLm9yZy9lY21hLTI2Mi82 LjAvI3NlYy1zZXJpYWxpemVqc29ub2JqZWN0CisgICAgICAgIFszXTogaHR0cDovL3d3dy5lY21h LWludGVybmF0aW9uYWwub3JnL2VjbWEtMjYyLzYuMC8jc2VjLXNlcmlhbGl6ZWpzb25hcnJheQor CisgICAgICAgICogcnVudGltZS9KU09OT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6dW53cmFw Qm94ZWRQcmltaXRpdmUpOgorICAgICAgICAoSlNDOjpTdHJpbmdpZmllcjo6YXBwZW5kU3RyaW5n aWZpZWRWYWx1ZSk6CisgICAgICAgIChKU0M6OlN0cmluZ2lmaWVyOjpIb2xkZXI6OmFwcGVuZE5l eHRQcm9wZXJ0eSk6CisgICAgICAgICogdGVzdHMvc3RyZXNzL3N5bWJvbC13aXRoLWpzb24uanM6 CisgICAgICAgIChzaG91bGRCZSk6CisKIDIwMTUtMDgtMzAgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBKU0MgcHJvcGVydHkgYXR0cmlidXRlcyBzaG91bGQgZml0 IGluIGEgYnl0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNP Tk9iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0LmNw cAppbmRleCBmNjdiYTdlY2U4ZGMzOTRhODEwODNmMzY3N2ZkMjY4OTVlNmEwN2VlLi40YTQ3ZjE4 NzZlZTdkMzE3ZTlkMmE5ZGJlN2RkZmVhMjdhZTBiODk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU09OT2JqZWN0LmNwcApAQCAtMTEwLDcgKzExMCw3IEBAIGNsYXNzIFN0 cmluZ2lmaWVyIHsKICAgICBKU1ZhbHVlIHRvSlNPTihKU1ZhbHVlLCBjb25zdCBQcm9wZXJ0eU5h bWVGb3JGdW5jdGlvbkNhbGwmKTsKICAgICBKU1ZhbHVlIHRvSlNPTkltcGwoSlNWYWx1ZSwgY29u c3QgUHJvcGVydHlOYW1lRm9yRnVuY3Rpb25DYWxsJik7CiAKLSAgICBlbnVtIFN0cmluZ2lmeVJl c3VsdCB7IFN0cmluZ2lmeUZhaWxlZCwgU3RyaW5naWZ5U3VjY2VlZGVkLCBTdHJpbmdpZnlGYWls ZWREdWVUb1VuZGVmaW5lZFZhbHVlIH07CisgICAgZW51bSBTdHJpbmdpZnlSZXN1bHQgeyBTdHJp bmdpZnlGYWlsZWQsIFN0cmluZ2lmeVN1Y2NlZWRlZCwgU3RyaW5naWZ5RmFpbGVkRHVlVG9VbmRl ZmluZWRPclN5bWJvbFZhbHVlIH07CiAgICAgU3RyaW5naWZ5UmVzdWx0IGFwcGVuZFN0cmluZ2lm aWVkVmFsdWUoU3RyaW5nQnVpbGRlciYsIEpTVmFsdWUsIEpTT2JqZWN0KiBob2xkZXIsIGNvbnN0 IFByb3BlcnR5TmFtZUZvckZ1bmN0aW9uQ2FsbCYpOwogCiAgICAgYm9vbCB3aWxsSW5kZW50KCkg Y29uc3Q7CkBAIC0xNDQsNiArMTQ0LDkgQEAgc3RhdGljIGlubGluZSBKU1ZhbHVlIHVud3JhcEJv eGVkUHJpbWl0aXZlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSkKICAgICAgICAgcmV0 dXJuIG9iamVjdC0+dG9TdHJpbmcoZXhlYyk7CiAgICAgaWYgKG9iamVjdC0+aW5oZXJpdHMoQm9v bGVhbk9iamVjdDo6aW5mbygpKSkKICAgICAgICAgcmV0dXJuIG9iamVjdC0+dG9QcmltaXRpdmUo ZXhlYyk7CisKKyAgICAvLyBEbyBub3QgdW53cmFwIFN5bWJvbE9iamVjdCB0byBTeW1ib2wuIEl0 IGlzIG5vdCBwZXJmb3JtZWQgaW4gdGhlIHNwZWMuCisgICAgLy8gaHR0cDovL3d3dy5lY21hLWlu dGVybmF0aW9uYWwub3JnL2VjbWEtMjYyLzYuMC8jc2VjLXNlcmlhbGl6ZWpzb25wcm9wZXJ0eQog ICAgIHJldHVybiB2YWx1ZTsKIH0KIApAQCAtMjk5LDggKzMwMiw4IEBAIFN0cmluZ2lmaWVyOjpT dHJpbmdpZnlSZXN1bHQgU3RyaW5naWZpZXI6OmFwcGVuZFN0cmluZ2lmaWVkVmFsdWUoU3RyaW5n QnVpbGRlciYKICAgICAgICAgICAgIHJldHVybiBTdHJpbmdpZnlGYWlsZWQ7CiAgICAgfQogCi0g ICAgaWYgKHZhbHVlLmlzVW5kZWZpbmVkKCkgJiYgIWhvbGRlci0+aW5oZXJpdHMoSlNBcnJheTo6 aW5mbygpKSkKLSAgICAgICAgcmV0dXJuIFN0cmluZ2lmeUZhaWxlZER1ZVRvVW5kZWZpbmVkVmFs dWU7CisgICAgaWYgKCh2YWx1ZS5pc1VuZGVmaW5lZCgpIHx8IHZhbHVlLmlzU3ltYm9sKCkpICYm ICFob2xkZXItPmluaGVyaXRzKEpTQXJyYXk6OmluZm8oKSkpCisgICAgICAgIHJldHVybiBTdHJp bmdpZnlGYWlsZWREdWVUb1VuZGVmaW5lZE9yU3ltYm9sVmFsdWU7CiAKICAgICBpZiAodmFsdWUu aXNOdWxsKCkpIHsKICAgICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJudWxsIik7CkBAIC0z NDksNyArMzUyLDcgQEAgU3RyaW5naWZpZXI6OlN0cmluZ2lmeVJlc3VsdCBTdHJpbmdpZmllcjo6 YXBwZW5kU3RyaW5naWZpZWRWYWx1ZShTdHJpbmdCdWlsZGVyJgogICAgICAgICAgICAgYnVpbGRl ci5hcHBlbmRMaXRlcmFsKCJudWxsIik7CiAgICAgICAgICAgICByZXR1cm4gU3RyaW5naWZ5U3Vj Y2VlZGVkOwogICAgICAgICB9Ci0gICAgICAgIHJldHVybiBTdHJpbmdpZnlGYWlsZWREdWVUb1Vu ZGVmaW5lZFZhbHVlOworICAgICAgICByZXR1cm4gU3RyaW5naWZ5RmFpbGVkRHVlVG9VbmRlZmlu ZWRPclN5bWJvbFZhbHVlOwogICAgIH0KIAogICAgIC8vIEhhbmRsZSBjeWNsZSBkZXRlY3Rpb24s IGFuZCBwdXQgdGhlIGhvbGRlciBvbiB0aGUgc3RhY2suCkBAIC01MTQsMTAgKzUxNywxMCBAQCBi b29sIFN0cmluZ2lmaWVyOjpIb2xkZXI6OmFwcGVuZE5leHRQcm9wZXJ0eShTdHJpbmdpZmllciYg c3RyaW5naWZpZXIsIFN0cmluZ0J1aQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug U3RyaW5naWZ5U3VjY2VlZGVkOgogICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgU3Ry aW5naWZ5RmFpbGVkRHVlVG9VbmRlZmluZWRWYWx1ZToKLSAgICAgICAgICAgIC8vIFRoaXMgb25s eSBvY2N1cnMgd2hlbiBnZXQgYW4gdW5kZWZpbmVkIHZhbHVlIGZvciBhbiBvYmplY3QgcHJvcGVy dHkuCi0gICAgICAgICAgICAvLyBJbiB0aGlzIGNhc2Ugd2UgZG9uJ3Qgd2FudCB0aGUgc2VwYXJh dG9yIGFuZCBwcm9wZXJ0eSBuYW1lIHRoYXQgd2UKLSAgICAgICAgICAgIC8vIGFscmVhZHkgYXBw ZW5kZWQsIHNvIHJvbGwgYmFjay4KKyAgICAgICAgY2FzZSBTdHJpbmdpZnlGYWlsZWREdWVUb1Vu ZGVmaW5lZE9yU3ltYm9sVmFsdWU6CisgICAgICAgICAgICAvLyBUaGlzIG9ubHkgb2NjdXJzIHdo ZW4gZ2V0IGFuIHVuZGVmaW5lZCB2YWx1ZSBvciBhIHN5bWJvbCB2YWx1ZSBmb3IKKyAgICAgICAg ICAgIC8vIGFuIG9iamVjdCBwcm9wZXJ0eS4gSW4gdGhpcyBjYXNlIHdlIGRvbid0IHdhbnQgdGhl IHNlcGFyYXRvciBhbmQKKyAgICAgICAgICAgIC8vIHByb3BlcnR5IG5hbWUgdGhhdCB3ZSBhbHJl YWR5IGFwcGVuZGVkLCBzbyByb2xsIGJhY2suCiAgICAgICAgICAgICBidWlsZGVyLnJlc2l6ZShy b2xsQmFja1BvaW50KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc3ltYm9sLXdpdGgtanNvbi5qcyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc3ltYm9sLXdpdGgtanNvbi5qcwppbmRl eCAzYzAzZDVkNWExMWQ0ODJhYWY2MDM4Y2MwYTQ3Zjk3MTljNWQ5ZjljLi5kOTEyN2IzMDViNDE4 NTVlYmFmM2I1NGZhNTQ4ZWU2MjMzYTY5ZDE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvdGVzdHMvc3RyZXNzL3N5bWJvbC13aXRoLWpzb24uanMKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9zeW1ib2wtd2l0aC1qc29uLmpzCkBAIC0xLDE0ICsxLDI5 IEBACiAvLyBUaGlzIHRlc3RzIEpTT04gY29ycmVjdGx5IGJlaGF2ZXMgd2l0aCBTeW1ib2wuCiAK LWlmIChKU09OLnN0cmluZ2lmeShTeW1ib2woJ0NvY29hJykpICE9PSB1bmRlZmluZWQpCi0gICAg dGhyb3cgIkVycm9yOiBiYWQgdmFsdWUgIiArIEpTT04uc3RyaW5naWZ5KFN5bWJvbCgnQ29jb2En KSk7CitmdW5jdGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVkKSB7CisgICAgaWYgKGFjdHVh bCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93IG5ldyBFcnJvcignYmFkIHZhbHVlOiAnICsg YWN0dWFsKTsKK30KKworc2hvdWxkQmUoSlNPTi5zdHJpbmdpZnkoU3ltYm9sKCdDb2NvYScpKSwg dW5kZWZpbmVkKTsKIAogdmFyIG9iamVjdCA9IHt9OwogdmFyIHN5bWJvbCA9IFN5bWJvbCgiQ29j b2EiKTsKIG9iamVjdFtzeW1ib2xdID0gNDI7CiBvYmplY3RbJ0NhcHB1Y2Npbm8nXSA9IDQyOwot aWYgKEpTT04uc3RyaW5naWZ5KG9iamVjdCkgIT09ICd7IkNhcHB1Y2Npbm8iOjQyfScpCi0gICAg dGhyb3cgIkVycm9yOiBiYWQgdmFsdWUgIiArIEpTT04uc3RyaW5naWZ5KG9iamVjdCk7CitzaG91 bGRCZShKU09OLnN0cmluZ2lmeShvYmplY3QpLCAneyJDYXBwdWNjaW5vIjo0Mn0nKTsKKworc2hv dWxkQmUoSlNPTi5zdHJpbmdpZnkob2JqZWN0LCBbIFN5bWJvbCgnQ29jb2EnKSBdKSwgInt9Iik7 CisKKy8vIFRoZSBwcm9wZXJ0eSB0aGF0IHZhbHVlIGlzIFN5bWJvbCB3aWxsIGJlIGlnbm9yZWQu CitzaG91bGRCZShKU09OLnN0cmluZ2lmeSh7IGNvY29hOiBTeW1ib2woJ0NvY29hJyksIGNhcHB1 Y2Npbm86IFN5bWJvbCgnQ2FwcHVjY2lubycpIH0pLCAne30nKTsKK3Nob3VsZEJlKEpTT04uc3Ry aW5naWZ5KHsgY29jb2E6IFN5bWJvbCgnQ29jb2EnKSwgY2FwcHVjY2lubzogJ2NhcHB1Y2Npbm8n LCBbU3ltYm9sKCdNYXRjaGEnKV06ICdtYXRjaGEnIH0pLCAneyJjYXBwdWNjaW5vIjoiY2FwcHVj Y2lubyJ9Jyk7Cit2YXIgb2JqZWN0ID0ge2ZvbzogU3ltYm9sKCl9Oworb2JqZWN0W1N5bWJvbCgp XSA9IDE7CitzaG91bGRCZShKU09OLnN0cmluZ2lmeShvYmplY3QpLCAne30nKTsKIAotaWYgKEpT T04uc3RyaW5naWZ5KG9iamVjdCwgWyBTeW1ib2woJ0NvY29hJykgXSkgIT09ICJ7fSIpCi0gICAg dGhyb3cgIkVycm9yOiBiYWQgdmFsdWUgIiArIEpTT04uc3RyaW5naWZ5KG9iamVjdCwgWyBTeW1i b2woJ0NvY29hJykgXSk7CisvLyBUaGUgc3ltYm9sIHZhbHVlIGluY2x1ZGVkIGluIEFycmF5IHdp bGwgYmUgY29udmVydGVkIHRvIG51bGwKK3Nob3VsZEJlKEpTT04uc3RyaW5naWZ5KFsgU3ltYm9s KCdDb2NvYScpIF0pLCAnW251bGxdJyk7CitzaG91bGRCZShKU09OLnN0cmluZ2lmeShbICJoZWxs byIsIFN5bWJvbCgnQ29jb2EnKSwgJ3dvcmxkJyBdKSwgJ1siaGVsbG8iLG51bGwsIndvcmxkIl0n KTsKK3ZhciBhcnJheSA9IFtTeW1ib2woKV07CitzaG91bGRCZShKU09OLnN0cmluZ2lmeShhcnJh eSksICdbbnVsbF0nKTsK