148623 2015-08-30 16:30:09 -0700 Implement bmalloc::isASanEnabled for generic Unix 2015-08-31 13:41:41 -0700 1 1 1 Unclassified WebKit Web Template Framework Other All All RESOLVED FIXED P2 Enhancement --- 1 mcatanzaro mcatanzaro ap ggaren mcatanzaro oldest_to_newest 1122082 0 mcatanzaro 2015-08-30 16:30:09 -0700 If you only care about Clang (not sure), bmalloc::isASanEnabled could be as simple as: static bool isASanEnabled() { #if defined(__has_feature) && __has_feature(address_sanitizer) return true; #else return false; #endif } Unless there is some reason I don't understand for the runtime check. GCC supports asan but not __has_feature. This runtime check works: void *handle = dlopen(nullptr, RTLD_NOW); if (!handle) return false; bool result = !!dlsym(handle, "__asan_poison_memory_region"); dlclose(handle); return result; I expect that would work fine on Darwin too. 1122085 1 260254 mcatanzaro 2015-08-30 16:34:34 -0700 Created attachment 260254 Patch 1122087 2 260255 mcatanzaro 2015-08-30 16:43:54 -0700 Created attachment 260255 Patch 1122094 3 ap 2015-08-30 17:43:05 -0700 The runtime check is needed because we need to disable bmalloc whenever ASan is enabled in the process - even if bmalloc itself is compiled without ASan. 1122183 4 mcatanzaro 2015-08-31 09:28:56 -0700 OK, that makes sense. 1122186 5 260289 mcatanzaro 2015-08-31 09:31:30 -0700 Created attachment 260289 Patch 1122268 6 260289 ggaren 2015-08-31 13:16:47 -0700 Comment on attachment 260289 Patch r=me 1122276 7 mcatanzaro 2015-08-31 13:41:41 -0700 Committed r189181: <http://trac.webkit.org/changeset/189181> 260254 2015-08-30 16:34:34 -0700 2015-08-30 16:43:51 -0700 Patch bug-148623-20150830183418.patch text/plain 2407 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggN2Y3ZjQ0N2I2Y2I2ZmFl NWFlODU2NGU5YjM0MmU1MjMwNGQyOWRjNy4uODBjZGY0NGViOTg3MGU5OWE1N2U5NjYxYWZmYjVj NmIwNzI1NzgxYyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTMwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBJbXBsZW1l bnQgYm1hbGxvYzo6aXNBU2FuRW5hYmxlZCBmb3IgQ2xhbmcgYW5kIGdlbmVyaWMgVW5peAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NjIzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0JQ bGF0Zm9ybS5oOiBBZGQgQk9TX1VOSVggdG8gZGV0ZWN0IHdoZXRoZXIgdGhlIE9TIGlzIGEgVW5p eC4KKyAgICAgICAgKiBibWFsbG9jL0Vudmlyb25tZW50LmNwcDoKKyAgICAgICAgKGJtYWxsb2M6 OmlzQVNhbkVuYWJsZWQpOiBJbXBsZW1lbnQgYSBjb21waWxlLXRpbWUgY2hlY2sgd2l0aCBfX2hh c19mZWF0dXJlLCB3aGljaCB3b3JrcyBpbgorICAgICAgICBDbGFuZywgcGx1cyBhIHJ1bnRpbWUg Y2hlY2sgdGhhdCBzaG91bGQgd29yayBvbiBhbnkgVW5peC4KKwogMjAxNS0wOC0xOSAgR2VvZmZy ZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIEAgYm1hbGxvYzo6 RW52aXJvbm1lbnQ6OmNvbXB1dGVJc0JtYWxsb2NFbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxh dGZvcm0uaAppbmRleCAyZTc2ODgwYjdlZjk1YTVhZmNlZGI5N2VmOGEwMjg4NzIxOGFmN2JkLi41 MWNmZjNiMWQ5MGFiZDBlMzdjMmJmNjQwZmY5NTRlZjNmZGJlZjZhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvQlBsYXRmb3JtLmgKQEAgLTQzLDQgKzQzLDggQEAKICNkZWZpbmUgQk9TX0RBUldJTiAxCiAj ZW5kaWYKIAorI2lmZGVmIF9fdW5peAorI2RlZmluZSBCT1NfVU5JWCAxCisjZW5kaWYKKwogI2Vu ZGlmIC8vIEJQbGF0Zm9ybV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Vu dmlyb25tZW50LmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCmlu ZGV4IDg1MjJmMGNlNTk5NDA5NjBjOWE0MmM5YWMwMGVjZDQ3OWYyZjllN2EuLmM0MzA3OWM4M2M3 MmQ4N2UyMzEyNzQxYWI1ZmY3ZjExNzc2MDg5MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9j L2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52 aXJvbm1lbnQuY3BwCkBAIC0yOSw2ICsyOSw4IEBACiAjaW5jbHVkZSA8Y3N0cmluZz4KICNpZiBC T1MoREFSV0lOKQogI2luY2x1ZGUgPG1hY2gtby9keWxkLmg+CisjZWxpZiBCT1MoVU5JWCkKKyNp bmNsdWRlIDxkbGZjbi5oPgogI2VuZGlmCiAKIG5hbWVzcGFjZSBibWFsbG9jIHsKQEAgLTc1LDcg Kzc3LDkgQEAgc3RhdGljIGJvb2wgaXNMaWJnbWFsbG9jRW5hYmxlZCgpCiAKIHN0YXRpYyBib29s IGlzQVNhbkVuYWJsZWQoKQogewotI2lmIEJPUyhEQVJXSU4pCisjaWYgZGVmaW5lZChfX2hhc19m ZWF0dXJlKSAmJiBfX2hhc19mZWF0dXJlKGFkZHJlc3Nfc2FuaXRpemVyKQorICAgIHJldHVybiB0 cnVlOworI2VsaWYgQk9TKERBUldJTikKICAgICB1aW50MzJfdCBpbWFnZUNvdW50ID0gX2R5bGRf aW1hZ2VfY291bnQoKTsKICAgICBmb3IgKHVpbnQzMl90IGkgPSAwOyBpIDwgaW1hZ2VDb3VudDsg KytpKSB7CiAgICAgICAgIGNvbnN0IGNoYXIqIGltYWdlTmFtZSA9IF9keWxkX2dldF9pbWFnZV9u YW1lKGkpOwpAQCAtODUsNiArODksMTMgQEAgc3RhdGljIGJvb2wgaXNBU2FuRW5hYmxlZCgpCiAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAgICAgcmV0dXJuIGZhbHNlOworI2VsaWYg Qk9TKFVOSVgpCisgICAgdm9pZCogaGFuZGxlID0gZGxvcGVuKG51bGxwdHIsIFJUTERfTk9XKTsK KyAgICBpZiAoIWhhbmRsZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGJvb2wgcmVzdWx0 ID0gISFkbHN5bShoYW5kbGUsICJfX2FzYW5fcG9pc29uX21lbW9yeV9yZWdpb24iKTsKKyAgICBk bGNsb3NlKGhhbmRsZSk7CisgICAgcmV0dXJuIHJlc3VsdDsKICNlbHNlCiAgICAgcmV0dXJuIGZh bHNlOwogI2VuZGlmCg== 260255 2015-08-30 16:43:54 -0700 2015-08-31 09:31:26 -0700 Patch bug-148623-20150830184338.patch text/plain 2444 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggN2Y3ZjQ0N2I2Y2I2ZmFl NWFlODU2NGU5YjM0MmU1MjMwNGQyOWRjNy4uODBjZGY0NGViOTg3MGU5OWE1N2U5NjYxYWZmYjVj NmIwNzI1NzgxYyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTMwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBJbXBsZW1l bnQgYm1hbGxvYzo6aXNBU2FuRW5hYmxlZCBmb3IgQ2xhbmcgYW5kIGdlbmVyaWMgVW5peAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NjIzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0JQ bGF0Zm9ybS5oOiBBZGQgQk9TX1VOSVggdG8gZGV0ZWN0IHdoZXRoZXIgdGhlIE9TIGlzIGEgVW5p eC4KKyAgICAgICAgKiBibWFsbG9jL0Vudmlyb25tZW50LmNwcDoKKyAgICAgICAgKGJtYWxsb2M6 OmlzQVNhbkVuYWJsZWQpOiBJbXBsZW1lbnQgYSBjb21waWxlLXRpbWUgY2hlY2sgd2l0aCBfX2hh c19mZWF0dXJlLCB3aGljaCB3b3JrcyBpbgorICAgICAgICBDbGFuZywgcGx1cyBhIHJ1bnRpbWUg Y2hlY2sgdGhhdCBzaG91bGQgd29yayBvbiBhbnkgVW5peC4KKwogMjAxNS0wOC0xOSAgR2VvZmZy ZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIEAgYm1hbGxvYzo6 RW52aXJvbm1lbnQ6OmNvbXB1dGVJc0JtYWxsb2NFbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxh dGZvcm0uaAppbmRleCAyZTc2ODgwYjdlZjk1YTVhZmNlZGI5N2VmOGEwMjg4NzIxOGFmN2JkLi41 MWNmZjNiMWQ5MGFiZDBlMzdjMmJmNjQwZmY5NTRlZjNmZGJlZjZhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvQlBsYXRmb3JtLmgKQEAgLTQzLDQgKzQzLDggQEAKICNkZWZpbmUgQk9TX0RBUldJTiAxCiAj ZW5kaWYKIAorI2lmZGVmIF9fdW5peAorI2RlZmluZSBCT1NfVU5JWCAxCisjZW5kaWYKKwogI2Vu ZGlmIC8vIEJQbGF0Zm9ybV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Vu dmlyb25tZW50LmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCmlu ZGV4IDg1MjJmMGNlNTk5NDA5NjBjOWE0MmM5YWMwMGVjZDQ3OWYyZjllN2EuLmFiZDY0NmMxMTE3 NDNkNzc4MzM3NDZlMjNkMDcwMDhiMGVkNDhmNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9j L2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52 aXJvbm1lbnQuY3BwCkBAIC0yOSw2ICsyOSw4IEBACiAjaW5jbHVkZSA8Y3N0cmluZz4KICNpZiBC T1MoREFSV0lOKQogI2luY2x1ZGUgPG1hY2gtby9keWxkLmg+CisjZWxpZiBCT1MoVU5JWCkKKyNp bmNsdWRlIDxkbGZjbi5oPgogI2VuZGlmCiAKIG5hbWVzcGFjZSBibWFsbG9jIHsKQEAgLTc1LDcg Kzc3LDEzIEBAIHN0YXRpYyBib29sIGlzTGliZ21hbGxvY0VuYWJsZWQoKQogCiBzdGF0aWMgYm9v bCBpc0FTYW5FbmFibGVkKCkKIHsKLSNpZiBCT1MoREFSV0lOKQorI2lmIGRlZmluZWQoX19oYXNf ZmVhdHVyZSkKKyNpZiBfX2hhc19mZWF0dXJlKGFkZHJlc3Nfc2FuaXRpemVyKQorICAgIHJldHVy biB0cnVlOworI2Vsc2UKKyAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKKyNlbGlmIEJPUyhEQVJX SU4pCiAgICAgdWludDMyX3QgaW1hZ2VDb3VudCA9IF9keWxkX2ltYWdlX2NvdW50KCk7CiAgICAg Zm9yICh1aW50MzJfdCBpID0gMDsgaSA8IGltYWdlQ291bnQ7ICsraSkgewogICAgICAgICBjb25z dCBjaGFyKiBpbWFnZU5hbWUgPSBfZHlsZF9nZXRfaW1hZ2VfbmFtZShpKTsKQEAgLTg1LDYgKzkz LDEzIEBAIHN0YXRpYyBib29sIGlzQVNhbkVuYWJsZWQoKQogICAgICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgfQogICAgIHJldHVybiBmYWxzZTsKKyNlbGlmIEJPUyhVTklYKQorICAgIHZvaWQq IGhhbmRsZSA9IGRsb3BlbihudWxscHRyLCBSVExEX05PVyk7CisgICAgaWYgKCFoYW5kbGUpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBib29sIHJlc3VsdCA9ICEhZGxzeW0oaGFuZGxlLCAi X19hc2FuX3BvaXNvbl9tZW1vcnlfcmVnaW9uIik7CisgICAgZGxjbG9zZShoYW5kbGUpOworICAg IHJldHVybiByZXN1bHQ7CiAjZWxzZQogICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgo= 260289 2015-08-31 09:31:30 -0700 2015-08-31 13:16:47 -0700 Patch bug-148623-20150831113113.patch text/plain 1961 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggN2Y3ZjQ0N2I2Y2I2ZmFl NWFlODU2NGU5YjM0MmU1MjMwNGQyOWRjNy4uN2NiNjMwYmYzMDlkMmJkMTQ1MWRmOWNlNzNlMWQz ODNhNmY2ZTllMCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTMxICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBJbXBsZW1l bnQgYm1hbGxvYzo6aXNBU2FuRW5hYmxlZCBmb3IgZ2VuZXJpYyBVbml4CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg2MjMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJtYWxsb2MvQlBsYXRmb3JtLmg6 IEFkZCBCT1NfVU5JWCB0byBkZXRlY3Qgd2hldGhlciB0aGUgT1MgaXMgYSBVbml4LgorICAgICAg ICAqIGJtYWxsb2MvRW52aXJvbm1lbnQuY3BwOgorICAgICAgICAoYm1hbGxvYzo6aXNBU2FuRW5h YmxlZCk6IEltcGxlbWVudCBhIHJ1bnRpbWUgY2hlY2sgdGhhdCBzaG91bGQgd29yayBvbiBhbnkg VW5peC4KKwogMjAxNS0wOC0xOSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgog CiAgICAgICAgIENyYXNoIEAgYm1hbGxvYzo6RW52aXJvbm1lbnQ6OmNvbXB1dGVJc0JtYWxsb2NF bmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oIGIv U291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaAppbmRleCAyZTc2ODgwYjdlZjk1YTVh ZmNlZGI5N2VmOGEwMjg4NzIxOGFmN2JkLi41MWNmZjNiMWQ5MGFiZDBlMzdjMmJmNjQwZmY5NTRl ZjNmZGJlZjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5o CisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3JtLmgKQEAgLTQzLDQgKzQzLDgg QEAKICNkZWZpbmUgQk9TX0RBUldJTiAxCiAjZW5kaWYKIAorI2lmZGVmIF9fdW5peAorI2RlZmlu ZSBCT1NfVU5JWCAxCisjZW5kaWYKKwogI2VuZGlmIC8vIEJQbGF0Zm9ybV9oCmRpZmYgLS1naXQg YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Vudmlyb25tZW50LmNwcCBiL1NvdXJjZS9ibWFsbG9j L2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCmluZGV4IDg1MjJmMGNlNTk5NDA5NjBjOWE0MmM5YWMw MGVjZDQ3OWYyZjllN2EuLjJmMDhlYzdjZTNjNGZhNmE2Njc0NzkxMmE4ZmFlYjhlNTI5MjMwZjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCisrKyBi L1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCkBAIC0yOSw2ICsyOSw4IEBA CiAjaW5jbHVkZSA8Y3N0cmluZz4KICNpZiBCT1MoREFSV0lOKQogI2luY2x1ZGUgPG1hY2gtby9k eWxkLmg+CisjZWxpZiBCT1MoVU5JWCkKKyNpbmNsdWRlIDxkbGZjbi5oPgogI2VuZGlmCiAKIG5h bWVzcGFjZSBibWFsbG9jIHsKQEAgLTg1LDYgKzg3LDEzIEBAIHN0YXRpYyBib29sIGlzQVNhbkVu YWJsZWQoKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogICAgIHJldHVybiBmYWxz ZTsKKyNlbGlmIEJPUyhVTklYKQorICAgIHZvaWQqIGhhbmRsZSA9IGRsb3BlbihudWxscHRyLCBS VExEX05PVyk7CisgICAgaWYgKCFoYW5kbGUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBi b29sIHJlc3VsdCA9ICEhZGxzeW0oaGFuZGxlLCAiX19hc2FuX3BvaXNvbl9tZW1vcnlfcmVnaW9u Iik7CisgICAgZGxjbG9zZShoYW5kbGUpOworICAgIHJldHVybiByZXN1bHQ7CiAjZWxzZQogICAg IHJldHVybiBmYWxzZTsKICNlbmRpZgo=