148601 2015-08-28 18:15:09 -0700 Web Inspector: Resource.prototype.associateWithScript assertions firing 2015-08-28 20:30:54 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1121904 0 joepeck 2015-08-28 18:15:09 -0700 * SUMMARY Resource.prototype.associateWithScript assertions firing. * STEPS TO REPRODUCE 1. Inspect <http://code.tutsplus.com/tutorials/say-hello-to-webkit-filters--net-23318> 2. Inspect inspector 3. Reload => lots of asserts * NOTES This assert is firing quite a bit: console.assert(this._type !=== Other); I recently added it when dropping iOS 6 support since there was an iOS 6 compatibility comment. Seems it is not just for iOS 6 support. Lets restore the old handling here. 1121905 1 260199 joepeck 2015-08-28 18:16:18 -0700 Created attachment 260199 [PATCH] Proposed Fix 1121919 2 260202 joepeck 2015-08-28 19:15:09 -0700 Created attachment 260202 [PATCH] Proposed Fix 1121942 3 260202 commit-queue 2015-08-28 20:30:50 -0700 Comment on attachment 260202 [PATCH] Proposed Fix Clearing flags on attachment: 260202 Committed r189141: <http://trac.webkit.org/changeset/189141> 1121943 4 commit-queue 2015-08-28 20:30:54 -0700 All reviewed patches have been landed. Closing bug. 260199 2015-08-28 18:16:18 -0700 2015-08-28 18:23:18 -0700 [PATCH] Proposed Fix asserts.patch text/plain 1677 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRiNmVmNDMuLmI4ZTk5MWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVzb3Vy Y2UucHJvdG90eXBlLmFzc29jaWF0ZVdpdGhTY3JpcHQgYXNzZXJ0aW9ucyBmaXJpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODYwMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9Nb2RlbHMvUmVzb3VyY2UuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2UucHJv dG90eXBlLmFzc29jaWF0ZVdpdGhTY3JpcHQpOgorICAgICAgICBSZXN0b3JlIHRoZSBjb2RlIHRo YXQgd2FzIGhlcmUgYmVmb3JlIGl0IHdhcyBjb252ZXJ0ZWQgdG8gYXNzZXJ0cy4KKyAgICAgICAg SXQgbG9va2VkIGFzIGlmIGl0IHdhcyBpT1MgNiBvbmx5IGJ1dCBpdCB3YXMgbm90LgorCiAyMDE1 LTA4LTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogSW1wcm92ZSBTY3JpcHRTeW50YXhUcmVlIGEgYml0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMK aW5kZXggMmFhZGU5Zi4uMGUwMzAwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcwpAQCAtNjQ0LDggKzY0NCwxMCBA QCBXZWJJbnNwZWN0b3IuUmVzb3VyY2UgPSBjbGFzcyBSZXNvdXJjZSBleHRlbmRzIFdlYkluc3Bl Y3Rvci5Tb3VyY2VDb2RlCiAKICAgICAgICAgdGhpcy5fc2NyaXB0cy5wdXNoKHNjcmlwdCk7CiAK LSAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5fdHlwZSAhPT0gV2ViSW5zcGVjdG9yLlJlc291 cmNlLlR5cGUuT3RoZXIpOwotICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl90eXBlID09PSBX ZWJJbnNwZWN0b3IuUmVzb3VyY2UuVHlwZS5TY3JpcHQgfHwgdGhpcy5fdHlwZSA9PT0gV2ViSW5z cGVjdG9yLlJlc291cmNlLlR5cGUuRG9jdW1lbnQpOworICAgICAgICBpZiAodGhpcy5fdHlwZSA9 PT0gV2ViSW5zcGVjdG9yLlJlc291cmNlLlR5cGUuT3RoZXIpIHsKKyAgICAgICAgICAgIHRoaXMu X3R5cGUgPSBXZWJJbnNwZWN0b3IuUmVzb3VyY2UuVHlwZS5TY3JpcHQ7CisgICAgICAgICAgICB0 aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuUmVzb3VyY2UuRXZlbnQu VHlwZURpZENoYW5nZSwge29sZFR5cGV9KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHNhdmVJ ZGVudGl0eVRvQ29va2llKGNvb2tpZSkK 260202 2015-08-28 19:15:09 -0700 2015-08-28 20:30:50 -0700 [PATCH] Proposed Fix assert2.patch text/plain 1716 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRiNmVmNDMuLmI4ZTk5MWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVzb3Vy Y2UucHJvdG90eXBlLmFzc29jaWF0ZVdpdGhTY3JpcHQgYXNzZXJ0aW9ucyBmaXJpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODYwMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9Nb2RlbHMvUmVzb3VyY2UuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2UucHJv dG90eXBlLmFzc29jaWF0ZVdpdGhTY3JpcHQpOgorICAgICAgICBSZXN0b3JlIHRoZSBjb2RlIHRo YXQgd2FzIGhlcmUgYmVmb3JlIGl0IHdhcyBjb252ZXJ0ZWQgdG8gYXNzZXJ0cy4KKyAgICAgICAg SXQgbG9va2VkIGFzIGlmIGl0IHdhcyBpT1MgNiBvbmx5IGJ1dCBpdCB3YXMgbm90LgorCiAyMDE1 LTA4LTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogSW1wcm92ZSBTY3JpcHRTeW50YXhUcmVlIGEgYml0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMK aW5kZXggMmFhZGU5Zi4uMGNjODVkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcwpAQCAtNjQ0LDggKzY0NCwxMSBA QCBXZWJJbnNwZWN0b3IuUmVzb3VyY2UgPSBjbGFzcyBSZXNvdXJjZSBleHRlbmRzIFdlYkluc3Bl Y3Rvci5Tb3VyY2VDb2RlCiAKICAgICAgICAgdGhpcy5fc2NyaXB0cy5wdXNoKHNjcmlwdCk7CiAK LSAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5fdHlwZSAhPT0gV2ViSW5zcGVjdG9yLlJlc291 cmNlLlR5cGUuT3RoZXIpOwotICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl90eXBlID09PSBX ZWJJbnNwZWN0b3IuUmVzb3VyY2UuVHlwZS5TY3JpcHQgfHwgdGhpcy5fdHlwZSA9PT0gV2ViSW5z cGVjdG9yLlJlc291cmNlLlR5cGUuRG9jdW1lbnQpOworICAgICAgICBpZiAodGhpcy5fdHlwZSA9 PT0gV2ViSW5zcGVjdG9yLlJlc291cmNlLlR5cGUuT3RoZXIpIHsKKyAgICAgICAgICAgIHZhciBv bGRUeXBlID0gdGhpcy5fdHlwZTsKKyAgICAgICAgICAgIHRoaXMuX3R5cGUgPSBXZWJJbnNwZWN0 b3IuUmVzb3VyY2UuVHlwZS5TY3JpcHQ7CisgICAgICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRU b0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuUmVzb3VyY2UuRXZlbnQuVHlwZURpZENoYW5nZSwge29s ZFR5cGV9KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHNhdmVJZGVudGl0eVRvQ29va2llKGNv b2tpZSkK