148592 2015-08-28 14:55:50 -0700 Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..." 2015-08-31 09:26:56 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue dbates dburkart ddkilzer glenn lforschler thorton oldest_to_newest 1121840 0 ap 2015-08-28 14:55:50 -0700 run-webkit-tests doesn't respect DYLD_INSERT_LIBRARIES passed as --additional-env-var. This is a problem when testing an ASan-built framework with a non-ASan build of WebKit. When main executable is not built with ASAn, you need to insert ASan's dynamic library manually. 1121841 1 260182 ap 2015-08-28 15:02:15 -0700 Created attachment 260182 proposed fix 1121843 2 260182 thorton 2015-08-28 15:04:22 -0700 Comment on attachment 260182 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=260182&action=review > Tools/Scripts/webkitpy/port/base.py:860 > + env[name] = env[name] + ":" + value what if env[name] has a trailing : 1121849 3 ap 2015-08-28 15:21:42 -0700 > what if env[name] has a trailing : I don't know! Would guess that "::" is probably OK, but also this shouldn't happen. 1121853 4 thorton 2015-08-28 15:29:43 -0700 (In reply to comment #3) > > what if env[name] has a trailing : > > I don't know! Would guess that "::" is probably OK, but also this shouldn't > happen. Safe in this case. Not safe if you're mutating $PATH. But sure :D 1121861 5 260182 commit-queue 2015-08-28 15:51:02 -0700 Comment on attachment 260182 proposed fix Clearing flags on attachment: 260182 Committed r189128: <http://trac.webkit.org/changeset/189128> 1121862 6 commit-queue 2015-08-28 15:51:06 -0700 All reviewed patches have been landed. Closing bug. 1122182 7 ap 2015-08-31 09:26:56 -0700 > Safe in this case. Not safe if you're mutating $PATH. But sure :D Turns out that at least for bash, a trailing colon in PATH needs to be converted to a double colon when appending: "A null directory name may appear as two adjacent colons, or as an initial or trailing colon." Obviously not a behavior to rely upon. 260182 2015-08-28 15:02:15 -0700 2015-08-28 15:51:02 -0700 proposed fix DYLD_INSERT_LIBRARIES.txt text/plain 3604 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4OTEyNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE1LTA4LTI4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEZpeCBydW4td2Via2l0LXRlc3RzIC0tYWRkaXRpb25hbC1lbnYtdmFyPSJE WUxEX0lOU0VSVF9MSUJSQVJJRVM9Li4uIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weToKKyAgICAg ICAgKFBvcnQudG8uc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKToKKyAgICAgICAgKFBvcnQudG8p OgorICAgICAgICAoUG9ydC50by5fYXBwZW5kX3ZhbHVlX2NvbG9uX3NlcGFyYXRlZCk6CisgICAg ICAgIChQb3J0LnRvLnNob3dfcmVzdWx0c19odG1sX2ZpbGUpOgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvcG9ydC9pb3MucHk6CisgICAgICAgIChJT1NTaW11bGF0b3JQb3J0LnNldHVwX2Vu dmlyb25fZm9yX3NlcnZlcik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5w eToKKyAgICAgICAgKE1hY1BvcnQuc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKToKKwogMjAxNS0w OC0yOCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2lu XSBVbnJldmlld2VkIEVXUyBjb3JyZWN0aW9uLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L2Jhc2UucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2Jhc2UucHkJKHJldmlzaW9uIDE4OTEyNCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9iYXNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC04NTMsNiArODUzLDE0IEBAIGNsYXNzIFBvcnQo b2JqZWN0KToKIAogICAgICAgICByZXR1cm4gY2xlYW5fZW52CiAKKyAgICBAc3RhdGljbWV0aG9k CisgICAgZGVmIF9hcHBlbmRfdmFsdWVfY29sb25fc2VwYXJhdGVkKGVudiwgbmFtZSwgdmFsdWUp OgorICAgICAgICBhc3NlcnQgIjoiIG5vdCBpbiB2YWx1ZQorICAgICAgICBpZiBuYW1lIGluIGVu diBhbmQgZW52W25hbWVdOgorICAgICAgICAgICAgZW52W25hbWVdID0gZW52W25hbWVdICsgIjoi ICsgdmFsdWUKKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIGVudltuYW1lXSA9IHZhbHVlCisK ICAgICBkZWYgc2hvd19yZXN1bHRzX2h0bWxfZmlsZShzZWxmLCByZXN1bHRzX2ZpbGVuYW1lKToK ICAgICAgICAgIiIiVGhpcyByb3V0aW5lIHNob3VsZCBkaXNwbGF5IHRoZSBIVE1MIGZpbGUgcG9p bnRlZCBhdCBieQogICAgICAgICByZXN1bHRzX2ZpbGVuYW1lIGluIGEgdXNlcnMnIGJyb3dzZXIu IiIiCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkJKHJldmlzaW9uIDE4OTEyNCkK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkJKHdvcmtpbmcgY29weSkKQEAg LTIzMSw5ICsyMzEsOCBAQCBjbGFzcyBJT1NTaW11bGF0b3JQb3J0KFBvcnQpOgogICAgICAgICAg ICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdsZWFrcycpOgogICAgICAgICAgICAgICAgIGVudlsnTWFs bG9jU3RhY2tMb2dnaW5nJ10gPSAnMScKICAgICAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbign Z3VhcmRfbWFsbG9jJyk6Ci0gICAgICAgICAgICAgICAgZW52WydEWUxEX0lOU0VSVF9MSUJSQVJJ RVMnXSA9ICcvdXNyL2xpYi9saWJnbWFsbG9jLmR5bGliOicgKyBzZWxmLl9idWlsZF9wYXRoKCJs aWJXZWJDb3JlVGVzdFNoaW0uZHlsaWIiKQotICAgICAgICAgICAgZWxzZToKLSAgICAgICAgICAg ICAgICBlbnZbJ0RZTERfSU5TRVJUX0xJQlJBUklFUyddID0gc2VsZi5fYnVpbGRfcGF0aCgibGli V2ViQ29yZVRlc3RTaGltLmR5bGliIikKKyAgICAgICAgICAgICAgICBzZWxmLl9hcHBlbmRfdmFs dWVfY29sb25fc2VwYXJhdGVkKGVudiwgJ0RZTERfSU5TRVJUX0xJQlJBUklFUycsICcvdXNyL2xp Yi9saWJnbWFsbG9jLmR5bGliJykKKyAgICAgICAgICAgIHNlbGYuX2FwcGVuZF92YWx1ZV9jb2xv bl9zZXBhcmF0ZWQoZW52LCAnRFlMRF9JTlNFUlRfTElCUkFSSUVTJywgc2VsZi5fYnVpbGRfcGF0 aCgibGliV2ViQ29yZVRlc3RTaGltLmR5bGliIikpCiAgICAgICAgIGVudlsnWE1MX0NBVEFMT0df RklMRVMnXSA9ICcnICAjIHdvcmsgYXJvdW5kIG1pc3NpbmcgL2V0Yy9jYXRhbG9nIDxyZGFyOi8v cHJvYmxlbS80MjkyOTk1PgogICAgICAgICByZXR1cm4gZW52CiAKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9tYWMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L21hYy5weQkocmV2aXNpb24gMTg5MTI0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L21hYy5weQkod29ya2luZyBjb3B5KQpAQCAtMTAyLDkgKzEwMiw4IEBAIGNsYXNz IE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbignbGVh a3MnKToKICAgICAgICAgICAgICAgICBlbnZbJ01hbGxvY1N0YWNrTG9nZ2luZyddID0gJzEnCiAg ICAgICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oJ2d1YXJkX21hbGxvYycpOgotICAgICAgICAg ICAgICAgIGVudlsnRFlMRF9JTlNFUlRfTElCUkFSSUVTJ10gPSAnL3Vzci9saWIvbGliZ21hbGxv Yy5keWxpYjonICsgc2VsZi5fYnVpbGRfcGF0aCgibGliV2ViQ29yZVRlc3RTaGltLmR5bGliIikK LSAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAgZW52WydEWUxEX0lOU0VSVF9MSUJS QVJJRVMnXSA9IHNlbGYuX2J1aWxkX3BhdGgoImxpYldlYkNvcmVUZXN0U2hpbS5keWxpYiIpCisg ICAgICAgICAgICAgICAgc2VsZi5fYXBwZW5kX3ZhbHVlX2NvbG9uX3NlcGFyYXRlZChlbnYsICdE WUxEX0lOU0VSVF9MSUJSQVJJRVMnLCAnL3Vzci9saWIvbGliZ21hbGxvYy5keWxpYicpCisgICAg ICAgICAgICBzZWxmLl9hcHBlbmRfdmFsdWVfY29sb25fc2VwYXJhdGVkKGVudiwgJ0RZTERfSU5T RVJUX0xJQlJBUklFUycsIHNlbGYuX2J1aWxkX3BhdGgoImxpYldlYkNvcmVUZXN0U2hpbS5keWxp YiIpKQogICAgICAgICBlbnZbJ1hNTF9DQVRBTE9HX0ZJTEVTJ10gPSAnJyAgIyB3b3JrIGFyb3Vu ZCBtaXNzaW5nIC9ldGMvY2F0YWxvZyA8cmRhcjovL3Byb2JsZW0vNDI5Mjk5NT4KICAgICAgICAg cmV0dXJuIGVudgogCg==