148572 2015-08-28 07:20:14 -0700 [Win][HighDPI] Repaint issues after scrolling. 2015-09-10 11:51:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham zalan oldest_to_newest 1121677 0 peavo 2015-08-28 07:20:14 -0700 After scrolling, there are often some repaint artifacts on Windows. This can for example be seen when looking at a bugreport on bugs.webkit.org. 1121816 1 260175 peavo 2015-08-28 13:38:33 -0700 Created attachment 260175 Patch 1121818 2 peavo 2015-08-28 13:39:42 -0700 (In reply to comment #1) > Created attachment 260175 [details] > Patch I'm not sure this is the best solution. Maybe it is better to fix this without adding another member variable to WebView? 1122165 3 peavo 2015-08-31 08:21:18 -0700 This patch is not correct because the FrameView parameter always is the main frame, giving incorrect results for scrolling frames other than the main frame. 1124887 4 260923 peavo 2015-09-10 06:44:34 -0700 Created attachment 260923 Patch 1124900 5 peavo 2015-09-10 08:29:33 -0700 (In reply to comment #4) > Created attachment 260923 [details] > Patch Fixed by repainting entire scroll area, but maybe it would be better to fix this by always rounding the device scale factor off to the nearest integer? 1124907 6 achristensen 2015-09-10 09:17:26 -0700 There's got to be a better way to do this. What about just adding a pixel to each side of the rect? 1124940 7 peavo 2015-09-10 10:43:15 -0700 (In reply to comment #6) > There's got to be a better way to do this. What about just adding a pixel to > each side of the rect? Yes, I agree that we should find another way :) I may not understand you correctly, but I don't think the problem is that we haven't invalidated a large enough area. Instead, the problem seems to be that after a few calls to the scroll method, we have blitted the contents to the wrong position, so that when "normal" drawing is performed, there are glitches between the blitted areas and the areas drawn "normally". The reason for this is that repeated conversions from floating point scroll deltas to integer deltas, is accumulating the error from each conversion. Maybe there exists some WebCore methods which will give us the correct deltas in pixels so the blitted areas end up at the correct position? 1124958 8 260923 achristensen 2015-09-10 11:28:48 -0700 Comment on attachment 260923 Patch I don't think this is a good idea. It covers up a bug and hurts performance. I think this might be specific to WinCairo because scrollNonCompositedContents takes an IntSize. I think we should actually find what is the problem and fix that. 1124967 9 peavo 2015-09-10 11:51:06 -0700 (In reply to comment #8) > Comment on attachment 260923 [details] > Patch > > I don't think this is a good idea. It covers up a bug and hurts > performance. I think this might be specific to WinCairo because > scrollNonCompositedContents takes an IntSize. I think we should actually > find what is the problem and fix that. Ok, I'll have a closer look :) I'm not sure that it is WinCairo only, though, since the bug is present when not in accelerated compositing mode. For me it happens with a device scale factor of 1.25, and e.g. hovering over a button after scrolling (dragging the scroll knob) on bugs.webkit.org. 260175 2015-08-28 13:38:33 -0700 2015-09-10 06:44:25 -0700 Patch bug-148572-20150828223557.patch text/plain 2518 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4OTEyMSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA4LTI4 ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXVtI aWdoRFBJXSBSZXBhaW50IGlzc3VlcyBhZnRlciBzY3JvbGxpbmcuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg1NzIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBhdm9pZCBhY2N1bXVsYXRpbmcgZXJy b3JzIGZyb20gZmxvYXRpbmcgcG9pbnQgdG8gaW50ZWdlciBjb252ZXJzaW9uLCB3ZSBjb21wdXRl CisgICAgICAgIHRoZSBzY3JvbGwgZGVsdGEgYnkgc3VidHJhY3RpbmcgdGhlIG5ldyBzY3JvbGwg cG9zdGlvbiBmcm9tIHRoZSBsYXN0IHNjcm9sbCBwb3NpdGlvbi4KKworICAgICAgICAqIFdlYlZp ZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6c2Nyb2xsQmFja2luZ1N0b3JlKToKKyAgICAgICAg KiBXZWJWaWV3Lmg6CisKIDIwMTUtMDgtMjcgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRnJvbnRlbmRDaGFubmVsIHNob3VsZCBrbm93IGl0 cyBvd24gY29ubmVjdGlvbiB0eXBlCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24g MTg5MTIxKQorKysgU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTg5OCwxNCArODk4LDE5IEBAIHZvaWQgV2ViVmlldzo6c2Nyb2xsQmFja2luZ1N0b3JlKEZy YW1lVmkKIAogICAgIC8vIERpbWVuc2lvbnMgcGFzc2VkIHRvIHVzIGZyb20gV2ViQ29yZSBhcmUg aW4gbG9naWNhbCB1bml0cy4gV2UgbXVzdCBjb252ZXJ0IHRvIHBpeGVsczoKICAgICBmbG9hdCBz Y2FsZUZhY3RvciA9IGRldmljZVNjYWxlRmFjdG9yKCk7Ci0gICAgaW50IGR4ID0gY2xhbXBUbzxp bnQ+KHNjYWxlRmFjdG9yICogbG9naWNhbER4KTsKLSAgICBpbnQgZHkgPSBjbGFtcFRvPGludD4o c2NhbGVGYWN0b3IgKiBsb2dpY2FsRHkpOwogICAgIEZsb2F0UmVjdCBzY3JvbGxWaWV3UmVjdEZs b2F0KGxvZ2ljYWxTY3JvbGxWaWV3UmVjdCk7CiAgICAgc2Nyb2xsVmlld1JlY3RGbG9hdC5zY2Fs ZShzY2FsZUZhY3Rvcik7CiAgICAgSW50UmVjdCBzY3JvbGxWaWV3UmVjdChlbmNsb3NpbmdJbnRS ZWN0KHNjcm9sbFZpZXdSZWN0RmxvYXQpKTsKICAgICBGbG9hdFJlY3QgY2xpcFJlY3QobG9naWNh bENsaXBSZWN0KTsKICAgICBjbGlwUmVjdC5zY2FsZShzY2FsZUZhY3Rvcik7CiAKKyAgICAvLyBU byBhdm9pZCBhY2N1bXVsYXRpbmcgZXJyb3JzIGZyb20gZmxvYXRpbmcgcG9pbnQgdG8gaW50ZWdl ciBjb252ZXJzaW9uLCB3ZSBjb21wdXRlCisgICAgLy8gdGhlIHNjcm9sbCBkZWx0YSBieSBzdWJ0 cmFjdGluZyB0aGUgbmV3IHNjcm9sbCBwb3N0aW9uIGZyb20gdGhlIGxhc3Qgc2Nyb2xsIHBvc2l0 aW9uLgorICAgIGludCBkeCA9IG1fbGFzdFNjcm9sbFBvc2l0aW9uLngoKSAtIGZyYW1lVmlldy0+ c2Nyb2xsWCgpICogc2NhbGVGYWN0b3I7CisgICAgaW50IGR5ID0gbV9sYXN0U2Nyb2xsUG9zaXRp b24ueSgpIC0gZnJhbWVWaWV3LT5zY3JvbGxZKCkgKiBzY2FsZUZhY3RvcjsKKworICAgIG1fbGFz dFNjcm9sbFBvc2l0aW9uLm1vdmUoZHgsIGR5KTsKKwogICAgIGlmIChpc0FjY2VsZXJhdGVkQ29t cG9zaXRpbmcoKSkgewogICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGJlIGRvaW5nIHNvbWV0 aGluZyBzbWFydGVyIGhlcmUsIGxpa2UgbW92aW5nIHRpbGVzIGFyb3VuZCBhbmQgcGFpbnRpbmcK ICAgICAgICAgLy8gYW55IG5ld2x5LWV4cG9zZWQgdGlsZXMuIDxodHRwOi8vd2Via2l0Lm9yZy9i LzUyNzE0PgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuaAkocmV2aXNpb24gMTg5MTIxKQorKysgU291cmNl L1dlYktpdC93aW4vV2ViVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC03MDEsNiArNzAxLDggQEAg cHJvdGVjdGVkOgogI2VuZGlmCiAKICAgICBSZWZQdHI8V2ViVmlld0dyb3VwPiBtX3dlYlZpZXdH cm91cDsKKworICAgIFdlYkNvcmU6OkludFBvaW50IG1fbGFzdFNjcm9sbFBvc2l0aW9uOwogfTsK IAogI2VuZGlmCg== 260923 2015-09-10 06:44:34 -0700 2015-09-10 11:28:48 -0700 Patch bug-148572-20150910154427.patch text/plain 2273 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4OTU2NykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA5LTEw ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXVtI aWdoRFBJXSBSZXBhaW50IGlzc3VlcyBhZnRlciBzY3JvbGxpbmcuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg1NzIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBhdm9pZCByZXBhaW50IGdsaXRjaGVz IGNhdXNlZCBieSBhY2N1bXVsYXRpbmcgZXJyb3JzIHdoZW4gY29udmVydGluZworICAgICAgICBm bG9hdGluZyBwb2ludHMgdG8gaW50ZWdlcnMsIHdlIHJlcGFpbnQgdGhlIGVudGlyZSByZWdpb24g YWZmZWN0ZWQgYnkKKyAgICAgICAgc2Nyb2xsaW5nLiBUaGlzIGlzIHN1Ym9wdGltYWwsIHNpbmNl IHdlIHNob3VsZCBiZSBhYmxlIHRvIGJsaXQgdGhlIHNjcm9sbAorICAgICAgICByZWN0YW5nbGUg aW4gaGlnaCBEUEkgY2FzZXMgYXMgd2VsbC4gVGhpcyBzaG91bGQgYmUgZml4ZWQuCisKKyAgICAg ICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6OnNjcm9sbEJhY2tpbmdTdG9yZSk6 CisKIDIwMTUtMDktMDggIFBlciBBcm5lIFZvbGxhbiAgPHBlYXZvQG91dGxvb2suY29tPgogCiAg ICAgICAgIFtXaW5dIEltcGxlbWVudCBET01Ob2RlOjphdHRyaWJ1dGVzLgpJbmRleDogU291cmNl L1dlYktpdC93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4v V2ViVmlldy5jcHAJKHJldmlzaW9uIDE4OTU2NykKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZp ZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OTQsMTAgKzg5NCwyMSBAQCB2b2lkIFdlYlZpZXc6 OmFkZFRvRGlydHlSZWdpb24oR0RJT2JqZWN0CiAKIHZvaWQgV2ViVmlldzo6c2Nyb2xsQmFja2lu Z1N0b3JlKEZyYW1lVmlldyogZnJhbWVWaWV3LCBpbnQgbG9naWNhbER4LCBpbnQgbG9naWNhbER5 LCBjb25zdCBJbnRSZWN0JiBsb2dpY2FsU2Nyb2xsVmlld1JlY3QsIGNvbnN0IEludFJlY3QmIGxv Z2ljYWxDbGlwUmVjdCkKIHsKKyAgICBjb25zdCBmbG9hdCBzY2FsZUZhY3RvciA9IGRldmljZVNj YWxlRmFjdG9yKCk7CisgICAgaWYgKHNjYWxlRmFjdG9yICE9IDEuMGYpIHsKKyAgICAgICAgLy8g VG8gYXZvaWQgcmVwYWludCBnbGl0Y2hlcyBjYXVzZWQgYnkgYWNjdW11bGF0aW5nIGVycm9ycyB3 aGVuIGNvbnZlcnRpbmcgZmxvYXRpbmcgcG9pbnRzIHRvIGludGVnZXJzLAorICAgICAgICAvLyB3 ZSByZXBhaW50IHRoZSBlbnRpcmUgcmVnaW9uIGFmZmVjdGVkIGJ5IHNjcm9sbGluZy4gVGhpcyBp cyBzdWJvcHRpbWFsLCBzaW5jZSB3ZSBzaG91bGQgYmUgYWJsZSB0byBibGl0CisgICAgICAgIC8v IHRoZSBzY3JvbGwgcmVjdGFuZ2xlIGluIHRoaXMgY2FzZSBhcyB3ZWxsLiBUaGlzIHNob3VsZCBi ZSBmaXhlZCA6KQorICAgICAgICBJbnRSZWN0IHJlcGFpbnRSZWN0ID0gbG9naWNhbFNjcm9sbFZp ZXdSZWN0OworICAgICAgICByZXBhaW50UmVjdC5tb3ZlKGxvZ2ljYWxEeCwgbG9naWNhbER5KTsK KyAgICAgICAgcmVwYWludFJlY3QudW5pdGUobG9naWNhbFNjcm9sbFZpZXdSZWN0KTsKKyAgICAg ICAgcmVwYWludChyZXBhaW50UmVjdCwgdHJ1ZSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisK ICAgICBtX25lZWRzRGlzcGxheSA9IHRydWU7CiAKICAgICAvLyBEaW1lbnNpb25zIHBhc3NlZCB0 byB1cyBmcm9tIFdlYkNvcmUgYXJlIGluIGxvZ2ljYWwgdW5pdHMuIFdlIG11c3QgY29udmVydCB0 byBwaXhlbHM6Ci0gICAgZmxvYXQgc2NhbGVGYWN0b3IgPSBkZXZpY2VTY2FsZUZhY3RvcigpOwog ICAgIGludCBkeCA9IGNsYW1wVG88aW50PihzY2FsZUZhY3RvciAqIGxvZ2ljYWxEeCk7CiAgICAg aW50IGR5ID0gY2xhbXBUbzxpbnQ+KHNjYWxlRmFjdG9yICogbG9naWNhbER5KTsKICAgICBGbG9h dFJlY3Qgc2Nyb2xsVmlld1JlY3RGbG9hdChsb2dpY2FsU2Nyb2xsVmlld1JlY3QpOwo=