148569 2015-08-28 02:08:29 -0700 REGRESSION(r188639): [GTK] Several inspector tests started to time out in GTK+ bots after r188639 2015-09-28 09:24:29 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez timothy oldest_to_newest 1121650 0 cgarcia 2015-08-28 02:08:29 -0700 Let's skip them for now 1121652 1 cgarcia 2015-08-28 02:13:24 -0700 Skipped in r189092 1124155 2 clopez 2015-09-07 12:35:04 -0700 *** Bug 148939 has been marked as a duplicate of this bug. *** 1124167 3 bburg 2015-09-07 14:17:14 -0700 You may need to spend some time getting GTK up to speed with new inspector test infrastructure: * Tests load either Test.html or TestStub.html * A new method in Internals returns the path to TestStub.html * Most tests need to be able to load some auxiliary local files (TestHarness.js, etc) even if they run inside an iframe 1128711 4 261926 cgarcia 2015-09-25 09:22:03 -0700 Created attachment 261926 Patch 1128712 5 cgarcia 2015-09-25 09:22:34 -0700 (In reply to comment #3) > You may need to spend some time getting GTK up to speed with new inspector > test infrastructure: > > * Tests load either Test.html or TestStub.html > * A new method in Internals returns the path to TestStub.html > * Most tests need to be able to load some auxiliary local files > (TestHarness.js, etc) even if they run inside an iframe This last point was the only thing missing actually. Thanks for your help. 1128719 6 bburg 2015-09-25 10:05:45 -0700 (In reply to comment #5) > (In reply to comment #3) > > You may need to spend some time getting GTK up to speed with new inspector > > test infrastructure: > > > > * Tests load either Test.html or TestStub.html > > * A new method in Internals returns the path to TestStub.html > > * Most tests need to be able to load some auxiliary local files > > (TestHarness.js, etc) even if they run inside an iframe > > This last point was the only thing missing actually. Thanks for your help. No problem. Let me know if you have any questions or other issues pop up. I'm hoping to get Windows tests working again soon. 1128868 7 cgarcia 2015-09-26 01:41:05 -0700 Committed r190265: <http://trac.webkit.org/changeset/190265> 1128989 8 cgarcia 2015-09-28 03:20:24 -0700 There are still some tests timing out in the bots, but I think they are just slow. I've tried some of them, for example inspector/css/createStyleSheet.html never times out for me, however inspector/css/stylesheet-events-basic.html fails for me when run with run-webkit-tests and passes when using WTR directly. It also pass when running run-webkit-tests with --no-timeout, the test is a lot slower when using run-webkit-tests for some reason. The thing is that I'm not sure if the slowness is somehow expected or a bug specific to the GTK+ port. It seems to me that the inspector tests actually run multiple test cases per test, so it's probably expected to be slow. Should we mark inspector tests as slow to use a higher timeout? 1129014 9 bburg 2015-09-28 09:24:29 -0700 (In reply to comment #8) > There are still some tests timing out in the bots, but I think they are just > slow. I've tried some of them, for example > inspector/css/createStyleSheet.html never times out for me, however > inspector/css/stylesheet-events-basic.html fails for me when run with > run-webkit-tests and passes when using WTR directly. It also pass when > running run-webkit-tests with --no-timeout, the test is a lot slower when > using run-webkit-tests for some reason. The thing is that I'm not sure if > the slowness is somehow expected or a bug specific to the GTK+ port. It > seems to me that the inspector tests actually run multiple test cases per > test, so it's probably expected to be slow. Should we mark inspector tests > as slow to use a higher timeout? We have been seeing similar issues for some Mac bots, with tests having high variance and taking several times longer to complete than when running locally, even on very old hardware (2008 MacBook runs tests in ~3s, bots can take up to 40s+). However, I have not noticed differences between run-webkit-tests and direct WKTR execution. If you are able to find anything out, do file a bug. <https://webkit.org/b/148636> tracks general flakiness in inspector tests. 261926 2015-09-25 09:22:03 -0700 2015-09-25 09:39:54 -0700 Patch wk-inspector-tests.diff text/plain 3082 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkYTVmYmU1Li5mYzJhYzRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTUtMDkt MjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAg IFJFR1JFU1NJT04ocjE4ODYzOSk6IFtHVEtdIFNldmVyYWwgaW5zcGVjdG9yIHRlc3RzIHN0YXJ0 ZWQgdG8gdGltZSBvdXQgaW4gR1RLKyBib3RzIGFmdGVyIHIxODg2MzkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODU2OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnM6IFVuc2tpcCB0aGUgaW5zcGVjdG9yIHRlc3RzLgorCisyMDE1LTA5LTI1ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBB U1NFUlRJT04gRkFJTEVEOiAhbV9pblVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlIGluIERyYXdpbmdB cmVhSW1wbDo6ZGlzcGxheSgpIGFmdGVyIERyYXdpbmdBcmVhSW1wbDo6Zm9yY2VSZXBhaW50KCkK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODk1Ngog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGZkODcyNTQu LjQ1NjJlMWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBA IC0xMzkzLDkgKzEzOTMsNiBAQCB3ZWJraXQub3JnL2IvMTQ4NTY3IGZhc3QvbWVkaWFzdHJlYW0v ZGVsYXllZC1wZXJtaXNzaW9uLWFsbG93ZWQuaHRtbCBbIFRpbWVvdXQgXQogd2Via2l0Lm9yZy9i LzE0ODU2NyBmYXN0L21lZGlhc3RyZWFtL2dldHVzZXJtZWRpYS5odG1sIFsgVGltZW91dCBdCiB3 ZWJraXQub3JnL2IvMTQ4NTY3IGZhc3QvbWVkaWFzdHJlYW0vc3VjY2Vzcy5odG1sIFsgVGltZW91 dCBdCiAKLSMgUkVHUkVTU0lPTihyMTg4NjM5KTogV2ViIEluc3BlY3Rvcjogc3BsaXQgVGVzdFN0 dWIuanMgaW50byBtdWx0aXBsZSBmaWxlcyBhbmQgbW9kZXJuaXplIGl0Ci13ZWJraXQub3JnL2Iv MTQ4NTY5IGluc3BlY3RvciBbIFRpbWVvdXQgXQotCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLwogIyBFbmQgb2YgVGVzdHMgdGltaW5nIG91dAogIy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBmNDVhYTdmLi4zMzBiMzBmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTUgQEAKIDIwMTUtMDktMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04ocjE4ODYzOSk6IFtHVEtdIFNldmVy YWwgaW5zcGVjdG9yIHRlc3RzIHN0YXJ0ZWQgdG8gdGltZSBvdXQgaW4gR1RLKyBib3RzIGFmdGVy IHIxODg2MzkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0ODU2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogUGxhdGZvcm1HVEsuY21ha2U6IEFkZCBtaXNzaW5nIGluc3BlY3RvciBmaWxlcyByZXF1aXJl ZCBmb3IKKyAgICAgICAgbGF5b3V0IHRlc3RzLgorCisyMDE1LTA5LTI1ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBBU1NFUlRJT04g RkFJTEVEOiAhbV9pblVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlIGluIERyYXdpbmdBcmVhSW1wbDo6 ZGlzcGxheSgpIGFmdGVyIERyYXdpbmdBcmVhSW1wbDo6Zm9yY2VSZXBhaW50KCkKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODk1NgogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtR1RLLmNtYWtlCmluZGV4IGI1YmVkZWMuLjdlNmZjNTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt R1RLLmNtYWtlCkBAIC00NDcsNiArNDQ3LDcgQEAgc2V0KEluc3BlY3RvckZpbGVzCiAgICAgJHtD TUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9FeHRl cm5hbC9Fc3ByaW1hLyouanMKICAgICAke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy8qLmpzCiAgICAgJHtDTUFLRV9TT1VSQ0VfRElS fS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC8qLmpzCisgICAg JHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9U ZXN0LyouanMKICAgICAke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzLyouY3NzCiAgICAgJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy8qLmpzCiAgICAgJHtDTUFLRV9TT1VS Q0VfRElSfS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9JbWFnZXMvZ3RrLyou cG5nCg==