148557 2015-08-27 21:45:10 -0700 Web Inspector: Type Profiler does not understand Functions within Default Argument Expressions 2015-08-28 12:10:18 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1121569 0 joepeck 2015-08-27 21:45:10 -0700 * SUMMARY Type Profiler does not understand Functions within Default Argument Expressions. Default Argument Expressions are currently ignored by our SyntaxTree. * TESTS function testFunctionDeclaration(a=(function(alpha=999){return alpha})(), b=20) { return a + b; }; add2(); (function testFunctionExpression(a=(function(alpha=999){return alpha})(), b=20) { return a + b; })() * RESULTS Expected type bubbles for the inner `function(alpha)...` function expressions, but they were even visited by our annotator. * NOTES No errors or warnings. 1121571 1 webkit-bug-importer 2015-08-27 21:45:38 -0700 <rdar://problem/22470013> 1121573 2 260119 joepeck 2015-08-27 22:02:04 -0700 Created attachment 260119 [PATCH] Proposed Fix 1121667 3 260119 commit-queue 2015-08-28 05:58:32 -0700 Comment on attachment 260119 [PATCH] Proposed Fix Clearing flags on attachment: 260119 Committed r189096: <http://trac.webkit.org/changeset/189096> 1121668 4 commit-queue 2015-08-28 05:58:38 -0700 All reviewed patches have been landed. Closing bug. 1121787 5 saam 2015-08-28 12:10:18 -0700 I wonder if the JSC implementation of the type profiler properly handles this. I don't think it does. 260119 2015-08-27 22:02:04 -0700 2015-08-28 05:58:32 -0700 [PATCH] Proposed Fix defaults.patch text/plain 3458 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVkM2YyZTEuLmRlN2JiYzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTA4LTI3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVHlwZSBQ cm9maWxlciBkb2VzIG5vdCB1bmRlcnN0YW5kIEZ1bmN0aW9ucyB3aXRoaW4gRGVmYXVsdCBBcmd1 bWVudCBFeHByZXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ4NTU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRTeW50YXhUcmVlLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdFN5bnRheFRyZWUucHJvdG90eXBlLl9yZWN1cnNlKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlLnByb3RvdHlwZS5fY3JlYXRl SW50ZXJuYWxTeW50YXhUcmVlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhU cmVlKToKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGFic3RyYWN0aW5nIGFuZCByZWN1cnNpbmcg dGhyb3VnaCB0aGUgZGVmYXVsdCBwYXJhbWV0ZXIKKyAgICAgICAgZXhwcmVzc2lvbnMgRXNwcmlt YSBoYXMgb24gZnVuY3Rpb24gZXhwcmVzc2lvbnMgYW5kIGRlY2xhcmF0aW9ucy4KKworMjAxNS0w OC0yNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFR5cGUgUHJvZmlsZXIgZG9lcyBub3QgdW5kZXJzdGFuZCBGdW5jdGlvbnMg aW5zaWRlIFRlbXBsYXRlIFN0cmluZ3MgKFNjcmlwdFN5bnRheFRyZWUgd2FybmluZ3MpCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg1NTYKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1Njcmlw dFN5bnRheFRyZWUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvU2NyaXB0U3ludGF4VHJlZS5qcwppbmRleCBkMTJlNDQzLi42MWQzYThmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0U3ludGF4 VHJlZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv U2NyaXB0U3ludGF4VHJlZS5qcwpAQCAtMzcyLDEyICszNzIsMTQgQEAgV2ViSW5zcGVjdG9yLlNj cmlwdFN5bnRheFRyZWUgPSBjbGFzcyBTY3JpcHRTeW50YXhUcmVlIGV4dGVuZHMgV2ViSW5zcGVj dG9yLk9iamUKICAgICAgICAgICAgIGNhbGxiYWNrKG5vZGUsIHN0YXRlKTsKICAgICAgICAgICAg IHRoaXMuX3JlY3Vyc2Uobm9kZS5pZCwgY2FsbGJhY2ssIHN0YXRlKTsKICAgICAgICAgICAgIHRo aXMuX3JlY3Vyc2VBcnJheShub2RlLnBhcmFtcywgY2FsbGJhY2ssIHN0YXRlKTsKKyAgICAgICAg ICAgIHRoaXMuX3JlY3Vyc2VBcnJheShub2RlLmRlZmF1bHRzLCBjYWxsYmFjaywgc3RhdGUpOwog ICAgICAgICAgICAgdGhpcy5fcmVjdXJzZShub2RlLmJvZHksIGNhbGxiYWNrLCBzdGF0ZSk7CiAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4 VHJlZS5Ob2RlVHlwZS5GdW5jdGlvbkV4cHJlc3Npb246CiAgICAgICAgICAgICBjYWxsYmFjayhu b2RlLCBzdGF0ZSk7CiAgICAgICAgICAgICB0aGlzLl9yZWN1cnNlKG5vZGUuaWQsIGNhbGxiYWNr LCBzdGF0ZSk7CiAgICAgICAgICAgICB0aGlzLl9yZWN1cnNlQXJyYXkobm9kZS5wYXJhbXMsIGNh bGxiYWNrLCBzdGF0ZSk7CisgICAgICAgICAgICB0aGlzLl9yZWN1cnNlQXJyYXkobm9kZS5kZWZh dWx0cywgY2FsbGJhY2ssIHN0YXRlKTsKICAgICAgICAgICAgIHRoaXMuX3JlY3Vyc2Uobm9kZS5i b2R5LCBjYWxsYmFjaywgc3RhdGUpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug V2ViSW5zcGVjdG9yLlNjcmlwdFN5bnRheFRyZWUuTm9kZVR5cGUuSWRlbnRpZmllcjoKQEAgLTY3 OCw2ICs2ODAsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJlZSA9IGNsYXNzIFNjcmlw dFN5bnRheFRyZWUgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZQogICAgICAgICAgICAgICAgIHR5 cGU6IFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlLk5vZGVUeXBlLkZ1bmN0aW9uRGVjbGFy YXRpb24sCiAgICAgICAgICAgICAgICAgaWQ6IHRoaXMuX2NyZWF0ZUludGVybmFsU3ludGF4VHJl ZShub2RlLmlkKSwKICAgICAgICAgICAgICAgICBwYXJhbXM6IG5vZGUucGFyYW1zLm1hcCh0aGlz Ll9jcmVhdGVJbnRlcm5hbFN5bnRheFRyZWUuYmluZCh0aGlzKSksCisgICAgICAgICAgICAgICAg ZGVmYXVsdHM6IG5vZGUuZGVmYXVsdHMubWFwKHRoaXMuX2NyZWF0ZUludGVybmFsU3ludGF4VHJl ZS5iaW5kKHRoaXMpKSwKICAgICAgICAgICAgICAgICBib2R5OiB0aGlzLl9jcmVhdGVJbnRlcm5h bFN5bnRheFRyZWUobm9kZS5ib2R5KSwKICAgICAgICAgICAgICAgICBpc0dldHRlck9yU2V0dGVy OiBmYWxzZSAvLyBUaGlzIGlzIG9idmlvdXMsIGJ1dCBpcyBjb252ZW5pZW50IG5vbmUgdGhlIGxl c3MgYi9jIERlY2xhcmF0aW9ucyBhbmQgRXhwcmVzc2lvbnMgYXJlIG9mdGVuIGludGVydHdpbmVk LgogICAgICAgICAgICAgfTsKQEAgLTY4Nyw2ICs2OTAsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0 U3ludGF4VHJlZSA9IGNsYXNzIFNjcmlwdFN5bnRheFRyZWUgZXh0ZW5kcyBXZWJJbnNwZWN0b3Iu T2JqZQogICAgICAgICAgICAgICAgIHR5cGU6IFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVl Lk5vZGVUeXBlLkZ1bmN0aW9uRXhwcmVzc2lvbiwKICAgICAgICAgICAgICAgICBpZDogdGhpcy5f Y3JlYXRlSW50ZXJuYWxTeW50YXhUcmVlKG5vZGUuaWQpLAogICAgICAgICAgICAgICAgIHBhcmFt czogbm9kZS5wYXJhbXMubWFwKHRoaXMuX2NyZWF0ZUludGVybmFsU3ludGF4VHJlZS5iaW5kKHRo aXMpKSwKKyAgICAgICAgICAgICAgICBkZWZhdWx0czogbm9kZS5kZWZhdWx0cy5tYXAodGhpcy5f Y3JlYXRlSW50ZXJuYWxTeW50YXhUcmVlLmJpbmQodGhpcykpLAogICAgICAgICAgICAgICAgIGJv ZHk6IHRoaXMuX2NyZWF0ZUludGVybmFsU3ludGF4VHJlZShub2RlLmJvZHkpLAogICAgICAgICAg ICAgICAgIGlzR2V0dGVyT3JTZXR0ZXI6IGZhbHNlIC8vIElmIHRydWUsIGl0IGlzIHNldCBpbiB0 aGUgUHJvcGVydHkgQVNUIG5vZGUuCiAgICAgICAgICAgICB9Owo=