148556 2015-08-27 21:29:19 -0700 Web Inspector: Type Profiler does not understand Functions inside Template Strings (ScriptSyntaxTree warnings) 2015-08-28 05:57:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1121563 0 joepeck 2015-08-27 21:29:19 -0700 * SUMMARY Type Profiler does not understand Functions inside Template Strings (ScriptSyntaxTree warning). * TEST (foo.js) console.log(String.raw`testing ${(function(a=10){return a})()}`); * EXPECTED Type bubble for (a). * ACTUAL WebInspectorUI.framework/Resources/Models/ScriptSyntaxTree.js:898:26: CONSOLE ERROR Unsupported Syntax Tree Node: TaggedTemplateExpression [object Object] 1121564 1 webkit-bug-importer 2015-08-27 21:29:38 -0700 <rdar://problem/22469933> 1121565 2 260118 joepeck 2015-08-27 21:30:34 -0700 Created attachment 260118 [PATCH] Proposed Fix 1121665 3 260118 commit-queue 2015-08-28 05:57:25 -0700 Comment on attachment 260118 [PATCH] Proposed Fix Clearing flags on attachment: 260118 Committed r189095: <http://trac.webkit.org/changeset/189095> 1121666 4 commit-queue 2015-08-28 05:57:31 -0700 All reviewed patches have been landed. Closing bug. 260118 2015-08-27 21:30:34 -0700 2015-08-28 05:57:25 -0700 [PATCH] Proposed Fix template-strings.patch text/plain 4116 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU4MDIyZmUuLmVkM2YyZTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTA4LTI3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVHlwZSBQ cm9maWxlciBkb2VzIG5vdCB1bmRlcnN0YW5kIEZ1bmN0aW9ucyBpbnNpZGUgVGVtcGxhdGUgU3Ry aW5ncyAoU2NyaXB0U3ludGF4VHJlZSB3YXJuaW5ncykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODU1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0U3lu dGF4VHJlZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlLnByb3Rv dHlwZS5fcmVjdXJzZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJlZS5w cm90b3R5cGUuX2NyZWF0ZUludGVybmFsU3ludGF4VHJlZSk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuU2NyaXB0U3ludGF4VHJlZSk6CisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBhYnN0cmFjdGlu ZyBhbmQgcmVjdXJzaW5nIHRocm91Z2ggdGhlIEVzcHJpbWEgdGVtcGxhdGUgbm9kZXMuCisKKzIw MTUtMDgtMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBTdGFuZGFyZGl6ZSBvbiBDU1NTdHlsZVNoZWV0LlR5cGUgZW51bSBh bmQgbW92ZSBtb3JlIHByb3RvY29sIGVudW0gY29udmVyc2lvbiB0byB0aGUgbWFuYWdlcgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NTE1CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3Jp cHRTeW50YXhUcmVlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL1NjcmlwdFN5bnRheFRyZWUuanMKaW5kZXggOTgxNTcxZS4uZDEyZTQ0MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFN5bnRh eFRyZWUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L1NjcmlwdFN5bnRheFRyZWUuanMKQEAgLTQ1OSw2ICs0NTksMTkgQEAgV2ViSW5zcGVjdG9yLlNj cmlwdFN5bnRheFRyZWUgPSBjbGFzcyBTY3JpcHRTeW50YXhUcmVlIGV4dGVuZHMgV2ViSW5zcGVj dG9yLk9iamUKICAgICAgICAgICAgIHRoaXMuX3JlY3Vyc2Uobm9kZS5jb25zZXF1ZW50LCBjYWxs YmFjaywgc3RhdGUpOwogICAgICAgICAgICAgdGhpcy5fcmVjdXJzZShub2RlLmFsdGVybmF0ZSwg Y2FsbGJhY2ssIHN0YXRlKTsKICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFdlYklu c3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlLk5vZGVUeXBlLlRhZ2dlZFRlbXBsYXRlRXhwcmVzc2lv bjoKKyAgICAgICAgICAgIGNhbGxiYWNrKG5vZGUsIHN0YXRlKTsKKyAgICAgICAgICAgIHRoaXMu X3JlY3Vyc2Uobm9kZS50YWcsIGNhbGxiYWNrLCBzdGF0ZSk7CisgICAgICAgICAgICB0aGlzLl9y ZWN1cnNlKG5vZGUucXVhc2ksIGNhbGxiYWNrLCBzdGF0ZSk7CisgICAgICAgICAgICBicmVhazsK KyAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJlZS5Ob2RlVHlwZS5UZW1w bGF0ZUVsZW1lbnQ6CisgICAgICAgICAgICBjYWxsYmFjayhub2RlLCBzdGF0ZSk7CisgICAgICAg ICAgICBicmVhazsKKyAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJlZS5O b2RlVHlwZS5UZW1wbGF0ZUxpdGVyYWw6CisgICAgICAgICAgICBjYWxsYmFjayhub2RlLCBzdGF0 ZSk7CisgICAgICAgICAgICB0aGlzLl9yZWN1cnNlQXJyYXkobm9kZS5xdWFzaXMsIGNhbGxiYWNr LCBzdGF0ZSk7CisgICAgICAgICAgICB0aGlzLl9yZWN1cnNlQXJyYXkobm9kZS5leHByZXNzaW9u cywgY2FsbGJhY2ssIHN0YXRlKTsKKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFdl Ykluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlLk5vZGVUeXBlLlRoaXNFeHByZXNzaW9uOgogICAg ICAgICAgICAgY2FsbGJhY2sobm9kZSwgc3RhdGUpOwogICAgICAgICAgICAgYnJlYWs7CkBAIC04 MDksNiArODIyLDI3IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlID0gY2xhc3MgU2Ny aXB0U3ludGF4VHJlZSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplCiAgICAgICAgICAgICAgICAg Y29uc2VxdWVudDogbm9kZS5jb25zZXF1ZW50Lm1hcCh0aGlzLl9jcmVhdGVJbnRlcm5hbFN5bnRh eFRyZWUuYmluZCh0aGlzKSkKICAgICAgICAgICAgIH07CiAgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgY2FzZSAiVGFnZ2VkVGVtcGxhdGVFeHByZXNzaW9uIjoKKyAgICAgICAgICAgIHJlc3Vs dCA9IHsKKyAgICAgICAgICAgICAgICB0eXBlOiBXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJl ZS5Ob2RlVHlwZS5UYWdnZWRUZW1wbGF0ZUV4cHJlc3Npb24sCisgICAgICAgICAgICAgICAgdGFn OiB0aGlzLl9jcmVhdGVJbnRlcm5hbFN5bnRheFRyZWUobm9kZS50YWcpLAorICAgICAgICAgICAg ICAgIHF1YXNpOiB0aGlzLl9jcmVhdGVJbnRlcm5hbFN5bnRheFRyZWUobm9kZS5xdWFzaSkKKyAg ICAgICAgICAgIH07CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSAiVGVtcGxhdGVF bGVtZW50IjoKKyAgICAgICAgICAgIHJlc3VsdCA9IHsKKyAgICAgICAgICAgICAgICB0eXBlOiBX ZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJlZS5Ob2RlVHlwZS5UZW1wbGF0ZUVsZW1lbnQsCisg ICAgICAgICAgICAgICAgdmFsdWU6IG5vZGUudmFsdWUsCisgICAgICAgICAgICAgICAgdGFpbDog bm9kZS50YWlsCisgICAgICAgICAgICB9OworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNh c2UgIlRlbXBsYXRlTGl0ZXJhbCI6CisgICAgICAgICAgICByZXN1bHQgPSB7CisgICAgICAgICAg ICAgICAgdHlwZTogV2ViSW5zcGVjdG9yLlNjcmlwdFN5bnRheFRyZWUuTm9kZVR5cGUuVGVtcGxh dGVMaXRlcmFsLAorICAgICAgICAgICAgICAgIHF1YXNpczogbm9kZS5xdWFzaXMubWFwKHRoaXMu X2NyZWF0ZUludGVybmFsU3ludGF4VHJlZS5iaW5kKHRoaXMpKSwKKyAgICAgICAgICAgICAgICBl eHByZXNzaW9uczogbm9kZS5leHByZXNzaW9ucy5tYXAodGhpcy5fY3JlYXRlSW50ZXJuYWxTeW50 YXhUcmVlLmJpbmQodGhpcykpCisgICAgICAgICAgICB9OworICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIGNhc2UgIlRoaXNFeHByZXNzaW9uIjoKICAgICAgICAgICAgIHJlc3VsdCA9IHsKICAg ICAgICAgICAgICAgICB0eXBlOiBXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJlZS5Ob2RlVHlw ZS5UaGlzRXhwcmVzc2lvbgpAQCAtOTMxLDYgKzk2NSw5IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRT eW50YXhUcmVlLk5vZGVUeXBlID0gewogICAgIFNwcmVhZEVsZW1lbnQ6IFN5bWJvbCgic3ByZWFk LWVsZW1lbnQiKSwKICAgICBTd2l0Y2hDYXNlOiBTeW1ib2woInN3aXRjaC1jYXNlIiksCiAgICAg U3dpdGNoU3RhdGVtZW50OiBTeW1ib2woInN3aXRjaC1zdGF0ZW1lbnQiKSwKKyAgICBUYWdnZWRU ZW1wbGF0ZUV4cHJlc3Npb246IFN5bWJvbCgidGFnZ2VkLXRlbXBsYXRlLWV4cHJlc3Npb24iKSwK KyAgICBUZW1wbGF0ZUVsZW1lbnQ6IFN5bWJvbCgidGVtcGxhdGUtZWxlbWVudCIpLAorICAgIFRl bXBsYXRlTGl0ZXJhbDogU3ltYm9sKCJ0ZW1wbGF0ZS1saXRlcmFsIiksCiAgICAgVGhpc0V4cHJl c3Npb246IFN5bWJvbCgidGhpcy1leHByZXNzaW9uIiksCiAgICAgVGhyb3dTdGF0ZW1lbnQ6IFN5 bWJvbCgidGhyb3ctc3RhdGVtZW50IiksCiAgICAgVHJ5U3RhdGVtZW50OiBTeW1ib2woInRyeS1z dGF0ZW1lbnQiKSwK