148551 2015-08-27 18:00:26 -0700 Minor fixes in reportUnexpectedSyscall 2015-08-28 07:23:21 -0700 1 1 1 Unclassified WebKit WebKit2 Other PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro commit-queue mcatanzaro zan oldest_to_newest 1121512 0 mcatanzaro 2015-08-27 18:00:26 -0700 There is an off-by-one in the static assert. Also, an unsigned long long is passed in, but the parameter is an int. Then it's passed to writeUnsignedInt, which takes an unsigned int. Let's use unsigned int instead. (The value is a syscall number, so it's safe to truncate regardless -- it never be anywhere near as large as an int -- so this is just a matter of style.) 1121513 1 260103 mcatanzaro 2015-08-27 18:04:12 -0700 Created attachment 260103 Patch 1121678 2 260103 commit-queue 2015-08-28 07:23:15 -0700 Comment on attachment 260103 Patch Clearing flags on attachment: 260103 Committed r189097: <http://trac.webkit.org/changeset/189097> 1121679 3 commit-queue 2015-08-28 07:23:21 -0700 All reviewed patches have been landed. Closing bug. 260103 2015-08-27 18:04:12 -0700 2015-08-28 07:23:15 -0700 Patch bug-148551-20150827200359.patch text/plain 2362 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzI5ZDg3Yjk0YTQwMDgy YzFkNjU3MDk4M2FhN2IyYWExOTRlZDM3NC4uY2VjMzkwYjA3ZDMxZjY5MGRlNGM2MWIxMWY5YmRl Njg1M2FkYTg1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA4LTI3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBNaW5vciBm aXhlcyBpbiByZXBvcnRVbmV4cGVjdGVkU3lzY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgYW4gb2ZmLWJ5LW9uZSBpbiB0aGUgc3Rh dGljIGFzc2VydC4KKworICAgICAgICBBbHNvLCBhbiB1bnNpZ25lZCBsb25nIGxvbmcgaXMgcGFz c2VkIGluLCBidXQgdGhlIHBhcmFtZXRlciBpcyBhbiBpbnQuIFRoZW4gaXQncyBwYXNzZWQgdG8K KyAgICAgICAgd3JpdGVVbnNpZ25lZEludCwgd2hpY2ggdGFrZXMgYW4gdW5zaWduZWQgaW50LiBM ZXQncyB1c2UgdW5zaWduZWQgaW50IGluc3RlYWQuIChUaGUgdmFsdWUKKyAgICAgICAgaXMgYSBz eXNjYWxsIG51bWJlciwgc28gaXQncyBzYWZlIHRvIHRydW5jYXRlIHJlZ2FyZGxlc3MgLS0gaXQg bmV2ZXIgYmUgYW55d2hlcmUgbmVhciBhcworICAgICAgICBsYXJnZSBhcyBhbiBpbnQsIHVubGVz cyB0aGUgaW5wdXQgaXMgbWFsaWNpb3VzLCBpbiB3aGljaCBjYXNlIHRydW5jYXRpbmcgaXQgaXMg dGhlIHJpZ2h0CisgICAgICAgIHRoaW5nIHRvIGRvIGFueXdheSAtLSBzbyB0aGlzIGlzIGp1c3Qg YSBtYXR0ZXIgb2Ygc3R5bGUuKQorCisgICAgICAgICogU2hhcmVkL2xpbnV4L1NlY2NvbXBGaWx0 ZXJzL1N5c2NhbGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpyZXBvcnRVbmV4cGVjdGVkU3lzY2Fs bCk6CisKIDIwMTUtMDgtMjcgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUu Y29tPgogCiAgICAgICAgIEZhY3RvciBvdXQgTG9va3VwIGludm9jYXRpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51eC9TZWNjb21wRmlsdGVycy9TeXNjYWxsLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51eC9TZWNjb21wRmlsdGVycy9TeXNjYWxsLmNwcApp bmRleCBkZTk3ZDMxNzE0ZmI4N2UyYTZkNDY5MGYzNTFhZGI4MTZlYTMzNzBmLi44OWU1MGQwNDAx ZjlmM2EzMTMxNGI5ODI2YmE2ZTg3MjA2NzJkNzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU3lzY2FsbC5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvU2hhcmVkL2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1N5c2NhbGwuY3BwCkBAIC02MiwxMSAr NjIsMTMgQEAgc3RhdGljIHZvaWQgd3JpdGVVbnNpZ25lZEludChjaGFyKiBidWYsIHVuc2lnbmVk IHZhbCkKICAgICAgICAgYnVmWy0td2lkdGhdID0gJzAnICsgKHRlbnMgJSAxMCk7CiB9CiAKLXN0 YXRpYyB2b2lkIHJlcG9ydFVuZXhwZWN0ZWRTeXNjYWxsKGludCBzeXNjYWxsKQorc3RhdGljIHZv aWQgcmVwb3J0VW5leHBlY3RlZFN5c2NhbGwodW5zaWduZWQgc3lzY2FsbCkKIHsKICAgICBjaGFy IGJ1ZlsxMjhdOwogI2lmIGRlZmluZWQoX19oYXNfYnVpbHRpbikgJiYgX19oYXNfYnVpbHRpbihf X2J1aWx0aW5fc3RybGVuKQotICAgIHN0YXRpY19hc3NlcnQoX19idWlsdGluX3N0cmxlbihtZXNz YWdlKSArIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6ZGlnaXRzMTAgKyAxIDwgc2l6ZW9mKGJ1 ZiksICJCdWZmZXIgdG9vIHNtYWxsIik7CisgICAgLy8gQnVmZmVyIG11c3QgYmUgYmlnIGVub3Vn aCBmb3IgdGhlIGxpdGVyYWwsIHBsdXMgdGhlIG51bWJlciBvZiBkaWdpdHMgaW4gdGhlIGxhcmdl c3QgcG9zc2libGUKKyAgICAvLyB1bnNpZ25lZCBpbnQsIHBsdXMgb25lIGZvciB0aGUgbmV3bGlu ZSwgcGx1cyBvbmUgbW9yZSBmb3IgdGhlIHRyYWlsaW5nIG51bGwuCisgICAgc3RhdGljX2Fzc2Vy dChfX2J1aWx0aW5fc3RybGVuKG1lc3NhZ2UpICsgc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25l ZD46OmRpZ2l0czEwICsgMiA8IHNpemVvZihidWYpLCAiQnVmZmVyIHRvbyBzbWFsbCIpOwogI2Vu ZGlmCiAgICAgc3RyY3B5KGJ1ZiwgbWVzc2FnZSk7CiAgICAgd3JpdGVVbnNpZ25lZEludChidWYg KyBzdHJsZW4oYnVmKSwgc3lzY2FsbCk7Cg==