148539 2015-08-27 14:19:31 -0700 [Win CMake] Fix incremental build after r188673 2015-08-27 14:32:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1121421 0 achristensen 2015-08-27 14:19:31 -0700 Using CMake's file(COPY ...) copies files only when CMake is run, which is only when a CMakeLists.txt or PlatformWin.cmake is touched. When a header is changed but no files are added or removed, it breaks the incremental build. Using xcopy as a build step solves this. 1121426 1 260088 achristensen 2015-08-27 14:24:20 -0700 Created attachment 260088 Patch 1121433 2 260088 bfulgham 2015-08-27 14:29:10 -0700 Comment on attachment 260088 Patch r=me 1121435 3 achristensen 2015-08-27 14:32:05 -0700 r189055 260088 2015-08-27 14:24:20 -0700 2015-08-27 14:29:10 -0700 Patch bug-148539-20150827142407.patch text/plain 7400 achristensen SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5MDUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTA4LTI3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgW1dpbiBDTWFrZV0gRml4IGluY3JlbWVudGFsIGJ1aWxkIGFmdGVyIHIxODg2 NzMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODUz OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxh dGZvcm1XaW4uY21ha2U6CisgICAgICAgIFVzZSB4Y29weSBhcyBhIGJ1aWxkIHN0ZXAgaW5zdGVh ZCBvZiBmaWxlKENPUFkgLi4uKSB0byBjb3B5IHVwZGF0ZWQgaGVhZGVycy4KKwogMjAxNS0wOC0y NyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGFkZCBhIGNvbW1lbnQgdG8gZGVzY3JpYmUgc29tZXRoaW5nIEkgbGVhcm5lZCBhYm91dCBhIGNv bmZ1c2luZ2x5LW5hbWVkIGZ1bmN0aW9uLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL1Bs YXRmb3JtV2luLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0 Zm9ybVdpbi5jbWFrZQkocmV2aXNpb24gMTg5MDQ4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L1BsYXRmb3JtV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0zNSwxNSArMzUsMTIgQEAgZmls ZShDT1BZCiAgICAgJHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9CiApCiAKK2ZpbGUo TUFLRV9ESVJFQ1RPUlkgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9Gb3J3YXJkaW5nSGVhZGVycy9K YXZhU2NyaXB0Q29yZSkKK3NldChKYXZhU2NyaXB0Q29yZV9QT1NUX0JVSUxEX0NPTU1BTkQgIiR7 Q01BS0VfQklOQVJZX0RJUn0vRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUvcG9zdEJ1aWxk LmNtZCIpCitmaWxlKFdSSVRFICIke0phdmFTY3JpcHRDb3JlX1BPU1RfQlVJTERfQ09NTUFORH0i ICJAeGNvcHkgL3kgL2QgL2YgXCIke0RFUklWRURfU09VUkNFU19ESVJ9L0phdmFTY3JpcHRDb3Jl LyouaFwiIFwiJHtERVJJVkVEX1NPVVJDRVNfRElSfS9Gb3J3YXJkaW5nSGVhZGVycy9KYXZhU2Ny aXB0Q29yZVwiID5udWwgMj5udWxcbiIpCitmaWxlKEFQUEVORCAiJHtKYXZhU2NyaXB0Q29yZV9Q T1NUX0JVSUxEX0NPTU1BTkR9IiAiQHhjb3B5IC95IC9kIC9mIFwiJHtERVJJVkVEX1NPVVJDRVNf RElSfS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvKi5oXCIgXCIke0RFUklWRURfU09VUkNFU19E SVJ9L0ZvcndhcmRpbmdIZWFkZXJzL0phdmFTY3JpcHRDb3JlXCIgPm51bCAyPm51bFxuIikKIGZv cmVhY2ggKF9kaXJlY3RvcnkgJHtKYXZhU2NyaXB0Q29yZV9GT1JXQVJESU5HX0hFQURFUlNfRElS RUNUT1JJRVN9KQotICAgIGZpbGUoR0xPQiBfZmlsZXMgIiR7SkFWQVNDUklQVENPUkVfRElSfS8k e19kaXJlY3Rvcnl9LyouaCIpCi0gICAgZm9yZWFjaCAoX2ZpbGUgJHtfZmlsZXN9KQotICAgICAg ICBmaWxlKENPUFkgJHtfZmlsZX0gREVTVElOQVRJT04gIiR7REVSSVZFRF9TT1VSQ0VTX0RJUn0v Rm9yd2FyZGluZ0hlYWRlcnMvSmF2YVNjcmlwdENvcmUiKQotICAgIGVuZGZvcmVhY2ggKCkKKyAg ICBmaWxlKEFQUEVORCAiJHtKYXZhU2NyaXB0Q29yZV9QT1NUX0JVSUxEX0NPTU1BTkR9IiAiQHhj b3B5IC95IC9kIC9mIFwiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9LyR7X2RpcmVjdG9yeX0vKi5oXCIg XCIke0RFUklWRURfU09VUkNFU19ESVJ9L0ZvcndhcmRpbmdIZWFkZXJzL0phdmFTY3JpcHRDb3Jl XCIgPm51bCAyPm51bFxuIikKIGVuZGZvcmVhY2ggKCkKIAotc2V0KEphdmFTY3JpcHRDb3JlX1BP U1RfQlVJTERfQ09NTUFORCAiJHtDTUFLRV9CSU5BUllfRElSfS9EZXJpdmVkU291cmNlcy9KYXZh U2NyaXB0Q29yZS9wb3N0QnVpbGQuY21kIikKLWZpbGUoV1JJVEUgIiR7SmF2YVNjcmlwdENvcmVf UE9TVF9CVUlMRF9DT01NQU5EfSIgIkB4Y29weSAveSAvZCAvZiBcIiR7REVSSVZFRF9TT1VSQ0VT X0RJUn0vSmF2YVNjcmlwdENvcmUvKi5oXCIgXCIke0RFUklWRURfU09VUkNFU19ESVJ9L0Zvcndh cmRpbmdIZWFkZXJzL0phdmFTY3JpcHRDb3JlXCIgPm51bCAyPm51bFxuQHhjb3B5IC95IC9kIC9m IFwiJHtERVJJVkVEX1NPVVJDRVNfRElSfS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvKi5oXCIg XCIke0RFUklWRURfU09VUkNFU19ESVJ9L0ZvcndhcmRpbmdIZWFkZXJzL0phdmFTY3JpcHRDb3Jl XCIgPm51bCAyPm51bFxuIikKLWZpbGUoTUFLRV9ESVJFQ1RPUlkgJHtERVJJVkVEX1NPVVJDRVNf RElSfS9Gb3J3YXJkaW5nSGVhZGVycy9KYXZhU2NyaXB0Q29yZSkKLQogc2V0KEphdmFTY3JpcHRD b3JlX09VVFBVVF9OQU1FIEphdmFTY3JpcHRDb3JlJHtERUJVR19TVUZGSVh9KQpJbmRleDogU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkocmV2aXNpb24gMTg5MDUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDgtMjcgIEFsZXggQ2hyaXN0ZW5zZW4g IDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbV2luIENNYWtlXSBGaXggaW5j cmVtZW50YWwgYnVpbGQgYWZ0ZXIgcjE4ODY3MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBQbGF0Zm9y bVdpbi5jbWFrZToKKyAgICAgICAgVXNlIHhjb3B5IGFzIGEgYnVpbGQgc3RlcCBpbnN0ZWFkIG9m IGZpbGUoQ09QWSAuLi4pIHRvIGNvcHkgdXBkYXRlZCBoZWFkZXJzLgorCiAyMDE1LTA4LTI3ICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lP TiAocjE4ODk4Nyk6IGltcG9ydGVkL21vemlsbGEvc3ZnL2ZpbHRlcnMvZmVDb252b2x2ZU1hdHJp eC0xLnN2ZyBmYWlscwpJbmRleDogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDE4OTA0OCkK KysrIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zNjE1 LDYgKzM2MTUsMTEgQEAgaWYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUNYWCBBTkQgIiR7TE9XRQog ICAgIEFERF9UQVJHRVRfUFJPUEVSVElFUyhXZWJDb3JlIENPTVBJTEVfRkxBR1MgIi1mbm8tdHJl ZS1zcmEiKQogZW5kaWYgKCkKIAoraWYgKFdlYkNvcmVfUFJFX0JVSUxEX0NPTU1BTkQpCisgICAg YWRkX2N1c3RvbV90YXJnZXQoV2ViQ29yZVByZUJ1aWxkIENPTU1BTkQgJHtXZWJDb3JlX1BSRV9C VUlMRF9DT01NQU5EfSBWRVJCQVRJTSkKKyAgICBhZGRfZGVwZW5kZW5jaWVzKFdlYkNvcmUgV2Vi Q29yZVByZUJ1aWxkKQorZW5kaWYgKCkKKwogaWYgKFdlYkNvcmVfUE9TVF9CVUlMRF9DT01NQU5E KQogICAgIGFkZF9jdXN0b21fY29tbWFuZChUQVJHRVQgV2ViQ29yZSBQT1NUX0JVSUxEIENPTU1B TkQgJHtXZWJDb3JlX1BPU1RfQlVJTERfQ09NTUFORH0gVkVSQkFUSU0pCiBlbmRpZiAoKQpJbmRl eDogU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XaW4uY21ha2UKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUGxhdGZvcm1XaW4uY21ha2UJKHJldmlzaW9uIDE4OTA0OCkKKysrIFNvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0yNzEsMjEgKzI3MSwx NCBAQCBlbmRpZiAoKQogCiBmaWxlKE1BS0VfRElSRUNUT1JZICR7REVSSVZFRF9TT1VSQ0VTX0RJ Un0vRm9yd2FyZGluZ0hlYWRlcnMvV2ViQ29yZSkKIAorc2V0KFdlYkNvcmVfUFJFX0JVSUxEX0NP TU1BTkQgIiR7Q01BS0VfQklOQVJZX0RJUn0vRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9wcmVCdWls ZC5jbWQiKQorZmlsZShXUklURSAiJHtXZWJDb3JlX1BSRV9CVUlMRF9DT01NQU5EfSIgIkB4Y29w eSAveSAvcyAvZCAvZiBcIiR7V0VCQ09SRV9ESVJ9L0ZvcndhcmRpbmdIZWFkZXJzLyouaFwiIFwi JHtERVJJVkVEX1NPVVJDRVNfRElSfS9Gb3J3YXJkaW5nSGVhZGVycy9XZWJDb3JlXCIgPm51bCAy Pm51bFxuIikKIGZvcmVhY2ggKF9kaXJlY3RvcnkgJHtXZWJDb3JlX0ZPUldBUkRJTkdfSEVBREVS U19ESVJFQ1RPUklFU30pCi0gICAgZmlsZShHTE9CIF9maWxlcyAiJHtXRUJDT1JFX0RJUn0vJHtf ZGlyZWN0b3J5fS8qLmgiKQotICAgIGZvcmVhY2ggKF9maWxlICR7X2ZpbGVzfSkKLSAgICAgICAg ZmlsZShDT1BZICR7X2ZpbGV9IERFU1RJTkFUSU9OICIke0RFUklWRURfU09VUkNFU19ESVJ9L0Zv cndhcmRpbmdIZWFkZXJzL1dlYkNvcmUiKQotICAgIGVuZGZvcmVhY2ggKCkKKyAgICBmaWxlKEFQ UEVORCAiJHtXZWJDb3JlX1BSRV9CVUlMRF9DT01NQU5EfSIgIkB4Y29weSAveSAvZCAvZiBcIiR7 V0VCQ09SRV9ESVJ9LyR7X2RpcmVjdG9yeX0vKi5oXCIgXCIke0RFUklWRURfU09VUkNFU19ESVJ9 L0ZvcndhcmRpbmdIZWFkZXJzL1dlYkNvcmVcIiA+bnVsIDI+bnVsXG4iKQogZW5kZm9yZWFjaCAo KQogCi0jIFRoZXNlIGZvcndhcmRpbmcgaGVhZGVycyBuZWVkIHRvIGtlZXAgdGhlaXIgZGlyZWN0 b3J5IHN0cnVjdHVyZS4KIHNldChXZWJDb3JlX1BPU1RfQlVJTERfQ09NTUFORCAiJHtDTUFLRV9C SU5BUllfRElSfS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL3Bvc3RCdWlsZC5jbWQiKQotZmlsZShX UklURSAiJHtXZWJDb3JlX1BPU1RfQlVJTERfQ09NTUFORH0iICJAeGNvcHkgL3kgL3MgL2QgL2Yg XCIke1dFQkNPUkVfRElSfS9Gb3J3YXJkaW5nSGVhZGVycy8qLmhcIiBcIiR7REVSSVZFRF9TT1VS Q0VTX0RJUn0vRm9yd2FyZGluZ0hlYWRlcnMvV2ViQ29yZVwiID5udWwgMj5udWxcbkB4Y29weSAv eSAvcyAvZCAvZiBcIiR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS8qLmhcIiBcIiR7REVS SVZFRF9TT1VSQ0VTX0RJUn0vRm9yd2FyZGluZ0hlYWRlcnMvV2ViQ29yZVwiID5udWwgMj5udWxc biIpCi0KLWZpbGUoR0xPQl9SRUNVUlNFIF9maWxlcyAiJHtXRUJDT1JFX0RJUn0vRm9yd2FyZGlu Z0hlYWRlcnMvKi5oIikKLWZvcmVhY2ggKF9maWxlICR7X2ZpbGVzfSkKLSAgICBmaWxlKENPUFkg JHtfZmlsZX0gREVTVElOQVRJT04gIiR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vRm9yd2FyZGluZ0hl YWRlcnMvV2ViQ29yZSIpCi1lbmRmb3JlYWNoICgpCitmaWxlKFdSSVRFICIke1dlYkNvcmVfUE9T VF9CVUlMRF9DT01NQU5EfSIgIkB4Y29weSAveSAvcyAvZCAvZiBcIiR7REVSSVZFRF9TT1VSQ0VT X1dFQkNPUkVfRElSfS8qLmhcIiBcIiR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vRm9yd2FyZGluZ0hl YWRlcnMvV2ViQ29yZVwiID5udWwgMj5udWxcbiIpCiAKIHNldChXZWJDb3JlX09VVFBVVF9OQU1F CiAgICAgV2ViQ29yZSR7REVCVUdfU1VGRklYfQpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5MDUwKQorKysgVG9vbHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDgtMjcgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbV2luIENN YWtlXSBGaXggaW5jcmVtZW50YWwgYnVpbGQgYWZ0ZXIgcjE4ODY3MworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NTM5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRmb3Jt V2luLmNtYWtlOgorICAgICAgICBDb3B5IGZvcndhcmRpbmcgaGVhZGVycyBmcm9tIFdlYkNvcmUg YmVmb3JlIGJ1aWxkaW5nIGluIGNhc2UgdGhhdCB3YXMgbm90IHlldCBkb25lLgorICAgICAgICBJ dCB1c2VkIHRvIGJlIGRvbmUgd2hlbiBydW5uaW5nIENNYWtlLCBidXQgbm93IGl0J3MgYSBidWls ZCBzdGVwLgorCiAyMDE1LTA4LTI3ICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgQVg6IEZpeCBhY2Nlc3NpYmlsaXR5L3NlbGVjdC1lbGVtZW50LWF0LWluZGV4Lmh0bWwg dGVzdApJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdpbi5jbWFrZQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtV2luLmNtYWtlCShyZXZpc2lvbiAx ODkwNDgpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtV2luLmNtYWtlCSh3b3JraW5n IGNvcHkpCkBAIC0yLDYgKzIsMTEgQEAgc2V0KFRFU1RXRUJLSVRBUElfUlVOVElNRV9PVVRQVVRf RElSRUNUTwogc2V0KFRFU1RXRUJLSVRBUElfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZX1dURiAi JHtURVNUV0VCS0lUQVBJX1JVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWX0iKQogYWRkX2RlZmluaXRp b25zKC1EVVNFX0NPTlNPTEVfRU5UUllfUE9JTlQpCiAKK2FkZF9jdXN0b21fdGFyZ2V0KGZvcndh cmRpbmctaGVhZGVyc1dpbkZvclRlc3RXZWJLaXRBUEkKKyAgICBDT01NQU5EICR7Q01BS0VfQklO QVJZX0RJUn0vRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9wcmVCdWlsZC5jbWQgVkVSQkFUSU0KKykK K3NldChGb3J3YXJkaW5nSGVhZGVyc0ZvclRlc3RXZWJLaXRBUElfTkFNRSBmb3J3YXJkaW5nLWhl YWRlcnNXaW5Gb3JUZXN0V2ViS2l0QVBJKQorCiBpZiAoJHtXVEZfUExBVEZPUk1fV0lOX0NBSVJP fSkKICAgICBhZGRfZGVmaW5pdGlvbnMoLURXSU5fQ0FJUk8pCiBlbmRpZiAoKQo=