148535 2015-08-27 11:40:51 -0700 The status message for combined builder queues should say "all builds passed" if everything built correctly. 2016-02-04 12:01:11 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=153882 P2 Normal --- 1 jmarcell webkit-unassigned adele ap bburg commit-queue dbates dean_johnson jake.nielsen.webkit jmarcell oldest_to_newest 1121382 0 jmarcell 2015-08-27 11:40:51 -0700 The status message for combined builder queues should say "all builds passed" if everything built correctly. 1121383 1 260073 jmarcell 2015-08-27 11:43:41 -0700 Created attachment 260073 Patch 1121494 2 260073 ddkilzer 2015-08-27 16:57:34 -0700 Comment on attachment 260073 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260073&action=review r=me if you fix the nit. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:90 > + var statusMessagePassed = "all " + (queue.builder ? "builds" : "tests") + " passed" Nit: This should have a semi-colon at the end of the line. 1121502 3 260099 jmarcell 2015-08-27 17:22:32 -0700 Created attachment 260099 Patch 1121504 4 260099 ddkilzer 2015-08-27 17:33:02 -0700 Comment on attachment 260099 Patch r=me 1121701 5 ap 2015-08-28 08:58:22 -0700 This should probably be "all builds succeeded", not "all builds passed". 1121743 6 260163 jmarcell 2015-08-28 10:47:17 -0700 Created attachment 260163 Patch 1121758 7 260163 commit-queue 2015-08-28 11:13:55 -0700 Comment on attachment 260163 Patch Clearing flags on attachment: 260163 Committed r189106: <http://trac.webkit.org/changeset/189106> 1121759 8 commit-queue 2015-08-28 11:13:59 -0700 All reviewed patches have been landed. Closing bug. 260073 2015-08-27 11:43:41 -0700 2015-08-27 17:22:28 -0700 Patch bug-148535-20150827114329.patch text/plain 2125 jmarcell ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNmFj NjJmMjI1NDNmZTdlMmJkNmU2MDY3MzhhZDFlZWZmYjY1MmRiLi4wMTFjN2UwZGIwZWY2ZmNjOTA2 MjI2NjdiMDU0MTlmNWNhNDg1MTI5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDgtMjcgIEphc29uIE1hcmNl bGwgIDxqbWFyY2VsbEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIHN0YXR1cyBtZXNzYWdlIGZv ciBjb21iaW5lZCBidWlsZGVyIHF1ZXVlcyBzaG91bGQgc2F5ICJhbGwgYnVpbGRzIHBhc3NlZCIg aWYgZXZlcnl0aGluZyBidWlsdCBjb3JyZWN0bHkuCisgICAgICAgIGJ1aWx0IGNvcnJlY3RseS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODUzNQor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RDb21iaW5lZFF1ZXVlVmlldy5qczoK KyAgICAgICAgKEJ1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcucHJvdG90eXBlLnVwZGF0ZSk6IE1h a2Ugc3RhdHVzIG1lc3NhZ2UgZm9yIGNvbWJpbmVkIGJ1aWxkZXIgcXVldWVzCisgICAgICAgIHNh eSAiYWxsIGJ1aWxkcyBwYXNzZWQiIGlmIGV2ZXJ5dGhpbmcgYnVpbHQgY29ycmVjdGx5LgorCiAy MDE1LTA4LTI3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgQnVpbGQgZml4IGFmdGVyIHIxODg5ODIKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TY3JpcHRzL0J1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcuanMgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9CdWlsZGJvdENvbWJpbmVkUXVldWVWaWV3LmpzCmluZGV4IGZhOTZlMDBlM2ZjZGM2MmQ4 ZThhZjljNDZmOGU3YmEwNDk2OGYzYjcuLmU2YTY1NTJkNTg5NDExODBmZDljMDZlYWM5ZWU3Nzgw NTQwMDc1MDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90Q29tYmlu ZWRRdWV1ZVZpZXcuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RDb21iaW5l ZFF1ZXVlVmlldy5qcwpAQCAtODcsNyArODcsOCBAQCBCdWlsZGJvdENvbWJpbmVkUXVldWVWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuX2FwcGVuZFBlbmRpbmdSZXZpc2lvbkNv dW50KHNsb3dlc3RRdWV1ZSk7CiAKICAgICAgICAgICAgIHZhciBtZXNzYWdlID0gdGhpcy5yZXZp c2lvbkNvbnRlbnRGb3JJdGVyYXRpb24oc2xvd2VzdFF1ZXVlLm1vc3RSZWNlbnRTdWNjZXNzZnVs SXRlcmF0aW9uKTsKLSAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZpZXco bWVzc2FnZSwgU3RhdHVzTGluZVZpZXcuU3RhdHVzLkdvb2QsICJhbGwgdGVzdHMgcGFzc2VkIiwg bnVsbCwgbnVsbCk7CisgICAgICAgICAgICB2YXIgc3RhdHVzTWVzc2FnZVBhc3NlZCA9ICJhbGwg IiArIChxdWV1ZS5idWlsZGVyID8gImJ1aWxkcyIgOiAidGVzdHMiKSArICIgcGFzc2VkIgorICAg ICAgICAgICAgdmFyIHN0YXR1cyA9IG5ldyBTdGF0dXNMaW5lVmlldyhtZXNzYWdlLCBTdGF0dXNM aW5lVmlldy5TdGF0dXMuR29vZCwgc3RhdHVzTWVzc2FnZVBhc3NlZCwgbnVsbCwgbnVsbCk7CiAg ICAgICAgICAgICBuZXcgUG9wb3ZlclRyYWNrZXIoc3RhdHVzLnN0YXR1c0J1YmJsZUVsZW1lbnQs IHRoaXMuX3ByZXNlbnRQb3BvdmVyRm9yQ29tYmluZWRHcmVlbkJ1YmJsZS5iaW5kKHRoaXMpKTsK ICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZChzdGF0dXMuZWxlbWVudCk7CiAg ICAgICAgIH0gZWxzZSB7Cg== 260099 2015-08-27 17:22:32 -0700 2015-08-28 10:47:12 -0700 Patch bug-148535-20150827172220.patch text/plain 2163 jmarcell ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNmFj NjJmMjI1NDNmZTdlMmJkNmU2MDY3MzhhZDFlZWZmYjY1MmRiLi4xODYyMGYyOTU2NzMyMzQzZjI1 NGFjYjg2MTIyNDI4NjlmMDA1MTY4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDgtMjcgIEphc29uIE1hcmNl bGwgIDxqbWFyY2VsbEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIHN0YXR1cyBtZXNzYWdlIGZv ciBjb21iaW5lZCBidWlsZGVyIHF1ZXVlcyBzaG91bGQgc2F5ICJhbGwgYnVpbGRzIHBhc3NlZCIg aWYgZXZlcnl0aGluZyBidWlsdCBjb3JyZWN0bHkuCisgICAgICAgIGJ1aWx0IGNvcnJlY3RseS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODUzNQor CisgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEtpbHplci4KKworICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL0J1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcuanM6CisgICAgICAgIChCdWlsZGJvdENv bWJpbmVkUXVldWVWaWV3LnByb3RvdHlwZS51cGRhdGUpOiBNYWtlIHN0YXR1cyBtZXNzYWdlIGZv ciBjb21iaW5lZCBidWlsZGVyIHF1ZXVlcworICAgICAgICBzYXkgImFsbCBidWlsZHMgcGFzc2Vk IiBpZiBldmVyeXRoaW5nIGJ1aWx0IGNvcnJlY3RseS4KKwogMjAxNS0wOC0yNyAgQWxleCBDaHJp c3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeCBh ZnRlciByMTg4OTgyCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdENv bWJpbmVkUXVldWVWaWV3LmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RDb21iaW5l ZFF1ZXVlVmlldy5qcwppbmRleCBmYTk2ZTAwZTNmY2RjNjJkOGU4YWY5YzQ2ZjhlN2JhMDQ5Njhm M2I3Li40MmQyMGNmYjcxY2ZjM2QwZGMzNmYwYTQxODhlNjg5NjJlOGFhYmQ5IDEwMDY0NAotLS0g YS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNf aHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdENvbWJpbmVkUXVldWVWaWV3LmpzCisrKyBi L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19o dG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcuanMKQEAgLTg3 LDcgKzg3LDggQEAgQnVpbGRib3RDb21iaW5lZFF1ZXVlVmlldy5wcm90b3R5cGUgPSB7CiAgICAg ICAgICAgICB0aGlzLl9hcHBlbmRQZW5kaW5nUmV2aXNpb25Db3VudChzbG93ZXN0UXVldWUpOwog CiAgICAgICAgICAgICB2YXIgbWVzc2FnZSA9IHRoaXMucmV2aXNpb25Db250ZW50Rm9ySXRlcmF0 aW9uKHNsb3dlc3RRdWV1ZS5tb3N0UmVjZW50U3VjY2Vzc2Z1bEl0ZXJhdGlvbik7Ci0gICAgICAg ICAgICB2YXIgc3RhdHVzID0gbmV3IFN0YXR1c0xpbmVWaWV3KG1lc3NhZ2UsIFN0YXR1c0xpbmVW aWV3LlN0YXR1cy5Hb29kLCAiYWxsIHRlc3RzIHBhc3NlZCIsIG51bGwsIG51bGwpOworICAgICAg ICAgICAgdmFyIHN0YXR1c01lc3NhZ2VQYXNzZWQgPSAiYWxsICIgKyAocXVldWUuYnVpbGRlciA/ ICJidWlsZHMiIDogInRlc3RzIikgKyAiIHBhc3NlZCI7CisgICAgICAgICAgICB2YXIgc3RhdHVz ID0gbmV3IFN0YXR1c0xpbmVWaWV3KG1lc3NhZ2UsIFN0YXR1c0xpbmVWaWV3LlN0YXR1cy5Hb29k LCBzdGF0dXNNZXNzYWdlUGFzc2VkLCBudWxsLCBudWxsKTsKICAgICAgICAgICAgIG5ldyBQb3Bv dmVyVHJhY2tlcihzdGF0dXMuc3RhdHVzQnViYmxlRWxlbWVudCwgdGhpcy5fcHJlc2VudFBvcG92 ZXJGb3JDb21iaW5lZEdyZWVuQnViYmxlLmJpbmQodGhpcykpOwogICAgICAgICAgICAgdGhpcy5l bGVtZW50LmFwcGVuZENoaWxkKHN0YXR1cy5lbGVtZW50KTsKICAgICAgICAgfSBlbHNlIHsK 260163 2015-08-28 10:47:17 -0700 2015-08-28 11:13:55 -0700 Patch bug-148535-20150828104704.patch text/plain 2208 jmarcell ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzQ3 M2I5YTRlYTY2N2IzOGU0ZmE3NDg0OTQ5MTFmY2JjN2NmMjAwLi5hMTFlM2RkMGEzMmQwMjMwMjMx MzUyZWY4Njg3MGM0N2FmNWI0ZWIwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDgtMjcgIEphc29uIE1hcmNl bGwgIDxqbWFyY2VsbEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIHN0YXR1cyBtZXNzYWdlIGZv ciBjb21iaW5lZCBidWlsZGVyIHF1ZXVlcyBzaG91bGQgc2F5ICJhbGwgYnVpbGRzIHN1Y2NlZWRl ZCIgaWYgZXZlcnl0aGluZworICAgICAgICBidWlsdCBjb3JyZWN0bHkuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg1MzUKKworICAgICAgICBSZXZp ZXdlZCBieSBEYXZpZCBLaWx6ZXIgYW5kIEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAg KiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9k YXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdENvbWJpbmVkUXVldWVWaWV3LmpzOgorICAgICAgICAo QnVpbGRib3RDb21iaW5lZFF1ZXVlVmlldy5wcm90b3R5cGUudXBkYXRlKTogTWFrZSBzdGF0dXMg bWVzc2FnZSBmb3IgY29tYmluZWQgYnVpbGRlciBxdWV1ZXMKKyAgICAgICAgc2F5ICJhbGwgYnVp bGRzIHN1Y2NlZWRlZCIgaWYgZXZlcnl0aGluZyBidWlsdCBjb3JyZWN0bHkuCisKIDIwMTUtMDgt MjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIFNpbXBsaWZ5IHRoZSBpbnRlcm5hbCBBUEkgdG8gY3JlYXRlIGEgV2ViVmlldwpkaWZm IC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RDb21iaW5lZFF1ZXVlVmlldy5q cyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcuanMKaW5k ZXggZmE5NmUwMGUzZmNkYzYyZDhlOGFmOWM0NmY4ZTdiYTA0OTY4ZjNiNy4uYTExNTM0ZTU5NTM0 YzQ1YTZiNTQ2YzUyMmEzZGYwNmU4MDQ4ZmI3MiAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Nj cmlwdHMvQnVpbGRib3RDb21iaW5lZFF1ZXVlVmlldy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9CdWlsZGJvdENvbWJpbmVkUXVldWVWaWV3LmpzCkBAIC04Nyw3ICs4Nyw4IEBAIEJ1aWxk Ym90Q29tYmluZWRRdWV1ZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICAgICAgdGhpcy5fYXBw ZW5kUGVuZGluZ1JldmlzaW9uQ291bnQoc2xvd2VzdFF1ZXVlKTsKIAogICAgICAgICAgICAgdmFy IG1lc3NhZ2UgPSB0aGlzLnJldmlzaW9uQ29udGVudEZvckl0ZXJhdGlvbihzbG93ZXN0UXVldWUu bW9zdFJlY2VudFN1Y2Nlc3NmdWxJdGVyYXRpb24pOwotICAgICAgICAgICAgdmFyIHN0YXR1cyA9 IG5ldyBTdGF0dXNMaW5lVmlldyhtZXNzYWdlLCBTdGF0dXNMaW5lVmlldy5TdGF0dXMuR29vZCwg ImFsbCB0ZXN0cyBwYXNzZWQiLCBudWxsLCBudWxsKTsKKyAgICAgICAgICAgIHZhciBzdGF0dXNN ZXNzYWdlUGFzc2VkID0gImFsbCAiICsgKHF1ZXVlLmJ1aWxkZXIgPyAiYnVpbGRzIHN1Y2NlZWRl ZCIgOiAidGVzdHMgcGFzc2VkIik7CisgICAgICAgICAgICB2YXIgc3RhdHVzID0gbmV3IFN0YXR1 c0xpbmVWaWV3KG1lc3NhZ2UsIFN0YXR1c0xpbmVWaWV3LlN0YXR1cy5Hb29kLCBzdGF0dXNNZXNz YWdlUGFzc2VkLCBudWxsLCBudWxsKTsKICAgICAgICAgICAgIG5ldyBQb3BvdmVyVHJhY2tlcihz dGF0dXMuc3RhdHVzQnViYmxlRWxlbWVudCwgdGhpcy5fcHJlc2VudFBvcG92ZXJGb3JDb21iaW5l ZEdyZWVuQnViYmxlLmJpbmQodGhpcykpOwogICAgICAgICAgICAgdGhpcy5lbGVtZW50LmFwcGVu ZENoaWxkKHN0YXR1cy5lbGVtZW50KTsKICAgICAgICAgfSBlbHNlIHsK