148512 2015-08-26 21:42:22 -0700 fast/css/object-fit/object-fit-embed.html isn't testing anything 2015-08-27 16:53:04 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=143743 P2 Normal --- 1 ap thorton aestes simon.fraser thorton oldest_to_newest 1121194 0 ap 2015-08-26 21:42:22 -0700 Positively bisected the flakiness to http://trac.webkit.org/r188807 - when the test fails, expected result seems to be dumped too early, before load finishes. I can reproduce on a debug build like this: run-webkit-tests fast/css/object-fit/object-fit-embed.html --repeat 50 -f --no-retry --no-show 1121199 1 thorton 2015-08-26 21:53:35 -0700 Interesting! I'll look at this tomorrow. 1121201 2 thorton 2015-08-26 21:58:06 -0700 It's fairly amazing that only one (or three or so) tests would be made flaky by this, if we really are snapshotting at the wrong time... 1121359 3 thorton 2015-08-27 10:56:16 -0700 Even upping it to 500, this doesn't repro for me. 1121459 4 thorton 2015-08-27 15:55:22 -0700 Alexey and I have learned a lot (like, for example, this test was previously not working correctly, but previously both the expected and actual would fail in the same way). It would appear that we are trying to use the "WebKit Test PlugIn" to load our PNG instead of an ImageDocument. And indeed, the plugin claims to load PNGs. Not yet sure why it ever sometimes works correctly, though. 1121462 5 thorton 2015-08-27 15:57:52 -0700 The test similarly behaves wrongly in DRT. 1121464 6 thorton 2015-08-27 16:04:38 -0700 And doing a: testRunner.setPluginsEnabled(false); makes it behave correctly. This does not, however, explain why the test became flaky (it should *always* behave incorrectly, consistently) with my patch on the bots and on Alexey's machine. 1121467 7 thorton 2015-08-27 16:06:34 -0700 Patch came from Blink, smfr merged it. That probably explains how we ended up with a broken test. 1121468 8 thorton 2015-08-27 16:06:54 -0700 (In reply to comment #7) > Patch came from Blink, smfr merged it. That probably explains how we ended > up with a broken test. Also, this is one of the bizarre downsides of reftests. 1121483 9 thorton 2015-08-27 16:41:56 -0700 (In reply to comment #4) > Not yet sure why it ever sometimes works correctly, though. Alexey has another bug about sometimes not loading plugins when we should, and is going to investigate that part separately. I'm going to post a patch to disable plugins in the few tests that are affected by the test plugin's handling of PNGs. 1121484 10 260096 thorton 2015-08-27 16:46:31 -0700 Created attachment 260096 Patch 1121487 11 thorton 2015-08-27 16:53:04 -0700 http://trac.webkit.org/changeset/189073 Alexey, can you relate the bug you're working on? 260096 2015-08-27 16:46:31 -0700 2015-08-27 16:50:37 -0700 Patch bug-148512-20150827164619.patch text/plain 4016 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MDU5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGVmMWNhMWViMDUzNzY0NDhmYTVl MjRmNjgxNmEwM2NhZDc5OTQyOC4uMDQ5ZjQ5MDMwNjM2NTkyYThiYTJmZjk4YWRlYTgxMTU3OGVh NWY4YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA4LTI3ICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIGZhc3QvY3NzL29iamVjdC1maXQvb2Jq ZWN0LWZpdC1lbWJlZC5odG1sIGlzbid0IHRlc3RpbmcgYW55dGhpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODUxMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9jc3Mvb2JqZWN0LWZpdC9v YmplY3QtZml0LWVtYmVkLWV4cGVjdGVkLmh0bWw6CisgICAgICAgICogZmFzdC9jc3Mvb2JqZWN0 LWZpdC9vYmplY3QtZml0LWVtYmVkLmh0bWw6CisgICAgICAgICogZmFzdC9yZXBsYWNlZC9ib3Jk ZXItcmFkaXVzLWNsaXAtY29udGVudC1lZGdlLmh0bWw6CisgICAgICAgICogZmFzdC9yZXBsYWNl ZC9vdXRsaW5lLXJlcGxhY2VkLWVsZW1lbnRzLmh0bWw6CisgICAgICAgIFRoZXNlIHRlc3RzIGxv YWQgUE5HcyBpbnNpZGUgPGVtYmVkcz4uIHI4MjAwMSBtYWRlIGl0IHNvIHRoYXQKKyAgICAgICAg dGhlIHRlc3QgcGx1Z2luIGhhbmRsZXMgUE5HcywgYW5kIGFsc28gc28gdGhhdCA8ZW1iZWQ+IHBy ZWZlcnMKKyAgICAgICAgcGx1Z2lucyBldmVuIGZvciB0eXBlcyB0aGF0IHdlIGtub3cgaG93IHRv IGhhbmRsZSBuYXRpdmVseS4KKworICAgICAgICBTaW5jZSB0aGVzZSB0ZXN0cyBhY3R1YWxseSB3 YW50IHRvIGxvYWQgUE5HcyBuYXRpdmVseSwgZGlzYWJsZQorICAgICAgICBwbHVnaW5zIHNvIHdl IGRvbid0IGdldCB0aGF0IGJlaGF2aW9yLgorCiAyMDE1LTA4LTI3ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRG9jdW1lbnQgd2luZG93Lk5vZGVGaWx0ZXIgcHJv cGVydGllcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvb2JqZWN0LWZpdC9vYmpl Y3QtZml0LWVtYmVkLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9vYmplY3Qt Zml0L29iamVjdC1maXQtZW1iZWQtZXhwZWN0ZWQuaHRtbAppbmRleCBkNGQ3MzA5MjcwYjE5ZDI5 NjgzZGJiNDc3YzNiZTMxM2IwMzAwNjBhLi42ZWM3YWIwYWUyMDgxNDgxNTFjZmZlMDFlZTZkZWM0 MDMxMTRjZWEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9vYmplY3QtZml0L29i amVjdC1maXQtZW1iZWQtZXhwZWN0ZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9v YmplY3QtZml0L29iamVjdC1maXQtZW1iZWQtZXhwZWN0ZWQuaHRtbApAQCAtMjMsNiArMjMsMTEg QEAKICAgICAgIC5ncm91cCA+ICo6bnRoLWNoaWxkKDYpICogeyB3aWR0aDoxMDAlOyBtYXJnaW4t dG9wOjI1JTsgfQogICAgICAgLmdyb3VwID4gKjpudGgtY2hpbGQoNykgKiB7IHdpZHRoOjEwMCU7 IGhlaWdodDoxMDAlOyB9CiAgICAgPC9zdHlsZT4KKyAgICA8c2NyaXB0PgorICAgIC8vIERpc2Fi bGUgcGx1Z2lucywgYmVjYXVzZSBvdGhlcndpc2UgdGhlICJUZXN0IFdlYktpdCBQbHVnSW4iIHN0 ZWFscyA8ZW1iZWQ+cyByZWZlcmVuY2luZyBQTkdzLgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5l cikKKyAgICAgIHRlc3RSdW5uZXIuc2V0UGx1Z2luc0VuYWJsZWQoZmFsc2UpOworICAgIDwvc2Ny aXB0PgogICA8L2hlYWQ+CiAgIDxib2R5PgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9vYmplY3QtZml0L29iamVjdC1maXQtZW1iZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL29iamVjdC1maXQvb2JqZWN0LWZpdC1lbWJlZC5odG1sCmluZGV4IGQ4NGRkNzc2MDcxNWIx NDE0ZWJjYTQ3ZjQ2MmY0ZGU0OWM1ZDJjMDYuLjZhNTk5MjRmYmU2MWEyNzFlMmNjZTc4ZjFlY2Ri YjZjZTYwYWVjNDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL29iamVjdC1maXQv b2JqZWN0LWZpdC1lbWJlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL29iamVjdC1m aXQvb2JqZWN0LWZpdC1lbWJlZC5odG1sCkBAIC0yMSw2ICsyMSwxMSBAQAogICAgICAgLmdyb3Vw ID4gKjpudGgtY2hpbGQoNikgeyBvYmplY3QtZml0OiBpbmhlcml0OyB9CiAgICAgICAuZ3JvdXAg PiAqOm50aC1jaGlsZCg3KSB7IH0KICAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+CisgICAgLy8g RGlzYWJsZSBwbHVnaW5zLCBiZWNhdXNlIG90aGVyd2lzZSB0aGUgIlRlc3QgV2ViS2l0IFBsdWdJ biIgc3RlYWxzIDxlbWJlZD5zIHJlZmVyZW5jaW5nIFBOR3MuCisgICAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyKQorICAgICAgdGVzdFJ1bm5lci5zZXRQbHVnaW5zRW5hYmxlZChmYWxzZSk7CisgICAg PC9zY3JpcHQ+CiAgIDwvaGVhZD4KICAgPGJvZHk+CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvcmVwbGFjZWQvYm9yZGVyLXJhZGl1cy1jbGlwLWNvbnRlbnQtZWRnZS5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9yZXBsYWNlZC9ib3JkZXItcmFkaXVzLWNsaXAtY29udGVudC1lZGdlLmh0 bWwKaW5kZXggYWUzMWRhMzk2YTEzZDU5MTAwYTdiMWEwYTAwMjQ2NjFhY2MyNThhNC4uZjI0NWZl OTk0NTU4M2E4MTU5ODlmY2I0ODU0MTdkMWU3MGVhYjYyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9yZXBsYWNlZC9ib3JkZXItcmFkaXVzLWNsaXAtY29udGVudC1lZGdlLmh0bWwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBsYWNlZC9ib3JkZXItcmFkaXVzLWNsaXAtY29udGVudC1l ZGdlLmh0bWwKQEAgLTMyLDYgKzMyLDEyIEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogPGJv ZHk+CiA8IS0tIFJlcGxhY2VkIGVsZW1lbnRzIHdpdGggYm9yZGVyLXJhZGl1cyBzaG91bGQgY2xp cCB0byB0aGUgY29udGVudCBlZGdlIGN1cnZlLiAtLT4KIAorPHNjcmlwdD4KKy8vIERpc2FibGUg cGx1Z2lucywgYmVjYXVzZSBvdGhlcndpc2UgdGhlICJUZXN0IFdlYktpdCBQbHVnSW4iIHN0ZWFs cyA8ZW1iZWQ+cyByZWZlcmVuY2luZyBQTkdzLgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICB0 ZXN0UnVubmVyLnNldFBsdWdpbnNFbmFibGVkKGZhbHNlKTsKKzwvc2NyaXB0PgorCiA8ZGl2Pgog ICA8b2JqZWN0IGRhdGE9InJlc291cmNlcy9zcXVhcmUtYmx1ZS0xMDB4MTAwLnBuZyI+PC9vYmpl Y3Q+CiA8L2Rpdj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVwbGFjZWQvb3V0bGlu ZS1yZXBsYWNlZC1lbGVtZW50cy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBsYWNlZC9vdXRs aW5lLXJlcGxhY2VkLWVsZW1lbnRzLmh0bWwKaW5kZXggYzljNmM4Y2FkOWRjODc3Nzg4OGQ5MGY0 MmJiNTAwMzYxYzVkMDhkMi4uMDA0MzAwM2VmYTM1NDQ1ODJjNzZjYzBkZTQ4OThlNGQ2YWY4YWVi MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9yZXBsYWNlZC9vdXRsaW5lLXJlcGxhY2Vk LWVsZW1lbnRzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZXBsYWNlZC9vdXRsaW5lLXJl cGxhY2VkLWVsZW1lbnRzLmh0bWwKQEAgLTE5LDYgKzE5LDkgQEAKIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikgewogICAgIHZhciBkdW1wUGl4ZWxSZXN1bHRzID0gdHJ1ZTsKICAgICB0ZXN0UnVubmVy LmR1bXBBc1RleHQoZHVtcFBpeGVsUmVzdWx0cyk7CisgICAgCisgICAgLy8gRGlzYWJsZSBwbHVn aW5zLCBiZWNhdXNlIG90aGVyd2lzZSB0aGUgIlRlc3QgV2ViS2l0IFBsdWdJbiIgc3RlYWxzIDxl bWJlZD5zIHJlZmVyZW5jaW5nIFBOR3MuCisgICAgdGVzdFJ1bm5lci5zZXRQbHVnaW5zRW5hYmxl ZChmYWxzZSk7CiB9CiA8L3NjcmlwdD4KIAo=