148508 2015-08-26 18:04:14 -0700 Web Inspector: Uncaught exception in CSS Completion - TypeError: undefined is not an object (evaluating 'this._values[middleIndex].startsWith') 2015-08-26 18:28:26 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck webkit-unassigned bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1121141 0 joepeck 2015-08-26 18:04:14 -0700 * SUMMARY Uncaught exception in CSS Completion - TypeError: undefined is not an object (evaluating 'this._values[middleIndex].startsWith') * STEPS TO REPRODUCE 1. Inspect <body> on about:blank 2. Styles > Rules 3. Type "background: re" => while typing "re" each letter triggers uncaught exception trying to generate completions * EXCEPTION Resources/Models/CSSCompletions.js:211:42: CONSOLE ERROR TypeError: undefined is not an object (evaluating 'this._values[middleIndex].startsWith') * NOTES - A COMPATIBILITY(iOS 6) comment was true, but it was also used that way by other code. Restore the code. 1121146 1 260014 joepeck 2015-08-26 18:10:35 -0700 Created attachment 260014 [PATCH] Proposed Fix 1121150 2 260014 commit-queue 2015-08-26 18:28:23 -0700 Comment on attachment 260014 [PATCH] Proposed Fix Clearing flags on attachment: 260014 Committed r189008: <http://trac.webkit.org/changeset/189008> 1121151 3 commit-queue 2015-08-26 18:28:26 -0700 All reviewed patches have been landed. Closing bug. 260014 2015-08-26 18:10:35 -0700 2015-08-26 18:28:23 -0700 [PATCH] Proposed Fix fix-exception.patch text/plain 3438 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ4ZTcwMmMuLmQ1MDBjYjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTA4LTI2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIGluIENTUyBDb21wbGV0aW9uIC0gVHlwZUVycm9yOiB1bmRlZmluZWQgaXMg bm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy5fdmFsdWVzW21pZGRsZUluZGV4XS5zdGFy dHNXaXRoJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0ODUwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTQ29tcGxldGlvbnMuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQ1NTQ29tcGxldGlvbnMpOgorICAgICAgICBBZGQgYSBjb21tZW50IGV4cGxhaW5p bmcgdGhhdCB0aGUgY29uc3RydWN0b3IgbWF5IGJlIGNhbGxlZCB3aXRoCisgICAgICAgIGEgbGlz dCBvZiBzdHJpbmdzIG9yIGEgbGlzdCBvZiBvYmplY3RzIGZyb20gdGhlIHByb3RvY29sLiBBZGQK KyAgICAgICAgYSBmYXN0IHBhdGggZm9yIHdoZW4gdGhpcyBpcyBjb25zdHJ1Y3RlZCB3aXRoIGEg bGlzdCBvZiBzdHJpbmdzLgorCisyMDE1LTA4LTI2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2VwYXJhdGUgY3JlYXRpbmcg YSBzdHlsZSBzaGVldCBmcm9tIGFkZGluZyBhIG5ldyBydWxlIGluIHRoZSBwcm90b2NvbAogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NTAyCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1ND b21wbGV0aW9ucy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVs cy9DU1NDb21wbGV0aW9ucy5qcwppbmRleCA3NjZmNDEwLi5iMGMzOTA2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTQ29tcGxldGlvbnMu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0Nv bXBsZXRpb25zLmpzCkBAIC0zOSwyNCArMzksMzMgQEAgV2ViSW5zcGVjdG9yLkNTU0NvbXBsZXRp b25zID0gY2xhc3MgQ1NTQ29tcGxldGlvbnMKICAgICAgICAgdGhpcy5fbG9uZ2hhbmRzID0ge307 CiAgICAgICAgIHRoaXMuX3Nob3J0aGFuZHMgPSB7fTsKIAotICAgICAgICBmb3IgKHZhciBwcm9w ZXJ0eSBvZiBwcm9wZXJ0aWVzKSB7Ci0gICAgICAgICAgICB2YXIgcHJvcGVydHlOYW1lID0gcHJv cGVydHkubmFtZTsKLSAgICAgICAgICAgIHRoaXMuX3ZhbHVlcy5wdXNoKHByb3BlcnR5TmFtZSk7 CisgICAgICAgIC8vIFRoZSBgcHJvcGVydGllc2AgcGFyYW1ldGVyIGNhbiBiZSBlaXRoZXIgYSBs aXN0IG9mIG9iamVjdHMgd2l0aCAnbmFtZScgLyAnbG9uZ2hhbmQnCisgICAgICAgIC8vIHByb3Bl cnRpZXMgd2hlbiBpbml0aWFsaXplZCBmcm9tIHRoZSBwcm90b2NvbCBmb3IgQ1NTQ29tcGxldGlv bnMuY3NzTmFtZUNvbXBsZXRpb25zLgorICAgICAgICAvLyBPciBpdCBtYXkganVzdCBhIGxpc3Qg b2Ygc3RyaW5ncyB3aGVuIHF1aWNrbHkgaW5pdGlhbGl6ZWQgZm9yIG90aGVyIGNvbXBsZXRpb24g cHVycG9zZXMuCisgICAgICAgIGlmIChwcm9wZXJ0aWVzLmxlbmd0aCAmJiB0eXBlb2YgcHJvcGVy dGllc1swXSA9PT0gInN0cmluZyIpCisgICAgICAgICAgICB0aGlzLl92YWx1ZXMgPSB0aGlzLl92 YWx1ZXMuY29uY2F0KHByb3BlcnRpZXMpOworICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgIGZv ciAodmFyIHByb3BlcnR5IG9mIHByb3BlcnRpZXMpIHsKKyAgICAgICAgICAgICAgICB2YXIgcHJv cGVydHlOYW1lID0gcHJvcGVydHkubmFtZTsKKyAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2Vy dChwcm9wZXJ0eU5hbWUpOwogCi0gICAgICAgICAgICB2YXIgbG9uZ2hhbmRzID0gcHJvcGVydHku bG9uZ2hhbmRzOwotICAgICAgICAgICAgaWYgKGxvbmdoYW5kcykgewotICAgICAgICAgICAgICAg IHRoaXMuX2xvbmdoYW5kc1twcm9wZXJ0eU5hbWVdID0gbG9uZ2hhbmRzOworICAgICAgICAgICAg ICAgIHRoaXMuX3ZhbHVlcy5wdXNoKHByb3BlcnR5TmFtZSk7CiAKLSAgICAgICAgICAgICAgICBm b3IgKHZhciBqID0gMDsgaiA8IGxvbmdoYW5kcy5sZW5ndGg7ICsraikgewotICAgICAgICAgICAg ICAgICAgICB2YXIgbG9uZ2hhbmROYW1lID0gbG9uZ2hhbmRzW2pdOworICAgICAgICAgICAgICAg IHZhciBsb25naGFuZHMgPSBwcm9wZXJ0eS5sb25naGFuZHM7CisgICAgICAgICAgICAgICAgaWYg KGxvbmdoYW5kcykgeworICAgICAgICAgICAgICAgICAgICB0aGlzLl9sb25naGFuZHNbcHJvcGVy dHlOYW1lXSA9IGxvbmdoYW5kczsKIAotICAgICAgICAgICAgICAgICAgICB2YXIgc2hvcnRoYW5k cyA9IHRoaXMuX3Nob3J0aGFuZHNbbG9uZ2hhbmROYW1lXTsKLSAgICAgICAgICAgICAgICAgICAg aWYgKCFzaG9ydGhhbmRzKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBzaG9ydGhhbmRzID0g W107Ci0gICAgICAgICAgICAgICAgICAgICAgICB0aGlzLl9zaG9ydGhhbmRzW2xvbmdoYW5kTmFt ZV0gPSBzaG9ydGhhbmRzOworICAgICAgICAgICAgICAgICAgICBmb3IgKHZhciBqID0gMDsgaiA8 IGxvbmdoYW5kcy5sZW5ndGg7ICsraikgeworICAgICAgICAgICAgICAgICAgICAgICAgdmFyIGxv bmdoYW5kTmFtZSA9IGxvbmdoYW5kc1tqXTsKKworICAgICAgICAgICAgICAgICAgICAgICAgdmFy IHNob3J0aGFuZHMgPSB0aGlzLl9zaG9ydGhhbmRzW2xvbmdoYW5kTmFtZV07CisgICAgICAgICAg ICAgICAgICAgICAgICBpZiAoIXNob3J0aGFuZHMpIHsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzaG9ydGhhbmRzID0gW107CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGhpcy5f c2hvcnRoYW5kc1tsb25naGFuZE5hbWVdID0gc2hvcnRoYW5kczsKKyAgICAgICAgICAgICAgICAg ICAgICAgIH0KKworICAgICAgICAgICAgICAgICAgICAgICAgc2hvcnRoYW5kcy5wdXNoKHByb3Bl cnR5TmFtZSk7CiAgICAgICAgICAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgICAgICAgICBz aG9ydGhhbmRzLnB1c2gocHJvcGVydHlOYW1lKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0K