148491 2015-08-26 14:24:55 -0700 REGRESSION: Safari navigates after a cancelled force click 2015-08-26 14:51:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1121062 0 bdakin 2015-08-26 14:24:55 -0700 REGRESSION: Safari navigates after a cancelled force click rdar://problem/22394323 1121063 1 259982 bdakin 2015-08-26 14:38:14 -0700 Created attachment 259982 Patch 1121066 2 bdakin 2015-08-26 14:51:44 -0700 Thanks Tim! http://trac.webkit.org/changeset/188990 259982 2015-08-26 14:38:14 -0700 2015-08-26 14:46:29 -0700 Patch for-review.txt text/plain 6771 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODk4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA4LTI2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBTYWZhcmkgbmF2 aWdhdGVzIGFmdGVyIGEgY2FuY2VsbGVkIGZvcmNlIGNsaWNrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0OTEKKyAgICAgICAgLWFuZCBjb3JyZXNw b25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMjM5NDMyMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcmVncmVzc2lvbiB3YXMgaW50 cm9kdWNlZCBvbiBFbCBDYXBpdGFuIGJlY2F1c2UgQXBwS2l0IHNlbmRzIOKAmGNhbmNlbOKAmSB0 byAKKyAgICAgICAgZ2VzdHVyZSByZWNvZ25pemVyIEJFRk9SRSBpdCBzZW5kcyB0aGUgbW91c2VV cC4gU28gdGhlIEltbWVkaWF0ZUFjdGlvblN0YWdlIG5lZWRzIAorICAgICAgICB0byB0cmFjayB3 aGV0aGVyIGEgY2FuY2VsIGhhcHBlbmVkIGFmdGVyIHVwZGF0ZXMgb3Igd2l0aG91dCBhbnkgdXBk YXRlcyBzaW5jZSB0aGV5IAorICAgICAgICBzaWduaWZ5IGRpZmZlcmVudCB0aGluZ3MuIAorCisg ICAgICAgIERvbuKAmXQgcGVyZm9ybSBkZWZhdWx0IGJlaGF2aW9ycyB3aGVuIHRoZSBzdGFnZSBp cyBBY3Rpb25DYW5jZWxsZWRBZnRlclVwZGF0ZS4KKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUmVsZWFz ZUV2ZW50KToKKworICAgICAgICBOZXcgcG9zc2libGUgc3RhZ2VzLCBhbmQgbmV3IGdldHRlciBm b3IgdGhlIGN1cnJlbnQgc3RhZ2UuCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuaDoKKyAg ICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aW1tZWRpYXRlQWN0aW9uU3RhZ2UpOgorCiAy MDE1LTA4LTI2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAg ICAgVXNlIFdvcmtRdWV1ZTo6Y29uY3VycmVudEFwcGx5IGluIEZFQ29udm9sdmVNYXRyaXgKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDE4ODkyNikKKysr IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjEwMSw3ICsyMTAxLDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUmVsZWFzZUV2 ZQogCiAgICAgLy8gSWYgYW4gaW1tZWRpYXRlIGFjdGlvbiBiZWdhbiBvciB3YXMgY29tcGxldGVk IHVzaW5nIHRoaXMgc2VyaWVzIG9mIG1vdXNlIGV2ZW50cywgdGhlbiB3ZSBzaG91bGQgc2VuZCBt b3VzZXVwIHRvCiAgICAgLy8gdGhlIERPTSBhbmQgcmV0dXJuIG5vdyBzbyB0aGF0IHdlIGRvbid0 IHBlcmZvcm0gb3VyIG93biBkZWZhdWx0IGJlaGF2aW9ycy4KLSAgICBpZiAobV9pbW1lZGlhdGVB Y3Rpb25TdGFnZSA9PSBJbW1lZGlhdGVBY3Rpb25TdGFnZTo6QWN0aW9uQ29tcGxldGVkIHx8IG1f aW1tZWRpYXRlQWN0aW9uU3RhZ2UgPT0gSW1tZWRpYXRlQWN0aW9uU3RhZ2U6OkFjdGlvblVwZGF0 ZWQpIHsKKyAgICBpZiAobV9pbW1lZGlhdGVBY3Rpb25TdGFnZSA9PSBJbW1lZGlhdGVBY3Rpb25T dGFnZTo6QWN0aW9uQ29tcGxldGVkIHx8IG1faW1tZWRpYXRlQWN0aW9uU3RhZ2UgPT0gSW1tZWRp YXRlQWN0aW9uU3RhZ2U6OkFjdGlvblVwZGF0ZWQgfHwgbV9pbW1lZGlhdGVBY3Rpb25TdGFnZSA9 PSBJbW1lZGlhdGVBY3Rpb25TdGFnZTo6QWN0aW9uQ2FuY2VsbGVkQWZ0ZXJVcGRhdGUpIHsKICAg ICAgICAgbV9pbW1lZGlhdGVBY3Rpb25TdGFnZSA9IEltbWVkaWF0ZUFjdGlvblN0YWdlOjpOb25l OwogICAgICAgICByZXR1cm4gIWRpc3BhdGNoTW91c2VFdmVudChldmVudE5hbWVzKCkubW91c2V1 cEV2ZW50LCBtX2xhc3RFbGVtZW50VW5kZXJNb3VzZS5nZXQoKSwgdHJ1ZSwgbV9jbGlja0NvdW50 LCBwbGF0Zm9ybU1vdXNlRXZlbnQsIGZhbHNlKTsKICAgICB9CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmgJKHJldmlzaW9uIDE4ODkyNikKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMSw3ICsxMjEsOCBAQCBlbnVtIGNs YXNzIEltbWVkaWF0ZUFjdGlvblN0YWdlIHsKICAgICBOb25lLAogICAgIFBlcmZvcm1lZEhpdFRl c3QsCiAgICAgQWN0aW9uVXBkYXRlZCwKLSAgICBBY3Rpb25DYW5jZWxsZWQsCisgICAgQWN0aW9u Q2FuY2VsbGVkV2l0aG91dFVwZGF0ZSwKKyAgICBBY3Rpb25DYW5jZWxsZWRBZnRlclVwZGF0ZSwK ICAgICBBY3Rpb25Db21wbGV0ZWQKIH07CiAKQEAgLTMxMyw2ICszMTQsNyBAQCBwdWJsaWM6CiAg ICAgYm9vbCBpc0hhbmRsaW5nV2hlZWxFdmVudCgpIGNvbnN0IHsgcmV0dXJuIG1faXNIYW5kbGlu Z1doZWVsRXZlbnQ7IH0KIAogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0SW1tZWRpYXRlQWN0 aW9uU3RhZ2UoSW1tZWRpYXRlQWN0aW9uU3RhZ2Ugc3RhZ2UpOworICAgIFdFQkNPUkVfRVhQT1JU IEltbWVkaWF0ZUFjdGlvblN0YWdlIGltbWVkaWF0ZUFjdGlvblN0YWdlKCkgY29uc3QgeyByZXR1 cm4gbV9pbW1lZGlhdGVBY3Rpb25TdGFnZTsgfQogCiBwcml2YXRlOgogI2lmIEVOQUJMRShEUkFH X1NVUFBPUlQpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODg5ODgpCisrKyBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxNS0wOC0y NiAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjog U2FmYXJpIG5hdmlnYXRlcyBhZnRlciBhIGNhbmNlbGxlZCBmb3JjZSBjbGljaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NDkxCisgICAgICAgIC1h bmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjIzOTQzMjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhlIGN1cnJl bnQgc3RhZ2UgdG8gZGV0ZXJtaW5lIHdoaWNoIHR5cGUgb2YgY2FuY2VsIHRoaXMgaXMuCisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlOjppbW1lZGlhdGVBY3Rpb25EaWRDYW5jZWwpOgorCiAyMDE1LTA4LTI2ICBF cmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhIFNl c3Npb246IG1ha2UgTWVkaWFTZXNzaW9uTWV0YWRhdGEgYSBjbGFzcwpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkocmV2 aXNpb24gMTg4OTI2KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9X ZWJQYWdlTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMjA4LDcgKzEyMDgsMTEgQEAgdm9pZCBX ZWJQYWdlOjppbW1lZGlhdGVBY3Rpb25EaWRVcGRhdGUoKQogCiB2b2lkIFdlYlBhZ2U6OmltbWVk aWF0ZUFjdGlvbkRpZENhbmNlbCgpCiB7Ci0gICAgbV9wYWdlLT5tYWluRnJhbWUoKS5ldmVudEhh bmRsZXIoKS5zZXRJbW1lZGlhdGVBY3Rpb25TdGFnZShJbW1lZGlhdGVBY3Rpb25TdGFnZTo6QWN0 aW9uQ2FuY2VsbGVkKTsKKyAgICBJbW1lZGlhdGVBY3Rpb25TdGFnZSBsYXN0U3RhZ2UgPSBtX3Bh Z2UtPm1haW5GcmFtZSgpLmV2ZW50SGFuZGxlcigpLmltbWVkaWF0ZUFjdGlvblN0YWdlKCk7Cisg ICAgaWYgKGxhc3RTdGFnZSA9PSBJbW1lZGlhdGVBY3Rpb25TdGFnZTo6QWN0aW9uVXBkYXRlZCkK KyAgICAgICAgbV9wYWdlLT5tYWluRnJhbWUoKS5ldmVudEhhbmRsZXIoKS5zZXRJbW1lZGlhdGVB Y3Rpb25TdGFnZShJbW1lZGlhdGVBY3Rpb25TdGFnZTo6QWN0aW9uQ2FuY2VsbGVkQWZ0ZXJVcGRh dGUpOworICAgIGVsc2UKKyAgICAgICAgbV9wYWdlLT5tYWluRnJhbWUoKS5ldmVudEhhbmRsZXIo KS5zZXRJbW1lZGlhdGVBY3Rpb25TdGFnZShJbW1lZGlhdGVBY3Rpb25TdGFnZTo6QWN0aW9uQ2Fu Y2VsbGVkV2l0aG91dFVwZGF0ZSk7CiB9CiAKIHZvaWQgV2ViUGFnZTo6aW1tZWRpYXRlQWN0aW9u RGlkQ29tcGxldGUoKQpJbmRleDogU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4OTg4KQorKysg U291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMDgtMjYgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT046IFNhZmFyaSBuYXZpZ2F0ZXMgYWZ0ZXIgYSBjYW5jZWxsZWQgZm9yY2UgY2xp Y2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODQ5 MQorICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzIy Mzk0MzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIHRoZSBjdXJyZW50IHN0YWdlIHRvIGRldGVybWluZSB3aGljaCB0eXBlIG9mIGNhbmNlbCB0 aGlzIGlzLgorICAgICAgICAqIFdlYlZpZXcvV2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5t bToKKyAgICAgICAgKC1bV2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlciBpbW1lZGlhdGVBY3Rp b25SZWNvZ25pemVyRGlkQ2FuY2VsQW5pbWF0aW9uOl0pOgorCiAyMDE1LTA4LTI2ICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCBUZXN0IHBs YXRmb3JtL21hYy9mYXN0L2V2ZW50cy9jb250ZW50LWluc2V0LWhpdC10ZXN0aW5nLWluLWZyYW1l Lmh0bWwgaXMgZmxha3kKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSW1tZWRp YXRlQWN0aW9uQ29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE4ODkyNikK KysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxl ci5tbQkod29ya2luZyBjb3B5KQpAQCAtMjEwLDggKzIxMCwxMyBAQCAtICh2b2lkKWltbWVkaWF0 ZUFjdGlvblJlY29nbml6ZXJEaWRDYW5jCiAgICAgICAgIHJldHVybjsKIAogICAgIEZyYW1lKiBj b3JlRnJhbWUgPSBjb3JlKFtbW1tfd2ViVmlldyBfc2VsZWN0ZWRPck1haW5GcmFtZV0gZnJhbWVW aWV3XSBkb2N1bWVudFZpZXddIF9mcmFtZV0pOwotICAgIGlmIChjb3JlRnJhbWUpCi0gICAgICAg IGNvcmVGcmFtZS0+ZXZlbnRIYW5kbGVyKCkuc2V0SW1tZWRpYXRlQWN0aW9uU3RhZ2UoSW1tZWRp YXRlQWN0aW9uU3RhZ2U6OkFjdGlvbkNhbmNlbGxlZCk7CisgICAgaWYgKGNvcmVGcmFtZSkgewor ICAgICAgICBJbW1lZGlhdGVBY3Rpb25TdGFnZSBsYXN0U3RhZ2UgPSBjb3JlRnJhbWUtPmV2ZW50 SGFuZGxlcigpLmltbWVkaWF0ZUFjdGlvblN0YWdlKCk7CisgICAgICAgIGlmIChsYXN0U3RhZ2Ug PT0gSW1tZWRpYXRlQWN0aW9uU3RhZ2U6OkFjdGlvblVwZGF0ZWQpCisgICAgICAgICAgICBjb3Jl RnJhbWUtPmV2ZW50SGFuZGxlcigpLnNldEltbWVkaWF0ZUFjdGlvblN0YWdlKEltbWVkaWF0ZUFj dGlvblN0YWdlOjpBY3Rpb25DYW5jZWxsZWRBZnRlclVwZGF0ZSk7CisgICAgICAgIGVsc2UKKyAg ICAgICAgICAgIGNvcmVGcmFtZS0+ZXZlbnRIYW5kbGVyKCkuc2V0SW1tZWRpYXRlQWN0aW9uU3Rh Z2UoSW1tZWRpYXRlQWN0aW9uU3RhZ2U6OkFjdGlvbkNhbmNlbGxlZFdpdGhvdXRVcGRhdGUpOwor ICAgIH0KIAogICAgIFtfd2ViVmlldyBfc2V0VGV4dEluZGljYXRvckFuaW1hdGlvblByb2dyZXNz OjBdOwogICAgIFtzZWxmIF9jbGVhckltbWVkaWF0ZUFjdGlvblN0YXRlXTsK