148486 2015-08-26 11:30:43 -0700 Media Session: make MediaSessionMetadata a class 2015-09-04 03:57:55 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue ossy webkit-bug-importer oldest_to_newest 1120994 0 eric.carlson 2015-08-26 11:30:43 -0700 MediaSessionMetadata is defined as a struct, but it is forward declared in several places as a class. Make it a class and rectify the errant forward declarations. 1121000 1 259966 eric.carlson 2015-08-26 11:39:42 -0700 Created attachment 259966 Proposed patch 1121013 2 webkit-bug-importer 2015-08-26 12:09:54 -0700 <rdar://problem/22441794> 1121015 3 259966 commit-queue 2015-08-26 12:19:13 -0700 Comment on attachment 259966 Proposed patch Rejecting attachment 259966 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 259966, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej patching file Source/WebCore/Modules/mediasession/MediaSessionMetadata.h patching file Source/WebCore/page/ChromeClient.h patching file Source/WebKit2/ChangeLog patching file Source/WebKit2/Shared/WebCoreArgumentCoders.h patching file Source/WebKit2/UIProcess/WebPageProxy.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/109924 1121023 4 259969 eric.carlson 2015-08-26 12:35:51 -0700 Created attachment 259969 Patch for landing. 1121038 5 259969 commit-queue 2015-08-26 13:29:22 -0700 Comment on attachment 259969 Patch for landing. Clearing flags on attachment: 259969 Committed r188983: <http://trac.webkit.org/changeset/188983> 1123389 6 ossy 2015-09-04 03:57:55 -0700 Already landed, let's close it. 259966 2015-08-26 11:39:42 -0700 2015-08-26 12:19:13 -0700 Proposed patch cleanup_patch_1.txt text/plain 3130 eric.carlson PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODg5NzEp CisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NSBAQAorMjAxNS0wOC0yNiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4K KworICAgICAgICBNZWRpYSBTZXNzaW9uOiBtYWtlIE1lZGlhU2Vzc2lvbk1ldGFkYXRhIGEgY2xh c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODQ4 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgbm8gb2JzZXJ2YWJsZSBjaGFuZ2VzLgorCisgICAgICAgICogTW9kdWxlcy9tZWRp YXNlc3Npb24vTWVkaWFTZXNzaW9uTWV0YWRhdGEuaDogTWFrZSBpdCBhIGNsYXNzLgorICAgICAg ICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6IHN0cnVjdCBNZWRpYVNlc3Npb25NZXRhZGF0YSAtPiBj bGFzcyBNZWRpYVNlc3Npb25NZXRhZGF0YS4KKwogMjAxNS0wOC0yNiAgSmlueW91bmcgSHVyICA8 aHVyLmltc0BuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIFtDYWlyb10gQWNjZWxlcmF0ZWQgY2Fu dmFzIHNob3VsZCBmYWxsIGJhY2sgdG8gbm9uLWFjY2VsZXJhdGVkIGNhbnZhcyBvbiBjcmVhdGlv biBmYWlsdXJlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRp YVNlc3Npb25NZXRhZGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbk1ldGFkYXRhLmgJKHJldmlzaW9uIDE4ODkzMikKKysr IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbk1ldGFkYXRh LmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDggQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUg ewogCi1zdHJ1Y3QgTWVkaWFTZXNzaW9uTWV0YWRhdGEgeworY2xhc3MgTWVkaWFTZXNzaW9uTWV0 YWRhdGEgZmluYWwgeworcHVibGljOgogICAgIE1lZGlhU2Vzc2lvbk1ldGFkYXRhKCkgPSBkZWZh dWx0OwogCiAgICAgTWVkaWFTZXNzaW9uTWV0YWRhdGEoY29uc3QgU3RyaW5nJiB0aXRsZSwgY29u c3QgU3RyaW5nJiBhcnRpc3QsIGNvbnN0IFN0cmluZyYgYWxidW0sIGNvbnN0IFVSTCYgYXJ0d29y a1VSTCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAkocmV2aXNpb24gMTg4OTMy KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAkod29ya2luZyBjb3B5KQpA QCAtNDcsNyArNDcsNyBAQAogCiAjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04pCiBuYW1lc3BhY2Ug V2ViQ29yZSB7Ci1zdHJ1Y3QgTWVkaWFTZXNzaW9uTWV0YWRhdGE7CitjbGFzcyBNZWRpYVNlc3Np b25NZXRhZGF0YTsKIH0KICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODg5NzEp CisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxNS0wOC0yNiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4K KworICAgICAgICBNZWRpYSBTZXNzaW9uOiBtYWtlIE1lZGlhU2Vzc2lvbk1ldGFkYXRhIGEgY2xh c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODQ4 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hh cmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oOiBzdHJ1Y3QgTWVkaWFTZXNzaW9uTWV0YWRhdGEg LT4gY2xhc3MgTWVkaWFTZXNzaW9uTWV0YWRhdGEuCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5oOiBEaXR0by4KKwogMjAxNS0wOC0yNSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgU3BlY3VsYXRpdmUgYnVpbGQgZml4LgpJbmRleDogU291cmNlL1dl YktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAkocmV2aXNpb24gMTg4OTMy KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMjMsNyArMTIzLDcgQEAgc3RydWN0IE1lZGlhUGxheWJhY2tUYXJnZXRD b250ZXh0OwogCiAjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04pCiBuYW1lc3BhY2UgV2ViQ29yZSB7 Ci1zdHJ1Y3QgTWVkaWFTZXNzaW9uTWV0YWRhdGE7CitjbGFzcyBNZWRpYVNlc3Npb25NZXRhZGF0 YTsKIH0KICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5oCShyZXZpc2lvbiAxODg5MzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMSw3ICsxMjEsNyBAQAogCiAjaWYgRU5BQkxF KE1FRElBX1NFU1NJT04pCiBuYW1lc3BhY2UgV2ViQ29yZSB7Ci1zdHJ1Y3QgTWVkaWFTZXNzaW9u TWV0YWRhdGE7CitjbGFzcyBNZWRpYVNlc3Npb25NZXRhZGF0YTsKIH0KICNlbmRpZgogCg== 259969 2015-08-26 12:35:51 -0700 2015-08-26 13:29:22 -0700 Patch for landing. cleanup_patch_2.txt text/plain 3090 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODk4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA4LTI2ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhIFNlc3Npb246 IG1ha2UgTWVkaWFTZXNzaW9uTWV0YWRhdGEgYSBjbGFzcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg SmVyIE5vYmxlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gb2JzZXJ2YWJsZSBjaGFuZ2Vz LgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uTWV0YWRhdGEu aDogTWFrZSBpdCBhIGNsYXNzLgorICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6IHN0cnVj dCBNZWRpYVNlc3Npb25NZXRhZGF0YSAtPiBjbGFzcyBNZWRpYVNlc3Npb25NZXRhZGF0YS4KKwog MjAxNS0wOC0yNiAgUGVyIEFybmUgVm9sbGFuICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAg ICAgW0N1cmxdIERlYWRsb2NrIHdoZW4gZG93bmxvYWRpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb25NZXRhZGF0YS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vzc2lvbk1ldGFk YXRhLmgJKHJldmlzaW9uIDE4ODkzMikKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz ZXNzaW9uL01lZGlhU2Vzc2lvbk1ldGFkYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMy LDggQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdHJ1Y3QgTWVkaWFTZXNzaW9uTWV0YWRh dGEgeworY2xhc3MgTWVkaWFTZXNzaW9uTWV0YWRhdGEgZmluYWwgeworcHVibGljOgogICAgIE1l ZGlhU2Vzc2lvbk1ldGFkYXRhKCkgPSBkZWZhdWx0OwogCiAgICAgTWVkaWFTZXNzaW9uTWV0YWRh dGEoY29uc3QgU3RyaW5nJiB0aXRsZSwgY29uc3QgU3RyaW5nJiBhcnRpc3QsIGNvbnN0IFN0cmlu ZyYgYWxidW0sIGNvbnN0IFVSTCYgYXJ0d29ya1VSTCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2UvQ2hyb21lQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9DaHJv bWVDbGllbnQuaAkocmV2aXNpb24gMTg4OTMyKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9DaHJv bWVDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQAogCiAjaWYgRU5BQkxF KE1FRElBX1NFU1NJT04pCiBuYW1lc3BhY2UgV2ViQ29yZSB7Ci1zdHJ1Y3QgTWVkaWFTZXNzaW9u TWV0YWRhdGE7CitjbGFzcyBNZWRpYVNlc3Npb25NZXRhZGF0YTsKIH0KICNlbmRpZgogCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCShyZXZpc2lvbiAxODg5ODApCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNS0wOC0yNiAgRXJpYyBDYXJsc29u ICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiBtYWtl IE1lZGlhU2Vzc2lvbk1ldGFkYXRhIGEgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IEplciBO b2JsZS4KKworICAgICAgICAqIFNoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaDogc3RydWN0 IE1lZGlhU2Vzc2lvbk1ldGFkYXRhIC0+IGNsYXNzIE1lZGlhU2Vzc2lvbk1ldGFkYXRhLgorICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDogRGl0dG8uCisKIDIwMTUtMDgtMjYgIFph biBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQu CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5o CShyZXZpc2lvbiAxODg5MzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3Vt ZW50Q29kZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMyw3ICsxMjMsNyBAQCBzdHJ1Y3QgTWVk aWFQbGF5YmFja1RhcmdldENvbnRleHQ7CiAKICNpZiBFTkFCTEUoTUVESUFfU0VTU0lPTikKIG5h bWVzcGFjZSBXZWJDb3JlIHsKLXN0cnVjdCBNZWRpYVNlc3Npb25NZXRhZGF0YTsKK2NsYXNzIE1l ZGlhU2Vzc2lvbk1ldGFkYXRhOwogfQogI2VuZGlmCiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmgJKHJldmlzaW9uIDE4ODkzMikKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtMTIxLDcgKzEyMSw3 IEBACiAKICNpZiBFTkFCTEUoTUVESUFfU0VTU0lPTikKIG5hbWVzcGFjZSBXZWJDb3JlIHsKLXN0 cnVjdCBNZWRpYVNlc3Npb25NZXRhZGF0YTsKK2NsYXNzIE1lZGlhU2Vzc2lvbk1ldGFkYXRhOwog fQogI2VuZGlmCiAK