148476 2015-08-26 08:03:22 -0700 [Cairo] Accelerated canvas should fall back to non-accelerated canvas on creation failure 2015-08-26 09:45:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hur.ims hur.ims commit-queue oldest_to_newest 1120934 0 hur.ims 2015-08-26 08:03:22 -0700 [Cairo] Accelerated canvas should fall back to uunaccelrated canvas on creation failure 1120937 1 259952 hur.ims 2015-08-26 08:42:28 -0700 Created attachment 259952 Patch 1120939 2 hur.ims 2015-08-26 08:44:47 -0700 Cairo-gl backed surface might fail to be created with large dimensions, e.g., 50x32000, depending on the gl implementations. In case of Mac port, ImageBufferCG falls back to a software surface when it fails to create IOSurface, an accelerated surface. Though the unaccelerated surface could be slower, it would be better to create a working surface than nothing. 1120940 3 hur.ims 2015-08-26 08:45:43 -0700 Cairo-gl backed surface might fail to be created with large dimensions, e.g., 50x32000, depending on the gl implementations. In case of Mac port, ImageBufferCG falls back to a software surface when it fails to create IOSurface, an accelerated surface. Though the unaccelerated surface could be slower, it would be better to create a working surface than nothing. 1120951 4 259952 bfulgham 2015-08-26 08:59:15 -0700 Comment on attachment 259952 Patch r=me. 1120962 5 259952 commit-queue 2015-08-26 09:44:59 -0700 Comment on attachment 259952 Patch Clearing flags on attachment: 259952 Committed r188968: <http://trac.webkit.org/changeset/188968> 1120963 6 commit-queue 2015-08-26 09:45:02 -0700 All reviewed patches have been landed. Closing bug. 259952 2015-08-26 08:42:28 -0700 2015-08-26 09:44:59 -0700 Patch bug-148476-20150827004217.patch text/plain 2416 hur.ims U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4ODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU3YjczOWUzNDY2NWQ2 NTI3OGU4YWJlODg1MzJkZDIwOGE2MmI1My4uMjliNTYxNTFjMGU0MmU2ZTQ1NjY5MzBmYjgyOTkz ODRjZjQ1MzNmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA4LTI2ICBKaW55 b3VuZyBIdXIgIDxodXIuaW1zQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgW0NhaXJvXSBBY2Nl bGVyYXRlZCBjYW52YXMgc2hvdWxkIGZhbGwgYmFjayB0byBub24tYWNjZWxlcmF0ZWQgY2FudmFz IG9uIGNyZWF0aW9uIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0ODQ3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENhaXJvLWdsIGJhY2tlZCBzdXJmYWNlIG1pZ2h0IGZhaWwgdG8gYmUgY3Jl YXRlZCB3aXRoIGxhcmdlIGRpbWVuc2lvbnMsIGUuZy4sIDUweDMyMDAwLCBkZXBlbmRpbmcgb24g CisgICAgICAgIHRoZSBnbCBpbXBsZW1lbnRhdGlvbnMuIEluIGNhc2Ugb2YgTWFjIHBvcnQsIElt YWdlQnVmZmVyQ0cgZmFsbHMgYmFjayB0byBhIHNvZnR3YXJlIHN1cmZhY2Ugd2hlbiBpdCBmYWls cyB0byBjcmVhdGUKKyAgICAgICAgSU9TdXJmYWNlLCBhbiBhY2NlbGVyYXRlZCBzdXJmYWNlLiBU aG91Z2ggdGhlIHVuYWNjZWxlcmF0ZWQgc3VyZmFjZSBjb3VsZCBiZSBzbG93ZXIsIGl0IHdvdWxk IGJlIGJldHRlcgorICAgICAgICB0byBjcmVhdGUgYSB3b3JraW5nIHN1cmZhY2UgdGhhbiBub3Ro aW5nLgorCisgICAgICAgIEJlY2F1c2UgdGhlIG1heCBkaW1lbnNpb25zIG9mIGdsIHRleHR1cmUg bWlnaHQgdmFyeSBhbW9uZyB0aGUgT3BlbkdMIGltcGxlbWVudGF0aW9ucywgYmVsb3cgdGVzdCBj YW4ndCBndWFyYW50ZWUKKyAgICAgICAgdGhlIHZlcmlmaWNhdGlvbiBvZiBiZWhhdmlvciBkaWZm ZXJlbmNlIGRlcGVuZGluZyBvbiB0aGUgcnVubmluZyBwbGF0Zm9ybS4KKworICAgICAgICBUZXN0 OiBmYXN0L2NhbnZhcy9jYW52YXMtbGFyZ2UtZGltZW5zaW9ucy5odG1sCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkltYWdlQnVmZmVyOjpJbWFnZUJ1ZmZlcik6CisKIDIwMTUtMDgtMjQgIE15bGVzIEMu IE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIGJ1aWxk IGZpeGVzIGluIHIxODg4NzUgYW5kIHIxODg4NzQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAKaW5kZXgg NjExZjRjZDZlZjBlMWNhMzIxODFmNjA3NGExYmNmYTgzOTIzNzYyNS4uMTZlOTgwMTQxYWZmZGQw Y2E2ZjI3ZmM3MmExMWNlYWJkYTg4Njg2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAKQEAgLTEw NSw5ICsxMDUsMTIgQEAgSW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKGNvbnN0IEZsb2F0U2l6ZSYg c2l6ZSwgZmxvYXQgLyogcmVzb2x1dGlvblNjYWxlICovLCBDb2wKICAgICAgICAgcmV0dXJuOwog CiAjaWYgRU5BQkxFKEFDQ0VMRVJBVEVEXzJEX0NBTlZBUykKLSAgICBpZiAocmVuZGVyaW5nTW9k ZSA9PSBBY2NlbGVyYXRlZCkKKyAgICBpZiAocmVuZGVyaW5nTW9kZSA9PSBBY2NlbGVyYXRlZCkg ewogICAgICAgICBtX2RhdGEubV9zdXJmYWNlID0gY3JlYXRlQ2Fpcm9HTFN1cmZhY2Uoc2l6ZSwg bV9kYXRhLm1fdGV4dHVyZSk7Ci0gICAgZWxzZQorICAgICAgICBpZiAoIW1fZGF0YS5tX3N1cmZh Y2UgfHwgY2Fpcm9fc3VyZmFjZV9zdGF0dXMobV9kYXRhLm1fc3VyZmFjZS5nZXQoKSkgIT0gQ0FJ Uk9fU1RBVFVTX1NVQ0NFU1MpCisgICAgICAgICAgICByZW5kZXJpbmdNb2RlID0gVW5hY2NlbGVy YXRlZDsgLy8gSWYgYWxsb2NhdGlvbiBmYWlscywgZmFsbCBiYWNrIHRvIG5vbi1hY2NlbGVyYXRl ZCBwYXRoLgorICAgIH0KKyAgICBpZiAocmVuZGVyaW5nTW9kZSA9PSBVbmFjY2VsZXJhdGVkKQog I2Vsc2UKICAgICBBU1NFUlRfVU5VU0VEKHJlbmRlcmluZ01vZGUsIHJlbmRlcmluZ01vZGUgIT0g QWNjZWxlcmF0ZWQpOwogI2VuZGlmCg==