148473 2015-08-26 06:35:05 -0700 [GTK] Disable ACCELERATED_2D_CANVAS by default 2015-09-14 06:55:04 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Enhancement --- 1 mcatanzaro mcatanzaro cgarcia clopez commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1120922 0 mcatanzaro 2015-08-26 06:35:05 -0700 Currently ACCELERATED_2D_CANVAS is enabled by default on most systems (which have CairoGL) but not on Debian (which does not). We've known this was problematic for a while, since it means we have two different sets of distro-dependent bugs, but never decided whether that outweighed the benefits of CarioGL or not. I'm making the call now: it's more important to have the same bugs everywhere. We can turn this on again for other distros when we're ready to turn it on for Debian. 1120926 1 mrobinson 2015-08-26 06:40:46 -0700 Okay. Sounds reasonable to me. 1120927 2 259947 mcatanzaro 2015-08-26 06:45:22 -0700 Created attachment 259947 Patch 1121001 3 259947 commit-queue 2015-08-26 11:46:20 -0700 Comment on attachment 259947 Patch Clearing flags on attachment: 259947 Committed r188973: <http://trac.webkit.org/changeset/188973> 1121002 4 commit-queue 2015-08-26 11:46:23 -0700 All reviewed patches have been landed. Closing bug. 1125588 5 clopez 2015-09-14 06:16:51 -0700 The script Tools/Scripts/build-webkit is still enabling this feature by default for the GTK port: $ grep -C1 accelerated2DCanvasSupport Tools/Scripts/webkitperl/FeatureList.pm { option => "accelerated-2d-canvas", desc => "Toggle Accelerated 2D Canvas support", define => "ENABLE_ACCELERATED_2D_CANVAS", default => isGtk(), value => \$accelerated2DCanvasSupport }, This means that both the developers and the bots are building and testing with this feature enabled. Should we do anything about that? 1125589 6 mcatanzaro 2015-09-14 06:55:04 -0700 It's expected that build-webkit often enables experimental options that are disabled by default for end users. Advantage of having enabled: If we disable it, there will be zero testing of the feature, and it could break. Disadvantage of having enabled: It could make it impossible to reproduce bugs with a development build. But ACCELERATED_2D_CANVAS is a public (non-experimental) option, which argues in favor of it being enabled for developers and tested. Maybe it should be private, though. 259947 2015-08-26 06:45:22 -0700 2015-08-26 11:46:20 -0700 Patch bug-148473-20150826084510.patch text/plain 3762 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4ODY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDYyNjdi ZmY4NGVhMTJjYjNlNTBiMzMzNjNhMGEyZjA4ZmM1NWJlODkuLjg3YTMzZjQ3N2M4ZjhiNDRlNThm NWYxMTc5ZDE2ZWYwMzlkMzQwZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMDksMjcgKzEw OSw3IEBAIGVsc2UgKCkKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfTUVNT1JZX1NBTVBMRVIgUFVCTElDIE9GRikKIGVuZGlmICgpCiAKLWlmIChPUEVOR0xfRk9V TkQpCi0gICAgaWYgKEdMWF9GT1VORCkKLSAgICAgICAgbGlzdChBUFBFTkQgQ0FJUk9HTF9DT01Q T05FTlRTIGNhaXJvLWdseCkKLSAgICBlbmRpZiAoKQotICAgIGlmIChFR0xfRk9VTkQpCi0gICAg ICAgIGxpc3QoQVBQRU5EIENBSVJPR0xfQ09NUE9ORU5UUyBjYWlyby1lZ2wpCi0gICAgZW5kaWYg KCkKLWVuZGlmICgpCi1maW5kX3BhY2thZ2UoQ2Fpcm9HTCAxLjEwLjIgQ09NUE9ORU5UUyAke0NB SVJPR0xfQ09NUE9ORU5UU30pCi0KLSMgTm9ybWFsbHkgd2UgZG8gbm90IHNldCB0aGUgdmFsdWUg b2Ygb3B0aW9ucyBhdXRvbWF0aWNhbGx5LiBIb3dldmVyLCBDYWlyb0dMIGlzIHNwZWNpYWwuIEN1 cnJlbnRseQotIyBtb3N0IG1ham9yIGRpc3Ryb3MgY29tcGlsZSBDYXJpbyB3aXRoIC0tZW5hYmxl LWdsLCBidXQgRGViaWFuIGFuZCBkZXJpdml0aXZlcyBhcmUgYSBtYWpvcgotIyBleGNlcHRpb24u IFlvdSB2ZXJ5IHByb2JhYmx5IHdhbnQgYWNjZWxlcmF0ZWQgMkQgY2FudmFzIGlmIENhcmlvIGhh cyBiZWVuIGNvbXBpbGVkIHdpdGggQ2FyaW9HTCwKLSMgYW5kIHZlcnkgcHJvYmFibHkgZG8gbm90 IHdhbnQgdG8gcmVjb21waWxlIENhcmlvIG90aGVyd2lzZS4gU28gd2UgZXhwZWN0IHNvbWUgbWFq b3IgZGlzdHJvcyB3aWxsCi0jIGVuYWJsZSB0aGlzIGZlYXR1cmUsIGFuZCBvdGhlcnMgd2lsbCBu b3QsIGFuZCB0aGF0IGlzIGp1c3QgZmluZSBmb3IgdGhlIHRpbWUgYmVpbmcuIE9uY2UgRGViaWFu Ci0jIGVuYWJsZXMgQ2Fpcm9HTCwgdGhlbiBpdCB3aWxsIGJlIHRpbWUgdG8gZm9yY2UgdGhpcyBP TiBieSBkZWZhdWx0LiBOb3RlIHRoYXQgaWYgR0xYIGlzIGluc3RhbGxlZCwKLSMgRUdMIGlzIG5v dCwgYW5kIEVOQUJMRV9YMTFfVEFSR0VUIGlzIE9GRiwgdGhpcyBndWVzcyBpcyB3cm9uZyBhbmQg dGhlIHVzZXIgbXVzdCBvdmVycmlkZSBpdC4gV2UKLSMgY2FuJ3QgY2hlY2sgRU5BQkxFX1gxMV9U QVJHRVQgYXQgdGhpcyBwb2ludCBiZWNhdXNlIHdlIGRvbid0IGtub3cgd2hldGhlciBpdCdzIGVu YWJsZWQgdW50aWwKLSMgV0VCS0lUX09QVElPTl9FTkQgaGFzIGJlZW4gY2FsbGVkLCBhbmQgYXQg dGhhdCBwb2ludCBpdCdzIHRvbyBsYXRlIHRvIGNoYW5nZSBkZWZhdWx0IHZhbHVlcy4KLVdFQktJ VF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMg UFVCTElDIENBSVJPR0xfRk9VTkQpCi0KK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DUkVERU5USUFMX1NUT1JBR0UgUFVCTElDIE9OKQog V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RSQUdfU1VQUE9SVCBQVUJM SUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0VPTE9DQVRJ T04gUFVCTElDIE9OKQpAQCAtMjQ4LDYgKzIyOCwyMCBAQCBpZiAoRU5BQkxFX0dBTUVQQURfREVQ UkVDQVRFRCBPUiBFTkFCTEVfR0VPTE9DQVRJT04pCiBlbmRpZiAoKQogZmluZF9wYWNrYWdlKEdM SUIgMi4zNiBSRVFVSVJFRCBDT01QT05FTlRTICR7Z2xpYl9jb21wb25lbnRzfSkKIAoraWYgKEVO QUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCisgICAgaWYgKEdMWF9GT1VORCkKKyAgICAgICAg bGlzdChBUFBFTkQgQ0FJUk9HTF9DT01QT05FTlRTIGNhaXJvLWdseCkKKyAgICBlbmRpZiAoKQor ICAgIGlmIChFR0xfRk9VTkQpCisgICAgICAgIGxpc3QoQVBQRU5EIENBSVJPR0xfQ09NUE9ORU5U UyBjYWlyby1lZ2wpCisgICAgZW5kaWYgKCkKKworICAgIGZpbmRfcGFja2FnZShDYWlyb0dMIDEu MTAuMiBDT01QT05FTlRTICR7Q0FJUk9HTF9DT01QT05FTlRTfSkKKyAgICBpZiAoTk9UIENBSVJP R0xfRk9VTkQpCisgICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIkNhaXJvR0wgaXMgbmVlZGVk IGZvciBFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIikKKyAgICBlbmRpZiAoKQorZW5kaWYg KCkKKwogaWYgKEVOQUJMRV9DUkVERU5USUFMX1NUT1JBR0UpCiAgICAgZmluZF9wYWNrYWdlKExp YnNlY3JldCkKICAgICBpZiAoTk9UIExJQlNFQ1JFVF9GT1VORCkKZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhMzMwZTI1OThjMTEyZmJiNjQxMzUyM2ZhZmZiODNkYzVj M2MwNGU3Li41YzJjYjA3NGY4OWM3ZDRkMDJlMTZiMWQ0MmYxZGRmNmJhMjM2N2FlIDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTUtMDgt MjYgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdIERpc2FibGUgQUNDRUxFUkFURURfMkRfQ0FOVkFTIGJ5IGRlZmF1bHQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODQ3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSBBQ0NFTEVS QVRFRF8yRF9DQU5WQVMgaXMgZW5hYmxlZCBieSBkZWZhdWx0IG9uIG1vc3Qgc3lzdGVtcyAod2hp Y2ggaGF2ZSBDYWlyb0dMKQorICAgICAgICBidXQgbm90IG9uIERlYmlhbiAod2hpY2ggZG9lcyBu b3QpLiBXZSd2ZSBrbm93biB0aGlzIHdhcyBwcm9ibGVtYXRpYyBmb3IgYSB3aGlsZSwgc2luY2Ug aXQKKyAgICAgICAgbWVhbnMgd2UgaGF2ZSB0d28gZGlmZmVyZW50IHNldHMgb2YgZGlzdHJvLWRl cGVuZGVudCBidWdzLCBidXQgbmV2ZXIgZGVjaWRlZCB3aGV0aGVyIHRoYXQKKyAgICAgICAgb3V0 d2VpZ2hlZCB0aGUgYmVuZWZpdHMgb2YgQ2FyaW9HTCBvciBub3QuIEknbSBtYWtpbmcgdGhlIGNh bGwgbm93OiBpdCdzIG1vcmUgaW1wb3J0YW50IHRvCisgICAgICAgIGhhdmUgdGhlIHNhbWUgYnVn cyBldmVyeXdoZXJlLiBXZSBjYW4gdHVybiB0aGlzIG9uIGFnYWluIGZvciBvdGhlciBkaXN0cm9z IHdoZW4gd2UncmUgcmVhZHkKKyAgICAgICAgdG8gdHVybiBpdCBvbiBmb3IgRGViaWFuLgorCisg ICAgICAgIEFsc28sIHByb3Blcmx5IGZhaWwgdGhlIGJ1aWxkIGlmIEVOQUJMRV9BQ0NFTEVSQVRF RF8yRF9DQU5WQVMgaXMgZW5hYmxlZCBidXQgQ2Fpcm9HTCBpcyBub3QKKyAgICAgICAgYXZhaWxh YmxlLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIwMTUt MDgtMjAgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEu Y28udWs+CiAKICAgICAgICAgW0dUS10gQXV0by1kZXRlY3Rpb24gb2YgY2Fpcm8tZ2wgZmFpbHMK