148469 2015-08-26 01:22:05 -0700 Remove the unused *Executable::unlinkCalls() and CodeBlock::unlinkCalls() 2015-08-26 11:34:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sukolsak webkit-unassigned benjamin commit-queue fpizlo ggaren keith_miller mark.lam msaboff saam sukolsak oldest_to_newest 1120885 0 sukolsak 2015-08-26 01:22:05 -0700 *Executable::unlinkCalls() and CodeBlock::unlinkCalls() are no longer used. We use CodeBlock::unlinkIncomingCalls() to unlink calls. 1120886 1 259939 sukolsak 2015-08-26 01:27:16 -0700 Created attachment 259939 Patch 1120976 2 259939 ggaren 2015-08-26 10:47:18 -0700 Comment on attachment 259939 Patch r=me 1120996 3 259939 commit-queue 2015-08-26 11:34:54 -0700 Comment on attachment 259939 Patch Clearing flags on attachment: 259939 Committed r188972: <http://trac.webkit.org/changeset/188972> 1120998 4 commit-queue 2015-08-26 11:34:57 -0700 All reviewed patches have been landed. Closing bug. 259939 2015-08-26 01:27:16 -0700 2015-08-26 11:34:54 -0700 Patch bug-148469-20150826012705.patch text/plain 6360 sukolsak U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 Mjk5OTJlZGVjZTY2NTliMDA4M2UxMzFlYjkwYzllNjM5MWQ1MjE5Li40MjQ1OTA2Mjk1N2YxYzNl ZGFkMzE0YmIxNzNkMWNhZTYzMjBiYWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNS0wOC0yNiAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdt YWlsLmNvbT4KKworICAgICAgICBSZW1vdmUgdGhlIHVudXNlZCAqRXhlY3V0YWJsZTo6dW5saW5r Q2FsbHMoKSBhbmQgQ29kZUJsb2NrOjp1bmxpbmtDYWxscygpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0NjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB1c2UgQ29kZUJsb2NrOjp1bmxpbmtJbmNv bWluZ0NhbGxzKCkgdG8gdW5saW5rIGNhbGxzLgorICAgICAgICAoLi4uKUV4ZWN1dGFibGU6OnVu bGlua0NhbGxzKCkgYW5kIENvZGVCbG9jazo6dW5saW5rQ2FsbHMoKSBhcmUgbm8gbG9uZ2VyIHVz ZWQuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlNDOjpD b2RlQmxvY2s6OnVubGlua0NhbGxzKTogRGVsZXRlZC4KKyAgICAgICAgKiBieXRlY29kZS9Db2Rl QmxvY2suaDoKKyAgICAgICAgKiBydW50aW1lL0V4ZWN1dGFibGUuY3BwOgorICAgICAgICAoSlND OjpFdmFsRXhlY3V0YWJsZTo6dW5saW5rQ2FsbHMpOiBEZWxldGVkLgorICAgICAgICAoSlNDOjpQ cm9ncmFtRXhlY3V0YWJsZTo6dW5saW5rQ2FsbHMpOiBEZWxldGVkLgorICAgICAgICAoSlNDOjpG dW5jdGlvbkV4ZWN1dGFibGU6OnVubGlua0NhbGxzKTogRGVsZXRlZC4KKyAgICAgICAgKiBydW50 aW1lL0V4ZWN1dGFibGUuaDoKKyAgICAgICAgKEpTQzo6U2NyaXB0RXhlY3V0YWJsZTo6dW5saW5r Q2FsbHMpOiBEZWxldGVkLgorCiAyMDE1LTA4LTI1ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBw bGUuY29tPgogCiAgICAgICAgIExldHMgcmVuYW1lIGNvZGVPcmlnaW5JbmRleCB0byBjYWxsU2l0 ZUluZGV4IGFuZCBnZXQgcmlkIG9mIENhbGxGcmFtZTo6TG9jYXRpb24uCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCmluZGV4IGQwMzFlYTkxMmZjZTdlNTQx NmY3NmQ0YzY2NjNiMzJlMTI3ODY0YTMuLjIwYzE0N2EwMTVkMmM0M2RlYzM4M2Y3YmFhODEwYTY2 YTkxOTE0NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2su Y3BwCkBAIC0yOTczLDI3ICsyOTczLDYgQEAgdm9pZCBDb2RlQmxvY2s6OnNocmlua1RvRml0KFNo cmlua01vZGUgc2hyaW5rTW9kZSkKIH0KIAogI2lmIEVOQUJMRShKSVQpCi12b2lkIENvZGVCbG9j azo6dW5saW5rQ2FsbHMoKQotewotICAgIGlmICghIW1fYWx0ZXJuYXRpdmUpCi0gICAgICAgIG1f YWx0ZXJuYXRpdmUtPnVubGlua0NhbGxzKCk7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBt X2xsaW50Q2FsbExpbmtJbmZvcy5zaXplKCk7ICsraSkgewotICAgICAgICBpZiAobV9sbGludENh bGxMaW5rSW5mb3NbaV0uaXNMaW5rZWQoKSkKLSAgICAgICAgICAgIG1fbGxpbnRDYWxsTGlua0lu Zm9zW2ldLnVubGluaygpOwotICAgIH0KLSAgICBpZiAobV9jYWxsTGlua0luZm9zLmlzRW1wdHko KSkKLSAgICAgICAgcmV0dXJuOwotICAgIGlmICghbV92bS0+Y2FuVXNlSklUKCkpCi0gICAgICAg IHJldHVybjsKLSAgICBSZXBhdGNoQnVmZmVyIHJlcGF0Y2hCdWZmZXIodGhpcyk7Ci0gICAgZm9y IChhdXRvIGl0ZXIgPSBtX2NhbGxMaW5rSW5mb3MuYmVnaW4oKTsgISFpdGVyOyArK2l0ZXIpIHsK LSAgICAgICAgQ2FsbExpbmtJbmZvJiBpbmZvID0gKippdGVyOwotICAgICAgICBpZiAoIWluZm8u aXNMaW5rZWQoKSkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBpbmZvLnVubGluayhy ZXBhdGNoQnVmZmVyKTsKLSAgICB9Ci19Ci0KIHZvaWQgQ29kZUJsb2NrOjpsaW5rSW5jb21pbmdD YWxsKEV4ZWNTdGF0ZSogY2FsbGVyRnJhbWUsIENhbGxMaW5rSW5mbyogaW5jb21pbmcpCiB7CiAg ICAgbm90aWNlSW5jb21pbmdDYWxsKGNhbGxlckZyYW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9Db2RlQmxvY2suaAppbmRleCAwYjk3ZTIzOTBlZDliOTg0ZmFkNTgzMTI5Mzg4 MDdmODIyMDhlNmZmLi45NDk5NDA1NjQzYWE5MTNkYzc4ZTc5OWFhMGNjNTY3MmViMzZlZjNjIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCkBAIC0yMzAsOCAr MjMwLDYgQEAgcHVibGljOgogICAgIHZvaWQgdW5saW5rSW5jb21pbmdDYWxscygpOwogCiAjaWYg RU5BQkxFKEpJVCkKLSAgICB2b2lkIHVubGlua0NhbGxzKCk7Ci0gICAgICAgIAogICAgIHZvaWQg bGlua0luY29taW5nQ2FsbChFeGVjU3RhdGUqIGNhbGxlckZyYW1lLCBDYWxsTGlua0luZm8qKTsK ICAgICB2b2lkIGxpbmtJbmNvbWluZ1BvbHltb3JwaGljQ2FsbChFeGVjU3RhdGUqIGNhbGxlckZy YW1lLCBQb2x5bW9ycGhpY0NhbGxOb2RlKik7CiAjZW5kaWYgLy8gRU5BQkxFKEpJVCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5jcHAKaW5kZXggNWZmYjhkYjdm MDUwNWI0ZDE2MjZhMzY4NDdhMjg4MWZiNGExNzUyMy4uMWI5YTczZDc5MzM4YWEzOTE0ZjNlNDU0 NTFiYjZmOWEwMGNjOTA5NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvRXhlY3V0YWJsZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhl Y3V0YWJsZS5jcHAKQEAgLTQ0MiwxNiArNDQyLDYgQEAgdm9pZCBFdmFsRXhlY3V0YWJsZTo6dmlz aXRDaGlsZHJlbihKU0NlbGwqIGNlbGwsIFNsb3RWaXNpdG9yJiB2aXNpdG9yKQogICAgIHZpc2l0 b3IuYXBwZW5kKCZ0aGlzT2JqZWN0LT5tX3VubGlua2VkRXZhbENvZGVCbG9jayk7CiB9CiAKLXZv aWQgRXZhbEV4ZWN1dGFibGU6OnVubGlua0NhbGxzKCkKLXsKLSNpZiBFTkFCTEUoSklUKQotICAg IGlmICghbV9qaXRDb2RlRm9yQ2FsbCkKLSAgICAgICAgcmV0dXJuOwotICAgIFJFTEVBU0VfQVNT RVJUKG1fZXZhbENvZGVCbG9jayk7Ci0gICAgbV9ldmFsQ29kZUJsb2NrLT51bmxpbmtDYWxscygp OwotI2VuZGlmCi19Ci0KIHZvaWQgRXZhbEV4ZWN1dGFibGU6OmNsZWFyQ29kZSgpCiB7CiAgICAg bV9ldmFsQ29kZUJsb2NrID0gbnVsbHB0cjsKQEAgLTQ3MywxNiArNDYzLDYgQEAgSlNPYmplY3Qq IFByb2dyYW1FeGVjdXRhYmxlOjpjaGVja1N5bnRheChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgcmV0 dXJuIGVycm9yLnRvRXJyb3JPYmplY3QobGV4aWNhbEdsb2JhbE9iamVjdCwgbV9zb3VyY2UpOwog fQogCi12b2lkIFByb2dyYW1FeGVjdXRhYmxlOjp1bmxpbmtDYWxscygpCi17Ci0jaWYgRU5BQkxF KEpJVCkKLSAgICBpZiAoIW1faml0Q29kZUZvckNhbGwpCi0gICAgICAgIHJldHVybjsKLSAgICBS RUxFQVNFX0FTU0VSVChtX3Byb2dyYW1Db2RlQmxvY2spOwotICAgIG1fcHJvZ3JhbUNvZGVCbG9j ay0+dW5saW5rQ2FsbHMoKTsKLSNlbmRpZgotfQotCiBKU09iamVjdCogUHJvZ3JhbUV4ZWN1dGFi bGU6OmluaXRpYWxpemVHbG9iYWxQcm9wZXJ0aWVzKFZNJiB2bSwgQ2FsbEZyYW1lKiBjYWxsRnJh bWUsIEpTU2NvcGUqIHNjb3BlKQogewogICAgIFJFTEVBU0VfQVNTRVJUKHNjb3BlKTsKQEAgLTU2 OSwyMCArNTQ5LDYgQEAgdm9pZCBGdW5jdGlvbkV4ZWN1dGFibGU6OmNsZWFyQ29kZSgpCiAgICAg QmFzZTo6Y2xlYXJDb2RlKCk7CiB9CiAKLXZvaWQgRnVuY3Rpb25FeGVjdXRhYmxlOjp1bmxpbmtD YWxscygpCi17Ci0jaWYgRU5BQkxFKEpJVCkKLSAgICBpZiAoISFtX2ppdENvZGVGb3JDYWxsKSB7 Ci0gICAgICAgIFJFTEVBU0VfQVNTRVJUKG1fY29kZUJsb2NrRm9yQ2FsbCk7Ci0gICAgICAgIG1f Y29kZUJsb2NrRm9yQ2FsbC0+dW5saW5rQ2FsbHMoKTsKLSAgICB9Ci0gICAgaWYgKCEhbV9qaXRD b2RlRm9yQ29uc3RydWN0KSB7Ci0gICAgICAgIFJFTEVBU0VfQVNTRVJUKG1fY29kZUJsb2NrRm9y Q29uc3RydWN0KTsKLSAgICAgICAgbV9jb2RlQmxvY2tGb3JDb25zdHJ1Y3QtPnVubGlua0NhbGxz KCk7Ci0gICAgfQotI2VuZGlmCi19Ci0KIEZ1bmN0aW9uRXhlY3V0YWJsZSogRnVuY3Rpb25FeGVj dXRhYmxlOjpmcm9tR2xvYmFsQ29kZSgKICAgICBjb25zdCBJZGVudGlmaWVyJiBuYW1lLCBFeGVj U3RhdGUmIGV4ZWMsIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgCiAgICAgSlNPYmplY3QqJiBl eGNlcHRpb24sIGludCBvdmVycmlkZUxpbmVOdW1iZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9FeGVjdXRhYmxlLmgKaW5kZXggMDQwNTM3NzNjMTA3NjQwZWI2NmYyYWRhMzIxODY5 MTk1MDgxMjc1Yy4uYjUxMzU0N2QwODMxY2E5NTE0MDkwM2ZjMDAyNjExMzBhM2M2NWY5YiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuaApAQCAtMzgxLDggKzM4 MSw2IEBAIHB1YmxpYzoKICAgICAKICAgICBib29sKiBhZGRyZXNzT2ZEaWRUcnlUb0VudGVySW5M b29wKCkgeyByZXR1cm4gJm1fZGlkVHJ5VG9FbnRlckluTG9vcDsgfQogCi0gICAgdm9pZCB1bmxp bmtDYWxscygpOwotICAgICAgICAKICAgICBDb2RlRmVhdHVyZXMgZmVhdHVyZXMoKSBjb25zdCB7 IHJldHVybiBtX2ZlYXR1cmVzOyB9CiAgICAgICAgIAogICAgIERFQ0xBUkVfSU5GTzsKQEAgLTQ3 MCw4ICs0NjgsNiBAQCBwdWJsaWM6CiAgICAgICAgIAogICAgIERFQ0xBUkVfSU5GTzsKIAotICAg IHZvaWQgdW5saW5rQ2FsbHMoKTsKLQogICAgIHZvaWQgY2xlYXJDb2RlKCk7CiAKICAgICBFeGVj dXRhYmxlSW5mbyBleGVjdXRhYmxlSW5mbygpIGNvbnN0IHsgcmV0dXJuIEV4ZWN1dGFibGVJbmZv KG5lZWRzQWN0aXZhdGlvbigpLCB1c2VzRXZhbCgpLCBpc1N0cmljdE1vZGUoKSwgZmFsc2UsIGZh bHNlLCBDb25zdHJ1Y3RvcktpbmQ6Ok5vbmUsIGZhbHNlKTsgfQpAQCAtNTI1LDggKzUyMSw2IEBA IHB1YmxpYzoKICAgICB9CiAgICAgICAgIAogICAgIERFQ0xBUkVfSU5GTzsKLSAgICAgICAgCi0g ICAgdm9pZCB1bmxpbmtDYWxscygpOwogCiAgICAgdm9pZCBjbGVhckNvZGUoKTsKIApAQCAtNjU2 LDggKzY1MCw2IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBERUNMQVJFX0lORk87Ci0gICAgICAg IAotICAgIHZvaWQgdW5saW5rQ2FsbHMoKTsKIAogICAgIHZvaWQgY2xlYXJDb2RlKCk7CiAgICAg CkBAIC02OTQsMjAgKzY4Niw2IEBAIGlubGluZSB2b2lkIEV4ZWN1dGFibGVCYXNlOjpjbGVhckNv ZGVWaXJ0dWFsKEV4ZWN1dGFibGVCYXNlKiBleGVjdXRhYmxlKQogICAgIH0KIH0KIAotaW5saW5l IHZvaWQgU2NyaXB0RXhlY3V0YWJsZTo6dW5saW5rQ2FsbHMoKQotewotICAgIHN3aXRjaCAodHlw ZSgpKSB7Ci0gICAgY2FzZSBFdmFsRXhlY3V0YWJsZVR5cGU6Ci0gICAgICAgIHJldHVybiBqc0Nh c3Q8RXZhbEV4ZWN1dGFibGUqPih0aGlzKS0+dW5saW5rQ2FsbHMoKTsKLSAgICBjYXNlIFByb2dy YW1FeGVjdXRhYmxlVHlwZToKLSAgICAgICAgcmV0dXJuIGpzQ2FzdDxQcm9ncmFtRXhlY3V0YWJs ZSo+KHRoaXMpLT51bmxpbmtDYWxscygpOwotICAgIGNhc2UgRnVuY3Rpb25FeGVjdXRhYmxlVHlw ZToKLSAgICAgICAgcmV0dXJuIGpzQ2FzdDxGdW5jdGlvbkV4ZWN1dGFibGUqPih0aGlzKS0+dW5s aW5rQ2FsbHMoKTsKLSAgICBkZWZhdWx0OgotICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVB Q0hFRCgpOwotICAgIH0KLX0KLQogfQogCiAjZW5kaWYK