148464 2015-08-25 22:05:35 -0700 [Cocoa] PerformanceTest Layout/RegionsShapes.html is failing 2015-08-26 17:20:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield oldest_to_newest 1120843 0 mmaxfield 2015-08-25 22:05:35 -0700 [Cocoa] PerformanceTest Layout/RegionsShapes.html is failing 1120845 1 259924 mmaxfield 2015-08-25 22:08:38 -0700 Created attachment 259924 Patch 1120852 2 259924 aestes 2015-08-25 22:42:23 -0700 Comment on attachment 259924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259924&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:472 > + RetainPtr<CFDictionaryRef> attributes = adoptCF(CFDictionaryCreate(kCFAllocatorDefault, keys, values, WTF_ARRAY_LENGTH(keys), &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); > + RetainPtr<CTFontDescriptorRef> descriptor = adoptCF(CTFontDescriptorCreateWithAttributes(attributes.get())); I like to use auto in these cases. 1121122 3 mmaxfield 2015-08-26 17:20:33 -0700 Committed r189005: <http://trac.webkit.org/changeset/189005> 259924 2015-08-25 22:08:38 -0700 2015-08-25 22:42:23 -0700 Patch bug-148464-20150825220827.patch text/plain 3304 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFiNWQxZTNkMzEzYjc2 ZjZmZDhjOGI1OTA0NDExOTFlMjg4OWJlMS4uOTNlMTU5ZjZmMDNiMzAwYWIyNGU4YjNlOWM4ZTc4 MWYxZTEwY2NiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA4LTI1ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBQ ZXJmb3JtYW5jZVRlc3QgTGF5b3V0L1JlZ2lvbnNTaGFwZXMuaHRtbCBpcyBmYWlsaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0NjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCBpcyBm YWlsaW5nIGJlY2F1c2UgQ29yZSBUZXh0IGVtaXRzIGEgd2FybmluZyBtZXNzYWdlIHdoZW4geW91 IHVzZSBDVEZvbnRDcmVhdGVXaXRoTmFtZSgpCisgICAgICAgIGFuZCBpdCBjYW5ub3QgZmluZCB0 aGUgbmFtZSB5b3UgcHJvdmlkZS4gSG93ZXZlciwgdGhpcyBpcyBleGFjdGx5IHRoZSBzaXR1YXRp b24gd2UgYXJlIGNyZWF0aW5nCisgICAgICAgIChieSBhdHRlbXB0aW5nIHRvIGF1dG8tYWN0aXZh dGUgYSBmb250IGlmIHdlIGNvdWxkIG5vdCBvdGhlcndpc2UgZmluZCBpdCkuIFRoZSBmaXggaXMg dG8gc2ltcGx5CisgICAgICAgIG5vdCB1c2UgdGhhdCBBUEkgZnVuY3Rpb24gaW4gZmF2b3Igb2Yg dXNpbmcgQ1RGb250Q3JlYXRlV2l0aEZvbnREZXNjcmlwdG9yKCksIHdoaWNoIGRvZXMgbm90IGVt aXQKKyAgICAgICAgYSB3YXJuaW5nIG1lc3NhZ2UuLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBi ZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmF1dG9BY3RpdmF0ZUZvbnQpOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpjcmVhdGVG b250UGxhdGZvcm1EYXRhKToKKwogMjAxNS0wOC0yNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFVzaW5nIHRoZSBmaWx0ZXIgZnVuY3Rpb25hbCBub3RhdGlvbiBm b3IgYmFja2dyb3VuZCBpbWFnZXMgcmVzdWx0cyBpbiB3cm9uZyBiYWNrZ3JvdW5kLXNpemUgcmVu ZGVyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9Gb250Q2FjaGVDb3JlVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jb2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHAKaW5kZXggYTljZTRlZmViNWQwNjJjMzllYzhk OTZlMjNkODA4MzZkN2FjZmMyOC4uZTNhM2ExMDY4MWNlYzFiMTgwZTgyMTgyMmY0YWY0YTlhZDBm M2M5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2Ev Rm9udENhY2hlQ29yZVRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcApAQCAtNDYyLDYgKzQ2MiwxNyBAQCBzdGF0 aWMgYm9vbCBzaG91bGRBdXRvQWN0aXZhdGVGb250SWZOZWVkZWQoY29uc3QgQXRvbWljU3RyaW5n JiBmYW1pbHkpCiAgICAgLy8gT25seSBhdHRlbXB0IHRvIGF1dG8tYWN0aXZhdGUgZm9udHMgb25j ZSBmb3IgcGVyZm9ybWFuY2UgcmVhc29ucy4KICAgICByZXR1cm4ga25vd25GYW1pbGllcy5nZXQo KS5hZGQoZmFtaWx5KS5pc05ld0VudHJ5OwogfQorCitzdGF0aWMgdm9pZCBhdXRvQWN0aXZhdGVG b250KGNvbnN0IFN0cmluZyYgbmFtZSwgQ0dGbG9hdCBzaXplKQoreworICAgIFJldGFpblB0cjxD RlN0cmluZ1JlZj4gZm9udE5hbWUgPSBuYW1lLmNyZWF0ZUNGU3RyaW5nKCk7CisgICAgQ0ZUeXBl UmVmIGtleXNbXSA9IHsga0NURm9udE5hbWVBdHRyaWJ1dGUgfTsKKyAgICBDRlR5cGVSZWYgdmFs dWVzW10gPSB7IGZvbnROYW1lLmdldCgpIH07CisgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJl Zj4gYXR0cmlidXRlcyA9IGFkb3B0Q0YoQ0ZEaWN0aW9uYXJ5Q3JlYXRlKGtDRkFsbG9jYXRvckRl ZmF1bHQsIGtleXMsIHZhbHVlcywgV1RGX0FSUkFZX0xFTkdUSChrZXlzKSwgJmtDRlR5cGVEaWN0 aW9uYXJ5S2V5Q2FsbEJhY2tzLCAma0NGVHlwZURpY3Rpb25hcnlWYWx1ZUNhbGxCYWNrcykpOwor ICAgIFJldGFpblB0cjxDVEZvbnREZXNjcmlwdG9yUmVmPiBkZXNjcmlwdG9yID0gYWRvcHRDRihD VEZvbnREZXNjcmlwdG9yQ3JlYXRlV2l0aEF0dHJpYnV0ZXMoYXR0cmlidXRlcy5nZXQoKSkpOwor ICAgIGlmIChDVEZvbnRSZWYgbmV3Rm9udCA9IENURm9udENyZWF0ZVdpdGhGb250RGVzY3JpcHRv cihkZXNjcmlwdG9yLmdldCgpLCBzaXplLCBudWxscHRyKSkKKyAgICAgICAgQ0ZSZWxlYXNlKG5l d0ZvbnQpOworfQogI2VuZGlmCiAKIHN0ZDo6dW5pcXVlX3B0cjxGb250UGxhdGZvcm1EYXRhPiBG b250Q2FjaGU6OmNyZWF0ZUZvbnRQbGF0Zm9ybURhdGEoY29uc3QgRm9udERlc2NyaXB0aW9uJiBm b250RGVzY3JpcHRpb24sIGNvbnN0IEF0b21pY1N0cmluZyYgZmFtaWx5KQpAQCAtNDc4LDcgKzQ4 OSw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxGb250UGxhdGZvcm1EYXRhPiBGb250Q2FjaGU6OmNyZWF0 ZUZvbnRQbGF0Zm9ybURhdGEoY29uc3QgRm9udERlCiAKICAgICAgICAgLy8gQXV0byBhY3RpdmF0 ZSB0aGUgZm9udCBiZWZvcmUgbG9va2luZyBmb3IgaXQgYSBzZWNvbmQgdGltZS4KICAgICAgICAg Ly8gSWdub3JlIHRoZSByZXN1bHQgYmVjYXVzZSB3ZSB3YW50IHRvIHVzZSBvdXIgb3duIGFsZ29y aXRobSB0byBhY3R1YWxseSBmaW5kIHRoZSBmb250LgotICAgICAgICBDRlJlbGVhc2UoQ1RGb250 Q3JlYXRlV2l0aE5hbWUoZmFtaWx5LnN0cmluZygpLmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCksIHNp emUsIG51bGxwdHIpKTsKKyAgICAgICAgYXV0b0FjdGl2YXRlRm9udChmYW1pbHkuc3RyaW5nKCks IHNpemUpOwogCiAgICAgICAgIGZvbnQgPSBmb250V2l0aEZhbWlseShmYW1pbHksIHRyYWl0cywg Zm9udERlc2NyaXB0aW9uLndlaWdodCgpLCBmb250RGVzY3JpcHRpb24uZmVhdHVyZVNldHRpbmdz KCksIGZvbnREZXNjcmlwdGlvbi50ZXh0UmVuZGVyaW5nTW9kZSgpLCBzaXplKTsKICAgICB9Cg==