148451 2015-08-25 16:33:33 -0700 [Win] Expose "Inverted Colors" option in WinLauncher 2015-08-25 20:47:50 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC All RESOLVED FIXED P2 Normal --- 148461 1 bfulgham bfulgham oldest_to_newest 1120767 0 bfulgham 2015-08-25 16:33:33 -0700 WebKit supports an inverted color mode for Accessibility. This option is not accessible in WinLauncher, which makes experimenting with the feature difficult. This patch adds a menu option to the "View" menu so that you can run WinLauncher with inverted colors. 1120768 1 259899 bfulgham 2015-08-25 16:36:15 -0700 Created attachment 259899 Patch 1120784 2 259899 sabouhallawa 2015-08-25 17:10:38 -0700 Comment on attachment 259899 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259899&action=review > Tools/WinLauncher/Common.cpp:494 > + case IDM_INVERT_COLORS: WinProc() and ToggleMenuItem() checks for the same set of wmIds. Can't we make ToggleMenuItem() returns true if handles the wmId and false if it does not? The default case of switch (wmId) in WinProc can be like this: default: if (!ToggleMenuItem(hWnd, mId)) return CallWindowProc(parentProc, hWnd, message, wParam, lParam); } 1120785 3 bfulgham 2015-08-25 17:16:13 -0700 Committed r188939: <http://trac.webkit.org/changeset/188939> 1120816 4 bfulgham 2015-08-25 19:42:59 -0700 (In reply to comment #2) > Comment on attachment 259899 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259899&action=review > > > Tools/WinLauncher/Common.cpp:494 > > + case IDM_INVERT_COLORS: > > WinProc() and ToggleMenuItem() checks for the same set of wmIds. Can't we > make ToggleMenuItem() returns true if handles the wmId and false if it does > not? The default case of switch (wmId) in WinProc can be like this: > > default: > if (!ToggleMenuItem(hWnd, mId)) > return CallWindowProc(parentProc, hWnd, message, wParam, > lParam); > } That's a great idea! I'll try to put a patch together for that. Thanks! 259899 2015-08-25 16:36:15 -0700 2015-08-25 17:08:12 -0700 Patch bug-148451-20150825165113.patch text/plain 3939 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4ODkzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDE1LTA4LTI1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIEV4cG9zZSAiSW52ZXJ0ZWQgQ29sb3JzIiBvcHRpb24gaW4gV2lu TGF1bmNoZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0ODQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCB0aGUgYWJpbGl0eSB0byB0b2dnbGUgdGhlICJJbnZlcnRlZCBDb2xvcnMiIHByZWZlcmVu Y2UKKyAgICAgICAgaW4gV2luTGF1bmNoZXIuCisgICAgICAgIAorICAgICAgICAqIFdpbkxhdW5j aGVyL0NvbW1vbi5jcHA6CisgICAgICAgIChUb2dnbGVNZW51SXRlbSk6IFRvZ2dsZSB0aGUgZmVh dHVyZSB3aGVuIHRoZSBtZW51IGl0ZW0KKyAgICAgICAgaXMgc2VsZWN0ZWQuCisgICAgICAgIChX bmRQcm9jKTogUmVjb2duaXplIHRoZSBuZXcgbWVudSBvcHRpb24uCisgICAgICAgICogV2luTGF1 bmNoZXIvV2luTGF1bmNoZXIuY3BwOgorICAgICAgICAoV2luTGF1bmNoZXI6OnNldFRvRGVmYXVs dFByZWZlcmVuY2VzKTogTGF1bmNoIHdpdGggIkludmVydAorICAgICAgICBDb2xvcnMiIHR1cm5l ZCBvZmYuCisgICAgICAgICogV2luTGF1bmNoZXIvV2luTGF1bmNoZXIudmN4cHJvai9XaW5MYXVu Y2hlckxpYi5yYzogQWRkIG1lbnUKKyAgICAgICAgZW50cnkgZm9yICJJbnZlcnQgQ29sb3JzIi4K KyAgICAgICAgKiBXaW5MYXVuY2hlci9XaW5MYXVuY2hlci52Y3hwcm9qL1dpbkxhdW5jaGVyTGli UmVzb3VyY2UuaDoKKwogMjAxNS0wOC0yNSAgTmFuIFdhbmcgIDxuX3dhbmdAYXBwbGUuY29tPgog CiAgICAgICAgIFtNYWNdIGFjY2Vzc2liaWxpdHkvZG9jdW1lbnQtYXR0cmlidXRlcy5odG1sIGZh aWxzCkluZGV4OiBUb29scy9XaW5MYXVuY2hlci9Db21tb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1dpbkxhdW5jaGVyL0NvbW1vbi5jcHAJKHJldmlzaW9uIDE4ODkzNCkKKysrIFRvb2xzL1dp bkxhdW5jaGVyL0NvbW1vbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5MCw2ICszOTAsOSBAQCBz dGF0aWMgdm9pZCBUb2dnbGVNZW51SXRlbShIV05EIGhXbmQsIFVJCiAgICAgICAgIGdXaW5MYXVu Y2hlci0+cHJpdmF0ZVByZWZlcmVuY2VzKCktPnNldFNob3dEZWJ1Z0JvcmRlcnMobmV3U3RhdGUp OwogICAgICAgICBnV2luTGF1bmNoZXItPnByaXZhdGVQcmVmZXJlbmNlcygpLT5zZXRTaG93UmVw YWludENvdW50ZXIobmV3U3RhdGUpOwogICAgICAgICBicmVhazsKKyAgICBjYXNlIElETV9JTlZF UlRfQ09MT1JTOgorICAgICAgICBnV2luTGF1bmNoZXItPnByaXZhdGVQcmVmZXJlbmNlcygpLT5z ZXRTaG91bGRJbnZlcnRDb2xvcnMobmV3U3RhdGUpOworICAgICAgICBicmVhazsKICAgICBjYXNl IElETV9ESVNBQkxFX0lNQUdFUzoKICAgICAgICAgZ1dpbkxhdW5jaGVyLT5zdGFuZGFyZFByZWZl cmVuY2VzKCktPnNldExvYWRzSW1hZ2VzQXV0b21hdGljYWxseSghbmV3U3RhdGUpOwogICAgICAg ICBicmVhazsKQEAgLTQ4OCw2ICs0OTEsNyBAQCBMUkVTVUxUIENBTExCQUNLIFduZFByb2MoSFdO RCBoV25kLCBVSU5UCiAgICAgICAgIGNhc2UgSURNX0FDQ19DT01QT1NJVElORzoKICAgICAgICAg Y2FzZSBJRE1fV0tfRlVMTFNDUkVFTjoKICAgICAgICAgY2FzZSBJRE1fQ09NUE9TSVRJTkdfQk9S REVSUzoKKyAgICAgICAgY2FzZSBJRE1fSU5WRVJUX0NPTE9SUzoKICAgICAgICAgY2FzZSBJRE1f RElTQUJMRV9JTUFHRVM6CiAgICAgICAgIGNhc2UgSURNX0RJU0FCTEVfU1RZTEVTOgogICAgICAg ICBjYXNlIElETV9ESVNBQkxFX0pBVkFTQ1JJUFQ6CkluZGV4OiBUb29scy9XaW5MYXVuY2hlci9X aW5MYXVuY2hlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNo ZXIuY3BwCShyZXZpc2lvbiAxODg5MzQpCisrKyBUb29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hl ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5MSw2ICsxOTEsNyBAQCBib29sIFdpbkxhdW5jaGVy OjpzZXRUb0RlZmF1bHRQcmVmZXJlbmNlCiAgICAgbV9wcmVmc1ByaXZhdGUtPnNldEZ1bGxTY3Jl ZW5FbmFibGVkKFRSVUUpOwogICAgIG1fcHJlZnNQcml2YXRlLT5zZXRTaG93RGVidWdCb3JkZXJz KEZBTFNFKTsKICAgICBtX3ByZWZzUHJpdmF0ZS0+c2V0U2hvd1JlcGFpbnRDb3VudGVyKEZBTFNF KTsKKyAgICBtX3ByZWZzUHJpdmF0ZS0+c2V0U2hvdWxkSW52ZXJ0Q29sb3JzKEZBTFNFKTsKIAog ICAgIG1fc3RhbmRhcmRQcmVmZXJlbmNlcy0+c2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5KFRS VUUpOwogICAgIG1fcHJlZnNQcml2YXRlLT5zZXRBdXRob3JBbmRVc2VyU3R5bGVzRW5hYmxlZChU UlVFKTsKSW5kZXg6IFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjeHByb2ovV2luTGF1 bmNoZXJMaWIucmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIu dmN4cHJvai9XaW5MYXVuY2hlckxpYi5yYwkocmV2aXNpb24gMTg4OTM0KQorKysgVG9vbHMvV2lu TGF1bmNoZXIvV2luTGF1bmNoZXIudmN4cHJvai9XaW5MYXVuY2hlckxpYi5yYwkod29ya2luZyBj b3B5KQpAQCAtNDgsNiArNDgsNyBAQCBCRUdJTgogICAgICAgICBNRU5VSVRFTSAiQWN0dWFsIFNp emUiLCAgICAgICAgICAgICAgICAgSURNX0FDVFVBTF9TSVpFDQogICAgICAgICBNRU5VSVRFTSAi Wm9vbSBJblx0Q3RybCsrIiwgICAgICAgICAgICAgSURNX1pPT01fSU4NCiAgICAgICAgIE1FTlVJ VEVNICJab29tIE91dFx0Q3RybCstIiwgICAgICAgICAgICBJRE1fWk9PTV9PVVQNCisgICAgICAg IE1FTlVJVEVNICJJbnZlcnQgQ29sb3JzIiwgICAgICAgICAgICAgICBJRE1fSU5WRVJUX0NPTE9S Uw0KICAgICBFTkQNCiAgICAgUE9QVVAgIiZIaXN0b3J5Ig0KICAgICBCRUdJTg0KSW5kZXg6IFRv b2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjeHByb2ovV2luTGF1bmNoZXJMaWJSZXNvdXJj ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjeHByb2ov V2luTGF1bmNoZXJMaWJSZXNvdXJjZS5oCShyZXZpc2lvbiAxODg5MzQpCisrKyBUb29scy9XaW5M YXVuY2hlci9XaW5MYXVuY2hlci52Y3hwcm9qL1dpbkxhdW5jaGVyTGliUmVzb3VyY2UuaAkod29y a2luZyBjb3B5KQpAQCAtMjIsNiArMjIsNyBAQAogI2RlZmluZSBJRE1fRElTQUJMRV9TVFlMRVMg ICAgICAgICAgICAgIDEyMgogI2RlZmluZSBJRE1fRElTQUJMRV9KQVZBU0NSSVBUICAgICAgICAg IDEyMwogI2RlZmluZSBJRE1fRElTQUJMRV9MT0NBTF9GSUxFX1JFU1RSSUNUSU9OUyAxMjQKKyNk ZWZpbmUgSURNX0lOVkVSVF9DT0xPUlMgICAgICAgICAgICAgICAxMjUKICNkZWZpbmUgSURSX01B SU5GUkFNRSAgICAgICAgICAgICAgICAgICAxMjgKICNkZWZpbmUgSUREX0NBQ0hFUyAgICAgICAg ICAgICAgICAgICAgICAxMjkKICNkZWZpbmUgSURNX0hJU1RPUllfQkFDS1dBUkQgICAgICAgICAg ICAxMzAK