148445 2015-08-25 13:36:55 -0700 [ES6] Arrow function syntax. Add missed tests for invoking the arrow function that created by 'eval' statement. 2015-08-31 23:44:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148148 140855 1 gskachkov webkit-unassigned commit-queue saam ysuzuki oldest_to_newest 1120703 0 gskachkov 2015-08-25 13:36:55 -0700 eval('var x=x=>x+10'); x(111); // Returns Exception: SyntaxError: Invalid character: '\0' 1120706 1 259876 gskachkov 2015-08-25 13:59:21 -0700 Created attachment 259876 Patch Added test for this case. Issue was fixed by following patch https://bugs.webkit.org/show_bug.cgi?id=148148 1120812 2 259876 ysuzuki 2015-08-25 19:32:46 -0700 Comment on attachment 259876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259876&action=review > LayoutTests/ChangeLog:5 > + Could you tell me which part fixed this issue in the original patch? http://trac.webkit.org/changeset/188928 Describing it here is nice. And could you tell me why `functionInfo.endOffset - 1` is needed in the original patch? 1120956 3 gskachkov 2015-08-26 09:10:12 -0700 (In reply to comment #2) > Comment on attachment 259876 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259876&action=review > > > LayoutTests/ChangeLog:5 > > + > > Could you tell me which part fixed this issue in the original patch? All changes, that were made in 'parser' module, fix current issue. > http://trac.webkit.org/changeset/188928 > Describing it here is nice. > > And could you tell me why `functionInfo.endOffset - 1` is needed in the > original patch? The issue was that during first parsing arrow function, with body as expression (z=>z*2), has redundant symbol at the end, i.e. var f = x => x+1; and after parsing it has own source as 'x => x+1;' with redundant ';' at the end. It is OK for all cases except case for eval, when it leads to error during invoking function. I found this issue when was fixing issue with toString method, because toString returns extra ';' but should not. So I decided to add test that will prevent this issue with eval in future. Possible it would be better to split original patch into two patches, 'fix parsing' and add 'correct toString' to avoid misunderstanding, also possible I need to rename current issue to just 'adding additional tests for arrow function'. What do you think I need to do to make this issue more clear? 1121493 4 ysuzuki 2015-08-27 16:57:19 -0700 (In reply to comment #3) > The issue was that during first parsing arrow function, with body as > expression (z=>z*2), has redundant symbol at the end, i.e. var f = x => x+1; > and after parsing it has own source as 'x => x+1;' with redundant ';' at the > end. It is OK for all cases except case for eval, when it leads to error > during invoking function. I found this issue when was fixing issue with > toString method, because toString returns extra ';' but should not. So I > decided to add test that will prevent this issue with eval in future. > > Possible it would be better to split original patch into two patches, 'fix > parsing' and add 'correct toString' to avoid misunderstanding, also possible > I need to rename current issue to just 'adding additional tests for arrow > function'. > > What do you think I need to do to make this issue more clear? Yeah. I think describing the details in ChangeLog (and issue title) is preferable :) 1122255 5 260307 gskachkov 2015-08-31 12:31:22 -0700 Created attachment 260307 Patch Updated patch 1122303 6 260307 ysuzuki 2015-08-31 14:41:08 -0700 Comment on attachment 260307 Patch r=me 1122316 7 260307 commit-queue 2015-08-31 15:29:54 -0700 Comment on attachment 260307 Patch Clearing flags on attachment: 260307 Committed r189187: <http://trac.webkit.org/changeset/189187> 1122317 8 commit-queue 2015-08-31 15:29:58 -0700 All reviewed patches have been landed. Closing bug. 1122502 9 gskachkov 2015-08-31 23:44:09 -0700 (In reply to comment #6) > Comment on attachment 260307 [details] > Patch > > r=me Thanks! 259876 2015-08-25 13:59:21 -0700 2015-08-31 12:31:14 -0700 Patch bug-148445-20150825235910.patch text/plain 2111 gskachkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NjM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTVkY2I4NzQ2MDAwZWZiMTUzMjQ3 M2VkOTQ3MTMwYjIxMDg3YzA2Zi4uMWViM2RkNGEwMTJhZWM5N2Q5YmRkY2FlM2E0NWZiMDNiMTAw MzEwNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4LTI1ICBBbGVrc2FuZHIgU2thY2hr b3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPgorCisgICAgICAgIFtFUzZdIEFycm93IGZ1bmN0aW9u IHN5bnRheC4gRXJyb3IgZHVyaW5nIGludm9raW5nIGFycm93IGZ1bmN0aW9uIHRoYXQgY3JlYXRl ZCBieSAnZXZhbCcgc3RhdGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDg0NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGpzL2Fycm93ZnVuY3Rpb24tc3ludGF4LWVuZGluZ3MtZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy9hcnJvd2Z1bmN0aW9uLXN5bnRheC1lbmRp bmdzLmpzOgorCiAyMDE1LTA4LTE4ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBs ZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBQdW5jdHVhdGlvbiBuZWFyIEhpbmRpIHRleHQgaXMg Z2FyYmxlZCB3aGVuIHN0eWxlZCB3aXRoIHRoZSBzeXN0ZW0gZm9udApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvanMvYXJyb3dmdW5jdGlvbi1zeW50YXgtZW5kaW5ncy1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9qcy9hcnJvd2Z1bmN0aW9uLXN5bnRheC1lbmRpbmdzLWV4cGVjdGVkLnR4dApp bmRleCA1MGJkNWIyMjcxYzhhZjNmNGQxOGE0ZjQyZmQzZTA2ZWExNzk2N2U0Li44NjlmMDE1OWU1 OGE2YjJlNTJhOTk0ZTVmYmQ5NDQ3ODI4NWE0NDk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9q cy9hcnJvd2Z1bmN0aW9uLXN5bnRheC1lbmRpbmdzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9qcy9hcnJvd2Z1bmN0aW9uLXN5bnRheC1lbmRpbmdzLWV4cGVjdGVkLnR4dApAQCAtOCw2 ICs4LDExIEBAIFBBU1MgeD0+eCsxIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgogUEFTUyB4PT54 KzEKICBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KIFBBU1MgZigpIGlzIDM5CitldmFsKCd2YXIg YWYgPSB4PT54KjInKQorUEFTUyBhZigxMCkgaXMgMjAKK2V2YWwoJ3ZhciBhZjEgPSB4PT54KjMs IGFmMj14PT54KjQnKQorUEFTUyBhZjEoMTApIGlzIDMwCitQQVNTIGFmMigxMCkgaXMgNDAKIFBB U1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2Fycm93ZnVuY3Rpb24tc3ludGF4LWVuZGlu Z3MuanMgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvYXJyb3dmdW5jdGlvbi1zeW50YXgt ZW5kaW5ncy5qcwppbmRleCA3NDkzNWU4OTU1Y2E4MzUxYTU1NDUwMTEyYTcyN2ZkNDhmMDczMTc5 Li41ZWU1M2U5ZGJkYTg1MDhmNzgzMzU5YjAzYTc0ZjVmZWE3ZTVkNDE5IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvYXJyb3dmdW5jdGlvbi1zeW50YXgtZW5kaW5ncy5q cworKysgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvYXJyb3dmdW5jdGlvbi1zeW50YXgt ZW5kaW5ncy5qcwpAQCAtMzIsNCArMzIsMTMgQEAgdmFyIGYgPSBmdW5jdGlvbiAoKSB7CiAKIHNo b3VsZEJlKCdmKCknLCAnMzknKTsKIAorZXZhbCgndmFyIGFmID0geD0+eCoyJyk7CitkZWJ1Zygi ZXZhbCgndmFyIGFmID0geD0+eCoyJykiKTsKK3Nob3VsZEJlKCdhZigxMCknLCcyMCcpOworCitl dmFsKCd2YXIgYWYxID0geD0+eCozLCBhZjI9eD0+eCo0Jyk7CitkZWJ1ZygiZXZhbCgndmFyIGFm MSA9IHg9PngqMywgYWYyPXg9PngqNCcpIik7CitzaG91bGRCZSgnYWYxKDEwKScsJzMwJyk7Citz aG91bGRCZSgnYWYyKDEwKScsJzQwJyk7CisKIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVl Owo= 260307 2015-08-31 12:31:22 -0700 2015-08-31 15:29:54 -0700 Patch bug-148445-20150831223104.patch text/plain 2944 gskachkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MTc0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjI0NTZmMGFkOWExYjVjZmEwNGYx NTJjYzIzMDA2ODRhYzA2ZTdmMy4uMTJkMmM3Mzc5Y2UwNjVlMWExMmE5MGUyY2IwMzU2YTg3MTEx ZDg3MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA4LTI1ICBBbGVrc2FuZHIgU2thY2hr b3YgIDxnc2thY2hrb3ZAZ21haWwuY29tPgorCisgICAgICAgIFtFUzZdIEFycm93IGZ1bmN0aW9u IHN5bnRheC4gQWRkIG1pc3NlZCB0ZXN0cyBmb3IgaW52b2tpbmcgdGhlIGFycm93IGZ1bmN0aW9u IHRoYXQgY3JlYXRlZCBieSAnZXZhbCcgc3RhdGVtZW50LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4NDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgCisgICAgICAgIEFkZGVkIHRlc3RzLCB0aGF0IGNvdmVy IGNhc2VzLCB3aGVuIGFycm93IGZ1bmN0aW9uIGlzIGNyZWF0ZWQgYnkgJ2V2YWwnIHN0YXRlbWVu dCBhbmQgdGhlbiBpbnZva2luZyBpdC4gCisgICAgICAgIFRoaXMgY2FzZSB3YXMgbWlzc2VkIGlu IHByZXZpb3VzIHBhdGNoZXMgdGhhdCBhcmUgcmVsYXRlZCB0byBhcnJvdyBmdW5jdGlvbiwgYWxz byBpdCBpcyBpbXBvcnRhbnQgdG8gCisgICAgICAgIHRlc3QgZGlmZmVyZW50IGNhc2VzIG9mIGVu ZGluZyBhcnJvdyBmdW5jdGlvbiBpbiAnZXZhbCcgYW5kIGludm9raW5nIGNyZWF0ZWQgYXJyb3cg ZnVuY3Rpb24gYmVjYXVzZSAKKyAgICAgICAgb2YgcmVwYXJzaW5nIGR1cmluZyBmdW5jdGlvbiBp bnZvY2F0aW9uLgorCisgICAgICAgICoganMvYXJyb3dmdW5jdGlvbi1zeW50YXgtZW5kaW5ncy1l eHBlY3RlZC50eHQ6CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL2Fycm93ZnVuY3Rpb24tc3lu dGF4LWVuZGluZ3MuanM6CisKIDIwMTUtMDgtMzEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBtYXJrIGEgZmV3IHRlc3RzIGFzIGZhaWxpbmcg b24gV2luZG93cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL2Fycm93ZnVuY3Rpb24tc3lu dGF4LWVuZGluZ3MtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvYXJyb3dmdW5jdGlvbi1z eW50YXgtZW5kaW5ncy1leHBlY3RlZC50eHQKaW5kZXggNTBiZDViMjI3MWM4YWYzZjRkMThhNGY0 MmZkM2UwNmVhMTc5NjdlNC4uNWZjMmU2ZjMyYzhkMTcxZWMyNDNmZmQwYTgwOThlMjYzY2IxZDE0 NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvanMvYXJyb3dmdW5jdGlvbi1zeW50YXgtZW5kaW5n cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvanMvYXJyb3dmdW5jdGlvbi1zeW50YXgt ZW5kaW5ncy1leHBlY3RlZC50eHQKQEAgLTgsNiArOCwxNyBAQCBQQVNTIHg9PngrMSBkaWQgbm90 IHRocm93IGV4Y2VwdGlvbi4KIFBBU1MgeD0+eCsxCiAgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24u CiBQQVNTIGYoKSBpcyAzOQorZXZhbCgndmFyIGFmID0geD0+eCoyJykKK1BBU1MgYWYoMTApIGlz IDIwCitldmFsKCd2YXIgYWYxID0geD0+eCozLCBhZjI9eD0+eCo0JykKK1BBU1MgYWYxKDEwKSBp cyAzMAorUEFTUyBhZjIoMTApIGlzIDQwCitldmFsKCd2YXIgYWYxID0geD0+eCozOycpCitQQVNT IGFmMygxMCkgaXMgMzAKK2V2YWwoJ3ZhciBhZjQgPSB4PT4oeCozKScpCitQQVNTIGFmNCgxMCkg aXMgMzAKK2V2YWwoJ3ZhciBhZjUgPSB4PT4geyByZXR1cm4geCozOyB9JykKK1BBU1MgYWY1KDEw KSBpcyAzMAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRF CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvYXJyb3dmdW5jdGlvbi1z eW50YXgtZW5kaW5ncy5qcyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9hcnJvd2Z1bmN0 aW9uLXN5bnRheC1lbmRpbmdzLmpzCmluZGV4IDc0OTM1ZTg5NTVjYTgzNTFhNTU0NTAxMTJhNzI3 ZmQ0OGYwNzMxNzkuLmE1OGJhZjU3ZjI5NDkyOWNiNTg4NjZlMjJlOGQ3YTlmOTFmNjM5YmMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9hcnJvd2Z1bmN0aW9uLXN5bnRh eC1lbmRpbmdzLmpzCisrKyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9hcnJvd2Z1bmN0 aW9uLXN5bnRheC1lbmRpbmdzLmpzCkBAIC0zMiw0ICszMiwyNSBAQCB2YXIgZiA9IGZ1bmN0aW9u ICgpIHsKIAogc2hvdWxkQmUoJ2YoKScsICczOScpOwogCitldmFsKCd2YXIgYWYgPSB4PT54KjIn KTsKK2RlYnVnKCJldmFsKCd2YXIgYWYgPSB4PT54KjInKSIpOworc2hvdWxkQmUoJ2FmKDEwKScs JzIwJyk7CisKK2V2YWwoJ3ZhciBhZjEgPSB4PT54KjMsIGFmMj14PT54KjQnKTsKK2RlYnVnKCJl dmFsKCd2YXIgYWYxID0geD0+eCozLCBhZjI9eD0+eCo0JykiKTsKK3Nob3VsZEJlKCdhZjEoMTAp JywnMzAnKTsKK3Nob3VsZEJlKCdhZjIoMTApJywnNDAnKTsKKworZXZhbCgndmFyIGFmMyA9IHg9 PngqMzsnKTsKK2RlYnVnKCJldmFsKCd2YXIgYWYxID0geD0+eCozOycpIik7CitzaG91bGRCZSgn YWYzKDEwKScsJzMwJyk7CisKK2V2YWwoJ3ZhciBhZjQgPSB4PT4oeCozKScpOworZGVidWcoImV2 YWwoJ3ZhciBhZjQgPSB4PT4oeCozKScpIik7CitzaG91bGRCZSgnYWY0KDEwKScsJzMwJyk7CisK K2V2YWwoJ3ZhciBhZjUgPSB4ID0+IHsgcmV0dXJuIHgqMzsgfScpOworZGVidWcoImV2YWwoJ3Zh ciBhZjUgPSB4PT4geyByZXR1cm4geCozOyB9JykiKTsKK3Nob3VsZEJlKCdhZjUoMTApJywnMzAn KTsKKwogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==