148441 2015-08-25 12:17:29 -0700 Construct default winding string arguments in CanvasRenderingContext2D from ASCIILiteral objects 2015-09-02 09:49:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue esprehn+autocc gyuyoung.kim oldest_to_newest 1120685 0 zan 2015-08-25 12:17:29 -0700 Construct default winding string arguments in CanvasRenderingContext2D from ASCIILiteral objects 1120687 1 259870 zan 2015-08-25 12:21:16 -0700 Created attachment 259870 Patch 1120699 2 259870 darin 2015-08-25 13:25:47 -0700 Comment on attachment 259870 Patch This is a slight optimization. Could optimize even more by overloading instead so we wouldn’t even have to allocate/destroy a StringImpl each time. 1122815 3 zan 2015-09-02 07:15:08 -0700 At least this case could be improved by generating better bindings code. There the string value is already tested to throw a type error if it doesn't equal either 'nonzero' or 'evenodd', so it would then just be a matter of passing an enum value to the implementation function. 1122833 4 zan 2015-09-02 09:49:37 -0700 Committed r189248: <http://trac.webkit.org/changeset/189248> 259870 2015-08-25 12:21:16 -0700 2015-08-25 13:25:05 -0700 Patch bug-148441-20150825212105.patch text/plain 2471 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjY1ZmFiNWQ1NzAzYzIw ZTI1ZTIzY2QwOWU3MDk4NTlhZWY5NjNjMS4uNTJjMDU2NzQwOGExNjBhZGQ4NjFkNTNlYmFhZDhi MDYxMmM2ZjVjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTI1ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBDb25zdHJ1Y3QgZGVm YXVsdCB3aW5kaW5nIHN0cmluZyBhcmd1bWVudHMgaW4gQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE IGZyb20gQVNDSUlMaXRlcmFsIG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0ODQ0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE Lmg6IFVzZSBBU0NJSUxpdGVyYWwgb2JqZWN0cyB0byBjb25zdHJ1Y3QKKyAgICAgICAgdGhlIGRl ZmF1bHQgdmFsdWVzIGZvciB0aGUgd2luZGluZyBhcmd1bWVudHMuIFRoaXMgd2lsbCBhdm9pZCBj b3B5aW5nIHRoZSBzdHJpbmcKKyAgICAgICAgZGF0YSBldmVyeSB0aW1lIHRoZSBtZXRob2RzIGFy ZSBpbnZva2VkIHdpdGggdGhlIGRlZmF1bHQgYXJndW1lbnQgdmFsdWUuCisKIDIwMTUtMDgtMjUg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIGN1 c3RvbSBiaW5kaW5ncyBmb3IgUmVxdWVzdEFuaW1hdGlvbkZyYW1lQ2FsbGJhY2suaGFuZGxlRXZl bnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVy aW5nQ29udGV4dDJELmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJp bmdDb250ZXh0MkQuaAppbmRleCA5MmEzMzBjOTYwMzk1Yjk3NjM3ZTI2MzgyMmUwMDMzNzU4ODY1 YmI1Li40ZTg0OTgzNWQ3NjRjNWJmODNhZmYyMTE0MmUwYWY0YTllMzRhYTBkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQu aApAQCAtMTMyLDE4ICsxMzIsMTggQEAgcHVibGljOgogCiAgICAgdm9pZCBiZWdpblBhdGgoKTsK IAotICAgIHZvaWQgZmlsbChjb25zdCBTdHJpbmcmIHdpbmRpbmcgPSAibm9uemVybyIpOworICAg IHZvaWQgZmlsbChjb25zdCBTdHJpbmcmIHdpbmRpbmcgPSBBU0NJSUxpdGVyYWwoIm5vbnplcm8i KSk7CiAgICAgdm9pZCBzdHJva2UoKTsKLSAgICB2b2lkIGNsaXAoY29uc3QgU3RyaW5nJiB3aW5k aW5nID0gIm5vbnplcm8iKTsKKyAgICB2b2lkIGNsaXAoY29uc3QgU3RyaW5nJiB3aW5kaW5nID0g QVNDSUlMaXRlcmFsKCJub256ZXJvIikpOwogCi0gICAgdm9pZCBmaWxsKERPTVBhdGgqLCBjb25z dCBTdHJpbmcmIHdpbmRpbmcgPSAibm9uemVybyIpOworICAgIHZvaWQgZmlsbChET01QYXRoKiwg Y29uc3QgU3RyaW5nJiB3aW5kaW5nID0gQVNDSUlMaXRlcmFsKCJub256ZXJvIikpOwogICAgIHZv aWQgc3Ryb2tlKERPTVBhdGgqKTsKLSAgICB2b2lkIGNsaXAoRE9NUGF0aCosIGNvbnN0IFN0cmlu ZyYgd2luZGluZyA9ICJub256ZXJvIik7CisgICAgdm9pZCBjbGlwKERPTVBhdGgqLCBjb25zdCBT dHJpbmcmIHdpbmRpbmcgPSBBU0NJSUxpdGVyYWwoIm5vbnplcm8iKSk7CiAKLSAgICBib29sIGlz UG9pbnRJblBhdGgoY29uc3QgZmxvYXQgeCwgY29uc3QgZmxvYXQgeSwgY29uc3QgU3RyaW5nJiB3 aW5kaW5nID0gIm5vbnplcm8iKTsKKyAgICBib29sIGlzUG9pbnRJblBhdGgoY29uc3QgZmxvYXQg eCwgY29uc3QgZmxvYXQgeSwgY29uc3QgU3RyaW5nJiB3aW5kaW5nID0gQVNDSUlMaXRlcmFsKCJu b256ZXJvIikpOwogICAgIGJvb2wgaXNQb2ludEluU3Ryb2tlKGNvbnN0IGZsb2F0IHgsIGNvbnN0 IGZsb2F0IHkpOwogCi0gICAgYm9vbCBpc1BvaW50SW5QYXRoKERPTVBhdGgqLCBjb25zdCBmbG9h dCB4LCBjb25zdCBmbG9hdCB5LCBjb25zdCBTdHJpbmcmIHdpbmRpbmcgPSAibm9uemVybyIpOwor ICAgIGJvb2wgaXNQb2ludEluUGF0aChET01QYXRoKiwgY29uc3QgZmxvYXQgeCwgY29uc3QgZmxv YXQgeSwgY29uc3QgU3RyaW5nJiB3aW5kaW5nID0gQVNDSUlMaXRlcmFsKCJub256ZXJvIikpOwog ICAgIGJvb2wgaXNQb2ludEluU3Ryb2tlKERPTVBhdGgqLCBjb25zdCBmbG9hdCB4LCBjb25zdCBm bG9hdCB5KTsKIAogICAgIHZvaWQgY2xlYXJSZWN0KGZsb2F0IHgsIGZsb2F0IHksIGZsb2F0IHdp ZHRoLCBmbG9hdCBoZWlnaHQpOwo=