148435 2015-08-25 10:08:23 -0700 storage/domstorage/events/basic-body-attribute.html is flaky 2018-12-03 16:06:25 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=155201 P2 Normal --- 1 ap webkit-unassigned andersca commit-queue ryanhaddad oldest_to_newest 1120619 0 ap 2015-08-25 10:08:23 -0700 storage/domstorage/events/basic-body-attribute.html became flaky on Mavericks, Yosemite and ELF WK2 bots around a week ago (first failure on August 18th). https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Fdomstorage%2F&showExpectations=true&revision=188905 --- /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/storage/domstorage/events/basic-body-attribute-expected.txt +++ /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/storage/domstorage/events/basic-body-attribute-actual.txt @@ -57,41 +57,46 @@ Reset storage event list storageEventList = new Array() storage.setItem('FOO', 'BAR') -PASS storageEventList.length is 1 -PASS storageEventList[0].key is "FOO" +FAIL got at least 2, expected only 1 events +FAIL storageEventList.length should be 1. Was 2. +FAIL storageEventList[0].key should be FOO. Was . PASS storageEventList[0].oldValue is null -PASS storageEventList[0].newValue is "BAR" +FAIL storageEventList[0].newValue should be BAR (of type string). Was null (of type object). storage.setItem('FU', 'BAR') storage.setItem('a', '1') storage.setItem('b', '2') storage.setItem('b', '3') -PASS storageEventList.length is 5 -PASS storageEventList[1].key is "FU" +FAIL got at least 6, expected only 5 events +FAIL storageEventList.length should be 5. Was 6. +FAIL storageEventList[1].key should be FU. Was FOO. PASS storageEventList[1].oldValue is null PASS storageEventList[1].newValue is "BAR" -PASS storageEventList[2].key is "a" +FAIL storageEventList[2].key should be a. Was FU. PASS storageEventList[2].oldValue is null -PASS storageEventList[2].newValue is "1" -PASS storageEventList[3].key is "b" +FAIL storageEventList[2].newValue should be 1. Was BAR. +FAIL storageEventList[3].key should be b. Was a. PASS storageEventList[3].oldValue is null -PASS storageEventList[3].newValue is "2" +FAIL storageEventList[3].newValue should be 2. Was 1. PASS storageEventList[4].key is "b" -PASS storageEventList[4].oldValue is "2" -PASS storageEventList[4].newValue is "3" +FAIL storageEventList[4].oldValue should be 2 (of type string). Was null (of type object). +FAIL storageEventList[4].newValue should be 3. Was 2. storage.removeItem('FOO') -PASS storageEventList.length is 6 -PASS storageEventList[5].key is "FOO" -PASS storageEventList[5].oldValue is "BAR" -PASS storageEventList[5].newValue is null +FAIL got at least 7, expected only 6 events +FAIL storageEventList.length should be 6. Was 7. +FAIL storageEventList[5].key should be FOO. Was b. +FAIL storageEventList[5].oldValue should be BAR. Was 2. +FAIL storageEventList[5].newValue should be null (of type object). Was 3 (of type string). storage.removeItem('FU') -PASS storageEventList.length is 7 -PASS storageEventList[6].key is "FU" +FAIL got at least 8, expected only 7 events +FAIL storageEventList.length should be 7. Was 8. +FAIL storageEventList[6].key should be FU. Was FOO. PASS storageEventList[6].oldValue is "BAR" PASS storageEventList[6].newValue is null storage.clear() -PASS storageEventList.length is 8 -PASS storageEventList[7].key is "" -PASS storageEventList[7].oldValue is null +FAIL got at least 9, expected only 8 events +FAIL storageEventList.length should be 8. Was 9. +FAIL storageEventList[7].key should be . Was FU. +FAIL storageEventList[7].oldValue should be null (of type object). Was BAR (of type string). PASS storageEventList[7].newValue is null 1121198 1 ap 2015-08-26 21:52:36 -0700 Some timing change must have happened, but the test failed before last week, too. ASan bot was seeing it. r188597 was the first revision where this occurred on non-ASan bots. 1131956 2 ryanhaddad 2015-10-09 11:12:26 -0700 Still seeing the flakiness: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/17797 http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Fdomstorage%2Fevents%2Fbasic-body-attribute.html 1132328 3 262893 ryanhaddad 2015-10-12 09:54:38 -0700 Created attachment 262893 Patch 1132330 4 ryanhaddad 2015-10-12 09:55:36 -0700 *** Bug 149969 has been marked as a duplicate of this bug. *** 1132409 5 262893 commit-queue 2015-10-12 12:03:51 -0700 Comment on attachment 262893 Patch Clearing flags on attachment: 262893 Committed r190877: <http://trac.webkit.org/changeset/190877> 1132410 6 commit-queue 2015-10-12 12:03:56 -0700 All reviewed patches have been landed. Closing bug. 1132435 7 ap 2015-10-12 12:36:00 -0700 Re-opening, as this is not fixed. 262893 2015-10-12 09:54:38 -0700 2015-10-12 12:03:51 -0700 Patch bug-148435-20151012095403.patch text/plain 1467 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwODU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGU1NjExZmUyZDlhNWM5NDc4ZWVl ZjIzNzViMjdiZjZkYTE2ZGQyOC4uNjk1NTliZmZhYjcyMmQ5YWMzNjBiYTFhZDI2MmI1MmUxMjBk MGMwZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTEwLTEyICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIE1hcmtpbmcgc3RvcmFnZS9kb21zdG9yYWdl L2V2ZW50cy9iYXNpYy1ib2R5LWF0dHJpYnV0ZS5odG1sIGFzIGZsYWt5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zOgorCiAyMDE1LTEwLTExICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBh cHBsZS5jb20+CiAKICAgICAgICAgVGVzdCBmb250LXZhcmlhbnQtKiBhbmQgZm9udC1mZWF0dXJl LXNldHRpbmdzIHdpdGggbW9ja2VkIHByZWluc3RhbGxlZCBmb250cwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAzYzNkM2QyZThkNGNlOTg3YzYyYmU0MjEw NGNhMGM2MzVhZGRiNzNlLi5kOTIxOTRiZjY4MzBlMTJhNmY2MGNlYzk2ODBhMDkyNWJmODU4OGIy IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTMzNiw1 ICsxMzM2LDggQEAgd2Via2l0Lm9yZy9iLzE0OTQ0MSBmYXN0L3NoYWRvdy1kb20vY3NzLXNjb3Bp bmctc2hhZG93LXNsb3QtZGlzcGxheS1vdmVycmlkZS5odG0KICMgTWFya2luZyB0ZXN0IGFzIGZs YWt5IGluIEVsIENhcGl0YW4KIHdlYmtpdC5vcmcvYi8xNDk4MTkgWyBEZWJ1ZyBFbENhcGl0YW4r IF0gY29tcG9zaXRpbmcvdmlkZW8vdmlkZW8tcG9zdGVyLmh0bWwgWyBQYXNzIENyYXNoIF0KIAor IyBGbGFreSBvbiBNYWMKK3dlYmtpdC5vcmcvYi8xNDg0MzUgc3RvcmFnZS9kb21zdG9yYWdlL2V2 ZW50cy9iYXNpYy1ib2R5LWF0dHJpYnV0ZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KKwogIyBJbXBv cnRlZCBCbGluayB0ZXN0cyB3aGljaCBoYXZlIG5vdCBiZWVuIGludmVzdGlnYXRlZC4KIGltcG9y dGVkL2JsaW5rL2NvbXBvc2l0aW5nL3ZpZGVvL3ZpZGVvLWNvbnRyb2xzLWxheWVyLWNyZWF0aW9u LXNxdWFzaGluZy5odG1sIFsgUGFzcyBJbWFnZU9ubHlGYWlsdXJlIF0K