148433 2015-08-25 08:52:43 -0700 [GStreamer] "method" property for the webkitwebsrc element 2015-08-26 02:51:44 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cgarcia mrobinson pnormand oldest_to_newest 1120595 0 pnormand 2015-08-25 08:52:43 -0700 The GStreamer uridownloader element makes use of this property in some cases for DASH. See also https://bugzilla.gnome.org/show_bug.cgi?id=752413 So we should also add this property in webkitwebsrc, the patch is trivial. 1120597 1 259847 pnormand 2015-08-25 09:00:39 -0700 Created attachment 259847 patch 1120877 2 259847 cgarcia 2015-08-26 00:27:05 -0700 Comment on attachment 259847 patch View in context: https://bugs.webkit.org/attachment.cgi?id=259847&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:116 > + GUniquePtr<gchar> method; method is quite confusing name, we can't change the property name, of course, but at least the variable could be httpMethod or something like that, I didn't know what this was about until I read the full patch. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:269 > + 0, static_cast<GParamFlags>(G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS))); nullptr. 1120906 3 pnormand 2015-08-26 02:51:44 -0700 Committed r188961: <http://trac.webkit.org/changeset/188961> 259847 2015-08-25 09:00:39 -0700 2015-08-26 00:27:05 -0700 patch patch.patch text/plain 4117 pnormand RnJvbSA5ZDczNTI0M2EyM2Q0NjljNGEyMDA1Y2ExMzhhNmI2NWY0YjAxNTA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDI1IEF1ZyAyMDE1IDE3OjU5OjU3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgMTYgKysrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dzdHJlYW1lci9X ZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwICAgIHwgMTggKysrKysrKysrKysrKysrKystCiAy IGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggNjY1ZmFiNS4uZTZjMDQwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1 LTA4LTI1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1N0cmVhbWVyXSAibWV0aG9kIiBwcm9wZXJ0eSBmb3IgdGhlIHdlYmtpdHdlYnNyYyBlbGVt ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0 MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IG5ldyBwcm9wZXJ0eSBpcyBzb21ldGltZXMgdXNlZCBieSB0aGUgR1N0cmVhbWVyIHVyaWRvd25s b2FkZXIKKyAgICAgICAgd2hlbiB0aW1lIHN5bmNocm9uaXphdGlvbiBpcyByZXF1aXJlZCBmb3Ig REFTSC4gVGhlIHNhbWUgcHJvcGVydHkKKyAgICAgICAgd2FzIGFkZGVkIHRvIHRoZSBzb3VwaHR0 cHNyYyBlbGVtZW50LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dl YktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgICh3ZWJLaXRXZWJTcmNTZXRQcm9w ZXJ0eSk6CisgICAgICAgICh3ZWJLaXRXZWJTcmNHZXRQcm9wZXJ0eSk6CisgICAgICAgICh3ZWJL aXRXZWJTcmNTdGFydCk6CisKIDIwMTUtMDgtMjUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIGN1c3RvbSBiaW5kaW5ncyBmb3IgUmVxdWVzdEFu aW1hdGlvbkZyYW1lQ2FsbGJhY2suaGFuZGxlRXZlbnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1l ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0 V2ViU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCBjMmRhMzcwLi45MDAzNDg1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291 cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcApAQCAtMTEzLDYgKzExMyw3IEBA IHN0cnVjdCBfV2ViS2l0V2ViU3JjUHJpdmF0ZSB7CiAgICAgYm9vbCBrZWVwQWxpdmU7CiAgICAg R1VuaXF1ZVB0cjxHc3RTdHJ1Y3R1cmU+IGV4dHJhSGVhZGVyczsKICAgICBib29sIGNvbXByZXNz OworICAgIEdVbmlxdWVQdHI8Z2NoYXI+IG1ldGhvZDsKIAogICAgIFdlYkNvcmU6Ok1lZGlhUGxh eWVyKiBwbGF5ZXI7CiAKQEAgLTE1Miw3ICsxNTMsOCBAQCBlbnVtIHsKICAgICBQUk9QX0xPQ0FU SU9OLAogICAgIFBST1BfS0VFUF9BTElWRSwKICAgICBQUk9QX0VYVFJBX0hFQURFUlMsCi0gICAg UFJPUF9DT01QUkVTUworICAgIFBST1BfQ09NUFJFU1MsCisgICAgUFJPUF9NRVRIT0QKIH07CiAK IHN0YXRpYyBHc3RTdGF0aWNQYWRUZW1wbGF0ZSBzcmNUZW1wbGF0ZSA9IEdTVF9TVEFUSUNfUEFE X1RFTVBMQVRFKCJzcmMiLApAQCAtMjYyLDYgKzI2NCwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRf d2ViX3NyY19jbGFzc19pbml0KFdlYktpdFdlYlNyY0NsYXNzKiBrbGFzcykKICAgICAgICAgZ19w YXJhbV9zcGVjX2Jvb2xlYW4oImNvbXByZXNzIiwgIkNvbXByZXNzIiwgIkFsbG93IGNvbXByZXNz ZWQgY29udGVudCBlbmNvZGluZ3MiLAogICAgICAgICAgICAgRkFMU0UsIHN0YXRpY19jYXN0PEdQ YXJhbUZsYWdzPihHX1BBUkFNX1JFQURXUklURSB8IEdfUEFSQU1fU1RBVElDX1NUUklOR1MpKSk7 CiAKKyAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9rbGFzcywgUFJPUF9NRVRI T0QsCisgICAgICAgIGdfcGFyYW1fc3BlY19zdHJpbmcoIm1ldGhvZCIsICJtZXRob2QiLCAiVGhl IEhUVFAgbWV0aG9kIHRvIHVzZSAoZGVmYXVsdDogR0VUKSIsCisgICAgICAgICAgICAwLCBzdGF0 aWNfY2FzdDxHUGFyYW1GbGFncz4oR19QQVJBTV9SRUFEV1JJVEUgfCBHX1BBUkFNX1NUQVRJQ19T VFJJTkdTKSkpOworCiAgICAgZWtsYXNzLT5jaGFuZ2Vfc3RhdGUgPSB3ZWJLaXRXZWJTcmNDaGFu Z2VTdGF0ZTsKIAogICAgIGdfdHlwZV9jbGFzc19hZGRfcHJpdmF0ZShrbGFzcywgc2l6ZW9mKFdl YktpdFdlYlNyY1ByaXZhdGUpKTsKQEAgLTM1OCw2ICszNjQsOSBAQCBzdGF0aWMgdm9pZCB3ZWJL aXRXZWJTcmNTZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BJRCwgY29uc3Qg R1ZhbHVlKgogICAgIGNhc2UgUFJPUF9DT01QUkVTUzoKICAgICAgICAgc3JjLT5wcml2LT5jb21w cmVzcyA9IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOwogICAgICAgICBicmVhazsKKyAgICBj YXNlIFBST1BfTUVUSE9EOgorICAgICAgICBzcmMtPnByaXYtPm1ldGhvZC5yZXNldChnX3ZhbHVl X2R1cF9zdHJpbmcodmFsdWUpKTsKKyAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAg ICAgR19PQkpFQ1RfV0FSTl9JTlZBTElEX1BST1BFUlRZX0lEKG9iamVjdCwgcHJvcElELCBwc3Bl Yyk7CiAgICAgICAgIGJyZWFrOwpAQCAtMzk1LDYgKzQwNCw5IEBAIHN0YXRpYyB2b2lkIHdlYktp dFdlYlNyY0dldFByb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcElELCBHVmFsdWUq IHZhbHVlCiAgICAgY2FzZSBQUk9QX0NPTVBSRVNTOgogICAgICAgICBnX3ZhbHVlX3NldF9ib29s ZWFuKHZhbHVlLCBwcml2LT5jb21wcmVzcyk7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgUFJP UF9NRVRIT0Q6CisgICAgICAgIGdfdmFsdWVfc2V0X3N0cmluZyh2YWx1ZSwgcHJpdi0+bWV0aG9k LmdldCgpKTsKKyAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgR19PQkpFQ1Rf V0FSTl9JTlZBTElEX1BST1BFUlRZX0lEKG9iamVjdCwgcHJvcElELCBwc3BlYyk7CiAgICAgICAg IGJyZWFrOwpAQCAtNTQyLDYgKzU1NCw3IEBAIHN0YXRpYyB2b2lkIHdlYktpdFdlYlNyY1N0YXJ0 KFdlYktpdFdlYlNyYyogc3JjKQogCiAgICAgQVNTRVJUKCFwcml2LT5jbGllbnQpOwogCisgICAg R1NUX0RFQlVHX09CSkVDVChzcmMsICJGZXRjaGluZyAlcyIsIHByaXYtPnVyaSk7CiAgICAgVVJM IHVybCA9IFVSTChVUkwoKSwgcHJpdi0+dXJpKTsKIAogICAgIFJlc291cmNlUmVxdWVzdCByZXF1 ZXN0KHVybCk7CkBAIC01NTMsNiArNTY2LDkgQEAgc3RhdGljIHZvaWQgd2ViS2l0V2ViU3JjU3Rh cnQoV2ViS2l0V2ViU3JjKiBzcmMpCiAgICAgaWYgKHByaXYtPnBsYXllcikKICAgICAgICAgcmVx dWVzdC5zZXRIVFRQUmVmZXJyZXIocHJpdi0+cGxheWVyLT5yZWZlcnJlcigpKTsKIAorICAgIGlm IChwcml2LT5tZXRob2QuZ2V0KCkpCisgICAgICAgIHJlcXVlc3Quc2V0SFRUUE1ldGhvZChwcml2 LT5tZXRob2QuZ2V0KCkpOworCiAjaWYgVVNFKFNPVVApCiAgICAgLy8gQnkgZGVmYXVsdCwgSFRU UCBBY2NlcHQtRW5jb2RpbmcgaXMgZGlzYWJsZWQgaGVyZSBhcyB3ZSBkb24ndAogICAgIC8vIHdh bnQgdGhlIHJlY2VpdmVkIHJlc3BvbnNlIHRvIGJlIGVuY29kZWQgaW4gYW55IHdheSBhcyB3ZSBu ZWVkCi0tIAoyLjUuMA==