148425 2015-08-25 03:08:53 -0700 Fix the !ENABLE(CSS_REGIONS) build after r188663 2015-08-25 11:04:30 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148193 1 ossy ossy cdumez commit-queue ggaren ossy oldest_to_newest 1120560 0 ossy 2015-08-25 03:08:53 -0700 http://trac.webkit.org/changeset/188663 broke the !ENABLE(CSS_REGIONS) build, because JSDOMNamedFlowCollection class is defined inside guard. ( http://trac.webkit.org/browser/trunk/Source/WebCore/dom/DOMNamedFlowCollection.idl#L1 ) build log: ../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:37:6: error: 'JSDOMNamedFlowCollection' has not been declared ../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp: In function 'bool WebCore::nameGetter(JSC::ExecState*, JSC::PropertyName, JSC::JSValue&)': ../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:39:22: error: 'impl' was not declared in this scope ../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:43:37: error: 'globalObject' was not declared in this scope ninja: build stopped: subcommand failed. There is no need for JSDOMNamedFlowCollection::nameGetter() outside the guard, so let's guard the whole Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp 1120563 1 259835 ossy 2015-08-25 03:13:44 -0700 Created attachment 259835 Patch 1120596 2 259835 cdumez 2015-08-25 08:59:29 -0700 Comment on attachment 259835 Patch r=me, thanks! 1120647 3 259835 commit-queue 2015-08-25 11:04:25 -0700 Comment on attachment 259835 Patch Clearing flags on attachment: 259835 Committed r188921: <http://trac.webkit.org/changeset/188921> 1120649 4 commit-queue 2015-08-25 11:04:30 -0700 All reviewed patches have been landed. Closing bug. 259835 2015-08-25 03:13:44 -0700 2015-08-25 11:04:25 -0700 Patch bug-148425-20150825121333.patch text/plain 1403 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjY1ZmFiNWQ1NzAzYzIw ZTI1ZTIzY2QwOWU3MDk4NTlhZWY5NjNjMS4uYzNiYjY1MzZjZTE4Y2Y0Mjc4YmFlMDk2MmUxNjYw M2Q3ZTQzYzQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA4LTI1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKENTU19SRUdJT05TKSBidWlsZCBhZnRlciByMTg4NjYzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NTmFtZWRGbG93 Q29sbGVjdGlvbkN1c3RvbS5jcHA6CisKIDIwMTUtMDgtMjUgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIGN1c3RvbSBiaW5kaW5ncyBmb3IgUmVx dWVzdEFuaW1hdGlvbkZyYW1lQ2FsbGJhY2suaGFuZGxlRXZlbnQoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01OYW1lZEZsb3dDb2xsZWN0aW9uQ3VzdG9tLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NTmFtZWRGbG93Q29sbGVjdGlvbkN1 c3RvbS5jcHAKaW5kZXggYjcyYmFkMzVjMTQwYzNlZGMzM2EzOWRjYmVkOTRkZDYyMDIzODEyZC4u MGRkNTQ1MTIxN2RjODA4ZGQzZTlmNTJhYmQyYjRmZmNkNjRmOGIzZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01OYW1lZEZsb3dDb2xsZWN0aW9uQ3VzdG9tLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTU5hbWVkRmxvd0NvbGxlY3Rp b25DdXN0b20uY3BwCkBAIC0yNiw2ICsyNiw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5j bHVkZSAiSlNET01OYW1lZEZsb3dDb2xsZWN0aW9uLmgiCiAKKyNpZiBFTkFCTEUoQ1NTX1JFR0lP TlMpCisKICNpbmNsdWRlICJET01OYW1lZEZsb3dDb2xsZWN0aW9uLmgiCiAjaW5jbHVkZSAiSlNE T01CaW5kaW5nLmgiCiAjaW5jbHVkZSAiSlNXZWJLaXROYW1lZEZsb3cuaCIKQEAgLTQ1LDMgKzQ3 LDUgQEAgYm9vbCBKU0RPTU5hbWVkRmxvd0NvbGxlY3Rpb246Om5hbWVHZXR0ZXIoRXhlY1N0YXRl KiBleGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHkKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQorCisjZW5kaWYgLy8gRU5BQkxFKENTU19SRUdJT05TKQo=