148424 2015-08-25 02:48:49 -0700 Fix the !ENABLE(VIDEO) build after r188693 2015-08-25 11:13:24 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148195 1 ossy ossy bdakin commit-queue thorton oldest_to_newest 1120558 0 ossy 2015-08-25 02:48:49 -0700 http://trac.webkit.org/changeset/188693 broke the !ENABLE(VIDEO) build, because ChromeClient::imageOrMediaDocumentSizeChanged() is defined inside ENABLE(VIDEO) guard, but is overriden unconfitionally: ../../Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:328:18: error: 'virtual void WebKit::WebChromeClient::imageOrMediaDocumentSizeChanged(const WebCore::IntSize&)' marked override, but does not override 1120559 1 259834 ossy 2015-08-25 02:52:19 -0700 Created attachment 259834 Patch 1120654 2 259834 commit-queue 2015-08-25 11:13:20 -0700 Comment on attachment 259834 Patch Clearing flags on attachment: 259834 Committed r188923: <http://trac.webkit.org/changeset/188923> 1120655 3 commit-queue 2015-08-25 11:13:24 -0700 All reviewed patches have been landed. Closing bug. 259834 2015-08-25 02:52:19 -0700 2015-08-25 11:13:20 -0700 Patch bug-148424-20150825115209.patch text/plain 1415 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzlmMGM4NDNiOWNjM2Ey NDQzOGRhODQ0ODRmOGQ2ZGQ3NGFhZGYwOS4uMzU2ZTdiMTc5NTc0MmJjYmE3Y2UzNWY3NTNiZTQ5 ZmQ1NWQxYWE3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA4LTI1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKFZJREVPKSBidWlsZCBhZnRlciByMTg4NjkzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6CisKIDIwMTUtMDgt MjQgIEppbnlvdW5nIEh1ciAgPGh1ci5pbXNAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBDbGVh ciBjYWlyby1nbCBzdXJmYWNlIGZvciBpbml0aWFsaXphdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21l Q2xpZW50LmgKaW5kZXggZWFmZGVmZGMyOTBjYzhmOWY5ODI0Mzg2NTAzY2Q4YzRmZDAzNmJmYS4u ZTYwMTdjODRiMzFmM2RmMzFiY2ZhYWRmZGIxZDdhOGIxMzExZDUxMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0Nocm9tZUNsaWVudC5oCkBAIC00NTUsMTIgKzQ1NSwxMSBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIHBsYXliYWNrVGFyZ2V0UGlja2VyQ2xpZW50U3RhdGVEaWRDaGFuZ2UodWludDY0X3Qg Lypjb250ZXh0SWQqLywgTWVkaWFQcm9kdWNlcjo6TWVkaWFTdGF0ZUZsYWdzKSB7IH0KICNlbmRp ZgogCi0jaWYgRU5BQkxFKFZJREVPKQogICAgIHZpcnR1YWwgdm9pZCBpbWFnZU9yTWVkaWFEb2N1 bWVudFNpemVDaGFuZ2VkKGNvbnN0IFdlYkNvcmU6OkludFNpemUmKSB7IH0KLSNpZiBVU0UoR1NU UkVBTUVSKQorCisjaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVSKQogICAgIHZpcnR1 YWwgdm9pZCByZXF1ZXN0SW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnMoY29uc3QgU3RyaW5nJiAv KmRldGFpbHMqLywgY29uc3QgU3RyaW5nJiAvKmRlc2NyaXB0aW9uKi8sIE1lZGlhUGxheWVyUmVx dWVzdEluc3RhbGxNaXNzaW5nUGx1Z2luc0NhbGxiYWNrJikgeyB9OwogI2VuZGlmCi0jZW5kaWYK IAogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgfkNocm9tZUNsaWVudCgpIHsgfQo=