148423 2015-08-25 02:19:34 -0700 [WebKit2] add some protection code at IndexedDB 2022-07-11 15:04:40 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 jincheol.jo jincheol.jo andersca beidson bfulgham gyuyoung.kim ossy sam sihui_liu oldest_to_newest 1120554 0 jincheol.jo 2015-08-25 02:19:34 -0700 Metadata pointer seems to need a null protection code. Its member is accessed in next line. I guess it can trigger crash. 1120555 1 259832 jincheol.jo 2015-08-25 02:24:32 -0700 Created attachment 259832 Patch 1120838 2 beidson 2015-08-25 21:49:23 -0700 Are you just offering this patch because of code inspection, or do you actually have a reproducible case of the null deref crash? 1120905 3 jincheol.jo 2015-08-26 02:51:40 -0700 (In reply to comment #2) > Are you just offering this patch because of code inspection, or do you > actually have a reproducible case of the null deref crash? When I blocked all function body code of KeyedEncoder and KeyedDecoder for my test, it triggered crash in that line. 1120955 4 beidson 2015-08-26 09:08:24 -0700 (In reply to comment #3) > (In reply to comment #2) > > Are you just offering this patch because of code inspection, or do you > > actually have a reproducible case of the null deref crash? > > When I blocked all function body code of KeyedEncoder and KeyedDecoder for > my test, it triggered crash in that line. For what test? This patch has no test. And what do you mean "blocked all function body code of KeyedEncoder and KeyedDecoder"? 1120960 5 beidson 2015-08-26 09:20:36 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Are you just offering this patch because of code inspection, or do you > > > actually have a reproducible case of the null deref crash? > > > > When I blocked all function body code of KeyedEncoder and KeyedDecoder for > > my test, it triggered crash in that line. > > For what test? This patch has no test. Since I hadn't explicitly stated this, I will now - Patches require tests unless there's a darned good reason why they're untestable. It sounds like you have a way of triggering the crash, we'd like a test that triggers the crash along with the patch. 1121164 6 jincheol.jo 2015-08-26 19:31:59 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > Are you just offering this patch because of code inspection, or do you > > > > actually have a reproducible case of the null deref crash? > > > > > > When I blocked all function body code of KeyedEncoder and KeyedDecoder for > > > my test, it triggered crash in that line. > > > > For what test? This patch has no test. > > Since I hadn't explicitly stated this, I will now - Patches require tests > unless there's a darned good reason why they're untestable. > > It sounds like you have a way of triggering the crash, we'd like a test that > triggers the crash along with the patch. (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > Are you just offering this patch because of code inspection, or do you > > > > actually have a reproducible case of the null deref crash? > > > > > > When I blocked all function body code of KeyedEncoder and KeyedDecoder for > > > my test, it triggered crash in that line. > > > > For what test? This patch has no test. > > Since I hadn't explicitly stated this, I will now - Patches require tests > unless there's a darned good reason why they're untestable. > > It sounds like you have a way of triggering the crash, we'd like a test that > triggers the crash along with the patch. Thanks for quick reply, I will prepare a test. 1151778 7 259832 mcatanzaro 2015-12-31 14:42:24 -0800 Comment on attachment 259832 Patch Removing this from the request queue, pending a testcase. 259832 2015-08-25 02:24:32 -0700 2015-12-31 14:42:24 -0800 Patch bug-148423-20150825182421.patch text/plain 1904 jincheol.jo U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGMwODY5ZTA5NTYzMzQx NDI0ZjEyNzJjNjg1YTgyOGFiMWMwMTBiMi4uZmUyYTg0MDhkMmU5NWQ1ZGJhZmMyYzdhMmNkMjg4 MDk5NTBkN2I5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA4LTI1ICBKaW5j aGVvbCBKbyAgPGppbmNoZW9sLmpvQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgW1dlYktpdDJd IGFkZCBzb21lIHByb3RlY3Rpb24gY29kZSBhdCBJbmRleGVkREIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MjMuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWV0YWRhdGEgcG9pbnRlciBzZWVtcyB0 byBuZWVkIGEgbnVsbCBwcm90ZWN0aW9uIGNvZGUuCisgICAgICAgIEl0cyBtZW1iZXIgaXMgYWNj ZXNzZWQgaW4gbmV4dCBsaW5lLgorICAgICAgICBJdCBjYW4gdHJpZ2VyIGEgY3Jhc2guCisKKyAg ICAgICAgKiBEYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9VbmlxdWVJREJEYXRhYmFz ZUJhY2tpbmdTdG9yZVNRTGl0ZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlVuaXF1ZUlEQkRhdGFi YXNlQmFja2luZ1N0b3JlU1FMaXRlOjpnZXRPckVzdGFibGlzaE1ldGFkYXRhKToKKwogMjAxNS0w OC0yNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgRUZMIGFuZCBHVEsgYnVpbGQgZml4IHNpbmNlIHIxODg4OTUuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9Vbmlx dWVJREJEYXRhYmFzZUJhY2tpbmdTdG9yZVNRTGl0ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9EYXRh YmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9VbmlxdWVJREJEYXRhYmFzZUJhY2tpbmdTdG9y ZVNRTGl0ZS5jcHAKaW5kZXggOGYwYmNmZjZkOWFlOGY1NjM3NmQ2ODVhYWM3Y2U5MmU0NzE5Yzk5 Ni4uODUwN2JkYTY5Mjk1NWY5NWUwYjc4NWFlYWYyMzlmODUyYzFiYTNkNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUvVW5pcXVlSURC RGF0YWJhc2VCYWNraW5nU3RvcmVTUUxpdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL0RhdGFi YXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1VuaXF1ZUlEQkRhdGFiYXNlQmFja2luZ1N0b3Jl U1FMaXRlLmNwcApAQCAtNDQ3LDggKzQ0NywxMSBAQCBzdGQ6OnVuaXF1ZV9wdHI8SURCRGF0YWJh c2VNZXRhZGF0YT4gVW5pcXVlSURCRGF0YWJhc2VCYWNraW5nU3RvcmVTUUxpdGU6OmdldE9yRQog ICAgIGlmICghbWV0YWRhdGEpCiAgICAgICAgIG1ldGFkYXRhID0gY3JlYXRlQW5kUG9wdWxhdGVJ bml0aWFsTWV0YWRhdGEoKTsKIAotICAgIGlmICghbWV0YWRhdGEpCisgICAgaWYgKCFtZXRhZGF0 YSkgewogICAgICAgICBMT0dfRVJST1IoIlVuYWJsZSB0byBlc3RhYmxpc2ggSURCIGRhdGFiYXNl IGF0IHBhdGggJyVzJyIsIGRiRmlsZW5hbWUudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIG1fc3Fs aXRlREIgPSBudWxscHRyOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICB9CiAKICAgICAv LyBUaGUgZGF0YWJhc2UgaWQgaXMgYSBydW50aW1lIGNvbmNlcHQgYW5kIGRvZXNuJ3QgbmVlZCB0 byBiZSBzdG9yZWQgaW4gdGhlIG1ldGFkYXRhIGRhdGFiYXNlLgogICAgIG1ldGFkYXRhLT5pZCA9 IGdlbmVyYXRlRGF0YWJhc2VJZCgpOwo=