148419 2015-08-24 22:41:26 -0700 [CSS DeviceAdaptation] Fix crash which occurs at visiting webpage using @viewport CSS rule when device adaptation is enabled 2019-04-30 07:58:01 -0700 1 1 1 Unclassified WebKit CSS WebKit Local Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 jh718.park jh718.park benjamin darin gyuyoung.kim ossy oldest_to_newest 1120540 0 jh718.park 2015-08-24 22:41:26 -0700 Currently width shorthand and height shorthand is not generated by makeprop.pl and the same css property names are already placed in CSSPropertyNames.in. So with enabled device adaptation, crash occurs when visiting webpage using @viewport rule because there is no shorthand property(width and height) for corresponding longhand property. This patch prevents the crash. 1120565 1 259836 jh718.park 2015-08-25 03:32:15 -0700 Created attachment 259836 Patch 1120567 2 259837 jh718.park 2015-08-25 03:43:41 -0700 Created attachment 259837 Patch 1121115 3 jh718.park 2015-08-26 17:15:01 -0700 For your reference, this crash occurs as assertion fail in debug build. The callstack is as below. (gdb) bt #0 0x00007f094663a0aa in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:321 #1 0x00007f094c32fd56 in WebCore::indexOfShorthandForLonghand ( shorthandID=WebCore::CSSPropertyWidth, shorthands=...) at ../../Source/WebCore/css/StylePropertyShorthand.cpp:83 #2 0x00007f094d4b2f7c in WebCore::CSSParser::addProperty ( this=0x7ffe219d72e0, propId=WebCore::CSSPropertyMinWidth, value=..., important=false, implicit=false) at ../../Source/WebCore/css/CSSParser.cpp:1621 #3 0x00007f094d4e2ecc in WebCore::CSSParser::parseViewportProperty ( this=0x7ffe219d72e0, propId=WebCore::CSSPropertyMinWidth, important=false) at ../../Source/WebCore/css/CSSParser.cpp:12785 #4 0x00007f094d4e2fed in WebCore::CSSParser::parseViewportShorthand ( this=0x7ffe219d72e0, propId=WebCore::CSSPropertyWidth, first=WebCore::CSSPropertyMinWidth, second=WebCore::CSSPropertyMaxWidth, important=false) at ../../Source/WebCore/css/CSSParser.cpp:12802 #5 0x00007f094d4e2d19 in WebCore::CSSParser::parseViewportProperty ( this=0x7ffe219d72e0, propId=WebCore::CSSPropertyWidth, important=false) at ../../Source/WebCore/css/CSSParser.cpp:12755 #6 0x00007f094d4b3fe4 in WebCore::CSSParser::parseValue (this=0x7ffe219d72e0, propId=WebCore::CSSPropertyWidth, important=false) at ../../Source/WebCore/css/CSSParser.cpp:1899 #7 0x00007f094d978884 in cssyyparse (parser=0x7ffe219d72e0) at /home/joonghunpark/WebKit/WebKitBuild/Debug/DerivedSources/WebCore/CSSGrammar.y:1320 #8 0x00007f094d4aed11 in WebCore::CSSParser::parseSheet (this=0x7ffe219d72e0, sheet=0x7f08c03f9820, string=..., textPosition=..., ruleSourceDataResult=0x0, logErrors=true) at ../../Source/WebCore/css/CSSParser.cpp:455 #9 0x00007f094d589449 in WebCore::StyleSheetContents::parseAuthorStyleSheet ( this=0x7f08c03f9820, cachedStyleSheet=0x7f08c29d3940, securityOrigin=0x7f092f38f348) at ../../Source/WebCore/css/StyleSheetContents.cpp:315 #10 0x00007f094c59bf47 in WebCore::HTMLLinkElement::setCSSStyleSheet ( this=0x7f08c3ad5190, href=..., baseURL=..., charset=..., cachedStyleSheet=0x7f08c29d3940) at ../../Source/WebCore/html/HTMLLinkElement.cpp:349 #11 0x00007f094c82e3f1 in WebCore::CachedCSSStyleSheet::checkNotify ( this=0x7f08c29d3940) at ../../Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:113 #12 0x00007f094c82e27b in WebCore::CachedCSSStyleSheet::finishLoading ( this=0x7f08c29d3940, data=0x7f08c1bcc0c0) at ../../Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:101 #13 0x00007f094c7ff8fa in WebCore::SubresourceLoader::didFinishLoading ( this=0x7f08c0018000, finishTime=0) at ../../Source/WebCore/loader/SubresourceLoader.cpp:374 #14 0x00007f094c7fa1b7 in WebCore::ResourceLoader::didFinishLoading ( this=0x7f08c0018000, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:613 #15 0x00007f094cff034a in WebCore::readCallback (asyncResult=0x1f65d20, data=0x7f08c2b77dc0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1340 #16 0x00007f0942de23d6 in async_ready_callback_wrapper ( source_object=0x1f71510, res=0x1f65d20, user_data=0x7f08c2b77dc0) at ginputstream.c:523 #17 0x00007f0942e089b4 in g_task_return_now (task=0x1f65d20) at gtask.c:1077 #18 0x00007f0942e089d9 in complete_in_idle_cb (task=0x1f65d20) at gtask.c:1086 #19 0x00007f09428407ed in g_main_dispatch (context=0x1d6aff0) at gmain.c:3064 #20 g_main_context_dispatch (context=context@entry=0x1d6aff0) at gmain.c:3663 #21 0x00007f09441aee48 in _ecore_glib_select__locked ( ecore_timeout=<optimized out>, efds=0x7ffe219d8b00, wfds=0x7ffe219d8a80, rfds=0x7ffe219d8a00, ecore_fds=<optimized out>, ctx=<optimized out>) at lib/ecore/ecore_glib.c:172 #22 _ecore_glib_select (ecore_fds=<optimized out>, rfds=0x7ffe219d8a00, wfds=0x7ffe219d8a80, efds=0x7ffe219d8b00, ecore_timeout=<optimized out>) at lib/ecore/ecore_glib.c:204 #23 0x00007f09441b2494 in _ecore_main_select (timeout=9.532824124368238e-130) at lib/ecore/ecore_main.c:1459 #24 0x00007f09441b2ed4 in _ecore_main_loop_iterate_internal ( once_only=once_only@entry=0) at lib/ecore/ecore_main.c:1893 #25 0x00007f09441b2fc7 in ecore_main_loop_begin () at lib/ecore/ecore_main.c:983 #26 0x00007f094dc8ee15 in WTF::RunLoop::run () at ../../Source/WTF/wtf/efl/RunLoopEfl.cpp:49 #27 0x00007f094c1044a7 in WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain> (argc=2, argv=0x7ffe219d8f38) at ../../Source/WebKit2/Shared/unix/ChildProcessMain.h:61 #28 0x00007f094c1040b5 in WebKit::WebProcessMainUnix (argc=2, argv=0x7ffe219d8f38) at ../../Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:161 #29 0x00000000004008ca in main (argc=2, argv=0x7ffe219d8f38) at ../../Source/WebKit2/WebProcess/EntryPoint/unix/WebProcessMain.cpp:44 1121155 4 259837 gyuyoung.kim 2015-08-26 18:53:18 -0700 Comment on attachment 259837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259837&action=review > Source/WebCore/ChangeLog:10 > + crash occurs. Any test ? 1121156 5 jh718.park 2015-08-26 18:58:08 -0700 (In reply to comment #4) > Comment on attachment 259837 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259837&action=review > > > Source/WebCore/ChangeLog:10 > > + crash occurs. > > Any test ? If you visit webpage using @viewport rule with Debug build MiniBrowser Efl, for example, then you will meet the assertion fail, e.g. https://www.wordpress.com. 1121168 6 gyuyoung.kim 2015-08-26 19:51:09 -0700 (In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 259837 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=259837&action=review > > > > > Source/WebCore/ChangeLog:10 > > > + crash occurs. > > > > Any test ? > > If you visit webpage using @viewport rule with Debug build MiniBrowser Efl, > for example, then you will meet the assertion fail, > e.g. https://www.wordpress.com. Basic rule is to add a proper test case per a fix, not mention reproduce site. 1121185 7 jh718.park 2015-08-26 20:51:11 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Comment on attachment 259837 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=259837&action=review > > > > > > > Source/WebCore/ChangeLog:10 > > > > + crash occurs. > > > > > > Any test ? > > > > If you visit webpage using @viewport rule with Debug build MiniBrowser Efl, > > for example, then you will meet the assertion fail, > > e.g. https://www.wordpress.com. > > Basic rule is to add a proper test case per a fix, not mention reproduce > site. Ok, I will add a corresponding test soon. :) 1121498 8 jh718.park 2015-08-27 17:04:31 -0700 I found there are already tests covering device adaptation in which using @viewport. Below is the result with debug build MiniBrowser EFL before and after this patch is applied. Assertion fails occur when using width and height shorthand. (css3/device-adapt. Total 38 tests) (1) Before this Patch (35 of the tests crash) 3 tests ran as expected, 35 didn't: Regressions: Unexpected crashes (35) css3/device-adapt/opera/cascading-001.xhtml [ Crash ] css3/device-adapt/opera/cascading-002.xhtml [ Crash ] css3/device-adapt/opera/cascading-003.xhtml [ Crash ] css3/device-adapt/opera/cascading-004.xhtml [ Crash ] css3/device-adapt/opera/constrain-001.xhtml [ Crash ] css3/device-adapt/opera/constrain-002.xhtml [ Crash ] css3/device-adapt/opera/constrain-003.xhtml [ Crash ] css3/device-adapt/opera/constrain-004.xhtml [ Crash ] css3/device-adapt/opera/constrain-005.xhtml [ Crash ] css3/device-adapt/opera/constrain-006.xhtml [ Crash ] css3/device-adapt/opera/constrain-007.xhtml [ Crash ] css3/device-adapt/opera/constrain-008.xhtml [ Crash ] css3/device-adapt/opera/constrain-010.xhtml [ Crash ] css3/device-adapt/opera/constrain-011.xhtml [ Crash ] css3/device-adapt/opera/constrain-012.xhtml [ Crash ] css3/device-adapt/opera/constrain-013.xhtml [ Crash ] css3/device-adapt/opera/constrain-014.xhtml [ Crash ] css3/device-adapt/opera/constrain-015.xhtml [ Crash ] css3/device-adapt/opera/constrain-016.xhtml [ Crash ] css3/device-adapt/opera/constrain-017.xhtml [ Crash ] css3/device-adapt/opera/constrain-018.xhtml [ Crash ] css3/device-adapt/opera/constrain-019.xhtml [ Crash ] css3/device-adapt/opera/constrain-020.xhtml [ Crash ] css3/device-adapt/opera/constrain-021.xhtml [ Crash ] css3/device-adapt/opera/constrain-022.xhtml [ Crash ] css3/device-adapt/opera/constrain-024.xhtml [ Crash ] css3/device-adapt/opera/cssom-001.xhtml [ Crash ] css3/device-adapt/opera/orientation-001.xhtml [ Crash ] css3/device-adapt/opera/orientation-002.xhtml [ Crash ] css3/device-adapt/opera/syntax-001.xhtml [ Crash ] css3/device-adapt/opera/syntax-002.xhtml [ Crash ] css3/device-adapt/opera/syntax-003.xhtml [ Crash ] css3/device-adapt/viewport-properties-validation.html [ Crash ] css3/device-adapt/viewport-width-check-window-innerwidth-correct.html [ Crash ] css3/device-adapt/viewport-width-not-affecting-next-page.html [ Crash ] (2) After this Patch (3 of the tests crash) 13 tests ran as expected, 25 didn't: Unexpected flakiness: text-only failures (2) css3/device-adapt/opera/constrain-010.xhtml [ Failure Crash Pass ] css3/device-adapt/opera/constrain-024.xhtml [ Failure Crash Pass ] Regressions: Unexpected text-only failures (20) css3/device-adapt/opera/cascading-002.xhtml [ Failure ] css3/device-adapt/opera/cascading-003.xhtml [ Failure ] css3/device-adapt/opera/cascading-004.xhtml [ Failure ] css3/device-adapt/opera/constrain-001.xhtml [ Failure ] css3/device-adapt/opera/constrain-004.xhtml [ Failure ] css3/device-adapt/opera/constrain-005.xhtml [ Failure ] css3/device-adapt/opera/constrain-008.xhtml [ Failure ] css3/device-adapt/opera/constrain-011.xhtml [ Failure ] css3/device-adapt/opera/constrain-013.xhtml [ Failure ] css3/device-adapt/opera/constrain-014.xhtml [ Failure ] css3/device-adapt/opera/constrain-015.xhtml [ Failure ] css3/device-adapt/opera/constrain-016.xhtml [ Failure ] css3/device-adapt/opera/constrain-017.xhtml [ Failure ] css3/device-adapt/opera/constrain-018.xhtml [ Failure ] css3/device-adapt/opera/constrain-019.xhtml [ Failure ] css3/device-adapt/opera/constrain-020.xhtml [ Failure ] css3/device-adapt/opera/syntax-001.xhtml [ Failure ] css3/device-adapt/opera/syntax-002.xhtml [ Failure ] css3/device-adapt/opera/syntax-003.xhtml [ Failure ] css3/device-adapt/viewport-width-check-window-innerwidth-correct.html [ Failure ] Regressions: Unexpected crashes (3) css3/device-adapt/opera/constrain-006.xhtml [ Crash ] css3/device-adapt/opera/constrain-007.xhtml [ Crash ] css3/device-adapt/viewport-properties-validation.html [ Crash ] 1122584 9 259837 darin 2015-09-01 10:53:04 -0700 Comment on attachment 259837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259837&action=review As previously discussed, patch needs to include a regression test showing the bug this fixes. > Source/WebCore/css/StylePropertyShorthand.h:98 > + return Vector<StylePropertyShorthand> { widthShorthand() }; Do we need to cite the type here? Does this work? return { widthShorthand() }; > Source/WebCore/css/StylePropertyShorthand.h:106 > + return Vector<StylePropertyShorthand>(); Should just: return { }; > Source/WebCore/css/StylePropertyShorthand.h:109 > +inline Vector<StylePropertyShorthand> matchingCustomShorthandsForLonghand(CSSPropertyID) { return Vector<StylePropertyShorthand>(); } Body should be just be: { return { }; } 259836 2015-08-25 03:32:15 -0700 2015-08-25 03:43:35 -0700 Patch bug-148419-20150825193204.patch text/plain 3423 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzlmMGM4NDNiOWNjM2Ey NDQzOGRhODQ0ODRmOGQ2ZGQ3NGFhZGYwOS4uYTlmOTAxNzkwYjI0ZWI4OWQ3ZjI4MGIwOTY3ZTE2 ZDRjYTJkOWM0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA4LTI0ICBKb29u Z2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ1NTIERldmlj ZUFkYXB0YXRpb25dIEZpeCBjcmFzaCB3aGljaCBvY2N1cnMgYXQgdmlzaXRpbmcgd2VicGFnZSB1 c2luZyBAdmlld3BvcnQgQ1NTIHJ1bGUgd2hlbiBkZXZpY2UgYWRhcHRhdGlvbiBpcyBlbmFibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlz c2luZyBzaG9ydGhhbmQgcHJvcGVydHkgd2lkdGggYW5kIGhlaWdodCBmb3IgdGhlIGNvcnJlc3Bv bmRpbmcgbG9uZ2hhbmQgcHJvcGVydHkuCisgICAgICAgIEZvciBzZWVpbmcgdGhlIGV4YW1wbGUs IHdoZW4gdmlzaXRpbmcgd29yZHByZXNzLmNvbSBpbiB3aGljaCB1c2luZyBAdmlld3BvcnQgcnVs ZSB3aXRoIGVuYWJsZWQgY3NzIGRldmljZSBhZGFwdGF0aW9uLAorICAgICAgICBjcmFzaCBvY2N1 cnMuCisKKyAgICAgICAgKiBjc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oOgorICAgICAgICAo V2ViQ29yZTo6d2lkdGhTaG9ydGhhbmQpOgorICAgICAgICAoV2ViQ29yZTo6aGVpZ2h0U2hvcnRo YW5kKToKKyAgICAgICAgKFdlYkNvcmU6Om1hdGNoaW5nQ3VzdG9tU2hvcnRoYW5kc0Zvckxvbmdo YW5kKToKKyAgICAgICAgKiBjc3MvbWFrZXByb3AucGw6CisKIDIwMTUtMDgtMjQgIEppbnlvdW5n IEh1ciAgPGh1ci5pbXNAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBDbGVhciBjYWlyby1nbCBz dXJmYWNlIGZvciBpbml0aWFsaXphdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3Bl cnR5U2hvcnRoYW5kLmgKaW5kZXggOTI0NGFlYjY1ZGE2MGM4N2YyNDFhYzkxMWM0OTNkMGY5ODY1 YmY2Mi4uZWQzMDA5ODFjZjJkYTgwNmQxNWQyYmE2YjUyNTdmNmYzNzNkYjNjZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oCkBAIC03MSw2ICs3MSw0NCBA QCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kIHNob3J0aGFuZEZvclByb3BlcnR5KENTU1Byb3BlcnR5 SUQpOwogLy8gVGhlIGltcGxlbWVudGF0aW9uIGlzIGdlbmVyYXRlZCBpbiBTdHlsZVByb3BlcnR5 U2hvcnRoYW5kRnVuY3Rpb25zLmNwcC4KIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPiBt YXRjaGluZ1Nob3J0aGFuZHNGb3JMb25naGFuZChDU1NQcm9wZXJ0eUlEKTsKIAorI2lmIGRlZmlu ZWQoRU5BQkxFX0NTU19ERVZJQ0VfQURBUFRBVElPTikgJiYgRU5BQkxFX0NTU19ERVZJQ0VfQURB UFRBVElPTgoraW5saW5lIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQgd2lkdGhTaG9ydGhhbmQoKQor eworICAgIHN0YXRpYyBjb25zdCBDU1NQcm9wZXJ0eUlEIHdpZHRoUHJvcGVydGllc1tdID0gewor ICAgICAgICBDU1NQcm9wZXJ0eU1pbldpZHRoLAorICAgICAgICBDU1NQcm9wZXJ0eU1heFdpZHRo LAorICAgIH07CisgICAgcmV0dXJuIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQoQ1NTUHJvcGVydHlX aWR0aCwgd2lkdGhQcm9wZXJ0aWVzKTsKK30KKworaW5saW5lIFN0eWxlUHJvcGVydHlTaG9ydGhh bmQgaGVpZ2h0U2hvcnRoYW5kKCkKK3sKKyAgICBzdGF0aWMgY29uc3QgQ1NTUHJvcGVydHlJRCBo ZWlnaHRQcm9wZXJ0aWVzW10gPSB7CisgICAgICAgIENTU1Byb3BlcnR5TWluSGVpZ2h0LAorICAg ICAgICBDU1NQcm9wZXJ0eU1heEhlaWdodCwKKyAgICB9OworICAgIHJldHVybiBTdHlsZVByb3Bl cnR5U2hvcnRoYW5kKENTU1Byb3BlcnR5SGVpZ2h0LCBoZWlnaHRQcm9wZXJ0aWVzKTsKK30KKwor aW5saW5lIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPiBtYXRjaGluZ0N1c3RvbVNob3J0 aGFuZHNGb3JMb25naGFuZChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQpCit7CisgICAgc3dpdGNo IChwcm9wZXJ0eUlEKSB7CisgICAgY2FzZSBDU1NQcm9wZXJ0eU1pbldpZHRoOgorICAgIGNhc2Ug Q1NTUHJvcGVydHlNYXhXaWR0aDoKKyAgICAgICAgcmV0dXJuIFZlY3RvcjxTdHlsZVByb3BlcnR5 U2hvcnRoYW5kPiB7IHdpZHRoU2hvcnRoYW5kKCkgfTsKKyAgICBjYXNlIENTU1Byb3BlcnR5TWlu SGVpZ2h0OgorICAgIGNhc2UgQ1NTUHJvcGVydHlNYXhIZWlnaHQ6CisgICAgICAgIHJldHVybiBW ZWN0b3I8U3R5bGVQcm9wZXJ0eVNob3J0aGFuZD4geyBoZWlnaHRTaG9ydGhhbmQoKSB9OworICAg IGRlZmF1bHQ6CisgICAgICAgIGJyZWFrOworICAgIH0KKworICAgIHJldHVybiBWZWN0b3I8U3R5 bGVQcm9wZXJ0eVNob3J0aGFuZD4oKTsKK30KKyNlbHNlCitpbmxpbmUgVmVjdG9yPFN0eWxlUHJv cGVydHlTaG9ydGhhbmQ+IG1hdGNoaW5nQ3VzdG9tU2hvcnRoYW5kc0ZvckxvbmdoYW5kKENTU1By b3BlcnR5SUQpIHsgfQorI2VuZGlmCisKIHVuc2lnbmVkIGluZGV4T2ZTaG9ydGhhbmRGb3JMb25n aGFuZChDU1NQcm9wZXJ0eUlELCBjb25zdCBWZWN0b3I8U3R5bGVQcm9wZXJ0eVNob3J0aGFuZD4m KTsKIAogYm9vbCBpc1Nob3J0aGFuZENTU1Byb3BlcnR5KENTU1Byb3BlcnR5SUQpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsIGIvU291cmNlL1dlYkNvcmUvY3Nz L21ha2Vwcm9wLnBsCmluZGV4IDZiMGJiMzVjNzcyZTdkZmU3N2E0YzU5MTlkZjA1NDEwOGFkZjQ0 OTcuLjk0ZDk0OTUxOTFhNzk5YTc1ZGQ3ZDUzMWJjNDVmMjNmZDk0MjhmOGQgMTAwNzU1Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv bWFrZXByb3AucGwKQEAgLTEwMjIsNyArMTAyMiw3IEBAIGZvciBteSAkdmVjdG9yIChzb3J0IGtl eXMgJXZlY3RvclRvTG9uZ2hhbmRzKSB7CiAKIHByaW50IFNIT1JUSEFORFNfQ1BQIDw8ICJFT0Yi OwogICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiB7IH07CisgICAgICAgIHJldHVybiBtYXRj aGluZ0N1c3RvbVNob3J0aGFuZHNGb3JMb25naGFuZChwcm9wZXJ0eUlEKTsKICAgICB9CiB9CiBF T0YK 259837 2015-08-25 03:43:41 -0700 2015-09-01 10:53:04 -0700 Patch bug-148419-20150825194330.patch text/plain 3464 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzlmMGM4NDNiOWNjM2Ey NDQzOGRhODQ0ODRmOGQ2ZGQ3NGFhZGYwOS4uY2UzZDcwYzg4ZDg4NzJhYmMwZTI0MTE5MjkyMjVl MDk2ZjM2YmI3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA4LTI1ICBKb29u Z2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ1NTIERldmlj ZUFkYXB0YXRpb25dIEZpeCBjcmFzaCB3aGljaCBvY2N1cnMgYXQgdmlzaXRpbmcgd2VicGFnZSB1 c2luZyBAdmlld3BvcnQgQ1NTIHJ1bGUgd2hlbiBkZXZpY2UgYWRhcHRhdGlvbiBpcyBlbmFibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlz c2luZyBzaG9ydGhhbmQgcHJvcGVydHkgd2lkdGggYW5kIGhlaWdodCBmb3IgdGhlIGNvcnJlc3Bv bmRpbmcgbG9uZ2hhbmQgcHJvcGVydHkuCisgICAgICAgIEZvciBzZWVpbmcgdGhlIGV4YW1wbGUs IHdoZW4gdmlzaXRpbmcgd29yZHByZXNzLmNvbSBpbiB3aGljaCB1c2luZyBAdmlld3BvcnQgcnVs ZSB3aXRoIGVuYWJsZWQgY3NzIGRldmljZSBhZGFwdGF0aW9uLAorICAgICAgICBjcmFzaCBvY2N1 cnMuCisKKyAgICAgICAgKiBjc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oOgorICAgICAgICAo V2ViQ29yZTo6d2lkdGhTaG9ydGhhbmQpOgorICAgICAgICAoV2ViQ29yZTo6aGVpZ2h0U2hvcnRo YW5kKToKKyAgICAgICAgKFdlYkNvcmU6Om1hdGNoaW5nQ3VzdG9tU2hvcnRoYW5kc0Zvckxvbmdo YW5kKToKKyAgICAgICAgKiBjc3MvbWFrZXByb3AucGw6CisKIDIwMTUtMDgtMjQgIEppbnlvdW5n IEh1ciAgPGh1ci5pbXNAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBDbGVhciBjYWlyby1nbCBz dXJmYWNlIGZvciBpbml0aWFsaXphdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3Bl cnR5U2hvcnRoYW5kLmgKaW5kZXggOTI0NGFlYjY1ZGE2MGM4N2YyNDFhYzkxMWM0OTNkMGY5ODY1 YmY2Mi4uYWQ4NDkwNGZlOGNhYmMxZDEzMjUzNTYwMmVkZjg4ODQ5MTIzMmMyNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oCkBAIC03MSw2ICs3MSw0NCBA QCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kIHNob3J0aGFuZEZvclByb3BlcnR5KENTU1Byb3BlcnR5 SUQpOwogLy8gVGhlIGltcGxlbWVudGF0aW9uIGlzIGdlbmVyYXRlZCBpbiBTdHlsZVByb3BlcnR5 U2hvcnRoYW5kRnVuY3Rpb25zLmNwcC4KIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPiBt YXRjaGluZ1Nob3J0aGFuZHNGb3JMb25naGFuZChDU1NQcm9wZXJ0eUlEKTsKIAorI2lmIGRlZmlu ZWQoRU5BQkxFX0NTU19ERVZJQ0VfQURBUFRBVElPTikgJiYgRU5BQkxFX0NTU19ERVZJQ0VfQURB UFRBVElPTgoraW5saW5lIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQgd2lkdGhTaG9ydGhhbmQoKQor eworICAgIHN0YXRpYyBjb25zdCBDU1NQcm9wZXJ0eUlEIHdpZHRoUHJvcGVydGllc1tdID0gewor ICAgICAgICBDU1NQcm9wZXJ0eU1pbldpZHRoLAorICAgICAgICBDU1NQcm9wZXJ0eU1heFdpZHRo LAorICAgIH07CisgICAgcmV0dXJuIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQoQ1NTUHJvcGVydHlX aWR0aCwgd2lkdGhQcm9wZXJ0aWVzKTsKK30KKworaW5saW5lIFN0eWxlUHJvcGVydHlTaG9ydGhh bmQgaGVpZ2h0U2hvcnRoYW5kKCkKK3sKKyAgICBzdGF0aWMgY29uc3QgQ1NTUHJvcGVydHlJRCBo ZWlnaHRQcm9wZXJ0aWVzW10gPSB7CisgICAgICAgIENTU1Byb3BlcnR5TWluSGVpZ2h0LAorICAg ICAgICBDU1NQcm9wZXJ0eU1heEhlaWdodCwKKyAgICB9OworICAgIHJldHVybiBTdHlsZVByb3Bl cnR5U2hvcnRoYW5kKENTU1Byb3BlcnR5SGVpZ2h0LCBoZWlnaHRQcm9wZXJ0aWVzKTsKK30KKwor aW5saW5lIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPiBtYXRjaGluZ0N1c3RvbVNob3J0 aGFuZHNGb3JMb25naGFuZChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQpCit7CisgICAgc3dpdGNo IChwcm9wZXJ0eUlEKSB7CisgICAgY2FzZSBDU1NQcm9wZXJ0eU1pbldpZHRoOgorICAgIGNhc2Ug Q1NTUHJvcGVydHlNYXhXaWR0aDoKKyAgICAgICAgcmV0dXJuIFZlY3RvcjxTdHlsZVByb3BlcnR5 U2hvcnRoYW5kPiB7IHdpZHRoU2hvcnRoYW5kKCkgfTsKKyAgICBjYXNlIENTU1Byb3BlcnR5TWlu SGVpZ2h0OgorICAgIGNhc2UgQ1NTUHJvcGVydHlNYXhIZWlnaHQ6CisgICAgICAgIHJldHVybiBW ZWN0b3I8U3R5bGVQcm9wZXJ0eVNob3J0aGFuZD4geyBoZWlnaHRTaG9ydGhhbmQoKSB9OworICAg IGRlZmF1bHQ6CisgICAgICAgIGJyZWFrOworICAgIH0KKworICAgIHJldHVybiBWZWN0b3I8U3R5 bGVQcm9wZXJ0eVNob3J0aGFuZD4oKTsKK30KKyNlbHNlCitpbmxpbmUgVmVjdG9yPFN0eWxlUHJv cGVydHlTaG9ydGhhbmQ+IG1hdGNoaW5nQ3VzdG9tU2hvcnRoYW5kc0ZvckxvbmdoYW5kKENTU1By b3BlcnR5SUQpIHsgcmV0dXJuIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPigpOyB9Cisj ZW5kaWYKKwogdW5zaWduZWQgaW5kZXhPZlNob3J0aGFuZEZvckxvbmdoYW5kKENTU1Byb3BlcnR5 SUQsIGNvbnN0IFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPiYpOwogCiBib29sIGlzU2hv cnRoYW5kQ1NTUHJvcGVydHkoQ1NTUHJvcGVydHlJRCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvbWFrZXByb3AucGwgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKaW5k ZXggNmIwYmIzNWM3NzJlN2RmZTc3YTRjNTkxOWRmMDU0MTA4YWRmNDQ5Ny4uOTRkOTQ5NTE5MWE3 OTlhNzVkZDdkNTMxYmM0NWYyM2ZkOTQyOGY4ZCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL21ha2Vwcm9wLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbApAQCAt MTAyMiw3ICsxMDIyLDcgQEAgZm9yIG15ICR2ZWN0b3IgKHNvcnQga2V5cyAldmVjdG9yVG9Mb25n aGFuZHMpIHsKIAogcHJpbnQgU0hPUlRIQU5EU19DUFAgPDwgIkVPRiI7CiAgICAgZGVmYXVsdDoK LSAgICAgICAgcmV0dXJuIHsgfTsKKyAgICAgICAgcmV0dXJuIG1hdGNoaW5nQ3VzdG9tU2hvcnRo YW5kc0ZvckxvbmdoYW5kKHByb3BlcnR5SUQpOwogICAgIH0KIH0KIEVPRgo=