148409 2015-08-24 18:22:49 -0700 Layout Test platform/mac/fast/events/content-inset-hit-testing-in-frame.html is flaky 2015-08-26 11:18:43 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ap bdakin mitz simon.fraser oldest_to_newest 1120480 0 thorton 2015-08-24 18:22:49 -0700 The following layout test is flaky on Mac WK1 platform/mac/fast/events/content-inset-hit-testing-in-frame.html 1120481 1 thorton 2015-08-24 18:23:40 -0700 I'm looking at this. In the bad case, we hit the iframe, but not the div inside it (we hit the body instead). 1120487 2 thorton 2015-08-24 18:38:57 -0700 Hmm. Render tree dumps for each hit test are exactly the same, we just hit a different node... 1120488 3 thorton 2015-08-24 18:41:16 -0700 Reproduces if you reduce your machine to 1 core, load it (with some while(1)s), and "run-webkit-tests -1 --repeat-each=100000 platform/mac/fast/events/content-inset-hit-testing-in-frame.html". 1120489 4 thorton 2015-08-24 18:44:49 -0700 The hit test *request* point is different (off by the topContentInset): bad case: 20 120 good case: 20 20 why is that racy, though? 1120490 5 thorton 2015-08-24 18:47:29 -0700 setTopContentInset does a layout, and the layout isn't wrong (as evidenced by the render tree dumps being identical)... it's the point mapping that's wrong. I'm not sure where topContentInset gets applied to incoming points, though. Will have to find that. 1120495 6 thorton 2015-08-24 18:55:51 -0700 We do a view->windowToContents() (in EventHandler's documentPointForWindowPoint) and are returned a lie. 1120658 7 thorton 2015-08-25 11:20:24 -0700 OK! In the bad case, the scrollOffset.y() = 100 (the top content inset). In the good case it's 0 (as it should be). Not sure why it takes time for the scrollOffset to adjust to the TCI change. Will continue investigating. 1120661 8 thorton 2015-08-25 11:31:49 -0700 scrollPositionChangedViaPlatformWidgetImpl is happening too late in the bad case. 1120666 9 thorton 2015-08-25 11:40:57 -0700 (In reply to comment #8) > scrollPositionChangedViaPlatformWidgetImpl is happening too late in the bad > case. In the good case, we get it underneath the layout that setTopContentInset does (like you'd expect). In the bad case, we get it much later, under [NSView viewWillDraw] stuff... 1120704 10 thorton 2015-08-25 13:39:20 -0700 And it looks like this is happening because we have scrollbars forced off until after the test runs (when they should be enabled as soon as we set a top content inset) 1120736 11 259890 thorton 2015-08-25 15:23:22 -0700 Created attachment 259890 Patch 1120739 12 thorton 2015-08-25 15:25:02 -0700 This is admittedly pretty icky, and I haven't managed to make a test app to demonstrate the underlying problem. 1120750 13 259890 thorton 2015-08-25 15:52:54 -0700 Comment on attachment 259890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259890&action=review > Source/WebKit/mac/WebView/WebDynamicScrollBarsView.mm:629 > + [super setContentInsets:edgeInsets]; Mavericks doesn't have this, need an ifdef. 1120993 14 thorton 2015-08-26 11:18:43 -0700 http://trac.webkit.org/changeset/188971 259890 2015-08-25 15:23:22 -0700 2015-08-26 11:14:22 -0700 Patch bug-148409-20150825152312.patch text/plain 3713 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4ODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZGJlNzJiNjNi ZGUwMmMxYjMyMzUwN2ZkNmY3OWUzZjhkYjlkMDYwZS4uNjJiMTYyMmM0ZTE4NWQ4YTQxY2ViY2I4 YjIyOGRlNTcwMGI0OWJkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1 LTA4LTI1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAg IExheW91dCBUZXN0IHBsYXRmb3JtL21hYy9mYXN0L2V2ZW50cy9jb250ZW50LWluc2V0LWhpdC10 ZXN0aW5nLWluLWZyYW1lLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODQwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcu bW06CisgICAgICAgICgtW1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldyBzZXRDb250ZW50SW5zZXRz Ol0pOgorICAgICAgICBFeHBsaWNpdGx5IGZvcmNlIG91ciBOU1Njcm9sbFZpZXcgdG8gbGF5IG91 dCBhZnRlciB1cGRhdGluZworICAgICAgICBjb250ZW50IGluc2V0cy4gV2UgZGVwZW5kIG9uIHRo aXMgaGFwcGVuaW5nIHN5bmNocm9ub3VzbHkgKHNwZWNpZmljYWxseSwKKyAgICAgICAgd2UgbmVl ZCBvdXIgZnJhbWUvYm91bmRzIGNoYW5nZSBjYWxsYmFja3MgdG8gZmlyZSksIGJlY2F1c2UgdGhl IGxheW91dAorICAgICAgICB3aGljaCB3aWxsIGhhcHBlbiBzdWJzZXF1ZW50bHkgbmVlZHMgdXAt dG8tZGF0ZSBpbmZvcm1hdGlvbiBpbiBvcmRlciB0bworICAgICAgICBjb3JyZWN0bHkgYSkgZW5h YmxlIHNjcm9sbGJhcnMgYW5kIHRoZW4gYikgdXBkYXRlIHRoZSBzY3JvbGwgcG9zaXRpb24uCisK IDIwMTUtMDgtMjMgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtD b250ZW50IEZpbHRlcmluZ10gUkVHUkVTU0lPTiAocjE4MjM1Nik6IFByb3Zpc2lvbmFsIFVSTCBp cyBpbmNvcnJlY3QgaW4gZGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9yUHJvdmlzaW9uYWxMb2Fk Rm9yRnJhbWUgd2hlbiBDb250ZW50IEZpbHRlcmluZyBpcyBlbmFibGVkCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tbSBiL1Nv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm1tCmluZGV4 IDNmM2Q2NzI2Yzg5ODc4ZjMxMDdkNGJjYTRmNGNmMzIzNTZkMWM4M2EuLmFiOWE2Yzg4ODcyYWUz YmMyNjhjNGIxNTQxMjY5MGM3YjRmMmUyOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm1tCkBAIC02MjQsNCArNjI0LDEw IEBAIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBjTWF4VXBkYXRlU2Nyb2xsYmFyc1Bhc3MgPSAyOwog ICAgIHJldHVybiBfcHJpdmF0ZS0+aW5Qcm9ncmFtbWF0aWNTY3JvbGw7CiB9CiAKKy0gKHZvaWQp c2V0Q29udGVudEluc2V0czooTlNFZGdlSW5zZXRzKWVkZ2VJbnNldHMKK3sKKyAgICBbc3VwZXIg c2V0Q29udGVudEluc2V0czplZGdlSW5zZXRzXTsKKyAgICBbc2VsZiB0aWxlXTsKK30KKwogQGVu ZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IGYyOTk1NjJjNDBiODM3ODRjNmU4OTY4NmVmZDYyZjFlN2YwOGRhZGUuLjMzNWZk ODFiZDQxZjNhYWZiOTUwNTc5ZDUyMTdkOTBiZTQwMjg3YWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxNS0wOC0yNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwor ICAgICAgICBMYXlvdXQgVGVzdCBwbGF0Zm9ybS9tYWMvZmFzdC9ldmVudHMvY29udGVudC1pbnNl dC1oaXQtdGVzdGluZy1pbi1mcmFtZS5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L2V2ZW50cy9y ZXNvdXJjZXMvaWZyYW1lLXRvLWhpdC10ZXN0Lmh0bWw6CisgICAgICAgIEFkanVzdCB0aGUgdGVz dCBzbyB0aGF0IGl0IGxvZ3Mgc29tZXRoaW5nIHVzZWZ1bCBpZiBpdCBmYWlscworICAgICAgICBp bnN0ZWFkIG9mIGNvbXBsYWluaW5nIGFib3V0IG5vdCBiZWluZyBydW4gaW4gV0tUUi9EUlQuCisK IDIwMTUtMDgtMjQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBO b2RlTGlzdCBzaG91bGQgbm90IGhhdmUgYSBuYW1lZCBnZXR0ZXIKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2V2ZW50cy9yZXNvdXJjZXMvaWZyYW1lLXRvLWhpdC10 ZXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9ldmVudHMvcmVzb3VyY2Vz L2lmcmFtZS10by1oaXQtdGVzdC5odG1sCmluZGV4IGE0NTBkYWFhNjU3ZWRiODBkZDVjYzAwYTE2 MWQ3NjEwZDVlY2U1ZDkuLmMzMTY5OGFhMDQ0NGJjNzUyNzZjMWYxNTI5MjU0ZWI4MTYwMDFiNDgg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2V2ZW50cy9yZXNvdXJj ZXMvaWZyYW1lLXRvLWhpdC10ZXN0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2Zhc3QvZXZlbnRzL3Jlc291cmNlcy9pZnJhbWUtdG8taGl0LXRlc3QuaHRtbApAQCAtOCwxMyAr OCwyNCBAQAogICAgIH0KIDwvc3R5bGU+CiA8c2NyaXB0PgotICAgIGZ1bmN0aW9uIGNsaWNrZWQo KSB7CisgICAgZnVuY3Rpb24gY2xpY2tlZChlKSB7CiAgICAgICAgIHZhciByZXN1bHQgPSBwYXJl bnQuZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpOwogICAgICAgICByZXN1bHQuaW5u ZXJIVE1MID0gIlBhc3MhIjsKKyAgICAgICAgZS5zdG9wUHJvcGFnYXRpb24oKTsKKyAgICB9CisK KyAgICBmdW5jdGlvbiBib2R5Q2xpY2tlZCgpIHsKKyAgICAgICAgdmFyIHJlc3VsdCA9IHBhcmVu dC5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0Iik7CisgICAgICAgIHJlc3VsdC5pbm5l ckhUTUwgPSAiRmFpbGVkISBIaXQgdGhlIGJvZHkuIjsKKyAgICB9CisKKyAgICB3aW5kb3cub25s b2FkID0gZnVuY3Rpb24gKCkgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFy Z2V0IikuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCBjbGlja2VkKTsKKyAgICAgICAgZG9jdW1l bnQuYm9keS5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIGJvZHlDbGlja2VkKTsKICAgICB9CiA8 L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5PgotICAgIDxkaXYgaWQ9InRhcmdldCIgb25jbGljaz0i Y2xpY2tlZCgpIj48L2Rpdj4KKyAgICA8ZGl2IGlkPSJ0YXJnZXQiPjwvZGl2PgogPC9ib2R5Pgog PC9odG1sPgo=