148402 2015-08-24 15:34:16 -0700 Long press gesture recognizer should adjust delay based on other recognizers 2015-08-25 11:19:43 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned benjamin dbates oldest_to_newest 1120424 0 bdakin 2015-08-24 15:34:16 -0700 Long press gesture recognizer should adjust delay based on other recognizers rdar://problem/22278723 1120425 1 259784 bdakin 2015-08-24 15:36:29 -0700 Created attachment 259784 Patch 1120543 2 259784 thorton 2015-08-24 22:59:53 -0700 Comment on attachment 259784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:73 > +#import <WebKitAdditions/WKContentViewInteraction.mm> You need to wrap this in a __has_include. 1120544 3 259784 thorton 2015-08-24 23:00:31 -0700 Comment on attachment 259784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:346 > + if ([_longPressGestureRecognizer respondsToSelector:@selector(_setAdjustsDelayBasedOnOtherRecognizers:)]) And this too (or, forward declare _setAdjustsDelayBasedOnOtherRecognizers). 1120657 4 bdakin 2015-08-25 11:19:43 -0700 Thanks Tim! http://trac.webkit.org/changeset/188924 259784 2015-08-24 15:36:29 -0700 2015-08-24 22:59:53 -0700 Patch for-review-os.txt text/plain 1980 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4ODg4OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA4LTI0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBMb25nIHByZXNzIGdlc3R1cmUgcmVj b2duaXplciBzaG91bGQgYWRqdXN0IGRlbGF5IGJhc2VkIG9uIG90aGVyIHJlY29nbml6ZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDg0MDIKKyAg ICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMjI3ODcy MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwg X3NldEFkanVzdHNEZWxheUJhc2VkT25PdGhlclJlY29nbml6ZXJzIHdpdGggYSB2YWx1ZSBvZiBZ RVMuCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06 CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgc2V0dXBJbnRlcmFjdGlvbl0pOgorCiAyMDE1LTA4 LTI0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFVz ZSBfTlNTY3JvbGxpbmdQcmVkb21pbmFudEF4aXNGaWx0ZXIgZm9yIHdoZWVsIGV2ZW50IGZpbHRl cmluZyBvbiBNYWMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAxODg3NjMpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQko d29ya2luZyBjb3B5KQpAQCAtNzAsNiArNzAsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9UZXh0SW5k aWNhdG9yLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1dlYkV2ZW50Lmg+CiAjaW1wb3J0IDxXZWJLaXQv V2ViU2VsZWN0aW9uUmVjdC5oPiAvLyBGSVhNRTogV0syIHNob3VsZCBub3QgaW5jbHVkZSBXZWJL aXQgaGVhZGVycyEKKyNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0+CiAjaW1wb3J0IDxXZWJLaXRTeXN0ZW1JbnRlcmZhY2VJT1MuaD4KICNpbXBvcnQg PHd0Zi9SZXRhaW5QdHIuaD4KIApAQCAtMzQyLDYgKzM0Myw4IEBAIC0gKHZvaWQpc2V0dXBJbnRl cmFjdGlvbgogICAgIF9sb25nUHJlc3NHZXN0dXJlUmVjb2duaXplciA9IGFkb3B0TlMoW1tVSUxv bmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyIGFsbG9jXSBpbml0V2l0aFRhcmdldDpzZWxmIGFjdGlv bjpAc2VsZWN0b3IoX2xvbmdQcmVzc1JlY29nbml6ZWQ6KV0pOwogICAgIFtfbG9uZ1ByZXNzR2Vz dHVyZVJlY29nbml6ZXIgc2V0RGVsYXk6dGFwQW5kSG9sZERlbGF5XTsKICAgICBbX2xvbmdQcmVz c0dlc3R1cmVSZWNvZ25pemVyIHNldERlbGVnYXRlOnNlbGZdOworICAgIGlmIChbX2xvbmdQcmVz c0dlc3R1cmVSZWNvZ25pemVyIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3NldEFkanVz dHNEZWxheUJhc2VkT25PdGhlclJlY29nbml6ZXJzOildKQorICAgICAgICBbX2xvbmdQcmVzc0dl c3R1cmVSZWNvZ25pemVyIF9zZXRBZGp1c3RzRGVsYXlCYXNlZE9uT3RoZXJSZWNvZ25pemVyczpZ RVNdOwogICAgIFtzZWxmIGFkZEdlc3R1cmVSZWNvZ25pemVyOl9sb25nUHJlc3NHZXN0dXJlUmVj b2duaXplci5nZXQoKV07CiAKICNpZiBIQVZFKExJTktfUFJFVklFVykK