148392 2015-08-24 14:07:53 -0700 Page does not update when <link> media attribute changes to no longer apply to page 2015-08-27 15:13:03 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck benjamin cdumez dbates joepeck koivisto simon.fraser oldest_to_newest 1120367 0 joepeck 2015-08-24 14:07:53 -0700 * SUMMARY Page does not update when <link> media attribute changes to no longer apply to page. * TEST <link id="link" rel="stylesheet" href="data:text/css,body{color:red}" media="print"> <p>Text To Change Color</p> <button id="button">Then Click me</button> <script> document.getElementById("button").addEventListener("click", function() { var link = document.getElementById("link"); var currentMedia = link.media; var newMedia = currentMedia === "screen" ? "print" : "screen"; console.log(currentMedia + " => " + newMedia); link.setAttribute("media", newMedia); }); </script> * STEPS TO REPRODUCE 1. Load test 2. Click the button (note the text changes from black => red) 3. Click the button again => text does not change from red => black, but it should * NOTES - Chrome and Firefox both behave as expected with this test case 1120374 1 joepeck 2015-08-24 14:26:23 -0700 Triggering a style recalc (document().styleResolverChanged(DeferRecalcStyle)) when the media attribute changes does fix this, but there is probably something better we should be doing, such as only recalcing if the media query status (active/inactive) changes. Other tests should probably also be written (if the type changes without a rel attribute), etc. 1120429 2 259785 joepeck 2015-08-24 15:43:23 -0700 Created attachment 259785 [PATCH] Proposed Fix 1120538 3 259785 cdumez 2015-08-24 22:14:23 -0700 Comment on attachment 259785 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=259785&action=review Just commenting on the layout test as I am not confident reviewing the fix. Somehow, it feels like process() should take care of this. > LayoutTests/fast/css/link-media-attr.html:19 > + // link.media is print Useless if we use shouldBe below. > LayoutTests/fast/css/link-media-attr.html:20 > + debug("media=" + link.media); shouldBeEqualToString("link.media", "print"); > LayoutTests/fast/css/link-media-attr.html:22 > + shouldBe("getComputedStyle(target).color", "'rgb(0, 0, 0)'"); shouldBeEqualToString() > LayoutTests/fast/css/link-media-attr.html:24 > + link.media = "screen"; evalAndLog() > LayoutTests/fast/css/link-media-attr.html:25 > + debug("media=" + link.media); shouldBeEqualToString("link.media", "screen"); > LayoutTests/fast/css/link-media-attr.html:27 > + shouldBe("getComputedStyle(target).color", "'rgb(255, 0, 0)'"); shouldBeEqualToString() > LayoutTests/fast/css/link-media-attr.html:29 > + link.media = "screen,screen"; evalAndLog() > LayoutTests/fast/css/link-media-attr.html:34 > + link.media = "print"; evalAndLog() > LayoutTests/fast/css/link-media-attr.html:35 > + debug("media=" + link.media); shouldBeEqualToString("link.media", "print"); > LayoutTests/fast/css/link-media-attr.html:37 > + shouldBe("getComputedStyle(target).color", "'rgb(0, 0, 0)'"); shouldBeEqualToString() 1120876 4 259937 joepeck 2015-08-26 00:25:57 -0700 Created attachment 259937 [PATCH] Proposed Fix 1121331 5 259937 koivisto 2015-08-27 09:56:05 -0700 Comment on attachment 259937 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=259937&action=review > Source/WebCore/html/HTMLLinkElement.cpp:172 > if (name == mediaAttr) { > m_media = value.string().lower(); > process(); > + if (!isDisabled()) > + document().styleResolverChanged(DeferRecalcStyle); > return; > } Maybe only do this if the lowered value is actually different? 1121334 6 259937 koivisto 2015-08-27 09:59:31 -0700 Comment on attachment 259937 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=259937&action=review >> Source/WebCore/html/HTMLLinkElement.cpp:172 >> } > > Maybe only do this if the lowered value is actually different? Also this shouldn't be needed if m_sheet is null. 1121450 7 joepeck 2015-08-27 15:13:03 -0700 http://trac.webkit.org/changeset/189060 259785 2015-08-24 15:43:23 -0700 2015-08-26 00:25:57 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 4500 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZGFkY2UzLi5kYTUxODZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDgt MjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBQYWdl IGRvZXMgbm90IHVwZGF0ZSB3aGVuIDxsaW5rPiBtZWRpYSBhdHRyaWJ1dGUgY2hhbmdlcyB0byBu byBsb25nZXIgYXBwbHkgdG8gcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ4MzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9saW5rLW1lZGlhLWF0dHItZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9saW5rLW1lZGlhLWF0dHIuaHRtbDogQWRkZWQuCisg ICAgICAgIEFkZCBhIHRlc3QgdG8gdmVyaWZ5IHRoYXQgc3R5bGVzIGNoYW5nZSBhZnRlciBhIGxp bmsncyBtZWRpYSBhdHRyaWJ1dGUgY2hhbmdlcy4KKwogMjAxNS0wOC0yMSAgTmFuIFdhbmcgIDxu X3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBGaXggYWNjZXNzaWJpbGl0eS9tYWMvc2Vh cmNoLXdpdGgtZnJhbWVzLmh0bWwgdGVzdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j c3MvbGluay1tZWRpYS1hdHRyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xp bmstbWVkaWEtYXR0ci1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMC4uNGYxNWZhNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xp bmstbWVkaWEtYXR0ci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyMSBAQAorTW9kaWZ5aW5nIHRo ZSBtZWRpYSBhdHRyaWJ1dGUgb2YgYSBsaW5rIGVsZW1lbnQgdG8gYXBwbHkgLyB1bmFwcGx5IHRv IHRoZSBwYWdlIHNob3VsZCByZWNhbGMgc3R5bGVzCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF Ii4KKworCittZWRpYT1wcmludAorUEFTUyBsaW5rLmRpc2FibGVkIGlzIGZhbHNlCitQQVNTIGdl dENvbXB1dGVkU3R5bGUodGFyZ2V0KS5jb2xvciBpcyAncmdiKDAsIDAsIDApJworbWVkaWE9c2Ny ZWVuCitQQVNTIGxpbmsuZGlzYWJsZWQgaXMgZmFsc2UKK1BBU1MgZ2V0Q29tcHV0ZWRTdHlsZSh0 YXJnZXQpLmNvbG9yIGlzICdyZ2IoMjU1LCAwLCAwKScKK21lZGlhPXNjcmVlbixzY3JlZW4KK1BB U1MgbGluay5kaXNhYmxlZCBpcyBmYWxzZQorUEFTUyBnZXRDb21wdXRlZFN0eWxlKHRhcmdldCku Y29sb3IgaXMgJ3JnYigyNTUsIDAsIDApJworbWVkaWE9cHJpbnQKK1BBU1MgbGluay5kaXNhYmxl ZCBpcyBmYWxzZQorUEFTUyBnZXRDb21wdXRlZFN0eWxlKHRhcmdldCkuY29sb3IgaXMgJ3JnYigw LCAwLCAwKScKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVU RQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9saW5rLW1lZGlhLWF0dHIuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpbmstbWVkaWEtYXR0ci5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmVlZjMyZmUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Nzcy9saW5rLW1lZGlhLWF0dHIuaHRtbApAQCAtMCwwICsxLDQ0IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8 bGluayBpZD0ibGluayIgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSJkYXRhOnRleHQvY3NzLCN0YXJn ZXR7Y29sb3I6cmVkfSIgbWVkaWE9InByaW50Ij4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c3BhbiBpZD0i dGFyZ2V0Ij48L3NwYW4+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIk1vZGlmeWluZyB0aGUgbWVk aWEgYXR0cmlidXRlIG9mIGEgbGluayBlbGVtZW50IHRvIGFwcGx5IC8gdW5hcHBseSB0byB0aGUg cGFnZSBzaG91bGQgcmVjYWxjIHN0eWxlcyIpOworCit3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRy dWU7CisKK2xpbmsgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibGluayIpOwordGFyZ2V0ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIpOworCit3aW5kb3cuYWRkRXZlbnRMaXN0 ZW5lcigibG9hZCIsIGZ1bmN0aW9uKCkgeworICAgIC8vIGxpbmsubWVkaWEgaXMgcHJpbnQKKyAg ICBkZWJ1ZygibWVkaWE9IiArIGxpbmsubWVkaWEpOworICAgIHNob3VsZEJlRmFsc2UoImxpbmsu ZGlzYWJsZWQiKTsKKyAgICBzaG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZSh0YXJnZXQpLmNvbG9y IiwgIidyZ2IoMCwgMCwgMCknIik7CisKKyAgICBsaW5rLm1lZGlhID0gInNjcmVlbiI7CisgICAg ZGVidWcoIm1lZGlhPSIgKyBsaW5rLm1lZGlhKTsKKyAgICBzaG91bGRCZUZhbHNlKCJsaW5rLmRp c2FibGVkIik7CisgICAgc2hvdWxkQmUoImdldENvbXB1dGVkU3R5bGUodGFyZ2V0KS5jb2xvciIs ICIncmdiKDI1NSwgMCwgMCknIik7CisKKyAgICBsaW5rLm1lZGlhID0gInNjcmVlbixzY3JlZW4i OworICAgIGRlYnVnKCJtZWRpYT0iICsgbGluay5tZWRpYSk7CisgICAgc2hvdWxkQmVGYWxzZSgi bGluay5kaXNhYmxlZCIpOworICAgIHNob3VsZEJlKCJnZXRDb21wdXRlZFN0eWxlKHRhcmdldCku Y29sb3IiLCAiJ3JnYigyNTUsIDAsIDApJyIpOworCisgICAgbGluay5tZWRpYSA9ICJwcmludCI7 CisgICAgZGVidWcoIm1lZGlhPSIgKyBsaW5rLm1lZGlhKTsKKyAgICBzaG91bGRCZUZhbHNlKCJs aW5rLmRpc2FibGVkIik7CisgICAgc2hvdWxkQmUoImdldENvbXB1dGVkU3R5bGUodGFyZ2V0KS5j b2xvciIsICIncmdiKDAsIDAsIDApJyIpOworCisgICAgZmluaXNoSlNUZXN0KCk7Cit9KTsKKzwv c2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDRkMDQ2MTcuLjcwNjNjYmQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNS0wOC0yNCAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFBhZ2UgZG9lcyBub3QgdXBkYXRlIHdo ZW4gPGxpbms+IG1lZGlhIGF0dHJpYnV0ZSBjaGFuZ2VzIHRvIG5vIGxvbmdlciBhcHBseSB0byBw YWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgz OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 OiBmYXN0L2Nzcy9saW5rLW1lZGlhLWF0dHIuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MTGlu a0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTExpbmtFbGVtZW50OjpwYXJzZUF0 dHJpYnV0ZSk6CisgICAgICAgIFdoZW4gdGhlIG1lZGlhIGF0dHJpYnV0ZSBjaGFuZ2VzLCByZWNh bGN1bGF0ZSBzdHlsZXMgaWYgdGhlIGxpbmsgaXMgbm90IGRpc2FibGVkLgorCiAyMDE1LTA4LTIw ICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYSBTZXNzaW9u OiBsZXQgVUkgY2xpZW50cyBjaGFuZ2UgdGhlIHZvbHVtZSBvZiB0aGUgZm9jdXNlZCBtZWRpYSBl bGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKaW5kZXggM2Y2MmYw Ni4uMzVjYTA5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNwcApAQCAt MTY2LDYgKzE2Niw4IEBAIHZvaWQgSFRNTExpbmtFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZShjb25z dCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNTdHJpCiAgICAgaWYgKG5hbWUgPT0g bWVkaWFBdHRyKSB7CiAgICAgICAgIG1fbWVkaWEgPSB2YWx1ZS5zdHJpbmcoKS5sb3dlcigpOwog ICAgICAgICBwcm9jZXNzKCk7CisgICAgICAgIGlmICghaXNEaXNhYmxlZCgpKQorICAgICAgICAg ICAgZG9jdW1lbnQoKS5zdHlsZVJlc29sdmVyQ2hhbmdlZChEZWZlclJlY2FsY1N0eWxlKTsKICAg ICAgICAgcmV0dXJuOwogICAgIH0KICAgICBpZiAobmFtZSA9PSBkaXNhYmxlZEF0dHIpIHsK 259937 2015-08-26 00:25:57 -0700 2015-08-27 09:56:05 -0700 [PATCH] Proposed Fix updated.patch text/plain 4799 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MzY1ZGIyLi5iZWNlYmMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDgt MjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBQYWdl IGRvZXMgbm90IHVwZGF0ZSB3aGVuIDxsaW5rPiBtZWRpYSBhdHRyaWJ1dGUgY2hhbmdlcyB0byBu byBsb25nZXIgYXBwbHkgdG8gcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ4MzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9saW5rLW1lZGlhLWF0dHItZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9saW5rLW1lZGlhLWF0dHIuaHRtbDogQWRkZWQuCisg ICAgICAgIEFkZCBhIHRlc3QgdG8gdmVyaWZ5IHRoYXQgc3R5bGVzIGNoYW5nZSBhZnRlciBhIGxp bmsncyBtZWRpYSBhdHRyaWJ1dGUgY2hhbmdlcy4KKwogMjAxNS0wOC0yNSAgTmFuIFdhbmcgIDxu X3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIGFjY2Vzc2liaWxpdHkvZG9jdW1lbnQt YXR0cmlidXRlcy5odG1sIGZhaWxzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9s aW5rLW1lZGlhLWF0dHItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGluay1t ZWRpYS1hdHRyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li4zZjQxOGE4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGluay1t ZWRpYS1hdHRyLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDI0IEBACitNb2RpZnlpbmcgdGhlIG1l ZGlhIGF0dHJpYnV0ZSBvZiBhIGxpbmsgZWxlbWVudCB0byBhcHBseSAvIHVuYXBwbHkgdG8gdGhl IHBhZ2Ugc2hvdWxkIHJlY2FsYyBzdHlsZXMKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgor CisKK1BBU1MgbGluay5tZWRpYSBpcyAicHJpbnQiCitQQVNTIGxpbmsuZGlzYWJsZWQgaXMgZmFs c2UKK1BBU1MgZ2V0Q29tcHV0ZWRTdHlsZSh0YXJnZXQpLmNvbG9yIGlzICJyZ2IoMCwgMCwgMCki CitsaW5rLm1lZGlhID0gInNjcmVlbiIKK1BBU1MgbGluay5tZWRpYSBpcyAic2NyZWVuIgorUEFT UyBsaW5rLmRpc2FibGVkIGlzIGZhbHNlCitQQVNTIGdldENvbXB1dGVkU3R5bGUodGFyZ2V0KS5j b2xvciBpcyAicmdiKDI1NSwgMCwgMCkiCitsaW5rLm1lZGlhID0gInNjcmVlbixzY3JlZW4iCitQ QVNTIGxpbmsubWVkaWEgaXMgInNjcmVlbixzY3JlZW4iCitQQVNTIGxpbmsuZGlzYWJsZWQgaXMg ZmFsc2UKK1BBU1MgZ2V0Q29tcHV0ZWRTdHlsZSh0YXJnZXQpLmNvbG9yIGlzICJyZ2IoMjU1LCAw LCAwKSIKK2xpbmsubWVkaWEgPSAicHJpbnQiCitQQVNTIGxpbmsubWVkaWEgaXMgInByaW50Igor UEFTUyBsaW5rLmRpc2FibGVkIGlzIGZhbHNlCitQQVNTIGdldENvbXB1dGVkU3R5bGUodGFyZ2V0 KS5jb2xvciBpcyAicmdiKDAsIDAsIDApIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xp bmstbWVkaWEtYXR0ci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGluay1tZWRpYS1hdHRy Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYjdlNDNmNQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xpbmstbWVkaWEtYXR0ci5odG1sCkBA IC0wLDAgKzEsNDMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxtZXRhIGNo YXJzZXQ9InV0Zi04Ij4KKzxsaW5rIGlkPSJsaW5rIiByZWw9InN0eWxlc2hlZXQiIGhyZWY9ImRh dGE6dGV4dC9jc3MsI3RhcmdldHtjb2xvcjpyZWR9IiBtZWRpYT0icHJpbnQiPgorPHNjcmlwdCBz cmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keT4KKzxzcGFuIGlkPSJ0YXJnZXQiPjwvc3Bhbj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigi TW9kaWZ5aW5nIHRoZSBtZWRpYSBhdHRyaWJ1dGUgb2YgYSBsaW5rIGVsZW1lbnQgdG8gYXBwbHkg LyB1bmFwcGx5IHRvIHRoZSBwYWdlIHNob3VsZCByZWNhbGMgc3R5bGVzIik7CisKK3dpbmRvdy5q c1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworbGluayA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJs aW5rIik7Cit0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iik7CisKK3dp bmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7CisgICAgc2hvdWxkQmVF cXVhbFRvU3RyaW5nKCJsaW5rLm1lZGlhIiwgInByaW50Iik7CisgICAgc2hvdWxkQmVGYWxzZSgi bGluay5kaXNhYmxlZCIpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZ2V0Q29tcHV0ZWRT dHlsZSh0YXJnZXQpLmNvbG9yIiwgInJnYigwLCAwLCAwKSIpOworCisgICAgZXZhbEFuZExvZygn bGluay5tZWRpYSA9ICJzY3JlZW4iJyk7CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJsaW5r Lm1lZGlhIiwgInNjcmVlbiIpOworICAgIHNob3VsZEJlRmFsc2UoImxpbmsuZGlzYWJsZWQiKTsK KyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImdldENvbXB1dGVkU3R5bGUodGFyZ2V0KS5jb2xv ciIsICJyZ2IoMjU1LCAwLCAwKSIpOworCisgICAgZXZhbEFuZExvZygnbGluay5tZWRpYSA9ICJz Y3JlZW4sc2NyZWVuIicpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygibGluay5tZWRpYSIs ICJzY3JlZW4sc2NyZWVuIik7CisgICAgc2hvdWxkQmVGYWxzZSgibGluay5kaXNhYmxlZCIpOwor ICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZ2V0Q29tcHV0ZWRTdHlsZSh0YXJnZXQpLmNvbG9y IiwgInJnYigyNTUsIDAsIDApIik7CisKKyAgICBldmFsQW5kTG9nKCdsaW5rLm1lZGlhID0gInBy aW50IicpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygibGluay5tZWRpYSIsICJwcmludCIp OworICAgIHNob3VsZEJlRmFsc2UoImxpbmsuZGlzYWJsZWQiKTsKKyAgICBzaG91bGRCZUVxdWFs VG9TdHJpbmcoImdldENvbXB1dGVkU3R5bGUodGFyZ2V0KS5jb2xvciIsICJyZ2IoMCwgMCwgMCki KTsKKworICAgIGZpbmlzaEpTVGVzdCgpOworfSk7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIu Li8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA3MWNjNzVjLi5kYmE4NzZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTUtMDgtMjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KworICAgICAgICBQYWdlIGRvZXMgbm90IHVwZGF0ZSB3aGVuIDxsaW5rPiBtZWRpYSBhdHRyaWJ1 dGUgY2hhbmdlcyB0byBubyBsb25nZXIgYXBwbHkgdG8gcGFnZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4MzkyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvbGluay1tZWRpYS1h dHRyLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTExpbmtFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxMaW5rRWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUpOgorICAgICAgICBXaGVu IHRoZSBtZWRpYSBhdHRyaWJ1dGUgY2hhbmdlcywgcmVjYWxjdWxhdGUgc3R5bGVzIGlmIHRoZSBs aW5rIGlzIG5vdCBkaXNhYmxlZC4KKwogMjAxNS0wOC0yNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgSWNvbkRhdGFiYXNlOiBzeW5jVGhyZWFk TWFpbkxvb3AoKSBpcyB1bmxvY2tpbmcgbV9zeW5jTG9jayB0d2ljZSB3aGVuIHRocmVhZCB0ZXJt aW5hdGlvbiBpcyByZXF1ZXN0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TExpbmtFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmNw cAppbmRleCAzZjYyZjA2Li4zNWNhMDlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxMaW5rRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0Vs ZW1lbnQuY3BwCkBAIC0xNjYsNiArMTY2LDggQEAgdm9pZCBIVE1MTGlua0VsZW1lbnQ6OnBhcnNl QXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUsIGNvbnN0IEF0b21pY1N0cmkKICAg ICBpZiAobmFtZSA9PSBtZWRpYUF0dHIpIHsKICAgICAgICAgbV9tZWRpYSA9IHZhbHVlLnN0cmlu ZygpLmxvd2VyKCk7CiAgICAgICAgIHByb2Nlc3MoKTsKKyAgICAgICAgaWYgKCFpc0Rpc2FibGVk KCkpCisgICAgICAgICAgICBkb2N1bWVudCgpLnN0eWxlUmVzb2x2ZXJDaGFuZ2VkKERlZmVyUmVj YWxjU3R5bGUpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIGlmIChuYW1lID09IGRpc2Fi bGVkQXR0cikgewo=