148377 2015-08-24 03:58:28 -0700 [EFL] REGRESSION(r188828): All performance tests and almost all layout tests crash 2015-08-26 00:36:54 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=148467 P2 Normal --- 143743 1 ossy gyuyoung.kim andersca calvaris cgarcia commit-queue enrica gyuyoung.kim ossy sam thorton oldest_to_newest 1120260 0 ossy 2015-08-24 03:58:28 -0700 https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/6629 error: Animation/balls.html 1 0x7fa009f39678 2 0x7fa005377eb0 3 0x420214 WTR::PlatformWebView::page() 4 0x4119b4 WTR::TestController::resetPreferencesToConsistentValues() 5 0x419921 WTR::TestController::initialize(int, char const**) 6 0x41a20a WTR::TestController::TestController(int, char const**) 7 0x40d0ab main 8 0x7fa005362ec5 __libc_start_main 9 0x40d107 - last known good revision: https://trac.webkit.org/changeset/188827 (however the testing failed with timeout during the test number 27) - build failure between: r188828 - r188842 - first failing revision: https://trac.webkit.org/changeset/188843 1120261 1 ossy 2015-08-24 04:02:10 -0700 I think https://trac.webkit.org/changeset/188828 might be the culprit, because it touches PlatformWebView code path in this revision interval. 1120283 2 thorton 2015-08-24 10:13:10 -0700 Seems likely! I will look shortly. 1120303 3 thorton 2015-08-24 10:58:22 -0700 It looks like we don't have a view yet when TestController::initialize tries to set some prefs (via resetPreferencesToConsistentValues). This is OK on PLATFORM(COCOA) because we keep around a global WKWebViewConfiguration and use that when retrieving the WKPreferences. Maybe someone from EFL or GTK (who can actually test this) can do the same with the WKPageConfiguration? 1120548 4 gyuyoung.kim 2015-08-25 01:00:19 -0700 (In reply to comment #3) > It looks like we don't have a view yet when TestController::initialize tries > to set some prefs (via resetPreferencesToConsistentValues). > > This is OK on PLATFORM(COCOA) because we keep around a global > WKWebViewConfiguration and use that when retrieving the WKPreferences. Maybe > someone from EFL or GTK (who can actually test this) can do the same with > the WKPageConfiguration? I simply apply below fix in order to run layout test on EFL port. --- a/Tools/WebKitTestRunner/TestController.cpp +++ b/Tools/WebKitTestRunner/TestController.cpp @@ -568,7 +568,11 @@ void TestController::ensureViewSupportsOptionsForTest(const TestInvocation& test void TestController::resetPreferencesToConsistentValues() { // Reset preferences +#if PLATFORM(COCOA) WKPreferencesRef preferences = platformPreferences(); +#else + WKPreferencesRef preferences = WKPageGroupGetPreferences(m_pageGroup.get()); +#endif EFL layout test begins to run again with this fix. However I'm not sure if this is correct fix for EFL and GTK. Tim, what do you think ? 1120577 5 gyuyoung.kim 2015-08-25 06:05:53 -0700 *** Bug 148420 has been marked as a duplicate of this bug. *** 1120578 6 259840 gyuyoung.kim 2015-08-25 06:10:33 -0700 Created attachment 259840 Patch 1120579 7 gyuyoung.kim 2015-08-25 06:11:32 -0700 I hope to fix EFL layout test and performance test as soon as possible. Tim, Ossy , please take a look this patch. 1120615 8 259840 andersca 2015-08-25 10:03:38 -0700 Comment on attachment 259840 Patch Please implement platformPreferences() in TestControllerEfl.cpp instead of adding more #ifdefs. 1120808 9 259912 gyuyoung.kim 2015-08-25 19:03:52 -0700 Created attachment 259912 Patch 1120809 10 gyuyoung.kim 2015-08-25 19:06:38 -0700 (In reply to comment #8) > Comment on attachment 259840 [details] > Patch > > Please implement platformPreferences() in TestControllerEfl.cpp instead of > adding more #ifdefs. It seems GTK layout test also has been broken since r188828. Fix it too. 1120868 11 259912 commit-queue 2015-08-26 00:03:39 -0700 Comment on attachment 259912 Patch Clearing flags on attachment: 259912 Committed r188948: <http://trac.webkit.org/changeset/188948> 1120869 12 commit-queue 2015-08-26 00:03:44 -0700 All reviewed patches have been landed. Closing bug. 1120871 13 259912 ossy 2015-08-26 00:16:23 -0700 Comment on attachment 259912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259912&action=review > Tools/WebKitTestRunner/TestController.cpp:1609 > +#if !PLATFORM(EFL) && !PLATFORM(GTK) && !PLATFORM(COCOA) > WKPreferencesRef TestController::platformPreferences() > { > WKRetainPtr<WKPageConfigurationRef> configuration = adoptWK(WKPageCopyPageConfiguration(m_mainWebView->page())); > return WKPageConfigurationGetPreferences(configuration.get()); > } > +#endif Aren't these lines unused? As far as I know there isn't this kind of platform. WK2 platforms are only Mac and iOS (Cocoa), EFL, GTK. 1120872 14 259912 gyuyoung.kim 2015-08-26 00:19:55 -0700 Comment on attachment 259912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259912&action=review >> Tools/WebKitTestRunner/TestController.cpp:1609 >> +#endif > > Aren't these lines unused? As far as I know there isn't this kind > of platform. WK2 platforms are only Mac and iOS (Cocoa), EFL, GTK. If so, this is unused code. I didn't know it. I'm sorry. 1120875 15 ossy 2015-08-26 00:23:11 -0700 (In reply to comment #14) > Comment on attachment 259912 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259912&action=review > > >> Tools/WebKitTestRunner/TestController.cpp:1609 > >> +#endif > > > > Aren't these lines unused? As far as I know there isn't this kind > > of platform. WK2 platforms are only Mac and iOS (Cocoa), EFL, GTK. > > If so, this is unused code. I didn't know it. I'm sorry. No problem, let me remove them in bug148467 1120879 16 calvaris 2015-08-26 00:36:54 -0700 *** Bug 148421 has been marked as a duplicate of this bug. *** 259840 2015-08-25 06:10:33 -0700 2015-08-25 19:03:47 -0700 Patch bug-148377-20150825061022.patch text/plain 1613 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGRkZDJlMDM2ZGU5ZjRjNzJkOTRjODZiMWVjM2I2NDEx MTcyMTNhYy4uZjMyMmMzMzNhODczYWZiNGQ3Y2JjMDJiZDEyNmJmMTkwZWVjOTQzNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA4LTI1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICAgW0VGTF0gUkVHUkVTU0lPTihyMTg4ODI4KTogQWxsIHBlcmZvcm1hbmNlIHRl c3RzIGFuZCBhbG1vc3QgYWxsIGxheW91dCB0ZXN0cyBjcmFzaCAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODM3NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29u dHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpyZXNldFByZWZlcmVu Y2VzVG9Db25zaXN0ZW50VmFsdWVzKTogVXNlIFdLUGFnZUdyb3VwR2V0UHJlZmVyZW5jZXMgZm9y IEVGTCBhbmQgR1RLLgorCiAyMDE1LTA4LTI0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFtXaW5dIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcuCmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCmluZGV4IDYzMjI4YjA0ZTYzNDUx NzcxNGU1YmY1MDYzYTQxYzljYWU2ODc3N2EuLjkxNTUxN2Y3MzYxZGJlM2I1ZTAxOWEyOGFlNDlj NDU0YWQxN2VlZTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRy b2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3Bw CkBAIC01NjgsNyArNTY4LDExIEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OmVuc3VyZVZpZXdTdXBw b3J0c09wdGlvbnNGb3JUZXN0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0CiB2b2lkIFRlc3RD b250cm9sbGVyOjpyZXNldFByZWZlcmVuY2VzVG9Db25zaXN0ZW50VmFsdWVzKCkKIHsKICAgICAv LyBSZXNldCBwcmVmZXJlbmNlcworI2lmIFBMQVRGT1JNKENPQ09BKQogICAgIFdLUHJlZmVyZW5j ZXNSZWYgcHJlZmVyZW5jZXMgPSBwbGF0Zm9ybVByZWZlcmVuY2VzKCk7CisjZWxzZQorICAgIFdL UHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXMgPSBXS1BhZ2VHcm91cEdldFByZWZlcmVuY2VzKG1f cGFnZUdyb3VwLmdldCgpKTsKKyNlbmRpZgogICAgIFdLUHJlZmVyZW5jZXNSZXNldFRlc3RSdW5u ZXJPdmVycmlkZXMocHJlZmVyZW5jZXMpOwogICAgIFdLUHJlZmVyZW5jZXNTZXRQYWdlVmlzaWJp bGl0eUJhc2VkUHJvY2Vzc1N1cHByZXNzaW9uRW5hYmxlZChwcmVmZXJlbmNlcywgZmFsc2UpOwog ICAgIFdLUHJlZmVyZW5jZXNTZXRPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQocHJl ZmVyZW5jZXMsIHRydWUpOwo= 259912 2015-08-25 19:03:52 -0700 2015-08-26 00:03:39 -0700 Patch bug-148377-20150826110341.patch text/plain 3569 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4OTAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWVjOGIxYjIyMzQ3ZjBmYmQyM2I3NGY2MDUxZDk2ODcx MjRhOGMxNi4uYjZkYmJkNWUzOTE1M2ZiMDBkNWEwODFmMzFiNjA2YmYyNmEzZDQwYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE1LTA4LTI1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBbRUZMXVtHVEtdIFJFR1JFU1NJT04ocjE4ODgyOCk6IEFsbCBwZXJmb3JtYW5j ZSB0ZXN0cyBhbmQgYWxtb3N0IGFsbCBsYXlvdXQgdGVzdHMgY3Jhc2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODM3NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVGTCBhbmQgR1RLIGRvbid0IHN1cHBv cnQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtUHJlZmVyZW5jZXMoKSB5ZXQgd2hpY2ggd2FzIGlu dHJvZHVjZWQgYnkgcjE4ODgyOC4KKyAgICAgICAgSXQgY2F1c2VkIGFsbCBjcmFzaGVzIG9mIGxh eW91dCB0ZXN0IGFuZCBwZXJmb3JtYW5jZSB0ZXN0IG9uIEVGTCBhbmQgR1RLLiBTbyB0aGlzIHBh dGNoIGltcGxlbWVudHMKKyAgICAgICAgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtUHJlZmVyZW5j ZXMoKSB1c2luZyBXS1BhZ2VHcm91cEdldFByZWZlcmVuY2VzKCkgd2hpY2ggd2FzIHByZXZpb3Vz IHRoaW5nIGZvcgorICAgICAgICBFRkwgYW5kIEdUSyBhdCB0aGUgbW9tZW50LgorCisgICAgICAg ICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OlRl c3RDb250cm9sbGVyOjpwbGF0Zm9ybVdpbGxSdW5UZXN0KToKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250 cm9sbGVyOjpwbGF0Zm9ybVByZWZlcmVuY2VzKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVy OjpwbGF0Zm9ybVByZWZlcmVuY2VzKToKKwogMjAxNS0wOC0yNCAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICAoRmluYWxseS4uLikgZ2V0IHJpZCBvZiBX S1ZpZXdJT1MKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXgg NjMyMjhiMDRlNjM0NTE3NzE0ZTViZjUwNjNhNDFjOWNhZTY4Nzc3YS4uMDU0MjJlZjE5OGFkMDhk ZWY2M2NhMDhlYWVkZmM1MTJmODVhMWRmZiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0 Q29udHJvbGxlci5jcHAKQEAgLTE2MDAsMTYgKzE2MDAsMTggQEAgdm9pZCBUZXN0Q29udHJvbGxl cjo6ZGlkVXBkYXRlSGlzdG9yeVRpdGxlKFdLU3RyaW5nUmVmIHRpdGxlLCBXS1VSTFJlZiBVUkws IFdLRnIKICAgICBtX2N1cnJlbnRJbnZvY2F0aW9uLT5vdXRwdXRUZXh0KFN0cmluZzo6Zm9ybWF0 KCJXZWJWaWV3IHVwZGF0ZWQgdGhlIHRpdGxlIGZvciBoaXN0b3J5IFVSTCBcIiVzXCIgdG8gXCIl c1wiLlxuIiwgdG9TVEQodXJsU3RyaW5nV0spLmNfc3RyKCksIHRvU1REKHRpdGxlKS5jX3N0cigp KSk7CiB9CiAKLSNpZiAhUExBVEZPUk0oQ09DT0EpCi12b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0 Zm9ybVdpbGxSdW5UZXN0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJikKLXsKLX0KLQorI2lmICFQTEFU Rk9STShFRkwpICYmICFQTEFURk9STShHVEspICYmICFQTEFURk9STShDT0NPQSkKIFdLUHJlZmVy ZW5jZXNSZWYgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtUHJlZmVyZW5jZXMoKQogewogICAgIFdL UmV0YWluUHRyPFdLUGFnZUNvbmZpZ3VyYXRpb25SZWY+IGNvbmZpZ3VyYXRpb24gPSBhZG9wdFdL KFdLUGFnZUNvcHlQYWdlQ29uZmlndXJhdGlvbihtX21haW5XZWJWaWV3LT5wYWdlKCkpKTsgCiAg ICAgcmV0dXJuIFdLUGFnZUNvbmZpZ3VyYXRpb25HZXRQcmVmZXJlbmNlcyhjb25maWd1cmF0aW9u LmdldCgpKTsKIH0KKyNlbmRpZgorCisjaWYgIVBMQVRGT1JNKENPQ09BKQordm9pZCBUZXN0Q29u dHJvbGxlcjo6cGxhdGZvcm1XaWxsUnVuVGVzdChjb25zdCBUZXN0SW52b2NhdGlvbiYpCit7Cit9 CiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtQ3JlYXRlV2ViVmlldyhXS1BhZ2VDb25m aWd1cmF0aW9uUmVmIGNvbmZpZ3VyYXRpb24sIGNvbnN0IFZpZXdPcHRpb25zJiBvcHRpb25zKQog ewpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvVGVzdENvbnRyb2xsZXJF ZmwuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvVGVzdENvbnRyb2xsZXJFZmwuY3Bw CmluZGV4IDY5M2VhNzViOTRmOWM0OWVhM2JlOTk5YmQ0YmRkYWI0OWRhMzcyM2EuLjY5ZDIwZGY5 ODE5NDcyNmZmYzk1MWI4YTI5OTczZmMxYTBmYTM2MTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNwcAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHAKQEAgLTYwLDYgKzYwLDExIEBAIHZv aWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCiAgICAgfQogfQogCitXS1By ZWZlcmVuY2VzUmVmIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybVByZWZlcmVuY2VzKCkKK3sKKyAg ICByZXR1cm4gV0tQYWdlR3JvdXBHZXRQcmVmZXJlbmNlcyhtX3BhZ2VHcm91cC5nZXQoKSk7Cit9 CisKIHZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtRGVzdHJveSgpCiB7CiB9CmRpZmYgLS1n aXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHAgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHAKaW5kZXggYWFm NzgwMWZkYWViMzYxNzg0MDc3YzdmZWY3NGM0M2QwOTYyYmU1My4uNjIwNTFiOTAxYWJjYzI4OGU3 ZTQxZWQ5NTEyMDFjMTFmOGU1MjBiOCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv Z3RrL1Rlc3RDb250cm9sbGVyR3RrLmNwcApAQCAtNDgsNiArNDgsMTEgQEAgdm9pZCBUZXN0Q29u dHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFsaXplKCkKIHsKIH0KIAorV0tQcmVmZXJlbmNlc1JlZiBU ZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1QcmVmZXJlbmNlcygpCit7CisgICAgcmV0dXJuIFdLUGFn ZUdyb3VwR2V0UHJlZmVyZW5jZXMobV9wYWdlR3JvdXAuZ2V0KCkpOworfQorCiB2b2lkIFRlc3RD b250cm9sbGVyOjpwbGF0Zm9ybURlc3Ryb3koKQogewogfQo=