148375 2015-08-24 01:57:29 -0700 Web Inspector: Rendering Frames filter checkboxes all become checked during recording 2015-08-24 08:55:56 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1120253 0 mattbaker 2015-08-24 01:57:29 -0700 * SUMMARY Rendering Frames filter checkboxes all become checked during recording. * STEPS TO REPRODUCE 1. Open Inspector > Timelines > Rendering Frames 2. Uncheck one or more task types 3. Reload the inspected page => Once recording begins, unchecked tasks become checked 1120254 1 webkit-bug-importer 2015-08-24 01:58:06 -0700 <rdar://problem/22398372> 1120256 2 259753 mattbaker 2015-08-24 02:05:05 -0700 Created attachment 259753 [Patch] Proposed Fix 1120273 3 259753 commit-queue 2015-08-24 08:55:54 -0700 Comment on attachment 259753 [Patch] Proposed Fix Clearing flags on attachment: 259753 Committed r188861: <http://trac.webkit.org/changeset/188861> 1120274 4 commit-queue 2015-08-24 08:55:56 -0700 All reviewed patches have been landed. Closing bug. 259753 2015-08-24 02:05:05 -0700 2015-08-24 08:55:54 -0700 [Patch] Proposed Fix bug-148375-20150824020456.patch text/plain 4039 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4ODUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk MDI0OGRiMmNlNGNiYzM2MWE1MTlhYjEzYTlmNGY3ZmE4ZTUxNmM0Li4zYzgzMjBmZjUwMjJjYmVh ZDc2MGRlM2M0MWRlNjQ1YTUwYjYwYzM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNS0wOC0yNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVuZGVyaW5nIEZyYW1lcyBmaWx0ZXIgY2hlY2ti b3hlcyBhbGwgYmVjb21lIGNoZWNrZWQgZHVyaW5nIHJlY29yZGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4Mzc1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0No YXJ0RGV0YWlsc1NlY3Rpb25Sb3cuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ2hhcnREZXRh aWxzU2VjdGlvblJvdy5wcm90b3R5cGUuX2NyZWF0ZUxlZ2VuZCk6CisgICAgICAgIFJlbW92ZWQg aW5jb3JyZWN0IGNvZGUgdGhhdCBmb3JjZWQgY2hlY2tlZCB0byB0cnVlLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbC5fcmVmcmVzaEZyYW1lU2VsZWN0aW9uQ2hh cnQpOgorICAgICAgICBQZXJzaXN0IGxlZ2VuZCBpdGVtIGNoZWNrYm94IHN0YXRlIHdoZW4gdXBk YXRpbmcgdGhlIGNoYXJ0LgorCiAyMDE1LTA4LTIzICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaWx0ZXJlZCBzdHlsZSBub3QgYXBw bGllZCB0byBncmFwaCBlbGVtZW50cyBkdXJpbmcgdGltZWxpbmUgcmVjb3JkaW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DaGFydERldGFp bHNTZWN0aW9uUm93LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ2hhcnREZXRhaWxzU2VjdGlvblJvdy5qcwppbmRleCBhNGY4ODAxNzQ4MjkzYzBhNDBlZDU4 ZTU0NzJlODM1YjI4N2I2MTk5Li4xYzUwNTU0YWU2ODA4ODQ1NTQyOWVmODc1OWVmMjUxZGJlNTEz OGI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9DaGFydERldGFpbHNTZWN0aW9uUm93LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NoYXJ0RGV0YWlsc1NlY3Rpb25Sb3cuanMKQEAgLTE4MSw3ICsx ODEsNyBAQCBXZWJJbnNwZWN0b3IuQ2hhcnREZXRhaWxzU2VjdGlvblJvdyA9IGNsYXNzIENoYXJ0 RGV0YWlsc1NlY3Rpb25Sb3cgZXh0ZW5kcyBXZWJJbgogICAgICAgICAgICAgICAgIGtleUVsZW1l bnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpbnB1dCIpOwogICAgICAgICAgICAgICAgIGtl eUVsZW1lbnQudHlwZSA9ICJjaGVja2JveCI7CiAgICAgICAgICAgICAgICAga2V5RWxlbWVudC5j bGFzc0xpc3QuYWRkKGNsYXNzTmFtZSk7Ci0gICAgICAgICAgICAgICAga2V5RWxlbWVudC5jaGVj a2VkID0gaXRlbS5jaGVja2VkIHx8IHRydWU7CisgICAgICAgICAgICAgICAga2V5RWxlbWVudC5j aGVja2VkID0gaXRlbS5jaGVja2VkOwogICAgICAgICAgICAgICAgIGtleUVsZW1lbnRbV2ViSW5z cGVjdG9yLkNoYXJ0RGV0YWlsc1NlY3Rpb25Sb3cuRGF0YUl0ZW1JZFN5bWJvbF0gPSBpdGVtLmlk OwogCiAgICAgICAgICAgICAgICAga2V5RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjaGFuZ2Ui LCB0aGlzLl9sZWdlbmRJdGVtQ2hlY2tib3hWYWx1ZUNoYW5nZWQuYmluZCh0aGlzKSk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGlu ZVNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzCmluZGV4IGM2MDU0ZDVkOWQwZDlmODU3MDNlYjc4 MDI3YTdlNGZkMjYxODAwNWIuLjI5ZjQ5N2Y4NTUyZTg2OTg0NjAyYTk1NTIwZGMzZGUyMTY1ZDA2 NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzCkBAIC04OTYsMTEgKzg5Niwx MyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwgPSBjbGFzcyBUaW1lbGluZVNp ZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICB2YXIgY2hhcnQgPSB0aGlzLl9m cmFtZVNlbGVjdGlvbkNoYXJ0Um93OwogICAgICAgICB2YXIgcmVjb3JkcyA9IGdldFNlbGVjdGVk UmVjb3Jkcy5jYWxsKHRoaXMpOwogICAgICAgICB2YXIgY2hhcnREYXRhID0gT2JqZWN0LmtleXMo V2ViSW5zcGVjdG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVSZWNvcmQuVGFza1R5cGUpLm1hcChm dW5jdGlvbih0YXNrVHlwZUtleSkgewotICAgICAgICAgICAgdmFyIHRhc2tUeXBlID0gV2ViSW5z cGVjdG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVSZWNvcmQuVGFza1R5cGVbdGFza1R5cGVLZXld OwotICAgICAgICAgICAgdmFyIGxhYmVsID0gV2ViSW5zcGVjdG9yLlJlbmRlcmluZ0ZyYW1lVGlt ZWxpbmVSZWNvcmQuZGlzcGxheU5hbWVGb3JUYXNrVHlwZSh0YXNrVHlwZSk7Ci0gICAgICAgICAg ICB2YXIgdmFsdWUgPSByZWNvcmRzLnJlZHVjZShmdW5jdGlvbihwcmV2aW91c1ZhbHVlLCBjdXJy ZW50VmFsdWUpIHsgcmV0dXJuIHByZXZpb3VzVmFsdWUgKyBjdXJyZW50VmFsdWUuZHVyYXRpb25G b3JUYXNrKHRhc2tUeXBlKTsgfSwgMCk7Ci0gICAgICAgICAgICB2YXIgY29sb3IgPSB0aGlzLl9j aGFydENvbG9ycy5nZXQodGFza1R5cGUpOwotICAgICAgICAgICAgcmV0dXJuIHtpZDogdGFza1R5 cGUsIGxhYmVsLCB2YWx1ZSwgY29sb3IsIGNoZWNrYm94OiB0YXNrVHlwZSAhPT0gV2ViSW5zcGVj dG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVSZWNvcmQuVGFza1R5cGUuT3RoZXJ9OworICAgICAg ICAgICAgbGV0IHRhc2tUeXBlID0gV2ViSW5zcGVjdG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVS ZWNvcmQuVGFza1R5cGVbdGFza1R5cGVLZXldOworICAgICAgICAgICAgbGV0IGxhYmVsID0gV2Vi SW5zcGVjdG9yLlJlbmRlcmluZ0ZyYW1lVGltZWxpbmVSZWNvcmQuZGlzcGxheU5hbWVGb3JUYXNr VHlwZSh0YXNrVHlwZSk7CisgICAgICAgICAgICBsZXQgdmFsdWUgPSByZWNvcmRzLnJlZHVjZShm dW5jdGlvbihwcmV2aW91c1ZhbHVlLCBjdXJyZW50VmFsdWUpIHsgcmV0dXJuIHByZXZpb3VzVmFs dWUgKyBjdXJyZW50VmFsdWUuZHVyYXRpb25Gb3JUYXNrKHRhc2tUeXBlKTsgfSwgMCk7CisgICAg ICAgICAgICBsZXQgY29sb3IgPSB0aGlzLl9jaGFydENvbG9ycy5nZXQodGFza1R5cGUpOworICAg ICAgICAgICAgbGV0IGNoZWNrYm94ID0gdGFza1R5cGUgIT09IFdlYkluc3BlY3Rvci5SZW5kZXJp bmdGcmFtZVRpbWVsaW5lUmVjb3JkLlRhc2tUeXBlLk90aGVyOworICAgICAgICAgICAgbGV0IGNo ZWNrZWQgPSBjaGVja2JveCAmJiAhdGhpcy5fcmVuZGVyaW5nRnJhbWVUYXNrRmlsdGVyLmhhcyh0 YXNrVHlwZSk7CisgICAgICAgICAgICByZXR1cm4ge2lkOiB0YXNrVHlwZSwgbGFiZWwsIHZhbHVl LCBjb2xvciwgY2hlY2tib3gsIGNoZWNrZWR9OwogICAgICAgICB9LCB0aGlzKTsKIAogICAgICAg ICB0aGlzLl9mcmFtZVNlbGVjdGlvbkNoYXJ0Um93LmRhdGEgPSBjaGFydERhdGE7Cg==