148369 2015-08-23 02:29:45 -0700 [EFL] Fix the build after r188828 2015-08-23 23:18:16 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 hs85.jeong hs85.jeong andersca commit-queue gyuyoung.kim lucas.de.marchi ossy thorton oldest_to_newest 1120167 0 hs85.jeong 2015-08-23 02:29:45 -0700 https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/24008/steps/compile-webkit/logs/stdio ../../Tools/WebKitTestRunner/PlatformWebView.h:30:33: fatal error: WebKit/WKFoundation.h: No such file or directory #include <WebKit/WKFoundation.h> 1120168 1 259738 hs85.jeong 2015-08-23 02:36:17 -0700 Created attachment 259738 Patch 1120169 2 259738 gyuyoung.kim 2015-08-23 02:59:19 -0700 Comment on attachment 259738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259738&action=review > Tools/WebKitTestRunner/PlatformWebView.h:30 > +#if PLATFORM(COCOA) PLATFORM(COCOA) macro is used 35 line too. So isn't it would be good to move "#include <WebKit/WKFoundation.h> inside the macro ? For example, http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h#L36 1120170 3 259738 thorton 2015-08-23 03:03:34 -0700 Comment on attachment 259738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259738&action=review >> Tools/WebKitTestRunner/PlatformWebView.h:30 >> +#if PLATFORM(COCOA) > > PLATFORM(COCOA) macro is used 35 line too. So isn't it would be good to move "#include <WebKit/WKFoundation.h> inside the macro ? > > For example, http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h#L36 That would be fine too. It just has to be before the first WK_API_ENABLED. 1120173 4 259739 hs85.jeong 2015-08-23 06:59:46 -0700 Created attachment 259739 Patch 1120174 5 hs85.jeong 2015-08-23 07:01:44 -0700 (In reply to comment #3) > Comment on attachment 259738 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259738&action=review > > >> Tools/WebKitTestRunner/PlatformWebView.h:30 > >> +#if PLATFORM(COCOA) > > > > PLATFORM(COCOA) macro is used 35 line too. So isn't it would be good to move "#include <WebKit/WKFoundation.h> inside the macro ? > > > > For example, http://trac.webkit.org/browser/trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h#L36 > > That would be fine too. It just has to be before the first WK_API_ENABLED. Thanks for the review. I moved the header file to PLATFORM(COCOA) guard. 1120200 6 259739 commit-queue 2015-08-23 14:43:37 -0700 Comment on attachment 259739 Patch Rejecting attachment 259739 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 259739, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 0-ab3c-d52691b4dbfc ... Currently at 188839 = 91a25641d6e666cbb91b29e02f143576e92522fc r188840 = d837bc87816f2e752cadd17919f79f0af0cd9d16 r188841 = 3ff214b4c03f49f6a34a49325d7e649e3a20ea55 r188842 = 6ba1ab28e51011b68ab5b65944576ea3e456cd8b r188843 = aab0d7c1c0fc76d5f985c54e758c9dbca5855a2e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/96879 1120209 7 hs85.jeong 2015-08-23 18:02:18 -0700 Oops.. Ossy, already fixed the build. http://trac.webkit.org/changeset/188840 I close this issue. 1120232 8 ossy 2015-08-23 23:18:16 -0700 (In reply to comment #7) > Oops.. > Ossy, already fixed the build. > http://trac.webkit.org/changeset/188840 > > I close this issue. Oops, sorry for the duplicated work. :( Unfortunately I only checked the review queue before fixing. I will check the pending commits too next time. 259738 2015-08-23 02:36:17 -0700 2015-08-23 06:59:39 -0700 Patch bug-148369-20150824033548.patch text/plain 2367 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjE3YWFmZGY5NGVmYTQ2 ODM5MWMwMTMxMGVjNTE2OTdmY2M5OTBkNi4uYmY2YTA5NjFmYmFiODI0NDMyODkxMjY5YzEzMTRm NmE2MjhmYzcyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA4LTIzICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXgg dGhlIGJ1aWxkIGFmdGVyIHIxODg4MjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0ODM2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IEFkZGVkIHRoZSBXS1VzZXJDb250ZW50 Q29udHJvbGxlclJlZiB0byBDTWFrZUxpc3RzLgorCiAyMDE1LTA4LTIyICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEZhY3RvciBvdXQgYW5kIGFkZCBs b2dnaW5nIHRvIHN3aXBlLXN0YXJ0IGh5c3RlcmVzaXMgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dApp bmRleCAxODA3MjE0YWUyNjc5ZGYyNjQyYjM2M2M4NGQzYjdlNDNkZjhhODIwLi4xYjgwNWQ4NmVm NmMyMTAwODMyNTI1OTJmMjgyOGU5YjQzMTk3NmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9DTWFrZUxpc3RzLnR4dApAQCAt NDQ4LDYgKzQ0OCw3IEBAIHNldChXZWJLaXQyX1NPVVJDRVMKICAgICBVSVByb2Nlc3MvQVBJL0Mv V0tSZXNvdXJjZUNhY2hlTWFuYWdlci5jcHAKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tTZXNzaW9u U3RhdGVSZWYuY3BwCiAgICAgVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIuY3BwCisgICAg VUlQcm9jZXNzL0FQSS9DL1dLVXNlckNvbnRlbnRDb250cm9sbGVyUmVmLmNwcAogICAgIFVJUHJv Y2Vzcy9BUEkvQy9XS1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0LmNwcAogICAgIFVJUHJvY2Vz cy9BUEkvQy9XS1ZpYnJhdGlvbi5jcHAKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tWaWV3cG9ydEF0 dHJpYnV0ZXMuY3BwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggNTZmYzYwNzg2ZDAyOTZhYTE1NmUxNGI5MzIxNjFjMDdmYjZmN2RlYS4uMGM3Y2Fl MjNjYTM3MzU5YjZmNTJmZjZiOWI0YzU2ZjYyY2ZkNjIyNCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA4LTIz ICBIdW5zZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZM XSBGaXggdGhlIGJ1aWxkIGFmdGVyIHIxODg4MjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODM2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcu aDogU2VwYXJhdGVkIHRoZSBoZWFkZXIgZmlsZSB1c2luZyB0aGUgUExBVEZPUk0gZ3VhcmQuCisK IDIwMTUtMDgtMjIgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgc2hvdWxkIHVzZSBXS1dlYlZpZXcgb24gT1MgWCBh bmQgaU9TCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmll dy5oIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaAppbmRleCA5NmI0 ZDJjOTQ2ZDVkZWZmYTA3ZmZiMTg5ZDM3NGQ3OTE4ZDBhM2UwLi5lMzhhZjY3OTNkNzNhMWNjMTIz MGUxN2U0MzhjM2JjNGNiOThjMWZjIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1BsYXRmb3JtV2ViVmlldy5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1X ZWJWaWV3LmgKQEAgLTI3LDcgKzI3LDkgQEAKICNkZWZpbmUgUGxhdGZvcm1XZWJWaWV3X2gKIAog I2luY2x1ZGUgIlZpZXdPcHRpb25zLmgiCisjaWYgUExBVEZPUk0oQ09DT0EpCiAjaW5jbHVkZSA8 V2ViS2l0L1dLRm91bmRhdGlvbi5oPgorI2VuZGlmCiAjaW5jbHVkZSA8V2ViS2l0L1dLUmV0YWlu UHRyLmg+CiAKICNpZiBQTEFURk9STShDT0NPQSkK 259739 2015-08-23 06:59:46 -0700 2015-08-23 14:43:37 -0700 Patch bug-148369-20150824075916.patch text/plain 2431 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4ODM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjE3YWFmZGY5NGVmYTQ2 ODM5MWMwMTMxMGVjNTE2OTdmY2M5OTBkNi4uYjRlOWM1ODQ4ZmI4NjBiZTk3YTI4N2Q1MWVmNTA3 ZTI5Y2RlNTgwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA4LTIzICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXgg dGhlIGJ1aWxkIGFmdGVyIHIxODg4MjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0ODM2OQorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24u CisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogQWRkZWQgdGhlIFdLVXNlckNvbnRlbnRDb250 cm9sbGVyUmVmIHRvIENNYWtlTGlzdHMuCisKIDIwMTUtMDgtMjIgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRmFjdG9yIG91dCBhbmQgYWRkIGxvZ2dp bmcgdG8gc3dpcGUtc3RhcnQgaHlzdGVyZXNpcyBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0CmluZGV4 IDE4MDcyMTRhZTI2NzlkZjI2NDJiMzYzYzg0ZDNiN2U0M2RmOGE4MjAuLjFiODA1ZDg2ZWY2YzIx MDA4MzI1MjU5MmYyODI4ZTliNDMxOTc2YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NN YWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0CkBAIC00NDgs NiArNDQ4LDcgQEAgc2V0KFdlYktpdDJfU09VUkNFUwogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1Jl c291cmNlQ2FjaGVNYW5hZ2VyLmNwcAogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1Nlc3Npb25TdGF0 ZVJlZi5jcHAKICAgICBVSVByb2Nlc3MvQVBJL0MvV0tUZXh0Q2hlY2tlci5jcHAKKyAgICBVSVBy b2Nlc3MvQVBJL0MvV0tVc2VyQ29udGVudENvbnRyb2xsZXJSZWYuY3BwCiAgICAgVUlQcm9jZXNz L0FQSS9DL1dLVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3QuY3BwCiAgICAgVUlQcm9jZXNzL0FQ SS9DL1dLVmlicmF0aW9uLmNwcAogICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1ZpZXdwb3J0QXR0cmli dXRlcy5jcHAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCA5ZjcyNmUwMzYwYjgyMzIzYjY1MWU2ZmZlYzNlODMyYTA0N2ZjM2RkLi4wMzA4OGIxNDM5 M2E3ZjM2ZWNkMzEwYWNlNGQzMjJlM2UxOWIwZDA0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDgtMjMgIEh1 bnNlb3AgSmVvbmcgIDxoczg1Lmplb25nQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEZp eCB0aGUgYnVpbGQgYWZ0ZXIgcjE4ODgyOAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4MzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRv bi4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3Lmg6IFNlcGFy YXRlZCB0aGUgaGVhZGVyIGZpbGUgdXNpbmcgdGhlIFBMQVRGT1JNIGd1YXJkLgorCiAyMDE1LTA4 LTIzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgc3R5bGUgY2hlY2tpbmcgcnVsZSByZWdhcmRpbmcgT3duUHRyIGFuZCBQYXNzT3duUHRy CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaAppbmRleCA5NmI0ZDJjOTQ2 ZDVkZWZmYTA3ZmZiMTg5ZDM3NGQ3OTE4ZDBhM2UwLi4wMTFlNGNkNDI0NzNkNmYxZjc2MWJlZWQ2 ZTliZjAxZTQ1ODFmM2QwIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRm b3JtV2ViVmlldy5oCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3 LmgKQEAgLTI3LDEwICsyNywxMCBAQAogI2RlZmluZSBQbGF0Zm9ybVdlYlZpZXdfaAogCiAjaW5j bHVkZSAiVmlld09wdGlvbnMuaCIKLSNpbmNsdWRlIDxXZWJLaXQvV0tGb3VuZGF0aW9uLmg+CiAj aW5jbHVkZSA8V2ViS2l0L1dLUmV0YWluUHRyLmg+CiAKICNpZiBQTEFURk9STShDT0NPQSkKKyNp bmNsdWRlIDxXZWJLaXQvV0tGb3VuZGF0aW9uLmg+CiBPQkpDX0NMQVNTIE5TVmlldzsKIE9CSkNf Q0xBU1MgVUlWaWV3OwogT0JKQ19DTEFTUyBXS1dlYlZpZXc7Cg==