148368 2015-08-22 20:27:18 -0700 Web Inspector: Command-Enter should evaluate selected JS in Debugger/Sources 2015-09-14 01:55:33 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1120152 0 nvasilyev 2015-08-22 20:27:18 -0700 Light Table has an inline evaluation. Pressing Command-Enter runs the selected code and shows the return value inline, right by the code. http://lighttable.com/#features Chrome DevTools have a Control-Shift-E shortcut to evaluate selected text in the console. I think, eventually we need to do something like Light Table. There are quite a few nuances and I could take while to get it right. So, for now, I propose to implement Command-Enter shortcut to evaluate the selected code in the console. 1120153 1 webkit-bug-importer 2015-08-22 20:27:46 -0700 <rdar://problem/22393224> 1120901 2 259942 nvasilyev 2015-08-26 02:45:58 -0700 Created attachment 259942 Patch 1120903 3 259942 timothy 2015-08-26 02:51:03 -0700 Comment on attachment 259942 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259942&action=review > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:730 > + if (modeName !== "javascript" && modeName !== "htmlmixed") I think there is a way to get the inner mode for the selection, that way we know if it is JS even inside html. Right now I think that will allow non-JS to be evaluated from HTML. The completion controller has code for looking at inner mode I think. 1120904 4 259942 timothy 2015-08-26 02:51:26 -0700 Comment on attachment 259942 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259942&action=review >> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:730 >> + if (modeName !== "javascript" && modeName !== "htmlmixed") > > I think there is a way to get the inner mode for the selection, that way we know if it is JS even inside html. Right now I think that will allow non-JS to be evaluated from HTML. The completion controller has code for looking at inner mode I think. Oh, now I see your comment in the ChangeLog. Sounds good. 1120907 5 nvasilyev 2015-08-26 02:57:20 -0700 (In reply to comment #4) > Comment on attachment 259942 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259942&action=review > > >> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:730 > >> + if (modeName !== "javascript" && modeName !== "htmlmixed") > > > > I think there is a way to get the inner mode for the selection, that way we know if it is JS even inside html. Right now I think that will allow non-JS to be evaluated from HTML. The completion controller has code for looking at inner mode I think. > > Oh, now I see your comment in the ChangeLog. Sounds good. Currently, pressing Command-Enter inside a resource doesn't do anything at all. It doesn't insert a new line. We may revisit what does it do for HTML in the future, but I don't have any other ideas at the moment. 1120953 6 259942 commit-queue 2015-08-26 09:06:38 -0700 Comment on attachment 259942 Patch Clearing flags on attachment: 259942 Committed r188967: <http://trac.webkit.org/changeset/188967> 1120954 7 commit-queue 2015-08-26 09:06:46 -0700 All reviewed patches have been landed. Closing bug. 1125577 8 nvasilyev 2015-09-14 01:55:33 -0700 Looking into this two weeks later with a fresh eye, I think Command-Enter should show the exact same popover as on hover. Evaluating in the console seems too disconnected from the source code and requires a bit of an extra mental effort not to lose the context. 259942 2015-08-26 02:45:58 -0700 2015-08-26 09:06:38 -0700 Patch patch.txt text/plain 2697 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc4NDQ3YmMuLjdlMjQyMDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA4LTI2ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbW1h bmQtRW50ZXIgc2hvdWxkIGV2YWx1YXRlIHNlbGVjdGVkIEpTIGluIERlYnVnZ2VyL1NvdXJjZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODM2OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuQ29kZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVyKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIucHJvdG90 eXBlLl9nZW5lcmF0ZUphdmFTY3JpcHRDb21wbGV0aW9ucyk6CisgICAgICAgIEV2YWx1YXRlIHNl bGVjdGVkIHRleHQgaW4gdGhlIGNvbnNvbGUgb25seSBmb3IgSlMgYW5kIEhUTUwgcmVzb3VyY2Vz LiBIVE1MIHJlc291cmNlcworICAgICAgICBzaG91bGQgYmUgYWxsb3dlZCBiZWNhdXNlIHRoZXkg Y2FuIGhhdmUgY29tbWVudGVkIG91dCAoaW5zaWRlIDwhLS0gLS0+KSBhbmQKKyAgICAgICAgaW5s aW5lIChvbmNsaWNrPSIiKSBKYXZhU2NyaXB0LgorCiAyMDE1LTA4LTI1ICBCcmlhbiBCdXJnICA8 YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1lc3NhZ2UgZGlzcGF0 Y2ggbWV0cmljcyBzaG91bGQgdXNlIGhpZ2gtcmVzb2x1dGlvbiB0aW1pbmcgZGF0YQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29k ZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVyLmpz CmluZGV4IDYxN2ZmMmEuLjQ4ODAxMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxl ci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIuanMKQEAgLTUxLDYgKzUxLDcgQEAgV2Vi SW5zcGVjdG9yLkNvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlciA9IGNsYXNzIENvZGVNaXJy b3JDb21wbGV0aW9uQ29udHJvbGwKICAgICAgICAgICAgICJSaWdodCI6IHRoaXMuX2hhbmRsZVJp Z2h0T3JFbnRlcktleS5iaW5kKHRoaXMpLAogICAgICAgICAgICAgIkVzYyI6IHRoaXMuX2hhbmRs ZUVzY2FwZUtleS5iaW5kKHRoaXMpLAogICAgICAgICAgICAgIkVudGVyIjogdGhpcy5faGFuZGxl UmlnaHRPckVudGVyS2V5LmJpbmQodGhpcyksCisgICAgICAgICAgICAiQ21kLUVudGVyIjogdGhp cy5faGFuZGxlQ29tbWFuZEVudGVyS2V5LmJpbmQodGhpcyksCiAgICAgICAgICAgICAiVGFiIjog dGhpcy5faGFuZGxlVGFiS2V5LmJpbmQodGhpcyksCiAgICAgICAgICAgICAiQ21kLUEiOiB0aGlz Ll9oYW5kbGVIaWRlS2V5LmJpbmQodGhpcyksCiAgICAgICAgICAgICAiQ21kLVoiOiB0aGlzLl9o YW5kbGVIaWRlS2V5LmJpbmQodGhpcyksCkBAIC03MjMsNiArNzI0LDE5IEBAIFdlYkluc3BlY3Rv ci5Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yQ29tcGxl dGlvbkNvbnRyb2xsCiAgICAgICAgIHRoaXMuX2NvbW1pdENvbXBsZXRpb25IaW50KCk7CiAgICAg fQogCisgICAgX2hhbmRsZUNvbW1hbmRFbnRlcktleShjb2RlTWlycm9yKQorICAgIHsKKyAgICAg ICAgY29uc3QgbW9kZU5hbWUgPSBjb2RlTWlycm9yLmdldE1vZGUoKS5uYW1lOworICAgICAgICBp ZiAobW9kZU5hbWUgIT09ICJqYXZhc2NyaXB0IiAmJiBtb2RlTmFtZSAhPT0gImh0bWxtaXhlZCIp CisgICAgICAgICAgICByZXR1cm4gQ29kZU1pcnJvci5QYXNzOworCisgICAgICAgIGNvbnN0IHNl bGVjdGVkVGV4dCA9IGNvZGVNaXJyb3IuZ2V0U2VsZWN0aW9uKCk7CisgICAgICAgIGlmICghc2Vs ZWN0ZWRUZXh0KQorICAgICAgICAgICAgcmV0dXJuIENvZGVNaXJyb3IuUGFzczsKKworICAgICAg ICBXZWJJbnNwZWN0b3IuY29uc29sZUxvZ1ZpZXdDb250cm9sbGVyLmNvbnNvbGVQcm9tcHRUZXh0 Q29tbWl0dGVkKG51bGwsIHNlbGVjdGVkVGV4dCk7CisgICAgfQorCiAgICAgX2hhbmRsZUVzY2Fw ZUtleShjb2RlTWlycm9yKQogICAgIHsKICAgICAgICAgdmFyIGRlbGVnYXRlSW1wbGVtZW50c1No b3VsZEFsbG93RXNjYXBlQ29tcGxldGlvbiA9IHRoaXMuX2RlbGVnYXRlICYmIHR5cGVvZiB0aGlz Ll9kZWxlZ2F0ZS5jb21wbGV0aW9uQ29udHJvbGxlclNob3VsZEFsbG93RXNjYXBlQ29tcGxldGlv biA9PT0gImZ1bmN0aW9uIjsK