148357 2015-08-21 23:24:02 -0700 build.webkit.org/dashboard: Respect step's hidden flag 2015-08-23 09:30:00 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue matthew_hanson thorton oldest_to_newest 1120090 0 ap 2015-08-21 23:24:02 -0700 Sometimes we want to hide an unsuccessful step if the error indicates that it doesn't apply. This doesn't work very well in buildbot itself, but we can make it work better on the dashboard. 1120091 1 259714 ap 2015-08-21 23:27:05 -0700 Created attachment 259714 proposed patch 1120184 2 259714 commit-queue 2015-08-23 09:29:57 -0700 Comment on attachment 259714 proposed patch Clearing flags on attachment: 259714 Committed r188836: <http://trac.webkit.org/changeset/188836> 1120185 3 commit-queue 2015-08-23 09:30:00 -0700 All reviewed patches have been landed. Closing bug. 259714 2015-08-21 23:27:05 -0700 2015-08-23 09:29:57 -0700 proposed patch DashboardHiddenStep.txt text/plain 2009 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4ODgxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA4LTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkOiBSZXNwZWN0IHN0ZXAncyBo aWRkZW4gZmxhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ4MzU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRt bC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qczoKKyAgICAgICAgKEJ1aWxk Ym90SXRlcmF0aW9uLnByb3RvdHlwZS5fcGFyc2VEYXRhKToKKwogMjAxNS0wOC0yMSAgQ29tbWl0 IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjE4ODgwNywgcjE4ODgxMywgYW5kIHIxODg4MTUuCkluZGV4OiBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qcwkocmV2aXNpb24gMTg4ODE4KQorKysg VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RJdGVyYXRpb24uanMJKHdvcmtpbmcgY29weSkK QEAgLTI0Myw3ICsyNDMsNyBAQCBCdWlsZGJvdEl0ZXJhdGlvbi5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgdGhpcy5mYWlsZWRUZXN0U3RlcHMgPSBbXTsKICAgICAgICAgZGF0YS5zdGVwcy5mb3JF YWNoKGZ1bmN0aW9uKHN0ZXApIHsKLSAgICAgICAgICAgIGlmICghc3RlcC5pc0ZpbmlzaGVkIHx8 ICEoc3RlcC5uYW1lIGluIEJ1aWxkYm90SXRlcmF0aW9uLlRlc3RTdGVwcykpCisgICAgICAgICAg ICBpZiAoIXN0ZXAuaXNGaW5pc2hlZCB8fCBzdGVwLmhpZGRlbiB8fCAhKHN0ZXAubmFtZSBpbiBC dWlsZGJvdEl0ZXJhdGlvbi5UZXN0U3RlcHMpKQogICAgICAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgICAgIHZhciByZXN1bHRzID0gbmV3IEJ1aWxkYm90VGVzdFJlc3VsdHMoc3RlcCk7CiAg ICAgICAgICAgICBpZiAoc3RlcC5uYW1lID09PSAibGF5b3V0LXRlc3QiKQpAQCAtMjYzLDcgKzI2 Myw3IEBAIEJ1aWxkYm90SXRlcmF0aW9uLnByb3RvdHlwZSA9IHsKIAogICAgICAgICB0aGlzLmxv YWRlZCA9IHRydWU7CiAKLSAgICAgICAgdGhpcy5fZmlyc3RGYWlsZWRTdGVwID0gZGF0YS5zdGVw cy5maW5kRmlyc3QoZnVuY3Rpb24oc3RlcCkgeyByZXR1cm4gc3RlcC5yZXN1bHRzWzBdID09PSBC dWlsZGJvdEl0ZXJhdGlvbi5GQUlMVVJFOyB9KTsKKyAgICAgICAgdGhpcy5fZmlyc3RGYWlsZWRT dGVwID0gZGF0YS5zdGVwcy5maW5kRmlyc3QoZnVuY3Rpb24oc3RlcCkgeyByZXR1cm4gIXN0ZXAu aGlkZGVuICYmIHN0ZXAucmVzdWx0c1swXSA9PT0gQnVpbGRib3RJdGVyYXRpb24uRkFJTFVSRTsg fSk7CiAKICAgICAgICAgY29uc29sZS5hc3NlcnQoZGF0YS5yZXN1bHRzID09PSBudWxsIHx8IHR5 cGVvZiBkYXRhLnJlc3VsdHMgPT09ICJudW1iZXIiKTsKICAgICAgICAgdGhpcy5fcmVzdWx0ID0g ZGF0YS5yZXN1bHRzOwo=