148356 2015-08-21 23:03:52 -0700 build.webkit.org/dashboard: Combined queues don't turn orange on internal failure 2015-08-23 09:33:16 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue thorton oldest_to_newest 1120087 0 ap 2015-08-21 23:03:52 -0700 Queues are supposed to turn red when there is a real bug detected, and orange when CI machinery doesn't work. Combined queues don't implement that properly. 1120088 1 259712 ap 2015-08-21 23:05:48 -0700 Created attachment 259712 proposed fix 1120189 2 259712 commit-queue 2015-08-23 09:33:13 -0700 Comment on attachment 259712 proposed fix Clearing flags on attachment: 259712 Committed r188838: <http://trac.webkit.org/changeset/188838> 1120190 3 commit-queue 2015-08-23 09:33:16 -0700 All reviewed patches have been landed. Closing bug. 259712 2015-08-21 23:05:48 -0700 2015-08-23 09:33:13 -0700 proposed fix CombinedQueueOrange.txt text/plain 2522 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4ODgxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTA4LTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkOiBDb21iaW5lZCBxdWV1ZXMg ZG9uJ3QgdHVybiBvcmFuZ2Ugb24gaW50ZXJuYWwgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4MzU2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdENv bWJpbmVkUXVldWVWaWV3LmpzOgorICAgICAgICAoQnVpbGRib3RDb21iaW5lZFF1ZXVlVmlldy5w cm90b3R5cGUudXBkYXRlKToKKwogMjAxNS0wOC0yMSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1 ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE4ODgw NywgcjE4ODgxMywgYW5kIHIxODg4MTUuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWls ZGJvdENvbWJpbmVkUXVldWVWaWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3Jp cHRzL0J1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcuanMJKHJldmlzaW9uIDE4ODgxOCkKKysrIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcuanMJKHdvcmtpbmcg Y29weSkKQEAgLTEwNiwxNCArMTA2LDE1IEBAIEJ1aWxkYm90Q29tYmluZWRRdWV1ZVZpZXcucHJv dG90eXBlID0gewogICAgICAgICAgICAgICAgIGlmIChmaXJzdFJlY2VudFVuc3VjY2Vzc2Z1bEl0 ZXJhdGlvbiAmJiBmaXJzdFJlY2VudFVuc3VjY2Vzc2Z1bEl0ZXJhdGlvbi5sb2FkZWQgJiYgbW9z dFJlY2VudEZpbmlzaGVkSXRlcmF0aW9uICYmIG1vc3RSZWNlbnRGaW5pc2hlZEl0ZXJhdGlvbi5s b2FkZWQpIHsKICAgICAgICAgICAgICAgICAgICAgY29uc29sZS5hc3NlcnQoIW1vc3RSZWNlbnRG aW5pc2hlZEl0ZXJhdGlvbi5zdWNjZXNzZnVsKTsKICAgICAgICAgICAgICAgICAgICAgdmFyIG1l c3NhZ2UgPSB0aGlzLnJldmlzaW9uQ29udGVudEZvckl0ZXJhdGlvbihtb3N0UmVjZW50RmluaXNo ZWRJdGVyYXRpb24sIG1vc3RSZWNlbnRGaW5pc2hlZEl0ZXJhdGlvbi5wcm9kdWN0aXZlID8gbW9z dFJlY2VudFN1Y2Nlc3NmdWxJdGVyYXRpb24gOiBudWxsKTsKLSAgICAgICAgICAgICAgICAgICAg aWYgKG1vc3RSZWNlbnRGaW5pc2hlZEl0ZXJhdGlvbi5mYWlsZWQpIHsKKyAgICAgICAgICAgICAg ICAgICAgaWYgKCFtb3N0UmVjZW50RmluaXNoZWRJdGVyYXRpb24ucHJvZHVjdGl2ZSkKKyAgICAg ICAgICAgICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBTdGF0dXNMaW5lVmlldy5TdGF0dXMuRGFu Z2VyOworICAgICAgICAgICAgICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAgICAgICAgICAg IC8vIERpcmVjdCBsaW5rcyB0byBzb21lIGNvbW1vbiBsb2dzLgogICAgICAgICAgICAgICAgICAg ICAgICAgdmFyIHVybCA9IG1vc3RSZWNlbnRGaW5pc2hlZEl0ZXJhdGlvbi5mYWlsdXJlTG9nVVJM KCJidWlsZCBsb2ciKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghdXJsKQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVybCA9IG1vc3RSZWNlbnRGaW5pc2hlZEl0ZXJhdGlvbi5m YWlsdXJlTG9nVVJMKCJzdGRpbyIpOwogICAgICAgICAgICAgICAgICAgICAgICAgdmFyIHN0YXR1 cyA9IFN0YXR1c0xpbmVWaWV3LlN0YXR1cy5CYWQ7Ci0gICAgICAgICAgICAgICAgICAgIH0gZWxz ZQotICAgICAgICAgICAgICAgICAgICAgICAgdmFyIHN0YXR1cyA9IFN0YXR1c0xpbmVWaWV3LlN0 YXR1cy5EYW5nZXI7CisgICAgICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgICAgICAg ICAvLyBTaG93IGEgcG9wb3ZlciB3aGVuIHRoZSBVUkwgaXMgbm90IGEgbWFpbiBidWlsZCBwYWdl IG9uZSwgYmVjYXVzZSB0aGVyZSBhcmUgdXN1YWxseSBtdWx0aXBsZSBsb2dzLCBhbmQgaXQncyBn b29kIHRvIHByb3ZpZGUgYSBjaG9pY2UuCiAgICAgICAgICAgICAgICAgICAgIHZhciBuZWVkc1Bv cG92ZXIgPSAhdXJsOwo=