148331 2015-08-21 14:35:51 -0700 DFG::PutStackSinkingPhase doesn't need to emit KillStack nodes 2015-08-21 14:44:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other All All RESOLVED FIXED P2 Normal --- 145204 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb msaboff nrotem oliver saam sam oldest_to_newest 1119924 0 fpizlo 2015-08-21 14:35:51 -0700 PutStackSinkingPhase currently emits KillStack nodes when it sinks a PutStack. This isn't necessary because KillStack is only interesting for OSR exit, and PutStack nodes that are relevant to OSR will already be preceded by a KillStack/MovHint pair. 1119926 1 259660 fpizlo 2015-08-21 14:37:43 -0700 Created attachment 259660 the patch 1119929 2 259660 ggaren 2015-08-21 14:39:25 -0700 Comment on attachment 259660 the patch r=me 1119933 3 fpizlo 2015-08-21 14:44:46 -0700 Landed in http://trac.webkit.org/changeset/188776 259660 2015-08-21 14:37:43 -0700 2015-08-21 14:39:25 -0700 the patch blah.patch text/plain 2088 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4NzcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA4LTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpQdXRTdGFja1NpbmtpbmdQaGFzZSBkb2Vzbid0IG5lZWQgdG8gZW1pdCBLaWxsU3RhY2sg bm9kZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 ODMzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFB1 dFN0YWNrU2lua2luZ1BoYXNlIHByZXZpb3VzbHkgZW1pdHRlZCBhIEtpbGxTdGFjayBub2RlIHdo ZW4gaXQgc2FuayBhIFB1dFN0YWNrLiBUaGlzCisgICAgICAgIGlzbid0IG5lY2Vzc2FyeSBiZWNh dXNlIEtpbGxTdGFjayBpcyBvbmx5IGludGVyZXN0aW5nIGZvciBPU1IgZXhpdCwgYW5kIFB1dFN0 YWNrIG5vZGVzCisgICAgICAgIHRoYXQgYXJlIHJlbGV2YW50IHRvIE9TUiB3aWxsIGFscmVhZHkg YmUgcHJlY2VkZWQgYnkgYSBLaWxsU3RhY2svTW92SGludCBwYWlyLgorCisgICAgICAgICogZGZn L0RGR1B1dFN0YWNrU2lua2luZ1BoYXNlLmNwcDoKKwogMjAxNS0wOC0yMSAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERGRzo6Tm9kZU9yaWdpbiBzaG91bGQgaGF2 ZSBhIGZsYWcgZGV0ZXJtaW5pbmcgaWYgZXhpdGluZyBpcyBPSyByaWdodCBub3cKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHV0U3RhY2tTaW5raW5nUGhhc2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHV0U3RhY2tTaW5raW5nUGhh c2UuY3BwCShyZXZpc2lvbiAxODg3NzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1B1dFN0YWNrU2lua2luZ1BoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTE2LDggKzUxNiw3 IEBAIHB1YmxpYzoKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgLy8gRmluYWxseSBlbGlt aW5hdGUgdGhlIHN1bmtlbiBQdXRTdGFja3MgYnkgdHVybmluZyB0aGVtIGludG8gQ2hlY2tzLiBU aGlzIGtlZXBzIHdoYXRldmVyCi0gICAgICAgIC8vIHR5cGUgY2hlY2sgdGhleSB3ZXJlIGRvaW5n LiBBbHNvIHByZXBlbmQgS2lsbFN0YWNrcyB0byB0aGVtIHRvIGVuc3VyZSB0aGF0IHdlIGtub3cg dGhhdAotICAgICAgICAvLyB0aGUgcmVsZXZhbnQgdmFsdWUgd2FzICpub3QqIHN0b3JlZCB0byB0 aGUgc3RhY2suCisgICAgICAgIC8vIHR5cGUgY2hlY2sgdGhleSB3ZXJlIGRvaW5nLgogICAgICAg ICBmb3IgKEJhc2ljQmxvY2sqIGJsb2NrIDogbV9ncmFwaC5ibG9ja3NJbk5hdHVyYWxPcmRlcigp KSB7CiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIG5vZGVJbmRleCA9IDA7IG5vZGVJbmRleCA8 IGJsb2NrLT5zaXplKCk7ICsrbm9kZUluZGV4KSB7CiAgICAgICAgICAgICAgICAgTm9kZSogbm9k ZSA9IGJsb2NrLT5hdChub2RlSW5kZXgpOwpAQCAtNTI1LDggKzUyNCw2IEBAIHB1YmxpYzoKICAg ICAgICAgICAgICAgICBpZiAoIXB1dExvY2Fsc1RvU2luay5jb250YWlucyhub2RlKSkKICAgICAg ICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAg ICAgaW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCi0gICAgICAgICAgICAgICAgICAgIG5vZGVJbmRl eCwgU3BlY05vbmUsIEtpbGxTdGFjaywgbm9kZS0+b3JpZ2luLCBPcEluZm8obm9kZS0+c3RhY2tB Y2Nlc3NEYXRhKCktPmxvY2FsLm9mZnNldCgpKSk7CiAgICAgICAgICAgICAgICAgbm9kZS0+cmVt b3ZlKCk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAK