148320 2015-08-21 12:17:29 -0700 Layout Test streams/reference-implementation/readable-stream.html is flaky 2015-08-28 03:03:07 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton calvaris benjamin calvaris commit-queue darin youennf oldest_to_newest 1119855 0 thorton 2015-08-21 12:17:29 -0700 The following layout test recently started flaking on Mac: streams/reference-implementation/readable-stream.html See: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=streams%2Freference-implementation%2Freadable-stream.html 1119856 1 thorton 2015-08-21 12:17:55 -0700 Youenn, this looks like a feature you've been working on. Any ideas why this might have recently started flaking? 1119871 2 youennf 2015-08-21 12:41:45 -0700 Tim, thanks for spotting these flakiness. Calvaris, it seems the changes brought on the tests when inverting the order of the promise resolution have some bad effects. Will you have some time to check these? 1120248 3 calvaris 2015-08-24 01:09:47 -0700 (In reply to comment #2) > Tim, thanks for spotting these flakiness. > Calvaris, it seems the changes brought on the tests when inverting the order > of the promise resolution have some bad effects. Will you have some time to > check these? Sure, I'm on it now. 1120278 4 259755 calvaris 2015-08-24 09:21:24 -0700 Created attachment 259755 Patch It is true that timeout hitting earlier happens a bit more often after the promise changes but it was already happening before aparently. Let's try to increase the timeout and see if the problem disappears. 1120308 5 youennf 2015-08-24 11:05:42 -0700 (In reply to comment #4) > Created attachment 259755 [details] > Patch > > It is true that timeout hitting earlier happens a bit more often after the > promise changes but it was already happening before aparently. Let's try to > increase the timeout and see if the problem disappears. Then, maybe we could rewrite the test cases a bit to reduce the flakiness probability. In particular we could call setTimeout at the latest time. For instance, in test 6, we could move the call to setTimeout within startPromise.then() callback. 1120447 6 259791 calvaris 2015-08-24 16:30:11 -0700 Created attachment 259791 Patch Set timeouts later as suggested by Youenn. I thought of that too but I was reluctant because we'd lose the structure of the original reference test, but I decided to add a comment to help with that. 1121330 7 calvaris 2015-08-27 09:52:44 -0700 This flakiness seemed important. Can we get this reviewed? 1121343 8 259791 ap 2015-08-27 10:30:20 -0700 Comment on attachment 259791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259791&action=review Sad, but looks like there is no other way to test for this. > LayoutTests/streams/reference-implementation/readable-stream.html:273 > + // In the original test this timeout is outside the promise fulfillment callback, but it makes test flakier so > + // we better move it inside here. This comment is not helpful without a reference to original. Are we modifying a W3C test here? I would just remove the comment (and other copies of it) unless there is a really important reason for it - otherwise anyone interested can just blame the source to see history. 1121401 9 youennf 2015-08-27 13:44:15 -0700 If feasible, one option might be to backport these changes to the reference tests. 1121640 10 260141 calvaris 2015-08-28 01:55:03 -0700 Created attachment 260141 Patch for landing 1121643 11 calvaris 2015-08-28 01:55:53 -0700 (In reply to comment #9) > If feasible, one option might be to backport these changes to the reference > tests. I'll propose the change, let's see if Domenic accepts it. 1121654 12 260141 commit-queue 2015-08-28 02:48:59 -0700 Comment on attachment 260141 Patch for landing Clearing flags on attachment: 260141 Committed r189093: <http://trac.webkit.org/changeset/189093> 1121655 13 commit-queue 2015-08-28 02:49:02 -0700 All reviewed patches have been landed. Closing bug. 1121656 14 calvaris 2015-08-28 03:03:07 -0700 (In reply to comment #11) > (In reply to comment #9) > > If feasible, one option might be to backport these changes to the reference > > tests. > > I'll propose the change, let's see if Domenic accepts it. Done: https://github.com/whatwg/streams/pull/392 259755 2015-08-24 09:21:24 -0700 2015-08-24 16:30:06 -0700 Patch bug-148320-20150824182114.patch text/plain 2165 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NjkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODVmZTJmZmY0ZmJiNmEwMGUxMzMy OTgxODExYzE2NDg0NzFhOGRlMS4uNTcwM2MzNzNkYjNhNWFmNTIzM2U2MTAxOThjOGM5ZGNiMDNh NjY4NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4LTI0ICBYYWJpZXIgUm9kcmlndWV6 IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Qgc3Ry ZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLmh0bWwgaXMgZmxh a3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODMy MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3Ry ZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLmh0bWw6IEluY3Jl YXNlIHRpbWVvdXQgb2YgdGhyZWUgdGVzdHMgdG8gbWFrZSB0aGVtIGxlc3MKKyAgICAgICAgbGlr ZWx5IHRvIGZhaWwuCisKIDIwMTUtMDgtMjAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIFRyZWF0IEVwb2NoIGFzIGludmFsaWQgdmFsdWUgZm9yICJM YXN0LU1vZGlmaWVkIiBoZWFkZXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0cmVhbXMvcmVm ZXJlbmNlLWltcGxlbWVudGF0aW9uL3JlYWRhYmxlLXN0cmVhbS5odG1sIGIvTGF5b3V0VGVzdHMv c3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLmh0bWwKaW5k ZXggNjg5NzM0MGY5NDFiNzc3OGQ2ZWEyOTVjYjQ4YWVmODgyMjc3ZjIxNy4uMjE4MzhiZTYzZDg0 N2U3ZWU5MzRlYTMwYjIxYzA1MTk5YjAxZjcxMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3Ry ZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3Ry ZWFtLmh0bWwKQEAgLTI3Myw3ICsyNzMsNyBAQCB0ZXN0Ni5zdGVwKGZ1bmN0aW9uKCkgewogICAg IHNldFRpbWVvdXQodGVzdDYuc3RlcF9mdW5jKGZ1bmN0aW9uKCkgewogICAgICAgICBhc3NlcnRf ZXF1YWxzKHB1bGxDb3VudCwgMSwgJ3B1bGwgc2hvdWxkIGJlIGNhbGxlZCBleGFjdGx5IG9uY2Un KTsKICAgICAgICAgdGVzdDYuZG9uZSgpOwotICAgIH0pLCAxMDAwKTsKKyAgICB9KSwgMTUwMCk7 CiB9KTsKIAogdmFyIHRlc3Q3ID0gYXN5bmNfdGVzdCgnUmVhZGFibGVTdHJlYW06IHNob3VsZCBj YWxsIHB1bGwgd2hlbiB0cnlpbmcgdG8gcmVhZCBmcm9tIGEgc3RhcnRlZCwgZW1wdHkgc3RyZWFt Jyk7CkBAIC0zMzQsNyArMzM0LDcgQEAgdGVzdDguc3RlcChmdW5jdGlvbigpIHsKICAgICBzZXRU aW1lb3V0KHRlc3Q4LnN0ZXBfZnVuYyhmdW5jdGlvbigpIHsKICAgICAgICAgYXNzZXJ0X2VxdWFs cyhwdWxsQ291bnQsIDEsICdwdWxsIHNob3VsZCBiZSBjYWxsZWQgZXhhY3RseSBvbmNlJyk7CiAg ICAgICAgIHRlc3Q4LmRvbmUoKTsKLSAgICB9KSwgMTAwMCk7CisgICAgfSksIDE1MDApOwogfSk7 CiAKIHZhciB0ZXN0OSA9IGFzeW5jX3Rlc3QoJ1JlYWRhYmxlU3RyZWFtOiBzaG91bGQgb25seSBj YWxsIHB1bGwgb25jZSBvbiBhIG5vbi1lbXB0eSBzdHJlYW0gcmVhZCBmcm9tIGFmdGVyIHN0YXJ0 IGZ1bGZpbGxzJyk7CkBAIC01NDYsNyArNTQ2LDcgQEAgdGVzdDE0LnN0ZXAoZnVuY3Rpb24oKSB7 CiAgICAgICAgIC8vIGFmdGVyIGVucXVldWUoNCk6IHNpemUgPSA0LCBkbyBub3QgcHVsbAogICAg ICAgICBhc3NlcnRfZXF1YWxzKHRpbWVzQ2FsbGVkLCA0LCAncHVsbCgpIHNob3VsZCBoYXZlIGJl ZW4gY2FsbGVkIGZvdXIgdGltZXMnKTsKICAgICAgICAgdGVzdDE0LmRvbmUoKTsKLSAgICB9KSwg MTAwMCk7CisgICAgfSksIDE1MDApOwogfSk7CiAKIHZhciB0ZXN0MTUgPSBhc3luY190ZXN0KCdS ZWFkYWJsZVN0cmVhbSBwdWxsIHNob3VsZCBiZSBhYmxlIHRvIGNsb3NlIGEgc3RyZWFtLicpOwo= 259791 2015-08-24 16:30:11 -0700 2015-08-28 01:54:56 -0700 Patch bug-148320-20150825013002.patch text/plain 4514 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NjkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODVmZTJmZmY0ZmJiNmEwMGUxMzMy OTgxODExYzE2NDg0NzFhOGRlMS4uYzBlNGEwODVmNDk0OWZlYzQ0NGUzMzJlZWU2ZjJhNGNkN2Fl MDE2OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4LTI0ICBYYWJpZXIgUm9kcmlndWV6 IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Qgc3Ry ZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLmh0bWwgaXMgZmxh a3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODMy MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3Ry ZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLmh0bWw6IFNldCB0 aGUgdGltZW91dHMgYXQgdGhlIGxhc3QgbW9tZW50IHNvIHRoYXQgaXQgaXMgbGVzcworICAgICAg ICBsaWtlbHkgdG8gaGl0IHRoZW0gZWFybGllciB0aGF0IHdlIHNob3VsZC4KKwogMjAxNS0wOC0y MCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gVHJl YXQgRXBvY2ggYXMgaW52YWxpZCB2YWx1ZSBmb3IgIkxhc3QtTW9kaWZpZWQiIGhlYWRlcgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVh ZGFibGUtc3RyZWFtLmh0bWwgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1l bnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0uaHRtbAppbmRleCA2ODk3MzQwZjk0MWI3Nzc4ZDZlYTI5 NWNiNDhhZWY4ODIyNzdmMjE3Li4xNDM4NGJiODNiNzhjOGQzZDViMjM0OGUxOWIyMGNiMWQ1ZGVj ZTljIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRh dGlvbi9yZWFkYWJsZS1zdHJlYW0uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVy ZW5jZS1pbXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0uaHRtbApAQCAtMjY4LDEyICsyNjgs MTUgQEAgdGVzdDYuc3RlcChmdW5jdGlvbigpIHsKIAogICAgIHN0YXJ0UHJvbWlzZS50aGVuKHRl c3Q2LnN0ZXBfZnVuYyhmdW5jdGlvbigpIHsKICAgICAgICAgYXNzZXJ0X2VxdWFscyhwdWxsQ291 bnQsIDEsICdwdWxsIHNob3VsZCBiZSBjYWxsZWQgb25jZSBzdGFydCBmaW5pc2hlcycpOworCisg ICAgICAgIC8vIEluIHRoZSBvcmlnaW5hbCB0ZXN0IHRoaXMgdGltZW91dCBpcyBvdXRzaWRlIHRo ZSBwcm9taXNlIGZ1bGZpbGxtZW50IGNhbGxiYWNrLCBidXQgaXQgbWFrZXMgdGVzdCBmbGFraWVy IHNvCisgICAgICAgIC8vIHdlIGJldHRlciBtb3ZlIGl0IGluc2lkZSBoZXJlLgorICAgICAgICBz ZXRUaW1lb3V0KHRlc3Q2LnN0ZXBfZnVuYyhmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGFzc2Vy dF9lcXVhbHMocHVsbENvdW50LCAxLCAncHVsbCBzaG91bGQgYmUgY2FsbGVkIGV4YWN0bHkgb25j ZScpOworICAgICAgICAgICAgdGVzdDYuZG9uZSgpOworICAgICAgICB9KSwgMTAwMCk7CiAgICAg fSkpOwogCi0gICAgc2V0VGltZW91dCh0ZXN0Ni5zdGVwX2Z1bmMoZnVuY3Rpb24oKSB7Ci0gICAg ICAgIGFzc2VydF9lcXVhbHMocHVsbENvdW50LCAxLCAncHVsbCBzaG91bGQgYmUgY2FsbGVkIGV4 YWN0bHkgb25jZScpOwotICAgICAgICB0ZXN0Ni5kb25lKCk7Ci0gICAgfSksIDEwMDApOwogfSk7 CiAKIHZhciB0ZXN0NyA9IGFzeW5jX3Rlc3QoJ1JlYWRhYmxlU3RyZWFtOiBzaG91bGQgY2FsbCBw dWxsIHdoZW4gdHJ5aW5nIHRvIHJlYWQgZnJvbSBhIHN0YXJ0ZWQsIGVtcHR5IHN0cmVhbScpOwpA QCAtMzI3LDE0ICszMzAsMTYgQEAgdGVzdDguc3RlcChmdW5jdGlvbigpIHsKICAgICBycy5nZXRS ZWFkZXIoKS5yZWFkKCkudGhlbih0ZXN0OC5zdGVwX2Z1bmMoZnVuY3Rpb24ocikgewogICAgICAg ICBhc3NlcnRfb2JqZWN0X2VxdWFscyhyLCB7IHZhbHVlOiAnYScsIGRvbmU6IGZhbHNlIH0sICdm aXJzdCByZWFkKCkgc2hvdWxkIHJldHVybiBmaXJzdCBjaHVuaycpOwogICAgICAgICBhc3NlcnRf ZXF1YWxzKHB1bGxDb3VudCwgMSwgJ3B1bGwgc2hvdWxkIG5vdCBoYXZlIGJlZW4gY2FsbGVkIGFn YWluJyk7CisKKyAgICAgICAgLy8gSW4gdGhlIG9yaWdpbmFsIHRlc3QgdGhpcyB0aW1lb3V0IGlz IG91dHNpZGUgdGhlIHByb21pc2UgZnVsZmlsbG1lbnQgY2FsbGJhY2ssIGJ1dCBpdCBtYWtlcyB0 ZXN0IGZsYWtpZXIgc28KKyAgICAgICAgLy8gd2UgYmV0dGVyIG1vdmUgaXQgaW5zaWRlIGhlcmUu CisgICAgICAgIHNldFRpbWVvdXQodGVzdDguc3RlcF9mdW5jKGZ1bmN0aW9uKCkgeworICAgICAg ICAgICAgYXNzZXJ0X2VxdWFscyhwdWxsQ291bnQsIDEsICdwdWxsIHNob3VsZCBiZSBjYWxsZWQg ZXhhY3RseSBvbmNlJyk7CisgICAgICAgICAgICB0ZXN0OC5kb25lKCk7CisgICAgICAgIH0pLCAx MDAwKTsKICAgICB9KSk7CiAKICAgICBhc3NlcnRfZXF1YWxzKHB1bGxDb3VudCwgMCwgJ2NhbGxp bmcgcmVhZCgpIHNob3VsZCBub3QgY2F1c2UgcHVsbCB0byBiZSBjYWxsZWQgeWV0Jyk7Ci0KLSAg ICBzZXRUaW1lb3V0KHRlc3Q4LnN0ZXBfZnVuYyhmdW5jdGlvbigpIHsKLSAgICAgICAgYXNzZXJ0 X2VxdWFscyhwdWxsQ291bnQsIDEsICdwdWxsIHNob3VsZCBiZSBjYWxsZWQgZXhhY3RseSBvbmNl Jyk7Ci0gICAgICAgIHRlc3Q4LmRvbmUoKTsKLSAgICB9KSwgMTAwMCk7CiB9KTsKIAogdmFyIHRl c3Q5ID0gYXN5bmNfdGVzdCgnUmVhZGFibGVTdHJlYW06IHNob3VsZCBvbmx5IGNhbGwgcHVsbCBv bmNlIG9uIGEgbm9uLWVtcHR5IHN0cmVhbSByZWFkIGZyb20gYWZ0ZXIgc3RhcnQgZnVsZmlsbHMn KTsKQEAgLTUyOSw2ICs1MzQsMjAgQEAgdGVzdDE0LnN0ZXAoZnVuY3Rpb24oKSB7CiAgICAgICAg IH0sCiAgICAgICAgIHB1bGw6IGZ1bmN0aW9uKGMpIHsKICAgICAgICAgICAgIGMuZW5xdWV1ZSgr K3RpbWVzQ2FsbGVkKTsKKworICAgICAgICAgICAgaWYgKHRpbWVzQ2FsbGVkID09IDQpIHsKKyAg ICAgICAgICAgICAgICAvLyBJbiB0aGUgb3JpZ2luYWwgdGVzdCB0aGlzIHRpbWVvdXQgaXMgb3V0 c2lkZSB0aGUgcHJvbWlzZSBmdWxmaWxsbWVudCBjYWxsYmFjaywgYnV0IGl0IG1ha2VzIHRlc3QK KyAgICAgICAgICAgICAgICAvLyBmbGFraWVyIHNvIHdlIGJldHRlciBtb3ZlIGl0IGluc2lkZSBo ZXJlLgorICAgICAgICAgICAgICAgIHNldFRpbWVvdXQodGVzdDE0LnN0ZXBfZnVuYyhmdW5jdGlv bigpIHsKKyAgICAgICAgICAgICAgICAgICAgLy8gYWZ0ZXIgc3RhcnQ6IHNpemUgPSAwLCBwdWxs KCkKKyAgICAgICAgICAgICAgICAgICAgLy8gYWZ0ZXIgZW5xdWV1ZSgxKTogc2l6ZSA9IDEsIHB1 bGwoKQorICAgICAgICAgICAgICAgICAgICAvLyBhZnRlciBlbnF1ZXVlKDIpOiBzaXplID0gMiwg cHVsbCgpCisgICAgICAgICAgICAgICAgICAgIC8vIGFmdGVyIGVucXVldWUoMyk6IHNpemUgPSAz LCBwdWxsKCkKKyAgICAgICAgICAgICAgICAgICAgLy8gYWZ0ZXIgZW5xdWV1ZSg0KTogc2l6ZSA9 IDQsIGRvIG5vdCBwdWxsCisgICAgICAgICAgICAgICAgICAgIGFzc2VydF9lcXVhbHModGltZXND YWxsZWQsIDQsICdwdWxsKCkgc2hvdWxkIGhhdmUgYmVlbiBjYWxsZWQgZm91ciB0aW1lcycpOwor ICAgICAgICAgICAgICAgICAgICB0ZXN0MTQuZG9uZSgpOworICAgICAgICAgICAgICAgIH0pLCAx MDAwKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0sCiAgICAgewpAQCAtNTM3LDE2 ICs1NTYsNiBAQCB0ZXN0MTQuc3RlcChmdW5jdGlvbigpIHsKICAgICAgICAgfSwKICAgICAgICAg aGlnaFdhdGVyTWFyazogNAogICAgIH0pOwotCi0gICAgc2V0VGltZW91dCh0ZXN0MTQuc3RlcF9m dW5jKGZ1bmN0aW9uKCkgewotICAgICAgICAvLyBhZnRlciBzdGFydDogc2l6ZSA9IDAsIHB1bGwo KQotICAgICAgICAvLyBhZnRlciBlbnF1ZXVlKDEpOiBzaXplID0gMSwgcHVsbCgpCi0gICAgICAg IC8vIGFmdGVyIGVucXVldWUoMik6IHNpemUgPSAyLCBwdWxsKCkKLSAgICAgICAgLy8gYWZ0ZXIg ZW5xdWV1ZSgzKTogc2l6ZSA9IDMsIHB1bGwoKQotICAgICAgICAvLyBhZnRlciBlbnF1ZXVlKDQp OiBzaXplID0gNCwgZG8gbm90IHB1bGwKLSAgICAgICAgYXNzZXJ0X2VxdWFscyh0aW1lc0NhbGxl ZCwgNCwgJ3B1bGwoKSBzaG91bGQgaGF2ZSBiZWVuIGNhbGxlZCBmb3VyIHRpbWVzJyk7Ci0gICAg ICAgIHRlc3QxNC5kb25lKCk7Ci0gICAgfSksIDEwMDApOwogfSk7CiAKIHZhciB0ZXN0MTUgPSBh c3luY190ZXN0KCdSZWFkYWJsZVN0cmVhbSBwdWxsIHNob3VsZCBiZSBhYmxlIHRvIGNsb3NlIGEg c3RyZWFtLicpOwo= 260141 2015-08-28 01:55:03 -0700 2015-08-28 02:48:59 -0700 Patch for landing bug-148320-20150828105449.patch text/plain 4003 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MDg4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODQ3MmEzNWQ1YzRjNzc4NDNhYTIw MjNjN2JmOTQ4ZDQxYzczYmYxMS4uN2VlMWU1ZGMxZmUxNDg0NGIzNGFiNGVjOTEwNGY5NzBmM2Ux MDVlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA4LTI4ICBYYWJpZXIgUm9kcmlndWV6 IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3Qgc3Ry ZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLmh0bWwgaXMgZmxh a3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODMy MAorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAg KiBzdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0uaHRtbDog U2V0IHRoZSB0aW1lb3V0cyBhdCB0aGUgbGFzdCBtb21lbnQgc28gdGhhdCBpdCBpcyBsZXNzCisg ICAgICAgIGxpa2VseSB0byBoaXQgdGhlbSBlYXJsaWVyIHRoYXQgd2Ugc2hvdWxkLgorCiAyMDE1 LTA4LTI3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTg5MDY0IGFuZCByMTg5MDg0LgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUt c3RyZWFtLmh0bWwgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlv bi9yZWFkYWJsZS1zdHJlYW0uaHRtbAppbmRleCA2ODk3MzQwZjk0MWI3Nzc4ZDZlYTI5NWNiNDhh ZWY4ODIyNzdmMjE3Li5jNGU2MDEzNzM5ZDhhZTQzNWY0YjIyMTRhYTAyYTliNTBlMmYwNDI2IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9y ZWFkYWJsZS1zdHJlYW0uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1p bXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0uaHRtbApAQCAtMjY4LDEyICsyNjgsMTMgQEAg dGVzdDYuc3RlcChmdW5jdGlvbigpIHsKIAogICAgIHN0YXJ0UHJvbWlzZS50aGVuKHRlc3Q2LnN0 ZXBfZnVuYyhmdW5jdGlvbigpIHsKICAgICAgICAgYXNzZXJ0X2VxdWFscyhwdWxsQ291bnQsIDEs ICdwdWxsIHNob3VsZCBiZSBjYWxsZWQgb25jZSBzdGFydCBmaW5pc2hlcycpOworCisgICAgICAg IHNldFRpbWVvdXQodGVzdDYuc3RlcF9mdW5jKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgYXNz ZXJ0X2VxdWFscyhwdWxsQ291bnQsIDEsICdwdWxsIHNob3VsZCBiZSBjYWxsZWQgZXhhY3RseSBv bmNlJyk7CisgICAgICAgICAgICB0ZXN0Ni5kb25lKCk7CisgICAgICAgIH0pLCAxMDAwKTsKICAg ICB9KSk7CiAKLSAgICBzZXRUaW1lb3V0KHRlc3Q2LnN0ZXBfZnVuYyhmdW5jdGlvbigpIHsKLSAg ICAgICAgYXNzZXJ0X2VxdWFscyhwdWxsQ291bnQsIDEsICdwdWxsIHNob3VsZCBiZSBjYWxsZWQg ZXhhY3RseSBvbmNlJyk7Ci0gICAgICAgIHRlc3Q2LmRvbmUoKTsKLSAgICB9KSwgMTAwMCk7CiB9 KTsKIAogdmFyIHRlc3Q3ID0gYXN5bmNfdGVzdCgnUmVhZGFibGVTdHJlYW06IHNob3VsZCBjYWxs IHB1bGwgd2hlbiB0cnlpbmcgdG8gcmVhZCBmcm9tIGEgc3RhcnRlZCwgZW1wdHkgc3RyZWFtJyk7 CkBAIC0zMjcsMTQgKzMyOCwxNCBAQCB0ZXN0OC5zdGVwKGZ1bmN0aW9uKCkgewogICAgIHJzLmdl dFJlYWRlcigpLnJlYWQoKS50aGVuKHRlc3Q4LnN0ZXBfZnVuYyhmdW5jdGlvbihyKSB7CiAgICAg ICAgIGFzc2VydF9vYmplY3RfZXF1YWxzKHIsIHsgdmFsdWU6ICdhJywgZG9uZTogZmFsc2UgfSwg J2ZpcnN0IHJlYWQoKSBzaG91bGQgcmV0dXJuIGZpcnN0IGNodW5rJyk7CiAgICAgICAgIGFzc2Vy dF9lcXVhbHMocHVsbENvdW50LCAxLCAncHVsbCBzaG91bGQgbm90IGhhdmUgYmVlbiBjYWxsZWQg YWdhaW4nKTsKKworICAgICAgICBzZXRUaW1lb3V0KHRlc3Q4LnN0ZXBfZnVuYyhmdW5jdGlvbigp IHsKKyAgICAgICAgICAgIGFzc2VydF9lcXVhbHMocHVsbENvdW50LCAxLCAncHVsbCBzaG91bGQg YmUgY2FsbGVkIGV4YWN0bHkgb25jZScpOworICAgICAgICAgICAgdGVzdDguZG9uZSgpOworICAg ICAgICB9KSwgMTAwMCk7CiAgICAgfSkpOwogCiAgICAgYXNzZXJ0X2VxdWFscyhwdWxsQ291bnQs IDAsICdjYWxsaW5nIHJlYWQoKSBzaG91bGQgbm90IGNhdXNlIHB1bGwgdG8gYmUgY2FsbGVkIHll dCcpOwotCi0gICAgc2V0VGltZW91dCh0ZXN0OC5zdGVwX2Z1bmMoZnVuY3Rpb24oKSB7Ci0gICAg ICAgIGFzc2VydF9lcXVhbHMocHVsbENvdW50LCAxLCAncHVsbCBzaG91bGQgYmUgY2FsbGVkIGV4 YWN0bHkgb25jZScpOwotICAgICAgICB0ZXN0OC5kb25lKCk7Ci0gICAgfSksIDEwMDApOwogfSk7 CiAKIHZhciB0ZXN0OSA9IGFzeW5jX3Rlc3QoJ1JlYWRhYmxlU3RyZWFtOiBzaG91bGQgb25seSBj YWxsIHB1bGwgb25jZSBvbiBhIG5vbi1lbXB0eSBzdHJlYW0gcmVhZCBmcm9tIGFmdGVyIHN0YXJ0 IGZ1bGZpbGxzJyk7CkBAIC01MjksNiArNTMwLDE4IEBAIHRlc3QxNC5zdGVwKGZ1bmN0aW9uKCkg ewogICAgICAgICB9LAogICAgICAgICBwdWxsOiBmdW5jdGlvbihjKSB7CiAgICAgICAgICAgICBj LmVucXVldWUoKyt0aW1lc0NhbGxlZCk7CisKKyAgICAgICAgICAgIGlmICh0aW1lc0NhbGxlZCA9 PSA0KSB7CisgICAgICAgICAgICAgICAgc2V0VGltZW91dCh0ZXN0MTQuc3RlcF9mdW5jKGZ1bmN0 aW9uKCkgeworICAgICAgICAgICAgICAgICAgICAvLyBhZnRlciBzdGFydDogc2l6ZSA9IDAsIHB1 bGwoKQorICAgICAgICAgICAgICAgICAgICAvLyBhZnRlciBlbnF1ZXVlKDEpOiBzaXplID0gMSwg cHVsbCgpCisgICAgICAgICAgICAgICAgICAgIC8vIGFmdGVyIGVucXVldWUoMik6IHNpemUgPSAy LCBwdWxsKCkKKyAgICAgICAgICAgICAgICAgICAgLy8gYWZ0ZXIgZW5xdWV1ZSgzKTogc2l6ZSA9 IDMsIHB1bGwoKQorICAgICAgICAgICAgICAgICAgICAvLyBhZnRlciBlbnF1ZXVlKDQpOiBzaXpl ID0gNCwgZG8gbm90IHB1bGwKKyAgICAgICAgICAgICAgICAgICAgYXNzZXJ0X2VxdWFscyh0aW1l c0NhbGxlZCwgNCwgJ3B1bGwoKSBzaG91bGQgaGF2ZSBiZWVuIGNhbGxlZCBmb3VyIHRpbWVzJyk7 CisgICAgICAgICAgICAgICAgICAgIHRlc3QxNC5kb25lKCk7CisgICAgICAgICAgICAgICAgfSks IDEwMDApOworICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfSwKICAgICB7CkBAIC01Mzcs MTYgKzU1MCw2IEBAIHRlc3QxNC5zdGVwKGZ1bmN0aW9uKCkgewogICAgICAgICB9LAogICAgICAg ICBoaWdoV2F0ZXJNYXJrOiA0CiAgICAgfSk7Ci0KLSAgICBzZXRUaW1lb3V0KHRlc3QxNC5zdGVw X2Z1bmMoZnVuY3Rpb24oKSB7Ci0gICAgICAgIC8vIGFmdGVyIHN0YXJ0OiBzaXplID0gMCwgcHVs bCgpCi0gICAgICAgIC8vIGFmdGVyIGVucXVldWUoMSk6IHNpemUgPSAxLCBwdWxsKCkKLSAgICAg ICAgLy8gYWZ0ZXIgZW5xdWV1ZSgyKTogc2l6ZSA9IDIsIHB1bGwoKQotICAgICAgICAvLyBhZnRl ciBlbnF1ZXVlKDMpOiBzaXplID0gMywgcHVsbCgpCi0gICAgICAgIC8vIGFmdGVyIGVucXVldWUo NCk6IHNpemUgPSA0LCBkbyBub3QgcHVsbAotICAgICAgICBhc3NlcnRfZXF1YWxzKHRpbWVzQ2Fs bGVkLCA0LCAncHVsbCgpIHNob3VsZCBoYXZlIGJlZW4gY2FsbGVkIGZvdXIgdGltZXMnKTsKLSAg ICAgICAgdGVzdDE0LmRvbmUoKTsKLSAgICB9KSwgMTAwMCk7CiB9KTsKIAogdmFyIHRlc3QxNSA9 IGFzeW5jX3Rlc3QoJ1JlYWRhYmxlU3RyZWFtIHB1bGwgc2hvdWxkIGJlIGFibGUgdG8gY2xvc2Ug YSBzdHJlYW0uJyk7Cg==