148285 2015-08-20 20:06:28 -0700 Web Inspector: Better Remember open tab types and order if using JSContext inspector 2015-08-20 21:22:45 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119612 0 joepeck 2015-08-20 20:06:28 -0700 * SUMMARY Better Remember open tab types and order if using JSContext inspector. * STEPS TO REPRODUCE 1. Open Web Inspector and all tabs 2. Close Web Inspector 3. Open JSContext Inspector (note some tabs are closed) 4. Close and Reopen a tab (to re-save modified list) 5. Open Web Inspector => Missing all Web tabs that should have been open (elements, network, timeline) * NOTES - We should remember unsupported tab types in the setting, and their regular index 1119613 1 webkit-bug-importer 2015-08-20 20:06:58 -0700 <rdar://problem/22374231> 1119626 2 259577 joepeck 2015-08-20 20:21:28 -0700 Created attachment 259577 [PATCH] Proposed Fix 1119646 3 259577 commit-queue 2015-08-20 21:22:42 -0700 Comment on attachment 259577 [PATCH] Proposed Fix Clearing flags on attachment: 259577 Committed r188750: <http://trac.webkit.org/changeset/188750> 1119647 4 commit-queue 2015-08-20 21:22:45 -0700 All reviewed patches have been landed. Closing bug. 259577 2015-08-20 20:21:28 -0700 2015-08-20 21:22:42 -0700 [PATCH] Proposed Fix restore-tabs.patch text/plain 4283 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZlM2RkNjIuLjNlZjhiZmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTA4LTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQmV0dGVy IFJlbWVtYmVyIG9wZW4gdGFiIHR5cGVzIGFuZCBvcmRlciBpZiB1c2luZyBKU0NvbnRleHQgaW5z cGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDgyODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmNvbnRl bnRMb2FkZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmFjdGl2YXRlRXh0cmFEb21haW5zKToK KyAgICAgICAgU2F2ZSBhbmQgcmVzdG9yZSBleHRyYSBkb21haW4gcmVsYXRlZCB0YWJzIGF0IHRo ZSBleHBlY3RlZCBzYXZlZCBpbmRleC4KKworICAgICAgICAoV2ViSW5zcGVjdG9yLl9yZW1lbWJl ck9wZW5UYWJzKToKKyAgICAgICAgS2VlcCB1bnN1cHBvcnRlZCB0YWIgdHlwZXMgaW4gdGhlIHNl dHRpbmcgc28gd2hlbiB0aGV5IGFyZSBzdXBwb3J0ZWQgdGhleSBvcGVuLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qczoKKyAgICAgICAgQWRkIGEgaGVscGVyIGZv ciBpbnNlcnRpbmcgYSBzaW5nbGUgb2JqZWN0IGludG8gYW4gYXJyYXkuCisKKzIwMTUtMDgtMjAg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBKU0NvbnRl eHQgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb24gb3BlbmluZyBTZWFyY2ggVGFiCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgyODQKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4 IDQ4Yjg4NjEuLmQ1YmZhYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTM0MSwxNSArMzQxLDE4IEBAIFdlYkluc3BlY3Rvci5j b250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX3VwZGF0ZURvY2tOYXZpZ2F0aW9u SXRlbXMoKTsKICAgICB0aGlzLl91cGRhdGVUb29sYmFySGVpZ2h0KCk7CiAKLSAgICB0aGlzLl9w ZW5kaW5nT3BlblRhYlR5cGVzID0gW107CisgICAgdGhpcy5fcGVuZGluZ09wZW5UYWJzID0gW107 CiAKLSAgICBmb3IgKHZhciB0YWJUeXBlIG9mIHRoaXMuX29wZW5UYWJzU2V0dGluZy52YWx1ZSkg eworICAgIGxldCBvcGVuVGFiVHlwZXMgPSB0aGlzLl9vcGVuVGFic1NldHRpbmcudmFsdWU7CisK KyAgICBmb3IgKGxldCBpID0gMDsgaSA8IG9wZW5UYWJUeXBlcy5sZW5ndGg7ICsraSkgeworICAg ICAgICBsZXQgdGFiVHlwZSA9IG9wZW5UYWJUeXBlc1tpXTsKICAgICAgICAgaWYgKCF0aGlzLmlz VGFiVHlwZUFsbG93ZWQodGFiVHlwZSkpIHsKLSAgICAgICAgICAgIHRoaXMuX3BlbmRpbmdPcGVu VGFiVHlwZXMucHVzaCh0YWJUeXBlKTsKKyAgICAgICAgICAgIHRoaXMuX3BlbmRpbmdPcGVuVGFi cy5wdXNoKHt0YWJUeXBlLCBpbmRleDogaX0pOwogICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgIH0KIAotICAgICAgICB2YXIgdGFiQ29udGVudFZpZXcgPSB0aGlzLl90YWJDb250ZW50Vmll d0ZvclR5cGUodGFiVHlwZSk7CisgICAgICAgIGxldCB0YWJDb250ZW50VmlldyA9IHRoaXMuX3Rh YkNvbnRlbnRWaWV3Rm9yVHlwZSh0YWJUeXBlKTsKICAgICAgICAgaWYgKCF0YWJDb250ZW50Vmll dykKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB0aGlzLnRhYkJyb3dzZXIuYWRkVGFi Rm9yQ29udGVudFZpZXcodGFiQ29udGVudFZpZXcsIHRydWUpOwpAQCAtNDQyLDYgKzQ0NSwxMCBA QCBXZWJJbnNwZWN0b3IuX3JlbWVtYmVyT3BlblRhYnMgPSBmdW5jdGlvbigpCiAgICAgICAgIG9w ZW5UYWJzLnB1c2godGFiQ29udGVudFZpZXcudHlwZSk7CiAgICAgfQogCisgICAgLy8gS2VlcCBj dXJyZW50bHkgdW5zdXBwb3J0ZWQgdGFicyBpbiB0aGUgc2V0dGluZyBhdCB0aGVpciBwcmV2aW91 cyBpbmRleC4KKyAgICBmb3IgKGxldCB7dGFiVHlwZSwgaW5kZXh9IG9mIHRoaXMuX3BlbmRpbmdP cGVuVGFicykKKyAgICAgICAgb3BlblRhYnMuaW5zZXJ0QXRJbmRleCh0YWJUeXBlLCBpbmRleCk7 CisKICAgICB0aGlzLl9vcGVuVGFic1NldHRpbmcudmFsdWUgPSBvcGVuVGFiczsKIH07CiAKQEAg LTUxMiwyMyArNTE5LDIzIEBAIFdlYkluc3BlY3Rvci5hY3RpdmF0ZUV4dHJhRG9tYWlucyA9IGZ1 bmN0aW9uKGRvbWFpbnMpCiAgICAgdGhpcy5fdXBkYXRlUmVsb2FkVG9vbGJhckJ1dHRvbigpOwog ICAgIHRoaXMuX3VwZGF0ZURvd25sb2FkVG9vbGJhckJ1dHRvbigpOwogCi0gICAgdmFyIHN0aWxs UGVuZGluZ09wZW5UYWJUeXBlcyA9IFtdOwotICAgIGZvciAodmFyIHRhYlR5cGUgb2YgdGhpcy5f cGVuZGluZ09wZW5UYWJUeXBlcykgeworICAgIGxldCBzdGlsbFBlbmRpbmdPcGVuVGFicyA9IFtd OworICAgIGZvciAobGV0IHt0YWJUeXBlLCBpbmRleH0gb2YgdGhpcy5fcGVuZGluZ09wZW5UYWJz KSB7CiAgICAgICAgIGlmICghdGhpcy5pc1RhYlR5cGVBbGxvd2VkKHRhYlR5cGUpKSB7Ci0gICAg ICAgICAgICBzdGlsbFBlbmRpbmdPcGVuVGFiVHlwZXMucHVzaCh0YWJUeXBlKTsKKyAgICAgICAg ICAgIHN0aWxsUGVuZGluZ09wZW5UYWJzLnB1c2goe3RhYlR5cGUsIGluZGV4fSk7CiAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgfQogCi0gICAgICAgIHZhciB0YWJDb250ZW50VmlldyA9 IHRoaXMuX3RhYkNvbnRlbnRWaWV3Rm9yVHlwZSh0YWJUeXBlKTsKKyAgICAgICAgbGV0IHRhYkNv bnRlbnRWaWV3ID0gdGhpcy5fdGFiQ29udGVudFZpZXdGb3JUeXBlKHRhYlR5cGUpOwogICAgICAg ICBpZiAoIXRhYkNvbnRlbnRWaWV3KQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAg dGhpcy50YWJCcm93c2VyLmFkZFRhYkZvckNvbnRlbnRWaWV3KHRhYkNvbnRlbnRWaWV3LCB0cnVl KTsKKyAgICAgICAgdGhpcy50YWJCcm93c2VyLmFkZFRhYkZvckNvbnRlbnRWaWV3KHRhYkNvbnRl bnRWaWV3LCB0cnVlLCBpbmRleCk7CiAKICAgICAgICAgdGFiQ29udGVudFZpZXcucmVzdG9yZVN0 YXRlRnJvbUNvb2tpZShXZWJJbnNwZWN0b3IuU3RhdGVSZXN0b3JhdGlvblR5cGUuTG9hZCk7CiAg ICAgfQogCi0gICAgdGhpcy5fcGVuZGluZ09wZW5UYWJUeXBlcyA9IHN0aWxsUGVuZGluZ09wZW5U YWJUeXBlczsKKyAgICB0aGlzLl9wZW5kaW5nT3BlblRhYnMgPSBzdGlsbFBlbmRpbmdPcGVuVGFi czsKIAogICAgIHRoaXMuX3VwZGF0ZU5ld1RhYkJ1dHRvblN0YXRlKCk7CiB9OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcwpp bmRleCA4OWIwZGEwLi42MDRkNWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcwpAQCAtNDMzLDYgKzQzMywxNCBAQCBP YmplY3QuZGVmaW5lUHJvcGVydHkoQXJyYXkucHJvdG90eXBlLCAicmVtb3ZlIiwKICAgICB9CiB9 KTsKIAorT2JqZWN0LmRlZmluZVByb3BlcnR5KEFycmF5LnByb3RvdHlwZSwgImluc2VydEF0SW5k ZXgiLAoreworICAgIHZhbHVlOiBmdW5jdGlvbih2YWx1ZSwgaW5kZXgpCisgICAgeworICAgICAg ICB0aGlzLnNwbGljZShpbmRleCwgMCwgdmFsdWUpOworICAgIH0KK30pOworCiBPYmplY3QuZGVm aW5lUHJvcGVydHkoQXJyYXkucHJvdG90eXBlLCAia2V5U2V0IiwKIHsKICAgICB2YWx1ZTogZnVu Y3Rpb24oKQo=