148283 2015-08-20 19:40:36 -0700 REGRESSION (r188581): Web Inspector: Console user command isn't visible when it's expected to be 2015-08-24 08:57:26 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119593 0 nvasilyev 2015-08-20 19:40:36 -0700 <button onclick="console.log('Clicked')">Click me</button> Steps: 1. > 1+1 2. Click the button 3. > 1+1 Expected: > 1+1 < 2 [Log] Clicked > 1+1 < 2 Actual: > 1+1 < 2 [Log] Clicked < 2 "> 1+1" before the last line is missing. 1119594 1 webkit-bug-importer 2015-08-20 19:41:02 -0700 <rdar://problem/22374022> 1119596 2 259568 nvasilyev 2015-08-20 19:45:36 -0700 Created attachment 259568 Patch 1119761 3 259568 bburg 2015-08-21 09:26:58 -0700 Comment on attachment 259568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259568&action=review > Source/WebInspectorUI/ChangeLog:7 > + You should explain why this regressed, and why the fix is correct. > Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:288 > + this._lastCommited = ""; Please rename this to _lastCommitted. It is spelled incorrectly. =) 1120089 4 259713 nvasilyev 2015-08-21 23:16:21 -0700 Created attachment 259713 Patch 1120275 5 259713 commit-queue 2015-08-24 08:57:22 -0700 Comment on attachment 259713 Patch Clearing flags on attachment: 259713 Committed r188862: <http://trac.webkit.org/changeset/188862> 1120276 6 commit-queue 2015-08-24 08:57:26 -0700 All reviewed patches have been landed. Closing bug. 259568 2015-08-20 19:45:36 -0700 2015-08-21 23:16:21 -0700 Patch patch.txt text/plain 1811 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5ZTQxZTkuLjcwMThmNDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTIwICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODg1ODEp OiBXZWIgSW5zcGVjdG9yOiBDb25zb2xlIHVzZXIgY29tbWFuZCBpc24ndCB2aXNpYmxlIHdoZW4g aXQncyBleHBlY3RlZCB0byBiZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ4MjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRMb2dWaWV3 Q29udHJvbGxlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0TG9nVmlld0Nv bnRyb2xsZXIucHJvdG90eXBlLl9hcHBlbmRDb25zb2xlTWVzc2FnZVZpZXcpOgorICAgICAgICBS ZXNldCBfbGFzdENvbW1pdGVkIGZvciBhbGwgbWVzc2FnZXMgZXhjZXB0IGZvciB1c2VyIGNvbW1h bmRzIGFuZCB1c2UgY29tbWFuZCByZXN1bHRzLgorCiAyMDE1LTA4LTIwICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgZmxleCBh bGlnbm1lbnQgc2VjdGlvbiB0byBWaXN1YWwgc2lkZWJhcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvSmF2YVNjcmlwdExvZ1ZpZXdD b250cm9sbGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyLmpzCmluZGV4IDVkOGU3Y2YuLjRjOTk4 YzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRy b2xsZXJzL0phdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlci5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0TG9nVmlld0NvbnRy b2xsZXIuanMKQEAgLTI4NCw2ICsyODQsOSBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdExvZ1Zp ZXdDb250cm9sbGVyID0gY2xhc3MgSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyIGV4dAogICAg ICAgICBpZiAoIXJlcGVhdENvdW50V2FzSW50ZXJydXB0ZWQpCiAgICAgICAgICAgICB0aGlzLl9w cmV2aW91c01lc3NhZ2VWaWV3ID0gbWVzc2FnZVZpZXc7CiAKKyAgICAgICAgaWYgKG1lc3NhZ2VW aWV3Lm1lc3NhZ2UgJiYgbWVzc2FnZVZpZXcubWVzc2FnZS5zb3VyY2UgIT09IFdlYkluc3BlY3Rv ci5Db25zb2xlTWVzc2FnZS5NZXNzYWdlU291cmNlLkpTKQorICAgICAgICAgICAgdGhpcy5fbGFz dENvbW1pdGVkID0gIiI7CisKICAgICAgICAgdmFyIHR5cGUgPSBtZXNzYWdlVmlldyBpbnN0YW5j ZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlQ29tbWFuZFZpZXcgPyBudWxsIDogbWVzc2FnZVZpZXcu bWVzc2FnZS50eXBlOwogICAgICAgICBpZiAodHlwZSA9PT0gV2ViSW5zcGVjdG9yLkNvbnNvbGVN ZXNzYWdlLk1lc3NhZ2VUeXBlLkVuZEdyb3VwKSB7CiAgICAgICAgICAgICB2YXIgcGFyZW50R3Jv dXAgPSB0aGlzLl9jdXJyZW50Q29uc29sZUdyb3VwLnBhcmVudEdyb3VwOwo= 259713 2015-08-21 23:16:21 -0700 2015-08-24 08:57:22 -0700 Patch patch.txt text/plain 3637 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5ZTQxZTkuLmJmNDVlNTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA4LTIxICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODg1ODEp OiBXZWIgSW5zcGVjdG9yOiBDb25zb2xlIHVzZXIgY29tbWFuZCBpc24ndCB2aXNpYmxlIHdoZW4g aXQncyBleHBlY3RlZCB0byBiZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ4MjgzCisKKyAgICAgICAgT25lIG9mIHRoZSBpbXByb3ZlbWVudHMgb2Yg cjE4ODU4MSAiT3B0aW9uLUVudGVyIHNob3VsZCBjb21taXQgY29uc29sZSBjb21tYW5kCisgICAg ICAgIHdpdGhvdXQgZXJhc2luZyB0aGUgcHJvbXB0IiB3YXMgbm90IHRvIHNob3cgYSBjb25zb2xl IHVzZXIgY29tbWFuZCBpZiBpdCdzIHRoZQorICAgICAgICBzYW1lIGFzIHRoZSBwcmV2aW91cyBv bmUuCisKKyAgICAgICAgSG93ZXZlciwgdGhlcmUgY291bGQgYmUgYSBsb3Qgb2Ygb3RoZXIgbWVz c2FnZXMgYmV0d2VlbiB0aGUgbGFzdCB0d28gdXNlcgorICAgICAgICBjb21tYW5kcyAtIGNvbnNv bGUubG9nLCBDU1Mgd2FybmluZ3MsIGV0Yy4gSW4gdGhhdCBjYXNlIHdlIHNob3VsZCBzaG93IGEg Y29uc29sZQorICAgICAgICB1c2VyIGNvbW1hbmQgYWdhaW4gYnkgcmVzZXR0aW5nIF9sYXN0Q29t bWl0dGVkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0TG9nVmlld0NvbnRyb2xsZXIu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0TG9nVmlld0NvbnRyb2xsZXIucHJvdG90 eXBlLnN0YXJ0TmV3U2Vzc2lvbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdExv Z1ZpZXdDb250cm9sbGVyLnByb3RvdHlwZS5fYXBwZW5kQ29uc29sZU1lc3NhZ2VWaWV3KToKKyAg ICAgICAgUmVzZXQgX2xhc3RDb21taXR0ZWQgZm9yIGFsbCBtZXNzYWdlcyBleGNlcHQgZm9yIHVz ZXIgY29tbWFuZHMgYW5kIHVzZSBjb21tYW5kIHJlc3VsdHMuCisKIDIwMTUtMDgtMjAgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFk ZCBmbGV4IGFsaWdubWVudCBzZWN0aW9uIHRvIFZpc3VhbCBzaWRlYmFyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0 TG9nVmlld0NvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Db250cm9sbGVycy9KYXZhU2NyaXB0TG9nVmlld0NvbnRyb2xsZXIuanMKaW5kZXggNWQ4ZTdj Zi4uNjQ3YTk4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRMb2dW aWV3Q29udHJvbGxlci5qcwpAQCAtNDUsNyArNDUsNyBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlw dExvZ1ZpZXdDb250cm9sbGVyID0gY2xhc3MgSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyIGV4 dAogCiAgICAgICAgIHRoaXMuX2NsZWFyZWQgPSB0cnVlOwogICAgICAgICB0aGlzLl9wcmV2aW91 c01lc3NhZ2VWaWV3ID0gbnVsbDsKLSAgICAgICAgdGhpcy5fbGFzdENvbW1pdGVkID0gIiI7Cisg ICAgICAgIHRoaXMuX2xhc3RDb21taXR0ZWQgPSAiIjsKICAgICAgICAgdGhpcy5fcmVwZWF0Q291 bnRXYXNJbnRlcnJ1cHRlZCA9IGZhbHNlOwogCiAgICAgICAgIHRoaXMuX3Nlc3Npb25zID0gW107 CkBAIC0xMDksNyArMTA5LDcgQEAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRMb2dWaWV3Q29udHJv bGxlciA9IGNsYXNzIEphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlciBleHQKICAgICAgICAgdmFy IGNvbnNvbGVTZXNzaW9uID0gbmV3IFdlYkluc3BlY3Rvci5Db25zb2xlU2Vzc2lvbjsKIAogICAg ICAgICB0aGlzLl9wcmV2aW91c01lc3NhZ2VWaWV3ID0gbnVsbDsKLSAgICAgICAgdGhpcy5fbGFz dENvbW1pdGVkID0gIiI7CisgICAgICAgIHRoaXMuX2xhc3RDb21taXR0ZWQgPSAiIjsKICAgICAg ICAgdGhpcy5fcmVwZWF0Q291bnRXYXNJbnRlcnJ1cHRlZCA9IGZhbHNlOwogCiAgICAgICAgIHRo aXMuX3Nlc3Npb25zLnB1c2goY29uc29sZVNlc3Npb24pOwpAQCAtMjIzLDEwICsyMjMsMTAgQEAg V2ViSW5zcGVjdG9yLkphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlciA9IGNsYXNzIEphdmFTY3Jp cHRMb2dWaWV3Q29udHJvbGxlciBleHQKICAgICB7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRl eHQpOwogCi0gICAgICAgIGlmICh0aGlzLl9sYXN0Q29tbWl0ZWQgIT09IHRleHQpIHsKKyAgICAg ICAgaWYgKHRoaXMuX2xhc3RDb21taXR0ZWQgIT09IHRleHQpIHsKICAgICAgICAgICAgIGxldCBj b21tYW5kTWVzc2FnZVZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLkNvbnNvbGVDb21tYW5kVmlldyh0 ZXh0KTsKICAgICAgICAgICAgIHRoaXMuX2FwcGVuZENvbnNvbGVNZXNzYWdlVmlldyhjb21tYW5k TWVzc2FnZVZpZXcsIHRydWUpOwotICAgICAgICAgICAgdGhpcy5fbGFzdENvbW1pdGVkID0gdGV4 dDsKKyAgICAgICAgICAgIHRoaXMuX2xhc3RDb21taXR0ZWQgPSB0ZXh0OwogICAgICAgICB9CiAK ICAgICAgICAgZnVuY3Rpb24gcHJpbnRSZXN1bHQocmVzdWx0LCB3YXNUaHJvd24sIHNhdmVkUmVz dWx0SW5kZXgpCkBAIC0yODQsNiArMjg0LDkgQEAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRMb2dW aWV3Q29udHJvbGxlciA9IGNsYXNzIEphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlciBleHQKICAg ICAgICAgaWYgKCFyZXBlYXRDb3VudFdhc0ludGVycnVwdGVkKQogICAgICAgICAgICAgdGhpcy5f cHJldmlvdXNNZXNzYWdlVmlldyA9IG1lc3NhZ2VWaWV3OwogCisgICAgICAgIGlmIChtZXNzYWdl Vmlldy5tZXNzYWdlICYmIG1lc3NhZ2VWaWV3Lm1lc3NhZ2Uuc291cmNlICE9PSBXZWJJbnNwZWN0 b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZVNvdXJjZS5KUykKKyAgICAgICAgICAgIHRoaXMuX2xh c3RDb21taXR0ZWQgPSAiIjsKKwogICAgICAgICB2YXIgdHlwZSA9IG1lc3NhZ2VWaWV3IGluc3Rh bmNlb2YgV2ViSW5zcGVjdG9yLkNvbnNvbGVDb21tYW5kVmlldyA/IG51bGwgOiBtZXNzYWdlVmll dy5tZXNzYWdlLnR5cGU7CiAgICAgICAgIGlmICh0eXBlID09PSBXZWJJbnNwZWN0b3IuQ29uc29s ZU1lc3NhZ2UuTWVzc2FnZVR5cGUuRW5kR3JvdXApIHsKICAgICAgICAgICAgIHZhciBwYXJlbnRH cm91cCA9IHRoaXMuX2N1cnJlbnRDb25zb2xlR3JvdXAucGFyZW50R3JvdXA7Cg==