148282 2015-08-20 19:26:11 -0700 [EFL] Revise PlatformWebView ctor according to r188718 2015-08-22 11:39:59 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park gyuyoung.kim lucas.de.marchi mcatanzaro ossy oldest_to_newest 1119584 0 jh718.park 2015-08-20 19:26:11 -0700 https://bugs.webkit.org/show_bug.cgi?id=147996 changed PlatformWebView ctor's argument to use WKPageConfigurationRef instead of WKContextRef and WKPageGroupRef respectively. So change the ctor argument aligning with it. 1119589 1 259565 jh718.park 2015-08-20 19:31:00 -0700 Created attachment 259565 Patch 1119650 2 259565 gyuyoung.kim 2015-08-20 21:28:53 -0700 Comment on attachment 259565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259565&action=review > Source/WebKit2/PlatformEfl.cmake:68 > + UIProcess/API/C/WKPageConfigurationRef.cpp Wrong alphabet order. 1119652 3 gyuyoung.kim 2015-08-20 21:30:58 -0700 Committed r188751: <http://trac.webkit.org/changeset/188751> 1119653 4 gyuyoung.kim 2015-08-20 21:31:32 -0700 (In reply to comment #3) > Committed r188751: <http://trac.webkit.org/changeset/188751> Land after fixing it. 1119665 5 jh718.park 2015-08-20 22:24:27 -0700 (In reply to comment #2) > Comment on attachment 259565 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259565&action=review > > > Source/WebKit2/PlatformEfl.cmake:68 > > + UIProcess/API/C/WKPageConfigurationRef.cpp > > Wrong alphabet order. If I place files as below, UIProcess/API/C/CoordinatedGraphics/WKView.cpp UIProcess/API/C/WKPageConfigurationRef.cpp then when I run check-webkit-style script, I meet the log like this. Source/WebKit2/PlatformEfl.cmake:69: Alphabetical sorting problem. "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before "UIProcess/API/C/CoordinatedGraphics/WKView.cpp". It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp because the former is file name and the latter is an intermediate path name I think. So I guess the current alphabetical order is the right one. 1119667 6 gyuyoung.kim 2015-08-20 22:30:51 -0700 (In reply to comment #5) > (In reply to comment #2) > > Comment on attachment 259565 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=259565&action=review > > > > > Source/WebKit2/PlatformEfl.cmake:68 > > > + UIProcess/API/C/WKPageConfigurationRef.cpp > > > > Wrong alphabet order. > > If I place files as below, > > UIProcess/API/C/CoordinatedGraphics/WKView.cpp > UIProcess/API/C/WKPageConfigurationRef.cpp > > then when I run check-webkit-style script, I meet the log like this. > > Source/WebKit2/PlatformEfl.cmake:69: Alphabetical sorting problem. > "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before > "UIProcess/API/C/CoordinatedGraphics/WKView.cpp". > > It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp > because the former is file name and the latter is an intermediate path name > I think. > > So I guess the current alphabetical order is the right one. Yes, it just needed to have a empty line. :) I fixed it. http://trac.webkit.org/changeset/188751/trunk/Source/WebKit2/PlatformEfl.cmake 1119668 7 jh718.park 2015-08-20 22:35:50 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #2) > > > Comment on attachment 259565 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=259565&action=review > > > > > > > Source/WebKit2/PlatformEfl.cmake:68 > > > > + UIProcess/API/C/WKPageConfigurationRef.cpp > > > > > > Wrong alphabet order. > > > > If I place files as below, > > > > UIProcess/API/C/CoordinatedGraphics/WKView.cpp > > UIProcess/API/C/WKPageConfigurationRef.cpp > > > > then when I run check-webkit-style script, I meet the log like this. > > > > Source/WebKit2/PlatformEfl.cmake:69: Alphabetical sorting problem. > > "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before > > "UIProcess/API/C/CoordinatedGraphics/WKView.cpp". > > > > It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp > > because the former is file name and the latter is an intermediate path name > > I think. > > > > So I guess the current alphabetical order is the right one. > > Yes, it just needed to have a empty line. :) I fixed it. > > http://trac.webkit.org/changeset/188751/trunk/Source/WebKit2/PlatformEfl. > cmake Ah, I missed the empty line. Thank you :) 1120124 8 mcatanzaro 2015-08-22 11:39:59 -0700 Thanks Joonghun. I moved it from PlatformEfl.cmake to CMakeLists.txt in r188826, since it's needed by every port. 259565 2015-08-20 19:31:00 -0700 2015-08-20 21:28:53 -0700 Patch bug-148282-20150821113054.patch text/plain 3199 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTg4NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzJhZTMzNzAyYjJiNDIy YjJhZmRlOWNmNmI3ZTEwYmVlMGY0N2JhZC4uMmZkNTQyMWYyYmQxODhmNTE0MWFlYjU2ZTU5OGRi ZTNjNDQzZjdhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA4LTIwICBKb29u Z2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBSZXZp c2UgUGxhdGZvcm1XZWJWaWV3IGN0b3IgYWNjb3JkaW5nIHRvIHIxODg3MTgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODI4MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6 CisKIDIwMTUtMDgtMjAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBVc2UgV0tQYWdlQ29uZmlndXJhdGlvblJlZiBpbiBXZWJLaXRUZXN0UnVubmVyCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGQxZGM4OTVlOTMxZmFhNmZjYzQ4NzZhZWE1ODYw ODMzNDY4ODRiNGMuLmJlZTQ1NDE3NTJlYTYxNzc5ZjM3NTAxMWYwNTRhY2JjNDY3ZTQ4NDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC02NSw2ICs2NSw3IEBAIGxpc3QoQVBQRU5EIFdl YktpdDJfU09VUkNFUwogICAgIFVJUHJvY2Vzcy9CYWNraW5nU3RvcmUuY3BwCiAgICAgVUlQcm9j ZXNzL0RlZmF1bHRVbmRvQ29udHJvbGxlci5jcHAKIAorICAgIFVJUHJvY2Vzcy9BUEkvQy9XS1Bh Z2VDb25maWd1cmF0aW9uUmVmLmNwcAogICAgIFVJUHJvY2Vzcy9BUEkvQy9Db29yZGluYXRlZEdy YXBoaWNzL1dLVmlldy5jcHAKIAogICAgIFVJUHJvY2Vzcy9BUEkvQy9jYWlyby9XS0ljb25EYXRh YmFzZUNhaXJvLmNwcApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IDAyOTQ5NDZmZjE1Yjk2ZjZkZDdhYzc2OTA5NjQ4ZjdhN2JkY2QzZjIuLjU5MzIy YjQ5ZWNiMTQ5YjI1ZTQxNmE4Y2YyMDQ0YzVmOGU2NDlkZWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNS0wOC0y MCAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gUmV2aXNlIFBsYXRmb3JtV2ViVmlldyBjdG9yIGFjY29yZGluZyB0byByMTg4NzE4CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgyODIKKworICAg ICAgICBUaGlzIHBhdGNoIGNoYW5nZSBQbGF0Zm9ybVdlYlZpZXcgY3RvcidzIGFyZ3VtZW50IHRv IHVzZSBXS1BhZ2VDb25maWd1cmF0aW9uUmVmCisgICAgICAgIGluc3RlYWQgb2YgV0tDb250ZXh0 UmVmIGFuZCBXS1BhZ2VHcm91cFJlZiByZXNwZWN0aXZlbHkuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0 Zm9ybVdlYlZpZXdFZmwuY3BwOgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZpZXc6OlBsYXRm b3JtV2ViVmlldyk6CisKIDIwMTUtMDgtMjAgIERldmluIFJvdXNzbyAgPGRjcm91c3NvK3dlYmtp dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgY2hhbmdlZCBEZXZpbiBSb3Vzc28n cyBlbWFpbC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3Jt V2ViVmlld0VmbC5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZp ZXdFZmwuY3BwCmluZGV4IDFlNmIzYmUzZWFlNmI4ZWI1MzQ5YTYyZWQ0ZjY2YTZlZGNkZDMwYjku LjgxMTY2YjJkZWEyYTZiNmEyODM4YjY5YWJjMjI4MjE4YmUwNzQ3ZDUgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3JtV2ViVmlld0VmbC5jcHAKKysrIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcApAQCAtNTMsNyAr NTMsNyBAQCBzdGF0aWMgRWNvcmVfRXZhcyogaW5pdEVjb3JlRXZhcygpCiAgICAgcmV0dXJuIGVj b3JlRXZhczsKIH0KIAotUGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZpZXcoV0tDb250ZXh0 UmVmIGNvbnRleHQsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cCwgV0tQYWdlUmVmIC8qIHJlbGF0 ZWRQYWdlICovLCBjb25zdCBWaWV3T3B0aW9ucyYgb3B0aW9ucykKK1BsYXRmb3JtV2ViVmlldzo6 UGxhdGZvcm1XZWJWaWV3KFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYgY29uZmlndXJhdGlvbiwgY29u c3QgVmlld09wdGlvbnMmIG9wdGlvbnMpCiAgICAgOiBtX29wdGlvbnMob3B0aW9ucykKIHsKICAg ICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gdXNlRml4ZWRMYXlvdXRLZXkoQWRvcHRXSywgV0tT dHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIlVzZUZpeGVkTGF5b3V0IikpOwpAQCAtNjEsNiAr NjEsOCBAQCBQbGF0Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRleHRSZWYgY29u dGV4dCwgV0tQYWdlR3JvdXBSZWYgcGFnZUdyb3VwLAogCiAgICAgbV93aW5kb3cgPSBpbml0RWNv cmVFdmFzKCk7CiAKKyAgICBXS0NvbnRleHRSZWYgY29udGV4dCA9IFdLUGFnZUNvbmZpZ3VyYXRp b25HZXRDb250ZXh0KGNvbmZpZ3VyYXRpb24pOworICAgIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91 cCA9IFdLUGFnZUNvbmZpZ3VyYXRpb25HZXRQYWdlR3JvdXAoY29uZmlndXJhdGlvbik7CiAgICAg bV92aWV3ID0gRVdLVmlld0NyZWF0ZShjb250ZXh0LCBwYWdlR3JvdXAsIGVjb3JlX2V2YXNfZ2V0 KG1fd2luZG93KSwgLyogc21hcnQgKi8gMCk7CiAKICAgICBXS1BhZ2VTZXRVc2VGaXhlZExheW91 dChXS1ZpZXdHZXRQYWdlKEVXS1ZpZXdHZXRXS1ZpZXcobV92aWV3KSksIG1fdXNpbmdGaXhlZExh eW91dCk7Cg==