148264 2015-08-20 16:34:53 -0700 Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links 2015-08-20 18:39:09 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 147563 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119440 0 hi 2015-08-20 16:34:53 -0700 file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:233:26: CONSOLE ERROR Uncaught exception in inspector page while dispatching callback for command CSS.getComputedStyleForNode: TypeError: Attempted to assign to readonly property. linked@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStylePropertyEditorLink.js:85:25 _updateProperties@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleDetailsPanel.js:185:33 _updateSections@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleDetailsPanel.js:162:35 dispatch@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:124:55 dispatchEventToListeners@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:131:17 _selectorChanged@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleSelectorSection.js:231:38 _selectorChanged@[native code] select@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TreeOutline.js:1015:33 createSelectorItem@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleSelectorSection.js:113:32 update@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleSelectorSection.js:163:36 refresh@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleDetailsPanel.js:107:41 _refreshPreservingScrollPosition@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/StyleDetailsPanel.js:151:21 nodeStylesRefreshed@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/StyleDetailsPanel.js:122:50 dispatch@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:124:55 dispatchEventToListeners@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:131:17 fetchedComputedStyle@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Models/DOMNodeStyles.js:235:42 fetchedComputedStyle@[native code] _dispatchResponseToCallback@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:231:27 _dispatchResponse@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:203:45 dispatch@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:85:35 dispatchNextQueuedMessageFromBackend@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/MessageDispatcher.js:42:34 1119442 1 webkit-bug-importer 2015-08-20 16:35:24 -0700 <rdar://problem/22371334> 1119445 2 259521 hi 2015-08-20 16:37:19 -0700 Created attachment 259521 Patch 1119548 3 259521 commit-queue 2015-08-20 18:39:06 -0700 Comment on attachment 259521 Patch Clearing flags on attachment: 259521 Committed r188731: <http://trac.webkit.org/changeset/188731> 1119549 4 commit-queue 2015-08-20 18:39:09 -0700 All reviewed patches have been landed. Closing bug. 259521 2015-08-20 16:37:19 -0700 2015-08-20 18:39:06 -0700 Patch bug-148264-20150820163714.patch text/plain 2005 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI5OGFjMTA2MTI1ZWNiMGIyZDlmOWM5ZmUxMmZl ODYwOTVkMjI5YmEuLjc3ZTkxMGYyNzZiNDczN2RhYWQwZGE5ZjRiY2IwMjg1ZTQzZGIwMWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA4LTIwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBG aXggImF0dGVtcHRlZCB0byBhc3NpZ24gdG8gcmVhZG9ubHkgcHJvcGVydHkiIGluIFZpc3VhbCBl ZGl0b3IgbGlua3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0ODI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yTGluay5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yTGluay5w cm90b3R5cGUuc2V0IGxpbmtlZCk6CisgICAgICAgIE5vIGxvbmdlciBhdHRlbXB0cyB0byBzZXQg dGhlICJoaWRkZW4iIGF0dHJpYnV0ZSBvZiB0aGUgbGluayBpY29ucyBiZWZvcmUgdGhleSBleGlz dC4KKwogMjAxNS0wOC0yMCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBjb25zb2xlIGFzc2VydGlvbiB3aGVuIGhpdHRpbmcgYnJlYWtwb2lu dCBhZnRlciBhdXRvLXJlY29yZGluZyBlbmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yTGluay5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxl UHJvcGVydHlFZGl0b3JMaW5rLmpzCmluZGV4IGVhNDlhZTE3Yjk1Mjk2NTIxNDQzNjA1OGFmNDJk MDMxNWU1Yzk1OTAuLjRjNDQxMGExZGI4NGQyNzM4YzlhODAyZmViNzE0YzJlMjhiMzcxMzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3Vh bFN0eWxlUHJvcGVydHlFZGl0b3JMaW5rLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlUHJvcGVydHlFZGl0b3JMaW5rLmpzCkBAIC04 Miw4ICs4MiwxMyBAQCBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVQcm9wZXJ0eUVkaXRvckxpbmsg PSBjbGFzcyBWaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yTGluawogICAgIHsKICAgICAgICAgdGhp cy5fbGlua2VkID0gZmxhZzsKICAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3QudG9nZ2xl KCJsaW5rZWQiLCB0aGlzLl9saW5rZWQpOwotICAgICAgICB0aGlzLl9saW5rZWRJY29uLmhpZGRl biA9ICF0aGlzLl9saW5rZWQ7Ci0gICAgICAgIHRoaXMuX3VubGlua2VkSWNvbi5oaWRkZW4gPSB0 aGlzLl9saW5rZWQ7CisKKyAgICAgICAgaWYgKHRoaXMuX2xpbmtlZEljb24pCisgICAgICAgICAg ICB0aGlzLl9saW5rZWRJY29uLmhpZGRlbiA9ICF0aGlzLl9saW5rZWQ7CisKKyAgICAgICAgaWYg KHRoaXMuX3VubGlua2VkSWNvbikKKyAgICAgICAgICAgIHRoaXMuX3VubGlua2VkSWNvbi5oaWRk ZW4gPSB0aGlzLl9saW5rZWQ7CisKICAgICAgICAgdGhpcy5faWNvbkVsZW1lbnQudGl0bGUgPSB0 aGlzLl9saW5rZWQgPyBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNsaWNrIHRvIHJlbW92ZSBsaW5r IikgOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkNsaWNrIHRvIGxpbmsgcHJvcGVydHkgdmFsdWVz Iik7CiAKICAgICAgICAgZm9yIChsZXQgbGlua1RvSGlkZSBvZiB0aGlzLl9saW5rc1RvSGlkZVdo ZW5MaW5rZWQpCg==