148246 2015-08-20 14:19:46 -0700 jsc-tailcall: Stack pointer should be moved to protect saving callee saves in LLInt 2015-09-14 11:00:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED DUPLICATE 148666 P2 Normal --- 1 msaboff msaboff basile_clement oldest_to_newest 1119354 0 msaboff 2015-08-20 14:19:46 -0700 Because we need to use a callee save register to make C++ calls to check the stack, we save the callee save register before moving the stack pointer to its eventual location. This is dangerous because a signal could temporarily take over the stack and overwrite the callee saves. We need to move the stack pointer at least enough to "protect" the callee saves. 1119355 1 259495 msaboff 2015-08-20 14:25:49 -0700 Created attachment 259495 Patch 1119379 2 msaboff 2015-08-20 14:55:17 -0700 Committed r188706: <http://trac.webkit.org/changeset/188706> 1122412 3 basile_clement 2015-08-31 18:10:10 -0700 *** This bug has been marked as a duplicate of bug 148666 *** 1125650 4 259495 ossy 2015-09-14 11:00:08 -0700 Comment on attachment 259495 Patch Cleared review? from attachment 259495 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 259495 2015-08-20 14:25:49 -0700 2015-09-14 11:00:08 -0700 Patch 148246.patch text/plain 1631 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4NzAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE1LTA4LTIwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGpzYy10YWlsY2FsbDogU3RhY2sgcG9pbnRlciBzaG91bGQgYmUgbW92ZWQgdG8gcHJvdGVj dCBzYXZpbmcgY2FsbGVlIHNhdmVzIGluIExMSW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDgyNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIHByZXNlcnZlQ2FsbGVlU2F2ZXNVc2VkQnlM TEludCgpIG1hY3JvIHRvIG1vdmUgdGhlIHN0YWNrIHBvaW50ZXIgYmVmb3JlIHNhdmluZworICAg ICAgICBhbnkgcmVnaXN0ZXJzLgorCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl ci5hc206CisKIDIwMTUtMDgtMTkgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+ CiAKICAgICAgICAganNjLXRhaWxjYWxsOiBVbmlmeSBSZWdpc3RlciBPZmZzZXQgY2xhc3NlcwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNt Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyLmFzbQkocmV2aXNpb24gMTg4NjU0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC01MDQsNiArNTA0 LDcgQEAgbWFjcm8gcmVzdG9yZUNhbGxlclBDQW5kQ0ZSKCkKIGVuZAogCiBtYWNybyBwcmVzZXJ2 ZUNhbGxlZVNhdmVzVXNlZEJ5TExJbnQoKQorICAgIHN1YnAgQ2FsbGVlU2F2ZVNwYWNlU3RhY2tB bGlnbmVkLCBzcAogICAgIGlmIENfTE9PUAogICAgIGVsc2lmIEFSTSBvciBBUk12N19UUkFESVRJ T05BTAogICAgIGVsc2lmIEFSTXY3CkBAIC04NzUsNyArODc2LDcgQEAgbWFjcm8gcHJvbG9ndWUo Y29kZUJsb2NrR2V0dGVyLCBjb2RlQmxvYwogCiAgICAgIyBTdGFjayBoZWlnaHQgY2hlY2sgZmFp bGVkIC0gbmVlZCB0byBjYWxsIGEgc2xvd19wYXRoLgogICAgICMgU2V0IHVwIHRlbXBvcmFyeSBz dGFjayBwb2ludGVyIGZvciBjYWxsIGluY2x1ZGluZyBjYWxsZWUgc2F2ZXMKLSAgICBzdWJwIG1h eEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsICsgQ2FsbGVlU2F2ZVNwYWNlU3RhY2tBbGlnbmVk LCBzcAorICAgIHN1YnAgbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwsIHNwCiAgICAgY2Fs bFNsb3dQYXRoKF9sbGludF9zdGFja19jaGVjaykKICAgICBicGVxIHIxLCAwLCAuc3RhY2tIZWln aHRPS0dldENvZGVCbG9jawogICAgIG1vdmUgcjEsIGNmcgo=