148243 2015-08-20 14:04:51 -0700 Web Inspector: Add flex alignment section to Visual sidebar 2015-08-20 18:42:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 147563 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119339 0 hi 2015-08-20 14:04:51 -0700 Currently, the layout properties for flex box have visual editors, but the alignment (align, justify, etc.) properties do not. 1119343 1 webkit-bug-importer 2015-08-20 14:05:54 -0700 <rdar://problem/22367976> 1119436 2 259517 hi 2015-08-20 16:30:01 -0700 Created attachment 259517 Patch 1119475 3 259517 timothy 2015-08-20 17:12:32 -0700 Comment on attachment 259517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review > Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590 > + advanced: advancedAlignmentKeywords.concat(["Space Evenly"]) Really advanced? I could see this being in the basic list. 1119478 4 259517 hi 2015-08-20 17:13:30 -0700 Comment on attachment 259517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review >> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590 >> + advanced: advancedAlignmentKeywords.concat(["Space Evenly"]) > > Really advanced? I could see this being in the basic list. I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox. Since Grid is much less supported than Flexbox, I don't want the users getting confused. 1119479 5 259517 timothy 2015-08-20 17:14:16 -0700 Comment on attachment 259517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review >>> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590 >>> + advanced: advancedAlignmentKeywords.concat(["Space Evenly"]) >> >> Really advanced? I could see this being in the basic list. > > I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox. Since Grid is much less supported than Flexbox, I don't want the users getting confused. Makes sense. 1119555 6 259517 commit-queue 2015-08-20 18:42:31 -0700 Comment on attachment 259517 Patch Clearing flags on attachment: 259517 Committed r188733: <http://trac.webkit.org/changeset/188733> 1119556 7 commit-queue 2015-08-20 18:42:34 -0700 All reviewed patches have been landed. Closing bug. 259517 2015-08-20 16:30:01 -0700 2015-08-20 18:42:31 -0700 Patch bug-148243-20150820162957.patch text/plain 6136 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI5OGFjMTA2MTI1ZWNiMGIyZDlmOWM5ZmUxMmZl ODYwOTVkMjI5YmEuLjBiMWZjNGIyODRjNzFhYjNmOGFkOTk0YzcxZGM3ZmRlMGQyYWQ2N2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA4LTIwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB ZGQgZmxleCBhbGlnbm1lbnQgc2VjdGlvbiB0byBWaXN1YWwgc2lkZWJhcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ4MjQzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlcyBzZWxlY3Qga2V5d29yZCBw aWNrZXJzIHRvIGNvbnRhaW4gdGhlIGxpc3Qgb2YgcG9zc2libGUgdmFsdWVzLiAgQWxzbyBzdXBw b3J0cworICAgICAgICB0aGUgdXBjb21pbmcgR3JpZCBsYXlvdXQga2V5d29yZHMgaW4gdGhlIGFk dmFuY2VkIGtleXdvcmQgbGlzdC4KKworICAgICAgICAqIExvY2FsaXphdGlvbnMvZW4ubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3Vh bFN0eWxlRGV0YWlsc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxl RGV0YWlsc1BhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZURldGFpbHNQ YW5lbC5wcm90b3R5cGUuX3BvcHVsYXRlRmxleGJveFNlY3Rpb24pOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlwZS5fcG9wdWxhdGVBbGlnbm1l bnRTZWN0aW9uKToKKwogMjAxNS0wOC0yMCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBjb25zb2xlIGFzc2VydGlvbiB3aGVuIGhpdHRpbmcg YnJlYWtwb2ludCBhZnRlciBhdXRvLXJlY29yZGluZyBlbmRzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVk U3RyaW5ncy5qcwppbmRleCBjMzk2YzY2ZmI2MWQ5OWY4YmE0ODc5ODg4Yjc3YjA0YjU0ZGI0NDRi Li44YjQ5N2RjODI4NjMxNGY1NjNkOTEyMjE0OTYzNDU3YmQ2YmExMTcxIDEwMDY0NApHSVQgYmlu YXJ5IHBhdGNoCmRlbHRhIDcxCnpjbVg/Z2hVTHsrbUpSTnJ0ZUZoeTQwKTNlI0VFaGBHVVBCb2Nw RnczUHU/JWF3JUpxayF4ZHBBaEZBcyMyM3NJagpWVmhDblAxdTlDTEViIWNMdi12QXc4dnQ5UzdG eiVTCgpkZWx0YSAxOQpiY21hRUxtZ1VxTG1KUk5ybi1ffEh5MFpEXkQ/dTlvWCE7Nk4KCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxT dHlsZURldGFpbHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCmluZGV4IGRjMjYzMzYzOTRkYTQ1MDI2 NjFhNDlkODZjODIyYzYyY2E1M2E4YzUuLjY0ZmEzYWEwNmI2NGFkMTExYjU4Mjc4MmRlN2NmNmM3 NGJhMjUyMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCkBAIC03 MCw4ICs3MCw5IEBAIFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZURldGFpbHNQYW5lbCA9IGNsYXNz IFZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsIGV4dGVuZHMgV2ViCiAgICAgICAgIHRoaXMuX2dlbmVy YXRlU2VjdGlvbigibWFyZ2luIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJNYXJnaW4iKSk7CiAg ICAgICAgIHRoaXMuX2dlbmVyYXRlU2VjdGlvbigicGFkZGluZyIsIFdlYkluc3BlY3Rvci5VSVN0 cmluZygiUGFkZGluZyIpKTsKICAgICAgICAgdGhpcy5fZ2VuZXJhdGVTZWN0aW9uKCJmbGV4Ym94 IiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJGbGV4Ym94IikpOworICAgICAgICB0aGlzLl9nZW5l cmF0ZVNlY3Rpb24oImFsaWdubWVudCIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiQWxpZ25tZW50 IikpOwogCi0gICAgICAgIHRoaXMuX3NlY3Rpb25zLmxheW91dCA9IG5ldyBXZWJJbnNwZWN0b3Iu RGV0YWlsc1NlY3Rpb24oImxheW91dCIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiTGF5b3V0Iiks IFt0aGlzLl9ncm91cHMuZGlzcGxheS5zZWN0aW9uLCB0aGlzLl9ncm91cHMucG9zaXRpb24uc2Vj dGlvbiwgdGhpcy5fZ3JvdXBzLmZsb2F0LnNlY3Rpb24sIHRoaXMuX2dyb3Vwcy5kaW1lbnNpb25z LnNlY3Rpb24sIHRoaXMuX2dyb3Vwcy5tYXJnaW4uc2VjdGlvbiwgdGhpcy5fZ3JvdXBzLnBhZGRp bmcuc2VjdGlvbiwgdGhpcy5fZ3JvdXBzLmZsZXhib3guc2VjdGlvbl0pOworICAgICAgICB0aGlz Ll9zZWN0aW9ucy5sYXlvdXQgPSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNTZWN0aW9uKCJsYXlv dXQiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkxheW91dCIpLCBbdGhpcy5fZ3JvdXBzLmRpc3Bs YXkuc2VjdGlvbiwgdGhpcy5fZ3JvdXBzLnBvc2l0aW9uLnNlY3Rpb24sIHRoaXMuX2dyb3Vwcy5m bG9hdC5zZWN0aW9uLCB0aGlzLl9ncm91cHMuZGltZW5zaW9ucy5zZWN0aW9uLCB0aGlzLl9ncm91 cHMubWFyZ2luLnNlY3Rpb24sIHRoaXMuX2dyb3Vwcy5wYWRkaW5nLnNlY3Rpb24sIHRoaXMuX2dy b3Vwcy5mbGV4Ym94LnNlY3Rpb24sIHRoaXMuX2dyb3Vwcy5hbGlnbm1lbnQuc2VjdGlvbl0pOwog ICAgICAgICB0aGlzLl9lbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuX3NlY3Rpb25zLmxheW91dC5l bGVtZW50KTsKIAogICAgICAgICAvLyBUZXh0IFNlY3Rpb24KQEAgLTU1OCw4ICs1NTksOCBAQCBX ZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwgPSBjbGFzcyBWaXN1YWxTdHlsZURl dGFpbHNQYW5lbCBleHRlbmRzIFdlYgogCiAgICAgICAgIGxldCBmbGV4U2l6ZVJvdyA9IG5ldyBX ZWJJbnNwZWN0b3IuRGV0YWlsc1NlY3Rpb25Sb3c7CiAKLSAgICAgICAgcHJvcGVydGllcy5mbGV4 R3JvdyA9IG5ldyBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveCgiZmxleC1n cm93IiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJHcm93IiksIHRoaXMuX2tleXdvcmRzLmRlZmF1 bHRzLCBudWxsKTsKLSAgICAgICAgcHJvcGVydGllcy5mbGV4U2hyaW5rID0gbmV3IFdlYkluc3Bl Y3Rvci5WaXN1YWxTdHlsZU51bWJlcklucHV0Qm94KCJmbGV4LXNocmluayIsIFdlYkluc3BlY3Rv ci5VSVN0cmluZygiU2hyaW5rIiksIHRoaXMuX2tleXdvcmRzLmRlZmF1bHRzLCBudWxsKTsKKyAg ICAgICAgcHJvcGVydGllcy5mbGV4R3JvdyA9IG5ldyBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVO dW1iZXJJbnB1dEJveCgiZmxleC1ncm93IiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJHcm93Iiks IHRoaXMuX2tleXdvcmRzLmRlZmF1bHRzKTsKKyAgICAgICAgcHJvcGVydGllcy5mbGV4U2hyaW5r ID0gbmV3IFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZU51bWJlcklucHV0Qm94KCJmbGV4LXNocmlu ayIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2hyaW5rIiksIHRoaXMuX2tleXdvcmRzLmRlZmF1 bHRzKTsKIAogICAgICAgICBmbGV4U2l6ZVJvdy5lbGVtZW50LmFwcGVuZENoaWxkKHByb3BlcnRp ZXMuZmxleEdyb3cuZWxlbWVudCk7CiAgICAgICAgIGZsZXhTaXplUm93LmVsZW1lbnQuYXBwZW5k Q2hpbGQocHJvcGVydGllcy5mbGV4U2hyaW5rLmVsZW1lbnQpOwpAQCAtNTc2LDYgKzU3Nyw0MSBA QCBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwgPSBjbGFzcyBWaXN1YWxTdHls ZURldGFpbHNQYW5lbCBleHRlbmRzIFdlYgogICAgICAgICB0aGlzLl9wb3B1bGF0ZVNlY3Rpb24o Z3JvdXAsIFtmbGV4Ym94R3JvdXBdKTsKICAgICB9CiAKKyAgICBfcG9wdWxhdGVBbGlnbm1lbnRT ZWN0aW9uKCkKKyAgICB7CisgICAgICAgIGxldCBncm91cCA9IHRoaXMuX2dyb3Vwcy5hbGlnbm1l bnQ7CisgICAgICAgIGxldCBwcm9wZXJ0aWVzID0gZ3JvdXAucHJvcGVydGllczsKKyAgICAgICAg bGV0IGFsaWdubWVudEtleXdvcmRzID0gWyJJbml0aWFsIiwgIkF1dG8iLCAiRmxleCBTdGFydCIs ICJGbGV4IEVuZCIsICJDZW50ZXIiLCAiU3RyZXRjaCJdOworICAgICAgICBsZXQgYWR2YW5jZWRB bGlnbm1lbnRLZXl3b3JkcyA9IFsiU3RhcnQiLCAiRW5kIiwgIkxlZnQiLCAiUmlnaHQiLCAiQmFz ZWxpbmUiLCAiTGFzdCBCYXNlbGluZSJdOworCisgICAgICAgIGxldCBjb250ZW50Um93ID0gbmV3 IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvblJvdzsKKyAgICAgICAgbGV0IGNvbnRlbnRLZXl3 b3JkcyA9IHsKKyAgICAgICAgICAgIGJhc2ljOiBhbGlnbm1lbnRLZXl3b3Jkcy5jb25jYXQoWyJT cGFjZSBCZXR3ZWVuIiwgIlNwYWNlIEFyb3VuZCJdKSwKKyAgICAgICAgICAgIGFkdmFuY2VkOiBh ZHZhbmNlZEFsaWdubWVudEtleXdvcmRzLmNvbmNhdChbIlNwYWNlIEV2ZW5seSJdKQorICAgICAg ICB9OworCisgICAgICAgIHByb3BlcnRpZXMuanVzdGlmeUNvbnRlbnQgPSBuZXcgV2ViSW5zcGVj dG9yLlZpc3VhbFN0eWxlS2V5d29yZFBpY2tlcigianVzdGlmeS1jb250ZW50IiwgV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJIb3Jpem9udGFsIiksIGNvbnRlbnRLZXl3b3Jkcyk7CisgICAgICAgIHBy b3BlcnRpZXMuYWxpZ25Db250ZW50ID0gbmV3IFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZUtleXdv cmRQaWNrZXIoImFsaWduLWNvbnRlbnQiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlZlcnRpY2Fs IiksIGNvbnRlbnRLZXl3b3Jkcyk7CisKKyAgICAgICAgY29udGVudFJvdy5lbGVtZW50LmFwcGVu ZENoaWxkKHByb3BlcnRpZXMuanVzdGlmeUNvbnRlbnQuZWxlbWVudCk7CisgICAgICAgIGNvbnRl bnRSb3cuZWxlbWVudC5hcHBlbmRDaGlsZChwcm9wZXJ0aWVzLmFsaWduQ29udGVudC5lbGVtZW50 KTsKKworICAgICAgICBsZXQgaXRlbXNSb3cgPSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNTZWN0 aW9uUm93OworICAgICAgICBsZXQgaXRlbUtleXdvcmRzID0geworICAgICAgICAgICAgYmFzaWM6 IGFsaWdubWVudEtleXdvcmRzLAorICAgICAgICAgICAgYWR2YW5jZWQ6IFsiU2VsZiBTdGFydCIs ICJTZWxmIEVuZCJdLmNvbmNhdChhZHZhbmNlZEFsaWdubWVudEtleXdvcmRzKQorICAgICAgICB9 OworCisgICAgICAgIHByb3BlcnRpZXMuYWxpZ25JdGVtcyA9IG5ldyBXZWJJbnNwZWN0b3IuVmlz dWFsU3R5bGVLZXl3b3JkUGlja2VyKCJhbGlnbi1pdGVtcyIsIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiQ2hpbGRyZW4iKSwgaXRlbUtleXdvcmRzKTsKKyAgICAgICAgcHJvcGVydGllcy5hbGlnblNl bGYgPSBuZXcgV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxlS2V5d29yZFBpY2tlcigiYWxpZ24tc2Vs ZiIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2VsZiIpLCBpdGVtS2V5d29yZHMpOworCisgICAg ICAgIGl0ZW1zUm93LmVsZW1lbnQuYXBwZW5kQ2hpbGQocHJvcGVydGllcy5hbGlnbkl0ZW1zLmVs ZW1lbnQpOworICAgICAgICBpdGVtc1Jvdy5lbGVtZW50LmFwcGVuZENoaWxkKHByb3BlcnRpZXMu YWxpZ25TZWxmLmVsZW1lbnQpOworCisgICAgICAgIGxldCBhbGlnbm1lbnRHcm91cCA9IG5ldyBX ZWJJbnNwZWN0b3IuRGV0YWlsc1NlY3Rpb25Hcm91cChbY29udGVudFJvdywgaXRlbXNSb3ddKTsK KyAgICAgICAgdGhpcy5fcG9wdWxhdGVTZWN0aW9uKGdyb3VwLCBbYWxpZ25tZW50R3JvdXBdKTsK KyAgICB9CisKICAgICBfcG9wdWxhdGVUZXh0U3R5bGVTZWN0aW9uKCkKICAgICB7CiAgICAgICAg IGxldCBncm91cCA9IHRoaXMuX2dyb3Vwcy50ZXh0U3R5bGU7Cg==