148242 2015-08-20 14:03:59 -0700 Web Inspector: Visual editor adds extra spaces to styles with no properties 2015-08-20 18:37:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 147563 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1119336 0 hi 2015-08-20 14:03:59 -0700 If there are no styles in a rule, the Visual panel should not add any extra spacing. 1119338 1 webkit-bug-importer 2015-08-20 14:04:40 -0700 <rdar://problem/22367954> 1119454 2 259525 hi 2015-08-20 16:51:17 -0700 Created attachment 259525 Patch 1119546 3 259525 commit-queue 2015-08-20 18:37:50 -0700 Comment on attachment 259525 Patch Clearing flags on attachment: 259525 Committed r188730: <http://trac.webkit.org/changeset/188730> 1119547 4 commit-queue 2015-08-20 18:37:53 -0700 All reviewed patches have been landed. Closing bug. 259525 2015-08-20 16:51:17 -0700 2015-08-20 18:37:50 -0700 Patch bug-148242-20150820165112.patch text/plain 3017 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMyMTMwMmU1MDgwMzkxZTdlNDk0ZmIzOTlkODll YzhkMjkzODMxMWEuLjlhOTVjMWFhYmFiNWZlY2VmY2EwNTgzNGQ3MWEzM2I3MTM5NDNjMTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA4LTIwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBW aXN1YWwgZWRpdG9yIGFkZHMgZXh0cmEgc3BhY2VzIHRvIHN0eWxlcyB3aXRoIG5vIHByb3BlcnRp ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODI0 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9Nb2RlbHMvQ1NTU3R5bGVEZWNsYXJhdGlvbi5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uLnByb3RvdHlwZS5zZXQgdGV4dCk6CisgICAgICAg IE5vdyB0cmltcyB0aGUgdGV4dCBhbmQsIGlmIHRoZSByZXN1bHRpbmcgc3RyaW5nIGhhcyBubyBs ZW5ndGggb3IgdGhlIHN0eWxlIGlzIGlubGluZSwKKyAgICAgICAgcmVwbGFjZXMgdGhlIHRleHQg dG8gYmUgc2V0IHdpdGggdGhlIHRyaW1tZWQgdGV4dC4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvVmlzdWFsU3R5bGVQcm9wZXJ0eUNvbWJpbmVyLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlZpc3VhbFN0eWxlUHJvcGVydHlDb21iaW5lci5wcm90b3R5cGUubW9kaWZ5UHJvcGVy dHlUZXh0KToKKyAgICAgICAgUmVtb3ZlZCB1bm5lY2Vzc2FyeSB0cmltLgorCiAyMDE1LTA4LTIw ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBGaWx0ZXJlZCBmcmFtZXMgc2hvdWxkIGJlIHN0eWxlZCBkaWZmZXJlbnRseSBpbiB0aGUg UmVuZGVyaW5nIEZyYW1lcyBvdmVydmlldyBncmFwaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU1N0eWxlRGVjbGFyYXRpb24uanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTU3R5bGVEZWNsYXJh dGlvbi5qcwppbmRleCA5ZjEwZDNmYWIwNjc5MTQ0MGJhM2EzNDM4NDc3Mzk3YmNjYmYzYTc1Li4y ODU0MzZlMGEyYWNhNDFiNmRlODgwNzA2NGI5Mzk1YjgyZTRhM2FmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTU3R5bGVEZWNsYXJhdGlv bi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NT U3R5bGVEZWNsYXJhdGlvbi5qcwpAQCAtMTg2LDcgKzE4NiwxNCBAQCBXZWJJbnNwZWN0b3IuQ1NT U3R5bGVEZWNsYXJhdGlvbiA9IGNsYXNzIENTU1N0eWxlRGVjbGFyYXRpb24gZXh0ZW5kcyBXZWJJ bnNwZWN0bwogICAgICAgICBpZiAodGhpcy5fdGV4dCA9PT0gdGV4dCkKICAgICAgICAgICAgIHJl dHVybjsKIAotICAgICAgICB2YXIgbW9kaWZpZWQgPSB0ZXh0ICE9PSB0aGlzLl9pbml0aWFsVGV4 dDsKKyAgICAgICAgbGV0IHRyaW1tZWRUZXh0ID0gdGV4dC50cmltKCk7CisgICAgICAgIGlmICh0 aGlzLl90ZXh0ID09PSB0cmltbWVkVGV4dCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAg ICBpZiAoIXRyaW1tZWRUZXh0Lmxlbmd0aCB8fCB0aGlzLl90eXBlID09PSBXZWJJbnNwZWN0b3Iu Q1NTU3R5bGVEZWNsYXJhdGlvbi5UeXBlLklubGluZSkKKyAgICAgICAgICAgIHRleHQgPSB0cmlt bWVkVGV4dDsKKworICAgICAgICBsZXQgbW9kaWZpZWQgPSB0ZXh0ICE9PSB0aGlzLl9pbml0aWFs VGV4dDsKICAgICAgICAgaWYgKG1vZGlmaWVkICE9PSB0aGlzLl9oYXNNb2RpZmllZEluaXRpYWxU ZXh0KSB7CiAgICAgICAgICAgICB0aGlzLl9oYXNNb2RpZmllZEluaXRpYWxUZXh0ID0gbW9kaWZp ZWQ7CiAgICAgICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0 b3IuQ1NTU3R5bGVEZWNsYXJhdGlvbi5FdmVudC5Jbml0aWFsVGV4dE1vZGlmaWVkKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0 eWxlUHJvcGVydHlDb21iaW5lci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1Zpc3VhbFN0eWxlUHJvcGVydHlDb21iaW5lci5qcwppbmRleCAyM2VlNGEwZTNm YTU0OWI3MjFjNTMzZjEwMGZkYmI1ODBlMzVkMjE1Li5iMzA0NmYzZmZhZmNiYmUxZTI5MTdlNzEy NjNjZjVlNDlhZGNkNGIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVByb3BlcnR5Q29tYmluZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVQcm9wZXJ0eUNv bWJpbmVyLmpzCkBAIC03Nyw3ICs3Nyw2IEBAIFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZVByb3Bl cnR5Q29tYmluZXIgPSBjbGFzcyBWaXN1YWxTdHlsZVByb3BlcnR5Q29tYmluZXIgZXh0CiAKICAg ICBtb2RpZnlQcm9wZXJ0eVRleHQodGV4dCwgdmFsdWUpCiAgICAgewotICAgICAgICBsZXQgdHJp bW1lZFRleHQgPSB0ZXh0LnRyaW1SaWdodCgpOwogICAgICAgICBpZiAodGhpcy5fdGV4dENvbnRh aW5zTmFtZVJlZ0V4cC50ZXN0KHRleHQpKQogICAgICAgICAgICAgdGV4dCA9IHRleHQucmVwbGFj ZSh0aGlzLl9yZXBsYWNlbWVudFJlZ0V4cCwgdmFsdWUgIT09IG51bGwgPyAiJDEkMjogIiArIHZh bHVlICsgIjsiIDogIiQxIik7CiAgICAgICAgIGVsc2UgaWYgKHZhbHVlICE9PSBudWxsKQo=