148203 2015-08-19 16:52:55 -0700 clearCode() should clear code 2015-08-20 20:54:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 148244 1 ggaren ggaren barraclough cdumez commit-queue rniwa oldest_to_newest 1119093 0 ggaren 2015-08-19 16:52:55 -0700 clearCode() should clear code 1119094 1 259429 ggaren 2015-08-19 16:55:25 -0700 Created attachment 259429 Patch 1119095 2 259429 saam 2015-08-19 17:00:29 -0700 Comment on attachment 259429 Patch r=me 1119143 3 259429 ggaren 2015-08-19 18:18:51 -0700 Comment on attachment 259429 Patch Clearing flags on attachment: 259429 Committed r188675: <http://trac.webkit.org/changeset/188675> 1119144 4 ggaren 2015-08-19 18:18:54 -0700 All reviewed patches have been landed. Closing bug. 1119295 5 cdumez 2015-08-20 10:55:47 -0700 This change seems to have regressed the PLT on Mac by ~17%. Please fix or roll out ASAP. 1119316 6 cdumez 2015-08-20 12:34:12 -0700 (In reply to comment #5) > This change seems to have regressed the PLT on Mac by ~17%. Please fix or > roll out ASAP. And looks like a ~3% PLT regression on iPad as well. 1119342 7 commit-queue 2015-08-20 14:05:46 -0700 Re-opened since this is blocked by bug 148244 1119636 8 cdumez 2015-08-20 20:54:47 -0700 Thanks for rolling out, the PLT recovered. 259429 2015-08-19 16:55:25 -0700 2015-08-19 18:18:51 -0700 Patch bug-148203-20150819165522.patch text/plain 6544 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg4NjYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM4IEBA CisyMDE1LTA4LTE5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgY2xlYXJDb2RlKCkgc2hvdWxkIGNsZWFyIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0ODIwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFyaW5nIGNvZGUgdXNlZCB0byByZXF1aXJlIHR3 byBzdGVwczogY2xlYXJDb2RlKCkgYW5kCisgICAgICAgIGNsZWFyVW5saW5rZWRDb2RlRm9yUmVj b21waWxhdGlvbigpLiBVbnN1cnByaXNpbmdseSwgY2xpZW50cyBzb21ldGltZXMKKyAgICAgICAg ZGlkIG9uZSBvciB0aGUgb3RoZXIgb3IgYm90aCB3aXRob3V0IG11Y2ggcmh5bWUgb3IgcmVhc29u LgorCisgICAgICAgIFRoaXMgcGF0Y2ggc2ltcGxpZmllcyB0aGluZ3MgYnkgbWVyZ2luZyBib3Ro IGZ1bmN0aW9ucyBpbnRvIGNsZWFyQ29kZSgpLgorCisgICAgICAgICogYnl0ZWNvZGUvVW5saW5r ZWRGdW5jdGlvbkV4ZWN1dGFibGUuaDoKKyAgICAgICAgKiBkZWJ1Z2dlci9EZWJ1Z2dlci5jcHA6 CisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6ZGVsZXRlQWxs Q29tcGlsZWRDb2RlKToKKyAgICAgICAgKEpTQzo6SGVhcDo6Y2xlYXJVbm1hcmtlZEV4ZWN1dGFi bGVzKToKKyAgICAgICAgKEpTQzo6SGVhcDo6ZGVsZXRlQWxsVW5saW5rZWRGdW5jdGlvbkNvZGUp OiBEZWxldGVkLiBObyBuZWVkIGZvciB0aGlzCisgICAgICAgIGZ1bmN0aW9uIGFueW1vcmUgc2lu Y2UgaXQgd2FzIG9ubHkgdXNlZCBieSBjbGllbnRzIHdobyBhbHJlYWR5IGNhbGxlZAorICAgICAg ICBjbGVhckNvZGUoKSAoYW5kIGl0IHdvdWxkIGJlIHRlcnJpYmx5IHdyb25nIHRvIHVzZSB3aXRo b3V0IGRvaW5nIGJvdGguKQorCisgICAgICAgICogaGVhcC9IZWFwLmg6CisgICAgICAgIChKU0M6 OkhlYXA6OnNpemVBZnRlckxhc3RGdWxsQ29sbGVjdGlvbik6CisgICAgICAgICogaW5zcGVjdG9y L2FnZW50cy9JbnNwZWN0b3JSdW50aW1lQWdlbnQuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpU eXBlUmVjb21waWxlcjo6dmlzaXQpOgorICAgICAgICAoSW5zcGVjdG9yOjpUeXBlUmVjb21waWxl cjo6b3BlcmF0b3IoKSk6CisgICAgICAgICogcnVudGltZS9FeGVjdXRhYmxlLmNwcDoKKyAgICAg ICAgKEpTQzo6RnVuY3Rpb25FeGVjdXRhYmxlOjp2aXNpdENoaWxkcmVuKToKKyAgICAgICAgKEpT Qzo6RnVuY3Rpb25FeGVjdXRhYmxlOjpjbGVhckNvZGUpOgorICAgICAgICAoSlNDOjpGdW5jdGlv bkV4ZWN1dGFibGU6OmNsZWFyVW5saW5rZWRDb2RlRm9yUmVjb21waWxhdGlvbik6IERlbGV0ZWQu CisgICAgICAgICogcnVudGltZS9FeGVjdXRhYmxlLmg6CisgICAgICAgICogcnVudGltZS9WTS5j cHA6CisgICAgICAgIChKU0M6OlZNOjpkZWxldGVBbGxDb2RlKToKKwogMjAxNS0wOC0xOSAgRXJp YyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5B QkxFX1dFQlZUVF9SRUdJT05TCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv VW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUuaAkocmV2aXNpb24g MTg4NTg0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkRnVuY3Rp b25FeGVjdXRhYmxlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwMiw3ICsxMDIsNyBAQCBwdWJsaWM6 CiAKICAgICBGdW5jdGlvbkV4ZWN1dGFibGUqIGxpbmsoVk0mLCBjb25zdCBTb3VyY2VDb2RlJiwg aW50IG92ZXJyaWRlTGluZU51bWJlciA9IC0xKTsKIAotICAgIHZvaWQgY2xlYXJDb2RlRm9yUmVj b21waWxhdGlvbigpCisgICAgdm9pZCBjbGVhckNvZGUoKQogICAgIHsKICAgICAgICAgbV9jb2Rl QmxvY2tGb3JDYWxsLmNsZWFyKCk7CiAgICAgICAgIG1fY29kZUJsb2NrRm9yQ29uc3RydWN0LmNs ZWFyKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5j cHAJKHJldmlzaW9uIDE4ODU4NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZWJ1Z2dlci9E ZWJ1Z2dlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg4LDcgKzg4LDYgQEAgaW5saW5lIHZvaWQg UmVjb21waWxlcjo6dmlzaXQoSlNDZWxsKiBjZQogCiAgICAgRXhlY1N0YXRlKiBleGVjID0gZnVu Y3Rpb24tPnNjb3BlKCktPmdsb2JhbE9iamVjdCgpLT5KU0dsb2JhbE9iamVjdDo6Z2xvYmFsRXhl YygpOwogICAgIGV4ZWN1dGFibGUtPmNsZWFyQ29kZSgpOwotICAgIGV4ZWN1dGFibGUtPmNsZWFy VW5saW5rZWRDb2RlRm9yUmVjb21waWxhdGlvbigpOwogICAgIGlmIChtX2RlYnVnZ2VyID09IGZ1 bmN0aW9uLT5zY29wZSgpLT5nbG9iYWxPYmplY3QoKS0+ZGVidWdnZXIoKSkKICAgICAgICAgbV9z b3VyY2VQcm92aWRlcnMuYWRkKGV4ZWN1dGFibGUtPnNvdXJjZSgpLnByb3ZpZGVyKCksIGV4ZWMp OwogfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHJldmlzaW9uIDE4ODU4 NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC05MzYsMTUgKzkzNiw2IEBAIHZvaWQgSGVhcDo6ZGVsZXRlQWxsQ29tcGlsZWRDb2RlKCkK ICAgICBtX2NvZGVCbG9ja3MuZGVsZXRlVW5tYXJrZWRBbmRVbnJlZmVyZW5jZWQoRnVsbENvbGxl Y3Rpb24pOwogfQogCi12b2lkIEhlYXA6OmRlbGV0ZUFsbFVubGlua2VkRnVuY3Rpb25Db2RlKCkK LXsKLSAgICBmb3IgKEV4ZWN1dGFibGVCYXNlKiBjdXJyZW50IDogbV9jb21waWxlZENvZGUpIHsK LSAgICAgICAgaWYgKCFjdXJyZW50LT5pc0Z1bmN0aW9uRXhlY3V0YWJsZSgpKQotICAgICAgICAg ICAgY29udGludWU7Ci0gICAgICAgIHN0YXRpY19jYXN0PEZ1bmN0aW9uRXhlY3V0YWJsZSo+KGN1 cnJlbnQpLT5jbGVhclVubGlua2VkQ29kZUZvclJlY29tcGlsYXRpb24oKTsKLSAgICB9Ci19Ci0K IHZvaWQgSGVhcDo6Y2xlYXJVbm1hcmtlZEV4ZWN1dGFibGVzKCkKIHsKICAgICBHQ1BIQVNFKENs ZWFyVW5tYXJrZWRFeGVjdXRhYmxlcyk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9IZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5o CShyZXZpc2lvbiAxODg1ODQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgJ KHdvcmtpbmcgY29weSkKQEAgLTIwOSw3ICsyMDksNiBAQCBwdWJsaWM6CiAgICAgc2l6ZV90IHNp emVBZnRlckxhc3RGdWxsQ29sbGVjdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fc2l6ZUFmdGVyTGFz dEZ1bGxDb2xsZWN0OyB9CiAKICAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGRlbGV0ZUFsbENv bXBpbGVkQ29kZSgpOwotICAgIHZvaWQgZGVsZXRlQWxsVW5saW5rZWRGdW5jdGlvbkNvZGUoKTsK IAogICAgIHZvaWQgZGlkQWxsb2NhdGUoc2l6ZV90KTsKICAgICB2b2lkIGRpZEFiYW5kb24oc2l6 ZV90KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3Bl Y3RvclJ1bnRpbWVBZ2VudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yUnVudGltZUFnZW50LmNwcAkocmV2aXNpb24gMTg4 NTg0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9y UnVudGltZUFnZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE2LDcgKzMxNiw2IEBAIHB1Ymxp YzoKIAogICAgICAgICBGdW5jdGlvbkV4ZWN1dGFibGUqIGV4ZWN1dGFibGUgPSBqc0Nhc3Q8RnVu Y3Rpb25FeGVjdXRhYmxlKj4oY2VsbCk7CiAgICAgICAgIGV4ZWN1dGFibGUtPmNsZWFyQ29kZSgp OwotICAgICAgICBleGVjdXRhYmxlLT5jbGVhclVubGlua2VkQ29kZUZvclJlY29tcGlsYXRpb24o KTsKICAgICB9CiAgICAgaW5saW5lIEl0ZXJhdGlvblN0YXR1cyBvcGVyYXRvcigpKEpTQ2VsbCog Y2VsbCkKICAgICB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRh YmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVj dXRhYmxlLmNwcAkocmV2aXNpb24gMTg4NTg0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvRXhlY3V0YWJsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1NywxMyArNTU3LDkgQEAg dm9pZCBGdW5jdGlvbkV4ZWN1dGFibGU6OnZpc2l0Q2hpbGRyZW4oSgogICAgIHZpc2l0b3IuYXBw ZW5kKCZ0aGlzT2JqZWN0LT5tX3NpbmdsZXRvbkZ1bmN0aW9uKTsKIH0KIAotdm9pZCBGdW5jdGlv bkV4ZWN1dGFibGU6OmNsZWFyVW5saW5rZWRDb2RlRm9yUmVjb21waWxhdGlvbigpCi17Ci0gICAg bV91bmxpbmtlZEV4ZWN1dGFibGUtPmNsZWFyQ29kZUZvclJlY29tcGlsYXRpb24oKTsKLX0KLQog dm9pZCBGdW5jdGlvbkV4ZWN1dGFibGU6OmNsZWFyQ29kZSgpCiB7CisgICAgbV91bmxpbmtlZEV4 ZWN1dGFibGUtPmNsZWFyQ29kZSgpOwogICAgIG1fY29kZUJsb2NrRm9yQ2FsbCA9IG51bGxwdHI7 CiAgICAgbV9jb2RlQmxvY2tGb3JDb25zdHJ1Y3QgPSBudWxscHRyOwogICAgIEJhc2U6OmNsZWFy Q29kZSgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUu aAkocmV2aXNpb24gMTg4NTg0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhl Y3V0YWJsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02NDAsNyArNjQwLDYgQEAgcHVibGljOgogICAg IEpTU3RyaW5nKiBuYW1lVmFsdWUoKSBjb25zdCB7IHJldHVybiBtX3VubGlua2VkRXhlY3V0YWJs ZS0+bmFtZVZhbHVlKCk7IH0KICAgICBzaXplX3QgcGFyYW1ldGVyQ291bnQoKSBjb25zdCB7IHJl dHVybiBtX3VubGlua2VkRXhlY3V0YWJsZS0+cGFyYW1ldGVyQ291bnQoKTsgfSAvLyBFeGNsdWRp bmcgJ3RoaXMnIQogCi0gICAgdm9pZCBjbGVhclVubGlua2VkQ29kZUZvclJlY29tcGlsYXRpb24o KTsKICAgICBzdGF0aWMgdm9pZCB2aXNpdENoaWxkcmVuKEpTQ2VsbCosIFNsb3RWaXNpdG9yJik7 CiAgICAgc3RhdGljIFN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJlKFZNJiB2bSwgSlNHbG9iYWxP YmplY3QqIGdsb2JhbE9iamVjdCwgSlNWYWx1ZSBwcm90bykKICAgICB7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCShyZXZpc2lvbiAxODg1ODQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4NSw3ICs0ODUs NiBAQCB2b2lkIFZNOjpkZWxldGVBbGxDb2RlKCkKICAgICBtX2NvZGVDYWNoZS0+Y2xlYXIoKTsK ICAgICBtX3JlZ0V4cENhY2hlLT5kZWxldGVBbGxDb2RlKCk7CiAgICAgaGVhcC5kZWxldGVBbGxD b21waWxlZENvZGUoKTsKLSAgICBoZWFwLmRlbGV0ZUFsbFVubGlua2VkRnVuY3Rpb25Db2RlKCk7 CiAgICAgaGVhcC5yZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCgpOwogfQogCg==